Commit Graph

686366 Commits

Author SHA1 Message Date
Dorel Luca
212a51bc09 Backed out 5 changesets (bug 1603856, bug 1606447, bug 1605584, bug 1598951) for build bustages. CLOSED TREE
Backed out changeset cf403935cf9b (bug 1598951)
Backed out changeset af6e8b6be574 (bug 1605584)
Backed out changeset fbfa92bd4ec8 (bug 1603856)
Backed out changeset a6d13450295d (bug 1603856)
Backed out changeset e0b049ff115f (bug 1606447)

--HG--
rename : toolkit/recordreplay/Recording.cpp => toolkit/recordreplay/File.cpp
rename : toolkit/recordreplay/Recording.h => toolkit/recordreplay/File.h
rename : toolkit/recordreplay/ExternalCall.cpp => toolkit/recordreplay/MiddlemanCall.cpp
rename : toolkit/recordreplay/ExternalCall.h => toolkit/recordreplay/MiddlemanCall.h
2020-01-03 18:43:40 +02:00
Yura Zenevich
edf6046d29 Bug 1606671 - ensure that the panel UI event handlers are cleaned up in case when panel is removed via settings. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D58538

--HG--
extra : moz-landing-system : lando
2020-01-03 15:33:00 +00:00
Edgar Chen
8a3c5a72a7 Bug 1606796 - Rename test_bug1453693.html to test_focus_shadow_dom.html; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D58596

--HG--
rename : dom/base/test/file_bug1453693.html => dom/base/test/file_focus_shadow_dom.html
rename : dom/base/test/test_bug1453693.html => dom/base/test/test_focus_shadow_dom.html
extra : moz-landing-system : lando
2020-01-03 16:05:21 +00:00
Edgar Chen
7e5c18223f Bug 1606796 - Make tab focus tests for shadow DOM work on Mac; r=smaug
The behavior of focus navigation on Mac depends on OS setting, but we could also change it by setting accessibility.tabfocus to 7, like other tests do.

Differential Revision: https://phabricator.services.mozilla.com/D58595

--HG--
extra : moz-landing-system : lando
2020-01-03 16:04:06 +00:00
chujun
71e76eea3b Bug 1596114 - Refactor server unit tests to async/await part2 r=jlast
The 3 `test_objectgrips-fn-apply` tests and 3 `test_objectgrips-property-value` tests used somewhat complicated callbacks returning `promise` . I thought they were not easy to read, and I might fail to understand its subtleness. I wondered why the tests were written in that way?

Differential Revision: https://phabricator.services.mozilla.com/D57752

--HG--
extra : moz-landing-system : lando
2020-01-03 16:01:20 +00:00
Brian Hackett
8dc52ffa8f Bug 1598951 Part 1 - Avoid connecting to parent when replaying remotely, r=gsvelto.
Depends on D58436

Differential Revision: https://phabricator.services.mozilla.com/D58437

--HG--
extra : moz-landing-system : lando
2020-01-02 16:27:35 +00:00
Brian Hackett
af065a244b Bug 1605584 - Create replaying processes in the cloud when requested, r=mccr8.
Differential Revision: https://phabricator.services.mozilla.com/D58436

--HG--
extra : moz-landing-system : lando
2019-12-31 20:12:25 +00:00
Brian Hackett
6560a78618 Bug 1603856 Part 2 - Workaround hang when waiting for exception time annotations from a replaying process that isn't actually crashing, r=gsvelto.
Depends on D57200

Differential Revision: https://phabricator.services.mozilla.com/D57201

--HG--
extra : moz-landing-system : lando
2019-12-31 16:11:25 +00:00
Brian Hackett
3bb2a00122 Bug 1603856 Part 1 - Specify crashing task explicitly when requesting minidumps, r=gsvelto.
Differential Revision: https://phabricator.services.mozilla.com/D57200

--HG--
extra : moz-landing-system : lando
2019-12-31 16:10:29 +00:00
Brian Hackett
47e1b573d0 Bug 1606447 - Initial landing for cloud replay, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D58444

--HG--
rename : toolkit/recordreplay/MiddlemanCall.cpp => toolkit/recordreplay/ExternalCall.cpp
rename : toolkit/recordreplay/MiddlemanCall.h => toolkit/recordreplay/ExternalCall.h
rename : toolkit/recordreplay/File.cpp => toolkit/recordreplay/Recording.cpp
rename : toolkit/recordreplay/File.h => toolkit/recordreplay/Recording.h
extra : moz-landing-system : lando
2020-01-03 15:57:15 +00:00
Mark Banner
7ceb5871b5 Bug 1596766 - Followup, fix a missed instance in the SearchService of switching an array to a string for the locales change. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D58528

--HG--
extra : moz-landing-system : lando
2020-01-03 15:36:00 +00:00
Tom Schuster
1596f1aa17 Bug 1605854 - Remove uneval/toSource from devtools tests. r=jlast
For test browser_net_prefs-reload.js, I am not sure about this change firstValue/currentValue seems to be different types numbers, strings, objects.
toString is maybe not the best way to compare those values.

Differential Revision: https://phabricator.services.mozilla.com/D58313

--HG--
extra : moz-landing-system : lando
2020-01-03 15:30:08 +00:00
Daniel Varga
1d798d7582 Bug 1605297 - disable browser_policyOverride.js for frequent failures. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D58421

--HG--
extra : moz-landing-system : lando
2020-01-01 23:34:25 +00:00
Coroiu Cristina
bb687ca476 Backed out changeset 7da82c2eea17 (bug 1597488) for chrome failures at layout/xul/test/test_resizer.xhtml on a CLOSED TREE 2020-01-03 17:14:49 +02:00
Yoshi Cheng-Hao Huang
fb45407510 Bug 1605633 - Check if it's a dead wrapper in WeakRef constructor. r=jonco
Throw error if the wrapped WeakRef is a dead wrapper.

Differential Revision: https://phabricator.services.mozilla.com/D58522

--HG--
extra : moz-landing-system : lando
2020-01-03 13:01:10 +00:00
Andreas Tolfsen
d9f8d5f71e bug 1606317: remote: revert "Disable Puppeteer tests in ignorehttpserrors.spec.js which crash the browser." r=remote-protocol-reviewers,whimboo
This reverts the commit:

	git:	d640ab64b993431099cd9205297bfff464d76927
	hg:	9f6327c0d8298ec58a6c9f8d51526872d01d765e

Differential Revision: https://phabricator.services.mozilla.com/D58503

--HG--
extra : moz-landing-system : lando
2020-01-03 13:44:39 +00:00
Andreas Tolfsen
691d52fe90 bug 1606317: security: allow remote agent to disable security checks; r=keeler
The remote agent is an implementation of a subset of
the Chromium Remote Debugging Protocol (CDP) for Gecko.
For similar reasons as Marionette it needs the ability to call
nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData().

It calls this method from remote/domains/parent/Security.jsm which
implements the Security.setIgnoreCertificateErrors protocol method.

The remote agent is slated to replace Marionette, but there is
currently no timeline for this.

Differential Revision: https://phabricator.services.mozilla.com/D58435

--HG--
extra : moz-landing-system : lando
2020-01-03 13:46:00 +00:00
Andreas Tolfsen
a0465d6c54 bug 1606317: security: use nsIMarionette.running() for disable security check; r=keeler
It must only be possible to call
nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData()
when Marionette is actually active, but the MOZ_MARIONETTE environment
variable can in theory be set by any user.

MOZ_MARIONETTE was introduced to support in-application restarts
so that the forked main process knows to re-initialise Marionette.
This makes it approximately equivalent to passing the --marionette flag.

Because Marionette can be started and stopped at runtime through
modifying the marionette.enabled preference, and Marionette never
resets MOZ_MARIONETTE, this makes it theoretically possible that
a future caller could circumvent this security check.

This is however not a security problem at present because the
method is only ever called from within testing/marionette/cert.js,
which itself is never called unless Marionette indeed is active.

Still, it would be safer for this to use nsIMarionette.running()
which returns true whenever the Marionette server is listening for
connections, and false when the Marionette automation protocol is
not enabled.

Differential Revision: https://phabricator.services.mozilla.com/D58434

--HG--
extra : moz-landing-system : lando
2020-01-03 13:46:38 +00:00
Tetsuharu OHZEKI
ddb1860966 Bug 1597488 - Fix uses of nsResizerFrame::GetContentToResize in layout/xul/nsResizerFrame.cpp. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58483

--HG--
extra : moz-landing-system : lando
2020-01-03 13:45:46 +00:00
Dorel Luca
de5c64c8f9 Backed out changeset a1487e1518de (bug 1605854) for ESline failure in gecko/devtools/shared/transport/local-transport.js. CLOSED TREE 2020-01-03 15:52:46 +02:00
Tom Schuster
7d4773b478 Bug 1605854 - Remove uneval/toSource from devtools tests. r=jlast
For test browser_net_prefs-reload.js, I am not sure about this change firstValue/currentValue seems to be different types numbers, strings, objects.
toString is maybe not the best way to compare those values.

Differential Revision: https://phabricator.services.mozilla.com/D58313

--HG--
extra : moz-landing-system : lando
2020-01-03 13:08:26 +00:00
Coroiu Cristina
9513ceda80 Backed out 3 changesets (bug 1606317) for build bustage at build/src/security/manager/ssl/nsCertOverrideService.cpp on a CLOSED TREE
Backed out changeset 9c34a0a40e62 (bug 1606317)
Backed out changeset 467db2b310a7 (bug 1606317)
Backed out changeset b12669c3ade7 (bug 1606317)
2020-01-03 15:11:29 +02:00
Andreas Tolfsen
27106918c7 bug 1606317: remote: revert "Disable Puppeteer tests in ignorehttpserrors.spec.js which crash the browser." r=remote-protocol-reviewers,whimboo
This reverts the commit:

	git:	d640ab64b993431099cd9205297bfff464d76927
	hg:	9f6327c0d8298ec58a6c9f8d51526872d01d765e

Differential Revision: https://phabricator.services.mozilla.com/D58503

--HG--
extra : moz-landing-system : lando
2020-01-03 10:16:13 +00:00
Andreas Tolfsen
bb0887db1e bug 1606317: security: allow remote agent to disable security checks; r=keeler
The remote agent is an implementation of a subset of
the Chromium Remote Debugging Protocol (CDP) for Gecko.
For similar reasons as Marionette it needs the ability to call
nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData().

It calls this method from remote/domains/parent/Security.jsm which
implements the Security.setIgnoreCertificateErrors protocol method.

The remote agent is slated to replace Marionette, but there is
currently no timeline for this.

Differential Revision: https://phabricator.services.mozilla.com/D58435

--HG--
extra : moz-landing-system : lando
2020-01-03 10:16:48 +00:00
Andreas Tolfsen
3d48cf1cf1 bug 1606317: security: use nsIMarionette.running() for disable security check; r=keeler
It must only be possible to call
nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData()
when Marionette is actually active, but the MOZ_MARIONETTE environment
variable can in theory be set by any user.

MOZ_MARIONETTE was introduced to support in-application restarts
so that the forked main process knows to re-initialise Marionette.
This makes it approximately equivalent to passing the --marionette flag.

Because Marionette can be started and stopped at runtime through
modifying the marionette.enabled preference, and Marionette never
resets MOZ_MARIONETTE, this makes it theoretically possible that
a future caller could circumvent this security check.

This is however not a security problem at present because the
method is only ever called from within testing/marionette/cert.js,
which itself is never called unless Marionette indeed is active.

Still, it would be safer for this to use nsIMarionette.running()
which returns true whenever the Marionette server is listening for
connections, and false when the Marionette automation protocol is
not enabled.

Differential Revision: https://phabricator.services.mozilla.com/D58434

--HG--
extra : moz-landing-system : lando
2020-01-03 10:16:35 +00:00
Chris Peterson
109c172dd1 Bug 1606274 - Remove always-false MOZ_GRAPHENE macro. r=firefox-build-system-reviewers,rstewart
Graphene was a B2G UI runtime (added in bug 1115098) used for the browser.html prototype. The Graphene code has since been removed.

Depends on D58358

Differential Revision: https://phabricator.services.mozilla.com/D58359

--HG--
extra : moz-landing-system : lando
2019-12-30 15:00:53 +00:00
Chris Peterson
1c077cf213 Bug 1606274 - Remove always-true MOZ_PHOENIX macro. r=firefox-build-system-reviewers,rstewart
MOZ_PHOENIX was a macro added back in 2002 to differentiate SeaMonkey and Phoenix appshell bits. The earliest references to MOZ_PHOENIX I can find in Gecko's pre-hg history are bug 161448, bug 213228, bug 243091, and 05ef2e9b38.

Differential Revision: https://phabricator.services.mozilla.com/D58358

--HG--
extra : moz-landing-system : lando
2019-12-30 15:00:20 +00:00
Martin Thomson
eb0f4adeb2 Bug 1606733 - Disable TLS 1.0 and 1.1 prior to release, r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D58563

--HG--
extra : moz-landing-system : lando
2020-01-03 04:06:23 +00:00
alwu
4bde50109e Bug 1571493 - part5 : use 'MediaControlKeysEventHandler' to deliver control keys event. r=chunmin
Use `MediaControlKeysEventHandler` to handle the control keys event, which can always find corresponding controlled media if there are some.

Differential Revision: https://phabricator.services.mozilla.com/D57575

--HG--
extra : moz-landing-system : lando
2020-01-03 01:27:24 +00:00
alwu
bdc6a8cae7 Bug 1571493 - part4 : support 'ControlledMediaState' in media controller r=chunmin
Introduce `ControlledMediaState` to media controller, so now we can now how many controlled media are playing, which allow us to update `mIsPlaying` correctly.

Differential Revision: https://phabricator.services.mozilla.com/D57574

--HG--
extra : moz-landing-system : lando
2020-01-03 01:39:33 +00:00
alwu
2d2b857325 Bug 1571493 - part3 : notify media state and audible state changes. r=chunmin
Modify IPC method to support notify `ControlledMediaState` to the media controller, and remove the previous implementation.

Differential Revision: https://phabricator.services.mozilla.com/D57572

--HG--
extra : moz-landing-system : lando
2020-01-03 01:34:34 +00:00
alwu
f5053f5850 Bug 1571493 - part2 : use 'MediaControlAgent' in media element. r=chunmin
We create `MediaControlEventListener` to register itself to the `MediaControlAgent` that is an event source, so that we can receive the media control event from the evnet source and operate media according to different types of event.

 `MediaControlEventListener` is also used to notify controlled media state to the media controller. When media first starts playing, or leaves bfcache and  has created listener before, we would notify `eStarted`. Notify `eStopped` when media destroys, or enter bfcache and has created listener before. When media's playing state changes, we would notifty `ePlayed` or `ePaused` depeding on media's `mPaused`.

Differential Revision: https://phabricator.services.mozilla.com/D57571

--HG--
extra : moz-landing-system : lando
2020-01-03 01:20:01 +00:00
alwu
9977c552ff Bug 1571493 - part1 : implement 'ContentMediaController' which is used to notify 'MediaControlKeysEvent' for controlled media. r=chunmin
Implement class `ContentMediaController` that is used to dispatch media controls key events to those media which would like to be controlled.

`ContentMediaController` is inherited from two classes, `MediaControlAgent` and `MediaControlKeysEventHandler`. The former one is used for controlled media, the controlled media can register itself to `MediaControlAgent` to receive events and do corresponding operations depending on the event type. The latter one is used to handle events sent from chrome process and dispatch them to the corresponding controlled media.

Differential Revision: https://phabricator.services.mozilla.com/D57570

--HG--
extra : moz-landing-system : lando
2020-01-03 01:29:38 +00:00
alwu
62b6b0092c Bug 1606588 - Enable media control key event on OSX version Nightly. r=chunmin
Differential Revision: https://phabricator.services.mozilla.com/D58497

--HG--
extra : moz-landing-system : lando
2020-01-02 17:54:13 +00:00
Greg V
cd4b391a87 Bug 1556301 - Wayland-EGL/GLES support in glxtest r=stransky,aosmond
This allows GfxInfoX11 to get GLES3 and Mesa version from Wayland-EGL, which
allows automatic enablement of acceleration to work without Xwayland.

This also fixes bug 1578598 - WebRender did not work correctly
without this GL version information.

Differential Revision: https://phabricator.services.mozilla.com/D57474

--HG--
extra : moz-landing-system : lando
2020-01-03 01:02:44 +00:00
Tom Tung
69d24d2c2a Bug 1606553 - Set coep.https.html as failing a test step outside of Nightly. r=nataliaCs
Bug 1594748 enabled cross origin opener policies but only on desktio Nightly.

Differential Revision: https://phabricator.services.mozilla.com/D58565

--HG--
extra : moz-landing-system : lando
2020-01-02 23:22:12 +00:00
Gurzau Raul
a49bfa16f8 Backed out changeset fce0a89353f1 (bug 1606161) for failing at /browser_net_har_copy_all_as_har.js on a CLOSED TREE. 2020-01-03 00:41:00 +02:00
Gerald Squelart
1484f8824a Bug 1600644 - Don't count ActivePS::mProfileBuffer's own size twice - r=canaltinova
In bug 1587332, ActivePS::mProfileBuffer was changed from
`const UniquePtr<ProfileBuffer>` to just `ProfileBuffer`, so its own object size
is now counted as part of `sizeof(ActivePS)`, and we should only count its
dependencies with `SizeOfExcludingThis`.

Differential Revision: https://phabricator.services.mozilla.com/D58288

--HG--
extra : moz-landing-system : lando
2020-01-02 12:21:58 +00:00
Sylvestre Ledru
81354de9c7 No bug - Document how add a new linter in the CI r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D58247

--HG--
extra : moz-landing-system : lando
2020-01-02 21:42:18 +00:00
Sylvestre Ledru
cd2807905f No bug - mozlint: Document the result object r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D58239

--HG--
extra : moz-landing-system : lando
2020-01-02 21:37:12 +00:00
Henrik Skupin
b35d14d120 Bug 1605722 - [remote] Enable target discovery by default for browser chrome tests. r=remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D58162

--HG--
extra : moz-landing-system : lando
2020-01-02 21:13:20 +00:00
championshuttler
587424842c Bug 1576912 - Improve docs for writing docs.r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D58486

--HG--
extra : moz-landing-system : lando
2020-01-02 21:06:52 +00:00
Harald Kirschner
7b5ebabe18 Bug 1606153 - Use tabular-nums in network status bar r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D58324

--HG--
extra : moz-landing-system : lando
2020-01-02 10:30:07 +00:00
J.C. Jones
956d95c76c Bug 1602020 - land NSS NSS_3_49_BETA1 UPGRADE_NSS_RELEASE, r=kjacobs
2020-01-02  Giulio Benetti  <giulio.benetti@benettiengineering.com>

	* lib/ssl/sslsnce.c:
	Bug 1606025 - Remove -Wmaybe-uninitialized warning in sslsnce.c
	r=jcj

	(Amended by jcj to also set privKeyCopy to NULL)
	[9ecd41cd2fa3] [NSS_3_49_BETA1]

	* lib/freebl/gcm.h:
	Bug 1606119 - Fix PPC HW Crypto build failure r=jcj

	All Altivec *_be() functions are supported from gcc version 8.x not
	5.x so modify gcc version check that at the moment cause build
	failure due to missing Altivec *_be() functions.
	[7ab634a7d772]

2020-01-01  Alex Henrie  <alexhenrie24@gmail.com>

	* cmd/modutil/install-ds.c:
	Bug 1605545 - Fix memory leak in Pk11Install_Platform_Generate. r=mt

	[748b308170a4]

Differential Revision: https://phabricator.services.mozilla.com/D58541

--HG--
extra : moz-landing-system : lando
2020-01-02 17:54:36 +00:00
Harald Kirschner
9683a90cfe Bug 1606161 - Avoid forced layouts in RequestListHeader r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D58320

--HG--
extra : moz-landing-system : lando
2020-01-02 12:50:36 +00:00
Harald Kirschner
c8219f4aa2 Bug 1599604 - Store netmonitor requests in Array vs Map r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D57748

--HG--
extra : moz-landing-system : lando
2020-01-02 12:48:17 +00:00
Rob Wood
562c18e2f2 Bug 1601414 - Add application name and version in vismet perfherder results r=perftest-reviewers,stephendonner
Differential Revision: https://phabricator.services.mozilla.com/D58459

--HG--
extra : moz-landing-system : lando
2020-01-02 20:09:45 +00:00
Boris Zbarsky
613f2313da Bug 1606672. Change nsIRunnablePriority values so increasing value indicates increased priority. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D58539

--HG--
extra : moz-landing-system : lando
2020-01-02 20:07:40 +00:00
David Major
dcb41e6ebd Bug 1602801 - Mark StyleBench as subtest_lower_is_better r=perftest-reviewers,rwood
Stylebench is patterned after Speedometer and calculates overall score from subtests in the same way. Stylebench should be marked as subtest_lower_is_better just like Speedometer.

Differential Revision: https://phabricator.services.mozilla.com/D56557

--HG--
extra : moz-landing-system : lando
2020-01-02 20:03:24 +00:00
Rob Wood
a1780842dc Bug 1601414 - Add application info json file to browsertime results for vismet jobs r=perftest-reviewers,stephendonner
Differential Revision: https://phabricator.services.mozilla.com/D58404

--HG--
extra : moz-landing-system : lando
2020-01-02 19:53:48 +00:00