Commit Graph

17778 Commits

Author SHA1 Message Date
Bogdan Tara
3667467db8 Backed out 10 changesets (bug 1662254) for lint failure on generate_static_pref_list.py CLOSED TREE
Backed out changeset 972e63387191 (bug 1662254)
Backed out changeset 3a9d6f0aa380 (bug 1662254)
Backed out changeset 4b3ffe7fe1af (bug 1662254)
Backed out changeset 4834b1025611 (bug 1662254)
Backed out changeset ec1f7afe8a2d (bug 1662254)
Backed out changeset c7a6b927b1de (bug 1662254)
Backed out changeset 2427d85b2605 (bug 1662254)
Backed out changeset 979bf4ac97bb (bug 1662254)
Backed out changeset 3e443333c636 (bug 1662254)
Backed out changeset a5261578ebfc (bug 1662254)
2020-11-12 23:59:07 +02:00
Steve Fink
9ab0a6a530 Bug 1662254 - Rename CC_WAITING -> CC_FINISHED r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D94792
2020-11-12 19:05:32 +00:00
Julian Descottes
2a85b4f393 Bug 1650963 - [devtools] Set non-fission flag when opening DevTools window from a non-fission host tab r=Honza
We cannot use swapFrameLoaders between a fission and a non fission window. We should make sure to open non-fission windows if the current host is not a fission one.

Differential Revision: https://phabricator.services.mozilla.com/D96696
2020-11-12 15:18:43 +00:00
Andreea Pavel
51f16bb9d2 Backed out changeset 62af829812bd (bug 1662736) for permafailing bug 1676641 and bug 1655183 on a CLOSED TREE 2020-11-11 19:53:14 +02:00
Hubert Boma Manilla
d4cec11d5a Bug 1662736 - [devtools] Simplify the network request payload r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D94457
2020-11-11 10:51:28 +00:00
Dan Minor
57441aa8cc Bug 1673054 - Migrate uses of intl.uidirection to intl.l10n.pseudo; r=Gijs,zbraniecki
This also removes pref overrides from methods like LocaleService::IsLocaleRTL or
IntlService.getLocaleInfo, because it doesn't really make sense to override the
result of checking an arbitrary locale, the relevant use case is overriding the
result for the current app locale.

Removal of the intl.uidirection pref completely will be done in a separate bug.

Differential Revision: https://phabricator.services.mozilla.com/D96235
2020-11-09 15:33:39 +00:00
Nicolas Chevobbe
6abc8ae401 Bug 1634208 - [devtools] Fix browser_jsterm_screenshot_command_warnings intermittent. r=ladybenko.
It looks like the test was hitting the timeout limit on slow hardware (e.g. on
linux ccov on TRY).
Requesting a longer timeout seems to fix the failure.

Differential Revision: https://phabricator.services.mozilla.com/D96405
2020-11-10 16:07:32 +00:00
Steven MacLeod
971103bdd5 Bug 1606061 - move TouchEventsOverride to BrowsingContext. r=farre,devtools-backward-compat-reviewers
This change removes docshell's `mTouchEventsOverride` and replaces it
with a new `BrowsingContext` field `TouchEventsOverrideInternal`.
All uses of the old field have been replaced and an override should
now work under fission when there are cross-origin descendent frames.

Differential Revision: https://phabricator.services.mozilla.com/D96414
2020-11-10 15:57:30 +00:00
Nicolas Chevobbe
56c8e9380a Bug 1667778 - [devtools] Remove mentions of launchpad in debugger. r=jdescottes.
This removes the few mentions of the launchpad that were
still existing in the debugger codebase.
We take this as an opportunity to use the #mount element
as the root of the React app (instead of creating a new
div for it).

Depends on D96384

Differential Revision: https://phabricator.services.mozilla.com/D96513
2020-11-10 13:05:24 +00:00
Nicolas Chevobbe
514b0ddad4 Bug 1675769 - [devtools] Move devtools-environment function into debugger/src. r=bomsy.
This moves the `isNode` and `isNodeTest` functions to the debugger/src/utils folder,
updates the callsites to those functions, generates the bundles, and finally,
removes the devtools-environment folder, as well as all mentions of it.

Differential Revision: https://phabricator.services.mozilla.com/D96384
2020-11-10 15:18:32 +00:00
Nicolas Chevobbe
6e6be10526 Bug 1675769 - [devtools] Remove usage of devtools-environment isTesting. r=bomsy.
When possible, we switch to the plain devtools/shared/flags module.
In some cases, the check was only done for jest test, so we use
isNodeTest instead.

Differential Revision: https://phabricator.services.mozilla.com/D96382
2020-11-10 15:14:07 +00:00
Nicolas Chevobbe
9725148bcb Bug 1675769 - [devtools] Clean-up devtools-environment usage. r=bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D96381
2020-11-10 15:07:57 +00:00
smolnar
ec58e559fc Backed out changeset 1780d41127e8 (bug 1662736) for causing devtools failure. CLOSED TREE 2020-11-10 15:07:27 +02:00
Nicolas Chevobbe
858da426e6 Bug 1674400 - [devtools] Update pretty-fast to 0.2.4. r=bomsy.
This updates the pretty-fast module to bring the commits
that were done there the 3 last years (date of the last
version being published).

Differential Revision: https://phabricator.services.mozilla.com/D96176
2020-11-10 12:15:13 +00:00
Hubert Boma Manilla
5c91d1f55c Bug 1662736 - [devtools] Simplify the network request payload r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D94457
2020-11-10 12:44:23 +00:00
Yura Zenevich
21c81dd7e6 Bug 1675539 - add telemetry for tabbing order overlay activation. r=jdescottes,janerik
Differential Revision: https://phabricator.services.mozilla.com/D96091
2020-11-09 16:19:20 +00:00
Alexandre Poirot
efdfcfb399 Bug 1672826 - [devtools] Unmanage fronts when we purge a whole prefix. r=nchevobbe
Previous `purgeRequestForDestroy` method was only rejecting all pending requests.
The new `syncFrontDestroy` allows to fully destroy the front, including
unregistering it/unmanage it. So that if we receive a packet from a brand new
actor, with the same prefix and actor ID, DevToolsClient.getFront doesn't return
the old destroyed front.
This issue was making pending requests that were never resolved.

Differential Revision: https://phabricator.services.mozilla.com/D94718
2020-11-09 12:29:53 +00:00
Fabien CASTERS
a2ece0090c Bug 1664766 - [devtools] Remove defer usage in devtools\client\shared\test\test-actor.js. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D94966
2020-11-09 11:36:51 +00:00
Andrey Bienkowski
9a314848ae Bug 1673934 - [devtools] Remove defer usage in client/debugger/src/actions/tests/preview.spec.js r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D95858
2020-11-09 11:31:42 +00:00
Ben Delevingne
6df2de2623 Bug 1674136 - [devtools] Remove defer usage in devtools/client/shared/test/shared-redux-head.js. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D95152
2020-11-09 10:21:26 +00:00
Nicolas Chevobbe
a76f5a8519 Bug 1675497 - [devtools] Remove unused duplicated object-inspector folder. r=bomsy.
Something probably went wrong in Bug 1671163 and we ended up
with this duplicated, unused folder.

Differential Revision: https://phabricator.services.mozilla.com/D96027
2020-11-09 09:57:12 +00:00
Nicolas Chevobbe
220bf52237 Bug 1675450 - [devtools] Remove unused ObjectActor.definitionSite. r=ochameau,devtools-backward-compat-reviewers.
The function wasn't used, except in a test that this patch removes.
Since it was also the only use of the getSourcesManager hook, we're able to
remove it as well.

Differential Revision: https://phabricator.services.mozilla.com/D95989
2020-11-09 09:50:26 +00:00
Alexandre Poirot
48133a28a8 Bug 1673627 - [devtools] Force showing iframe content instead of inline content for remote frames. r=jdescottes
For some reason we return an inlineTextChild when the iframe is remote, so only with fission turned on.
When the iframe isn't remote, WalkerFront.inlineTextChild returns undefined.

Differential Revision: https://phabricator.services.mozilla.com/D95868
2020-11-09 08:43:28 +00:00
Nick Alexander
b143efdd25 Bug 1675332 - Make --headless --jsdebugger launch a headed Browser Toolbox. r=emalysz
Before this commit, the `MOZ_HEADLESS` environment variable was set by
the `--headless` process and inherited by the launched Browser Toolbox
process, hiding the debugger UI.  This commit allows to launch the JS
debugger when running under `--headless` by explicitly removing the
`MOZ_HEADLESS` variable from the environment.  To do this, a small
tweak to `Subprocess.jsm` is used that allows `null` to signal
"removal", distinct from `undefined` for "ignored".

While here I prefixed the output from the launched Browser Toolbox
process, which helps visually distinguish warnings, etc; and I also
corrected a typo that I stumbled across.

Differential Revision: https://phabricator.services.mozilla.com/D95897
2020-11-06 04:53:24 +00:00
Nicolas Chevobbe
90fc707966 Bug 1673368 - [devtools] Remove unnecessary parts of debugger's webpack config. r=jdescottes
I inlined the two existing functions that were modifying the base config directly
back into the base webpack config, and then removed everything that wasn't hit
or used by the bundling script.
Thanks to this work, we're able to remove a few files that were previously only
used in Launchpad, or that are simple enough to be inlined into the webpack config.

Since postcss wasn't used, we can also remove the postcss.config.js file, as
well as some libraries from package.json.

Differential Revision: https://phabricator.services.mozilla.com/D96018
2020-11-06 14:49:16 +00:00
Nicolas Chevobbe
e783099865 Bug 1673368 - [devtools] Remove dependency on devtools-launchpad in webpack config. jdescottes. r=jdescottes
This patch is simply inlining what was in devtools-launchpad directly into the
debugger's webpack config.
In order for the bundling script to still work, we had to add the dependencies
that were used in devtools-launchpad.
For some reason, this shifted a lot of modules in the generated files (but files
have the same size before and after, so I guess nothing changed).

Next patch in the serie will cleanup this webpack config.

Differential Revision: https://phabricator.services.mozilla.com/D96017
2020-11-06 14:29:44 +00:00
Julian Descottes
d6d8ea296d Bug 1654763 - [devtools] Remove implementation, tests and documentation for actorHasMethod r=rcaliman,ochameau,devtools-backward-compat-reviewers
actorhasMethod had several technical limitations making it hard to use consistently. We now removed all the call sites for this method. This changeset removes the method and all its dependencies.

Differential Revision: https://phabricator.services.mozilla.com/D95861
2020-11-06 13:50:52 +00:00
Julian Descottes
7f05d92a6e Bug 1673605 - [devtools] Remove unused css variables from perf.css r=julienw
Depends on D94747

Differential Revision: https://phabricator.services.mozilla.com/D94828
2020-10-27 17:44:14 +00:00
Nicolas Chevobbe
2e2dfdc264 Bug 1673641 - [devtools] Fix browser_browser_toolbox_evaluation_context.js failure on beta simulation. r=ladybenko.
The test was failing on Beta because we weren't setting the devtools.webconsole.input.context
pref, which is true only on Nightly.
This patch flip this pref in the test, which seems to make the test pass.

Differential Revision: https://phabricator.services.mozilla.com/D96061
2020-11-05 17:04:10 +00:00
Andrew Halberstadt
331bc892dd Bug 1675319 - [manifestparser] Properly support multiline skip-if statements, r=jmaher,extension-reviewers,zombie
This supports one manifestparser expression per line in the 'skip-if',
'fail-if' and 'run-if' keys. As a side effect the:

    skip-if = foo ||
        bar

syntax is no longer supported. Instead it can be:

    skip-if =
        foo  # bug 123
        bar  # bug 456

Differential Revision: https://phabricator.services.mozilla.com/D95927
2020-11-05 19:55:08 +00:00
Razvan Caliman
ac7cf1d57c Bug 1675226 - [devtools] Remove leftover specific box model highlighter events r=jdescottes
Use the generic "highlighter-shown" / "highlighter-hidden" events and check for highlighter type.
Use generic helpers in tests.
Fix an unrelated leftover nit from D92802

Differential Revision: https://phabricator.services.mozilla.com/D95835
2020-11-05 14:43:46 +00:00
Oriol Brufau
d2199d3928 Bug 1674590 - Show reason of rejected promise in console, and allow it to be inspected. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D95450
2020-11-05 14:28:01 +00:00
Nerixyz
60cff423b5 Bug 1674577: Show icon corresponding to the source file if it's inside of an extension. r=jdescottes,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D95446
2020-11-05 09:54:42 +00:00
Nicolas Chevobbe
4bad3995de Bug 1592584 - [devtools] Accept worker targets in console. r=ochameau.
The `dom.worker.console.dispatch_events_to_main_thread` pref is used by platform
code to check if console API messages in the worker thread should be dispatched
to the main thread. If so, the message parameters are cloned, or stringified if
they can't be. This is currently the default behavior.

The pref is checked on the server side and added as a trait to the root actor.
On the client, if the pref isn't true, then we accept messages coming from
worker targets in the console. We can't accept them without condition, otherwise
we would get duplicated message (from the main thread AND the worker thread).

The browser_webconsole_console_logging_workers_api.js test is repurposed for
worker logging since it was disabled on e10s anyway. We add a few test case
to check we can get cached and live message, and that non-clonable object, like
worker scope, are displayed like regular objects when the pref is false.

Differential Revision: https://phabricator.services.mozilla.com/D85397
2020-11-05 10:17:36 +00:00
Julian Descottes
d8f70bb25f Bug 1675020 - [devtools] Disable frequent intermittents / permafail DevTools tests on Fission platforms r=Honza
Temporarily add skip-if=fission in order to move devtools tests on Fission platforms to Tier1

Differential Revision: https://phabricator.services.mozilla.com/D95746
2020-11-04 18:39:57 +00:00
Julian Descottes
e65f71419f Bug 1674977 - [devtools] Remove gDevTools::isFissionContentToolboxEnabled r=ochameau
Depends on D95686

Finally, remove the method itself.

Differential Revision: https://phabricator.services.mozilla.com/D95687
2020-11-04 18:32:37 +00:00
Julian Descottes
4952a99950 Bug 1674977 - [devtools] Always return true from gDevTools::isFissionContentToolboxEnabled r=ochameau
Depends on D95685

Keep the isFissionContentToolboxEnabled method but always return true to effectively enable all fission related behavior for all content toolboxes.

Differential Revision: https://phabricator.services.mozilla.com/D95686
2020-11-04 14:33:37 +00:00
Alexandre Poirot
613fcbb932 Bug 1675256 - [devtools] Remove discardRequestBody and discardResponseBody attributes of NETWORK_EVENT resource. r=bomsy,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95846
2020-11-04 17:14:03 +00:00
Alexandre Poirot
2de72821eb Bug 1675237 - [devtools] Set NETWORK_EVENT resource's isRacing attribute early, on securityInfo update. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D95836
2020-11-04 17:14:03 +00:00
Yura Zenevich
c7aaa8e041 Bug 1654956 - add UI for displaying tabbing order overlay in the accessibility panel. r=jdescottes,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D94926
2020-11-03 15:33:16 +00:00
Yura Zenevich
ba825c5746 Bug 1654956 - add AccessibleWalker functionality to show/hide tabbing order overlay. r=jdescottes,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D94925
2020-11-03 15:33:09 +00:00
Csoregi Natalia
7f8521b157 Backed out changeset b39d14d9fe26 (bug 1673934) for debugger failures. CLOSED TREE 2020-11-04 13:19:59 +02:00
Hubert Boma Manilla
42cc6b08ee Bug 1675039 - [devtools] Fix crash when serverTiming does not exists r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D95749
2020-11-04 10:37:53 +00:00
Andrey Bienkowski
2ec70a4044 Bug 1673934 - [devtools] Remove defer usage in client/debugger/src/actions/tests/preview.spec.js r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D95275
2020-11-04 10:45:45 +00:00
Kartikaya Gupta
b86f005446 Bug 1673071 - Disable failing tests. r=jrmuizel,marionette-reviewers,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D95429
2020-11-03 23:05:08 +00:00
Razvan Maries
10425eddfc Backed out 7 changesets (bug 1658084, bug 1671983) for perma failures on browser_async_remove_tab.js and browser_e10s_chrome_process.js. CLOSED TREE
Backed out changeset 2e6309c1cdbd (bug 1658084)
Backed out changeset 99aafd9304ef (bug 1671983)
Backed out changeset 80280b85280a (bug 1671983)
Backed out changeset 008db2659002 (bug 1671983)
Backed out changeset 32bd45c7fe3a (bug 1671983)
Backed out changeset 56e227e6580c (bug 1671983)
Backed out changeset a404f809f79d (bug 1671983)
2020-11-04 04:23:47 +02:00
Nika Layzell
5f9c85da95 Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-04 00:55:36 +00:00
Razvan Maries
156298851f Backed out 4 changesets (bug 1673071) for perma failures on grid-minimum-contribution-baseline-shim-vertical-lr.html. CLOSED TREE
Backed out changeset a8ad01797ee0 (bug 1673071)
Backed out changeset f2ed8ed80bf2 (bug 1673071)
Backed out changeset 34d6c0fbfeef (bug 1673071)
Backed out changeset d6857ecf3c81 (bug 1673071)
2020-11-04 00:56:16 +02:00
Kartikaya Gupta
7bfa94e01a Bug 1673071 - Disable failing tests. r=jrmuizel,marionette-reviewers,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D95429
2020-11-03 14:59:47 +00:00
Julian Descottes
5f04ebe1d9 Bug 1654758 - [devtools] Remove usage of actorHasMethod in responsive/ui module r=bradwerth
All the backward compatibility code can be removed.

"setMaxTouchPoints" was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1500672 (FF77)
"simulateScreenOrientationChange" was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1357774 (FF69)
"captureScreenshot" was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1579133 (FF71)

Differential Revision: https://phabricator.services.mozilla.com/D95313
2020-11-03 16:48:25 +00:00