Commit Graph

3725 Commits

Author SHA1 Message Date
Nicholas Nethercote
3b0485fcdb Bug 1294645 - Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl. r=froydnj.
Slightly less than half (93 / 210) of the NS_METHOD instances in the codebase
are because of the use of NS_CALLBACK in
nsI{Input,Output,UnicharInput},Stream.idl. The use of __stdcall on Win32 isn't
important for these callbacks because they are only used as arguments to
[noscript] methods.

This patch converts them to vanilla |nsresult| functions. It increases the size
of xul.dll by about ~600 bytes, which is about 0.001%.

--HG--
extra : rebase_source : c15d85298e0975fd030cd8f8f8e54501f453959b
2016-08-12 17:36:22 +10:00
Wes Kocher
e9097643d5 Merge inbound to central, a=merge 2016-08-12 13:44:29 -07:00
Nicholas Nethercote
bab6d17ebf Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj.
This patch makes the following changes on many in-class methods.

- NS_IMETHODIMP F() override;      --> NS_IMETHOD F() override;
- NS_IMETHODIMP F() override {...} --> NS_IMETHOD F() override {...}
- NS_IMETHODIMP F() final;         --> NS_IMETHOD F() final;
- NS_IMETHODIMP F() final {...}    --> NS_IMETHOD F() final {...}

Using NS_IMETHOD is the preferred way of marking in-class virtual methods.
Although these transformations add an explicit |virtual|, they are safe --
there's an implicit |virtual| anyway because |override| and |final| only work
with virtual methods.

--HG--
extra : rebase_source : 386ee4e4ea2ecd8d5001efabc3ac87b4d6c0659f
2016-08-08 10:54:47 +10:00
Nicholas Nethercote
e7f10a07fd Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.

As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.

--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
2016-08-08 12:18:10 +10:00
Henri Sivonen
cab627f244 Bug 1274400 - Check out javaparser from GitHub instead of Google Code. r=froydnj
MozReview-Commit-ID: 4w8rc0H2E5E

--HG--
extra : rebase_source : 96fd729869703b1f44abe7c8f88906346c99c93b
2016-08-11 16:09:17 +03:00
Gijs Kruitbosch
61094e5a36 Bug 1280584 - implement cloneWithNewRef and thereby make hash/ref links use a simple unified codepath in the IO service, r=valentin
MozReview-Commit-ID: 8FIyclkJPDp

--HG--
extra : rebase_source : 49fb2b12488bd57a5417c7c3bff2211d651c5de7
extra : amend_source : d9940a1d9009930dc2f499417a7e1446d4601c20
2016-07-26 23:38:46 +01:00
Tom Tromey
5538d692d3 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx

--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Chris Peterson
d634a99cad Bug 1277106 - Part 4: Remove MOZ_UTF16() macro. r=Waldo 2016-07-19 21:07:53 -07:00
Chris Peterson
b175c9fdd5 Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo 2016-07-20 22:03:25 -07:00
Masayuki Nakano
379230116b Bug 1260651 part.16 Rename nsHTMLEditUtils to mozilla::HTMLEditUtils (and their files too) r=mccr8
MozReview-Commit-ID: DABzQHszB0c

--HG--
rename : editor/libeditor/nsHTMLEditUtils.cpp => editor/libeditor/HTMLEditUtils.cpp
rename : editor/libeditor/nsHTMLEditUtils.h => editor/libeditor/HTMLEditUtils.h
2016-07-07 14:01:12 +09:00
Thomas Nguyen
4b7ad0e2c5 Bug 1223838 - Fix wrong policy associated with empty string. r=fkiefer,hsivonen
MozReview-Commit-ID: 7kFH39cegmH
2016-05-30 15:17:45 +08:00
Franziskus Kiefer
cbf15542b0 Bug 1223838 - enable perElementReferrer by default. r=hsivonen 2015-12-02 11:12:12 +01:00
Eric Rahm
b2ddb18a6f Bug 1274777 - Check for oveflow. r=peterv 2016-06-08 13:54:05 -07:00
Nicholas Nethercote
b587f77c54 Bug 616421 - Better distinguish invalid mOpCode values in nsHtml5TreeOperation::Perform. r=hsivonen.
This patch:

- Removes eTreeOpAddError{Atom,TwoAtoms}, which are unused.

- Adds a MOZ_CRASHing case for eTreeOpUninitialized.

- Reorders the cases in the switch to match the enum declaration order, which
  makes it easier to see that all opcodes are now covered.
2016-06-02 17:49:44 +10:00
Boris Zbarsky
dc120449d2 Bug 1275698. Get rid of nsScriptSecurityManager::ScriptAllowed and replace it with xpc::Scriptability::Get(obj).Allowed() for better performance and less indirection. r=khuey 2016-05-27 20:26:56 -04:00
Boris Zbarsky
49a90cb122 Bug 1268852. Change <label> elements to not be form-associated anymore. r=bkelly,hsivonen,surkov
The web platform tests changes are just a cherrypick of
https://github.com/w3c/web-platform-tests/pull/2926 so I don't have to add
failure annotations until the next test uplift.

I've audited our uses of nsIFormControl, and this patch looks to me like it
preserves existing behavior in all but the following cases:

1)  nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space
is pressed while something inside a <label> is focused.  We used to not scroll
in this situation; I think this is a bug, so I'm changing that behavior to
scroll instead.

2)  In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case,
when mContent is a <label> we used to return its form's default submit element.
Now we will just return Relation().
2016-05-26 19:39:03 -04:00
Eric Rahm
5e7354d86b Bug 1236923 - Check int for overflow. r=peterv 2016-05-21 10:05:05 -07:00
Boris Zbarsky
3c447f1d99 Bug 1267989 part 1. Rename nsScriptLoader::Add/RemoveExecuteBlocker to Add/RemoveParserBlockingScriptBlocker, to more clearly reflect what it does. r=smaug 2016-05-20 23:13:18 -04:00
Boris Zbarsky
653b3eb5a3 Bug 1273282. Fix the handling of numeric entities in xml-stylesheet href values. r=peterv 2016-05-19 13:48:11 -04:00
Henri Sivonen
b3deac953d Bug 1270381. r=wchen. 2016-05-15 17:03:06 +03:00
Chris Peterson
8a9e2d2bd4 Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium 2016-05-14 00:54:55 -07:00
Chris Peterson
353ee65255 Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium 2016-05-11 00:00:01 -07:00
Kyle Huey
941ab1f522 Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj 2016-05-05 01:45:00 -07:00
Aryeh Gregor
49d7e81abf Bug 1264270 - Parser should output attributes in source order, not reversed; r=hsivonen,bgrins 2016-05-01 15:15:26 +03:00
Carsten "Tomcat" Book
ba3fe0975c Backed out changeset 85ce8cb0639a (bug 1268313)
--HG--
extra : rebase_source : 56d1cf41a2dc4959b67f834e07192a5c772176a8
2016-04-29 14:21:16 +02:00
Kyle Huey
48a594a09e Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj 2016-04-28 14:08:25 -07:00
Yoshi Huang
ba1bb72568 Bug 1263496 - Part 3: fix for nsNullPrincipal::Create
This fixed the locations listed by
http://searchfox.org/mozilla-central/search?q=nsNullPrincipal::Create(&redirect=true
that needs to inherit origin attributes.
2016-04-27 18:38:07 +08:00
Boris Zbarsky
907c772eb9 Bug 1266851. Make <xmp> and <listing> use HTMLPreElement as their primary interface, per <https://github.com/whatwg/html/issues/1015>. r=peterv 2016-04-26 12:50:30 -04:00
Kyle Huey
c73656947b Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj 2016-04-25 17:23:21 -07:00
Ryan VanderMeulen
5250a3ef34 Bug 1233774 - Re-enable the htmlparser mochitests on Windows debug e10s.
--HG--
extra : histedit_source : 8b893630c129c347961e26cbd9fd0f9ebdac7604
2016-04-15 13:26:01 -04:00
Jonathan Watt
fb7bb15e68 Bug 1263782 - Kill off the deprecated nsINode::IsInDoc(). r=baku 2016-03-31 11:58:25 +01:00
Nicholas Nethercote
d8cfadc76d Bug 1261744 - Add two missing null checks for nsStringBuffer::Alloc(). r=erahm.
--HG--
extra : rebase_source : 7465db70cf5a3e19416a742481b3321e8b6eef16
2016-04-07 09:35:50 +10:00
William Chen
303bd1fd42 Bug 1259590 - Remove B2G ACL code. r=khuey 2016-04-07 09:50:01 -07:00
Nicholas Nethercote
cd63c6bfee Bug 1261735 (part 3) - De-virtualize nsIAtom::IsStaticAtom(). r=froydnj,erahm.
This avoids the need for some virtual function calls and also will help lead to
distinct representations for dynamic and static atoms.

--HG--
extra : rebase_source : 16bbe6f1e1309ee3e4fab7a0d222e638178a2a9c
2016-04-06 11:28:40 +10:00
Nicholas Nethercote
e4dec8d42f Bug 1261735 (part 1) - Overhaul the atom implementation. r=froydnj,erahm.
This patch changes things so that dynamic atoms and static atoms have distinct
implementations. This is a step towards allowing dynamic atoms and static atoms
to have different layouts in memory, which will allow static atoms to be
represented more compactly.

Specifically, the patch does the following.

- It renames AtomImpl as DynamicAtom and PermanentAtomImpl as StaticAtom, and
  the latter is no longer a subclass of the former. This required duplicating
  some methods from the former into the latter: ScriptableToString(),
  ToUTF8String(), ScriptableEquals(), IsStaticAtom(). (This duplication will
  disappear in the future if the representations of dynamic atoms and static
  atoms diverge. Indeed, SizeOfIncludingThis() is already different in the two
  classes.)

- It replaces all mentions of "permanent"/"non-permanent" atoms with
  "static"/"dynamic".

- In ~DynamicAtom() it removes the check that causes gAtomTable to be deleted
  when it becomes empty. This will only happen at shutdown and so doesn't seem
  useful.

- It documents better various things, especially the basics of the
  dynamic/static split, the transmutation of dynamic atoms to static atoms, and
  the details of the SizeOf functions.

--HG--
extra : rebase_source : dbf903012e70ebf1a43de1e1088db1bc1b8dd4f4
2016-04-01 11:18:06 +11:00
Nicholas Nethercote
d376f9f82e Bug 1260871 - Remove do_GetAtom() and rename NS_NewAtom() as NS_Atomize(). r=erahm.
do_GetAtom() is currently just a synonym for NS_NewAtom().

--HG--
extra : rebase_source : f4409784f931616cbc300591e6b843d30805c273
2016-03-29 10:09:43 +11:00
Nicholas Nethercote
41e924c6e0 Bug 1257128 (part 1) - Remove nsIAtom.equalsUTF8. r=froydnj.
It's only used in tests.
2016-03-16 21:05:30 +11:00
Gregory Szorc
0f46d6549f Bug 1256558 - Change MUST_CONVERT to avoid C4311 in VS2015; r=khuey
This code is cherry picked from the trunk version of expat.

MozReview-Commit-ID: 8RDaArq2BwO

--HG--
extra : rebase_source : 72d9b56ec2d6d17a99e578017f0e5828ffd3aa1f
2016-03-21 12:00:41 -07:00
Mats Palmgren
81171b713c Bug 1256530 - Fix compiler warnings about casting to larger size. r=hsivonen
Specifically, the Microsoft VS2015u1 compiler said:
warning C4312: 'type cast': conversion from 'unsigned int' to
'nsIContent *' of greater size
2016-03-17 17:27:56 +01:00
Nicholas Nethercote
a2f068b2ad Bug 1253085 - Remove the |PLDHashTable*| argument from PLDHash{HashKey,MatchEntry}. r=froydnj.
This is easy because it's never needed.

--HG--
extra : rebase_source : 78830dab41c40a1544fa55fc69ca9c1c6709d767
2016-03-16 15:33:44 +11:00
sajitk
823704b8d6 Bug 1219482: Replace PRLogModuleInfo with LazyLogModule in various files.r=benjamin 2016-01-28 10:35:00 -08:00
Christoph Kerschbaumer
f29ec8d62f Bug 1254689 - Remove SEC_NORMAL where loadingPrincipal is SystemPrincipal or NullPrincipal. r=sicking 2016-03-09 13:55:59 -08:00
Wilmer Paulino
37e46b9248 Bug 1238545 - Remove nsISimpleUnicharStreamFactory; r=froydnj 2016-01-13 17:04:25 -05:00
Wes Kocher
817d8829fc Backed out changeset 7cbab9ec76d5 (bug 1254689) for browser_dbg_addon-sources.js failures
MozReview-Commit-ID: 3zPliH7mmPj

--HG--
extra : rebase_source : 90a6c96c2106ec23043160ed93041cd7e15b1640
2016-03-09 10:56:23 -08:00
Christoph Kerschbaumer
007c074be0 Bug 1254689 - Remove SEC_NORMAL where loadingPrincipal is SystemPrincipal or NullPrincipal (r=sicking)
MozReview-Commit-ID: LKK3MGMODNI
2016-03-09 09:01:45 -08:00
Jonathan Griffin
0b0e0abda1 Bug 1232780 - Adjust test exclusions for win7 debug e10s, a=test-only 2016-03-01 10:36:31 -08:00
Bogdan Postelnicu
87b035590d Bug 1251235 - changed from naked pointers to UniquePtr to prevent resource leak. r=froydnj
MozReview-Commit-ID: FVZWMdASQKG

--HG--
extra : rebase_source : 48d87dbf8cedf37c801af7739f55b9d7d8762bd6
2016-02-25 16:34:21 +02:00
Dragana Damjanovic
5031bdb80e Bug 580313 - New resource hints for link. r=smaug
--HG--
extra : rebase_source : 5ce4ef05217f6d513052f83a7e18b00d1596417a
2016-02-26 02:41:00 +01:00
Mason Chang
b4c228baec Bug 1246213 - Skia reftest fuzzing for Skia content on OS X. r=jmuizelaar 2016-02-16 09:07:52 -08:00
Henri Sivonen
7a0b1d45ab Bug 1246014. r=wchen. 2016-02-10 12:39:06 +02:00