Commit Graph

561 Commits

Author SHA1 Message Date
amy
a58ca1d174 Bug 976073 - Part 1 : Implement spec, r=jdm r=dveditz 2016-11-09 17:14:21 +08:00
Bill McCloskey
d9f445e359 Bug 792652 - Get rid of CloneProtocol (r=dvander)
CloneProtocol is leftover code from Nuwa. We can remove it now.
2016-11-08 15:22:33 -08:00
Wes Kocher
4b3d16605a Backed out 18 changesets (bug 792652) for build bustage on linux64 a=backout CLOSED TREE
Backed out changeset 90eaf6aec002 (bug 792652)
Backed out changeset ddd915ab4a48 (bug 792652)
Backed out changeset 95eff6c45cae (bug 792652)
Backed out changeset 75855b5a9ab9 (bug 792652)
Backed out changeset b658ebaad5d7 (bug 792652)
Backed out changeset 2ba36b8ac60c (bug 792652)
Backed out changeset 94fcd3bf3f34 (bug 792652)
Backed out changeset cf9c4164eb43 (bug 792652)
Backed out changeset 59e6d0a4f35b (bug 792652)
Backed out changeset bdf86b8b9c43 (bug 792652)
Backed out changeset 8edf4b247250 (bug 792652)
Backed out changeset 63a3c8e4016e (bug 792652)
Backed out changeset e3e496eab991 (bug 792652)
Backed out changeset 5a1e3136323a (bug 792652)
Backed out changeset dbbe3a8c00e7 (bug 792652)
Backed out changeset 1829d5358808 (bug 792652)
Backed out changeset 004cd692ba6d (bug 792652)
Backed out changeset 92e7fee81fa2 (bug 792652)
2016-11-08 12:05:28 -08:00
Bill McCloskey
1a00da8679 Bug 792652 - Get rid of CloneProtocol (r=dvander)
CloneProtocol is leftover code from Nuwa. We can remove it now.
2016-11-08 11:32:23 -08:00
Andi-Bogdan Postelnicu
c62f16bdda Bug 1311669 - Use C++11's override and remove virtual where applicable. r=valentin
MozReview-Commit-ID: Ab5BC8NhbIO
2016-11-08 16:36:58 +02:00
Sebastian Hengst
db89e7fcf4 Bug 1310297 - Remove test annotations using b2g, mulet or gonk: netwerk. r=RyanVM
MozReview-Commit-ID: F2Wm2m6Wrkf

--HG--
extra : rebase_source : bcc9ccffedc16682d872cf8748c2c185bb453fa2
2016-11-05 11:29:21 +01:00
Andi-Bogdan Postelnicu
9d9d070b27 Bug 1311669 - Replace integer literals which are cast to bool. r=valentin
MozReview-Commit-ID: LdvpF0mFA5V

--HG--
extra : rebase_source : 831e71b9f40015636cbea9a6d72c96e7dfd070af
2016-11-01 14:44:10 +02:00
Andi-Bogdan Postelnicu
702a3fbf63 Bug 1311669 - replace default bodies of special member functions with = default; r=valentin
MozReview-Commit-ID: YxHWVHUyDq

--HG--
extra : rebase_source : 24dbb81862770d82a3dc139ba8041bb576cf7cc4
2016-11-01 14:44:09 +02:00
Bill McCloskey
f478d1188c Bug 1306708 - Rename prio to nested in IPDL (r=dvander) 2016-10-04 20:34:54 -07:00
Bill McCloskey
b83db28a45 Revert "Bug 1306708 - Rename prio to nested in IPDL (r=dvander)" on a CLOSED TREE
This reverts commit b1460c626078afbb9290e7d9ecaf3af605d5e893.
2016-10-04 15:55:19 -07:00
Bill McCloskey
eddd80027c Bug 1306708 - Rename prio to nested in IPDL (r=dvander) 2016-10-04 15:28:14 -07:00
Jesper Kristensen
05fa4f284c Bug 777620 - Support access to private prowsing cookies in nsICookieManager. r=jduell
MozReview-Commit-ID: G97YHqCOpM6

--HG--
extra : rebase_source : 9faaa28f12e8e25dcf1b951fa86a1b40d65b251c
2016-03-31 18:29:27 +02:00
Andrea Marchesini
a3e7227683 Bug 1280590 - nsICookieManager2.cookieExists must use the originAttributes - part 2, r=me 2016-09-30 08:30:15 +02:00
Andrea Marchesini
14d32a0990 Bug 1280590 - nsICookieManager2.cookieExists must use the originAttributes, r=smaug 2016-09-30 08:24:21 +02:00
Carsten "Tomcat" Book
c89ca66d22 Backed out changeset 826cc48624a3 (bug 1280590) for windows m-oth and xpc crashes
--HG--
extra : rebase_source : 895634096f3c1e275ab4f74f1d93691f5b55e22c
2016-09-29 15:28:53 +02:00
Andrea Marchesini
f69927d55d Bug 1280590 - nsICookieManager2.cookieExists must use the originAttributes, r=smaug 2016-09-29 12:02:30 +02:00
Carsten "Tomcat" Book
baff2f0613 Backed out changeset 885e361d4c73 (bug 1280590) for xpcshell bustage 2016-09-28 15:08:45 +02:00
Andrea Marchesini
cd5d3f1870 Bug 1280590 - nsICookieManager2.cookieExists must use the originAttributes, r=smaug 2016-09-28 08:05:12 +02:00
Umesh Panchaksharaiah
056d5a6135 Bug 1301629 - Fix incorrect parameter name in comments. r=ettseng
--HG--
extra : rebase_source : a45c6c9641ceb70301e8bcd957a3e21c95aef423
2016-09-14 19:57:20 +02:00
Josh Matthews
7784aa2e51 Bug 1302824 - Avoid duplicating domain-matching and path-matching logic in cookie service. r=ehsan 2016-09-19 15:40:12 -04:00
Jonathan Hao
108459bd3b Bug 1272856 - Fix intermittent e10s browser_originattributes.js r=ehsan
--HG--
extra : rebase_source : 5b17628829673c1174273ef6423a062912d10ca2
2016-09-13 03:06:00 +02:00
Yoshi Huang
1b06918946 Bug 1301406 - replace SerializedLoadContext with NeckoOriginAttributes. r=smaug, ehsan, jduell
SerializedLoadContext carries the origin attributes of the docshell to
parent process. However document could have different origin attributes
than the docshell's. And the origin attributes of the document comes
from the LoadInfo of the channel.
So we replace SerializedLoadContext with NeckoOriginAttributes, which is from
the loadInfo of the channel, therefore parent can get the correct origin
attributes from the document.
2016-09-20 14:24:23 +08:00
Josh Matthews
3b4eeee788 Bug 1264192 - Adjust cookie eviction heuristics when exceeding the maximum cookies allowed per host. r=ehsan
If no expired cookies exist, in order of preference, evict the oldest:
* session cookie with a non-matching path
* session cookie with a matching path
* non-session cookie with a non-matching path
* non-session cookie with a matching path

This replaces the previous heuristic of evicting the oldest cookie, irregardless of any other attributes,
if no expired cookies were present. This ensures that cookies that are already considered transient by
web applications will be removed first, followed by cookies that are unrelated to the response that is
adding new cookies.
* * *
Bug 1264192 - Interdiff
2016-09-09 16:29:15 -04:00
Sebastian Hengst
80e39088f2 Backed out changeset 2ecd402d3934 (bug 1264192) for frequent failure in netwerk/cookie/test/unit/test_eviction.js. r=backout 2016-09-04 15:07:24 +02:00
Tim Huang
55292e77a0 Bug 1278037 - Part 1: Modify the getCookiesWithOriginAttributes of the nsICookieManager2 to take the host as an optional argument. r=jdm
--HG--
extra : rebase_source : 918c1f81dedb5dfa6ddb9a78b613ace6f34f4758
extra : histedit_source : f28df59c4b608f7311e04dc00bce286624d7ad81
2016-07-28 11:46:04 +08:00
Josh Matthews
64a98fc3b7 Bug 1264192 - Adjust cookie eviction heuristics when exceeding the maximum cookies allowed per host. r=ehsan
If no expired cookies exist, in order of preference, evict the oldest:
* session cookie with a non-matching path
* session cookie with a matching path
* non-session cookie with a non-matching path
* non-session cookie with a matching path

This replaces the previous heuristic of evicting the oldest cookie, irregardless of any other attributes,
if no expired cookies were present. This ensures that cookies that are already considered transient by
web applications will be removed first, followed by cookies that are unrelated to the response that is
adding new cookies.

--HG--
extra : amend_source : f79ba9dd393a3f37760e643b10b7137e37a6397a
2016-08-26 18:04:47 -04:00
Nicholas Nethercote
b71747b2ac Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.

--HG--
extra : rebase_source : 886e57a9e433e0cb6ed635cc075b34b7ebf81853
2016-09-01 15:01:16 +10:00
Sumit Tiwari
054b2202b0 Bug 1298512 - Remove aRequireHostMatch to nsCookieService::CheckPrefs; r=jdm
MozReview-Commit-ID: 2SdJhbJtBDO

--HG--
extra : rebase_source : 1c19d0de7f2c8052a7691d474a864e260c35daba
2016-08-26 21:42:04 -04:00
James Andreou
4c787b8989 Bug 1282882 - Remove LoadContextInfo and LoadContext private browsing flags; r=jdm,mayhemer 2016-08-26 13:06:48 -04:00
Nicholas Nethercote
c2306345d5 Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm.
This patch removes checking of all the callback calls in memory reporter
CollectReport() functions, because it's not useful.

The patch also does some associated clean-up.

- Replaces some uses of nsIMemoryReporterCallback with the preferred
  nsIHandleReportCallback typedef.

- Replaces aCallback/aCb/aClosure with aHandleRepor/aData for CollectReports()
  parameter names, for consistency.

- Adds MOZ_MUST_USE/[must_use] in a few places in nsIMemoryReporter.idl.

- Uses the MOZ_COLLECT_REPORT macro in all suitable places.

Overall the patch reduces code size by ~300 lines and reduces the size of
libxul by about 37 KiB on my Linux64 builds.

--HG--
extra : rebase_source : e94323614bd10463a0c5134a7276238a7ca1cf23
2016-08-24 15:23:45 +10:00
Jason Duell
603d8711c3 Bug 1005184 - Clarify comments in Necko ActorDestroy functions clarifying that nothing needs to be implemented. r=jduell
--HG--
extra : rebase_source : fce9be11972f5117cf85a326d0d31a746f11df41
2016-08-23 16:21:00 -04:00
Kan-Ru Chen
b6d880aca1 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES


--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Kan-Ru Chen
429b0cc56b Bug 1295103 - Check OriginAttributes::PopulateFromSuffix return value in nsCookieService. r=mayhemer
MozReview-Commit-ID: 8aN6faugiqq

--HG--
extra : rebase_source : 6a779feec1845f1b1f0154641136368c494dc42a
2016-08-15 18:18:19 +08:00
amy
819f6f556d Bug 368964 - Cookie expires attribute should be absolute, not relative to server time. r=ehsan 2016-08-19 17:28:09 +08:00
Nicholas Nethercote
bab6d17ebf Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj.
This patch makes the following changes on many in-class methods.

- NS_IMETHODIMP F() override;      --> NS_IMETHOD F() override;
- NS_IMETHODIMP F() override {...} --> NS_IMETHOD F() override {...}
- NS_IMETHODIMP F() final;         --> NS_IMETHOD F() final;
- NS_IMETHODIMP F() final {...}    --> NS_IMETHOD F() final {...}

Using NS_IMETHOD is the preferred way of marking in-class virtual methods.
Although these transformations add an explicit |virtual|, they are safe --
there's an implicit |virtual| anyway because |override| and |final| only work
with virtual methods.

--HG--
extra : rebase_source : 386ee4e4ea2ecd8d5001efabc3ac87b4d6c0659f
2016-08-08 10:54:47 +10:00
Tom Tromey
5538d692d3 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx

--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Chris Peterson
b175c9fdd5 Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo 2016-07-20 22:03:25 -07:00
Daniel Veditz
d6202de12b Bug 1283368 - Implement cookie prefixes spec, r=valentin r=amchung 2016-06-29 22:42:36 -07:00
Jarda Snajdr
7d691d831b Bug 1194208 - Remove storage inspector stores-reloaded event. r=mratcliffe 2016-07-04 02:48:00 +02:00
Ralph Giles
2635086221 Bug 1275744 - Reference MOZ_LOG in netwerk comments. r=erahm
NSPR_LOG_MODULES is deprecated.

Programs in the test directory still use PR_NewLogModule,
so NSPR_LOG_MODULES is accurate for them. Getting these
to link against libxul for LazyLogModule is still to do,
so leave those for now.

MozReview-Commit-ID: 3uMR3YPJyyi

--HG--
extra : rebase_source : a94c6392cb0de1b6d6324b192954f48f784e8cbe
2016-05-25 16:13:54 -07:00
Valentin Gosu
704a204aff Bug 1276442 - Backout 6647b13a6ad9 (Bug 219157) a=backout 2016-05-30 16:05:21 +02:00
Tim Huang
c4f79ec32f Bug 1267910 - Part 3: Add test cases for add() and getCookiesFromHost() of the nsICookieManager2. r=jdm
--HG--
extra : rebase_source : d99511c519fd305177b8b55c17f7c2a2e6dd44ce
2016-05-25 11:54:22 +08:00
Tim Huang
cc903e433a Bug 1267910 - Part 1: Make the API getCookiesFromHost of the nsICookieManager2 OriginAttributes-aware. r=jdm
--HG--
extra : rebase_source : 18945a3aac4c331a1513ac402553d725cf334b76
2016-05-25 11:54:21 +08:00
mitchdevel
ce5b229c18 Bug 219157 - Fix to prevent 3rd party sites from getting cookies r=valentin
MozReview-Commit-ID: A0ltsuDnxnf
2016-05-20 16:48:00 +02:00
Wes Kocher
2596f34110 Backed out 3 changesets (bug 1267910) for reports of it breaking session restore a=backout
Backed out changeset 5962f8e6d030 (bug 1267910)
Backed out changeset f8afc5cf9e0e (bug 1267910)
Backed out changeset cc202e0ac0dd (bug 1267910)
2016-05-20 21:15:17 -07:00
Tim Huang
bfd4ca4961 Bug 1267910 - Part 3: Add test cases for add() and getCookiesFromHost() of the nsICookieManager2. r=jdm
--HG--
extra : rebase_source : c81c3692ee7203e0023e7e2aab42c5ca1cad1b87
2016-05-18 20:44:00 -04:00
Tim Huang
589b71d649 Bug 1267910 - Part 1: Make the API getCookiesFromHost of the nsICookieManager2 OriginAttributes-aware. r=jdm
--HG--
extra : rebase_source : a36d46df6a43f2a1283bf4c2f55b0d2247c98673
2016-05-13 02:29:00 -04:00
Chris Peterson
353ee65255 Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium 2016-05-11 00:00:01 -07:00
Ethan Tseng
7bf2d7f142 Bug 1214071 - Replace Get/RemoveCookiesForApp() with Get/RemoveCookiesWithOriginAttributes() r=ehsan
MozReview-Commit-ID: JTi1BwBVvyA
2016-01-08 17:58:56 +08:00
Jonathan Hao
9b7088faeb Bug 1214071 - Tests for Get/RemoveCookiesWithOriginAttributes() r=ehsan
MozReview-Commit-ID: 5kqqfI9OdVn
2016-05-12 10:12:47 +08:00