Commit Graph

101 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
1f3abc7835 Bug 1630837 - Optimize CC of rules from constructable stylesheets. r=smaug,nordzilla
This removes StyleSheet::GetComposedDoc because it wasn't doing the
right thing, and while constructable stylesheets _could_ in theory
return something meaningful (the constructor doc iff any adopters is
connected), it's not a concept we need in other places for now.

Differential Revision: https://phabricator.services.mozilla.com/D71261
2020-04-17 21:12:11 +00:00
Emilio Cobos Álvarez
a65fe39265 Bug 1600155 - Make @import rules less weird. r=heycam
Have their own notification for when the child sheet loads instead of
piggy-backing in the RuleAdded one, and make the callers check instead.

This prevents incorrectly marking as modified sheets which only have @import
rules.

Differential Revision: https://phabricator.services.mozilla.com/D55184

--HG--
extra : moz-landing-system : lando
2019-11-30 12:24:24 +00:00
Emilio Cobos Álvarez
2c0c593033 Bug 1600376 - Remove useless namespace qualifications in layout/style. r=jwatt
All these things are in the mozilla namespace and such. Clean up a bit.

Differential Revision: https://phabricator.services.mozilla.com/D55319

--HG--
extra : moz-landing-system : lando
2019-11-30 11:57:10 +00:00
Emilio Cobos Álvarez
8d47bdf9ba Bug 1566684 - Make sure to unlink rule declarations before unlinking css::Rule. r=smaug,emilio
Rules and their declarations are a single object as far as the CC is concerned.  They have a single nsCycleCollectionISupports and they are represented by a single node in the CC graph.  That single object has two nsWrapperCache instances in it that point to different JS objects, and we need to make sure that the ordering of the unlink operations for those nsWrapperCache instances is handled correctly.

Differential Revision: https://phabricator.services.mozilla.com/D38326

--HG--
extra : moz-landing-system : lando
2019-07-22 18:33:29 +00:00
Cameron McCormack
e95797966a Bug 1539159 - Prevent modification of UA style sheets. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D25661

--HG--
extra : moz-landing-system : lando
2019-04-29 05:34:06 +00:00
Emilio Cobos Álvarez
d2ed260822 Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.

Overall it's not a very interesting patch I think.

nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.

I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.

While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
2019-01-03 17:48:33 +01:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Cameron McCormack
48fe6dbe69 Bug 1472065 - Initialize mSheet and mParentRule in css::Rule's constructor. r=xidorn
MozReview-Commit-ID: JI3cMiJaH3x

--HG--
extra : rebase_source : 3f45a63c8817df9550c5c638ad5b978421fa051c
2018-06-29 12:56:09 +10:00
Jeff Gilbert
5b753da289 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Emilio Cobos Álvarez
2054320f28 Bug 1459529: Make sheets be associated to a shadow root too potentially. r=bz
MozReview-Commit-ID: Cd8xJuLRY5w
2018-05-15 18:44:25 +02:00
Xidorn Quan
12ad13c3fd Bug 1451216 - Remove Rule::Clone method. r=emilio
MozReview-Commit-ID: 6Re8DENmdUT

--HG--
extra : rebase_source : a39ad55f43a8cddccef94e4f0add2c77eb57c245
2018-04-05 18:18:17 +10:00
Xidorn Quan
e1ecaae43e Bug 1449390 - Remove Rule::GetType() and its corresponding constants. r=emilio
MozReview-Commit-ID: 5r64ATHUAux

--HG--
extra : rebase_source : 9a593b6ed1a1006bfac031c3b47b06a7e28605b4
2018-03-28 14:22:01 +11:00
Xidorn Quan
70a598f41e Bug 1449103 part 1 - Make Rule::mParentRule not necessarily a GroupRule. r=emilio
For part 2, where CSSKeyframesRule will inherit directly from Rule while
it is parent rule for its CSSKeyframeRules.

It seems there is nothing relying on mParentRule being a GroupRule so we
can just change it.

MozReview-Commit-ID: Cyte6h3Q2LB

--HG--
extra : rebase_source : 01ac2ab201a1438aa73eadc5cce0ea67e164ecce
2018-03-28 12:20:41 +11:00
Boris Zbarsky
b48329cce4 Bug 1434390. Mostly get rid of GetCssTextImpl. r=emilio
MozReview-Commit-ID: 5fejArxQckq
2018-01-30 16:30:08 -05:00
Cameron McCormack
55dcbea002 Bug 1427512 - Part 16: Remove nsIDOMCSSRule. r=xidorn,jryans,bz
MozReview-Commit-ID: GvVdW9w5Cc4
2018-01-11 16:17:56 +08:00
Daniel Holbert
680815cd6e Bug 1412346 part 5: (automated patch) Switch a bunch of C++ files in layout to use our standard mode lines. r=jfkthame
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py

For every file that is modified in this patch, the changes are as follows:
 (1) The patch changes the file to use the exact C++ mode lines from the
     Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line

 (2) The patch deletes any blank lines between the mode line & the MPL
     boilerplate comment.

 (3) If the file previously had the mode lines and MPL boilerplate in a
     single contiguous C++ comment, then the patch splits them into
     separate C++ comments, to match the boilerplate in the coding style.

MozReview-Commit-ID: EuRsDue63tK

--HG--
extra : rebase_source : 3356d4b80ff6213935192e87cdbc9103fec6084c
2017-10-27 10:33:53 -07:00
Xidorn Quan
082e026668 Bug 1345696 part 1 - Lots of fixup for the next patch. r=heycam
The next patch moves nsCSSFontFaceRule into a separate header, which
somehow affects lots of header dependencies. I'm not completely sure
why this happens, though.

MozReview-Commit-ID: KuXbsaX0NUd

--HG--
extra : rebase_source : cef91018964b5488c5031df8aada90aa7fa0ad51
2017-03-28 20:05:12 +11:00
Xidorn Quan
0e11635123 Bug 1315601 part 8 - Constify Rule::GetCssText. r=heycam
MozReview-Commit-ID: Dn2lWQWUedL

--HG--
extra : rebase_source : 6051886a6695e01f811fecdcdbf2274b2dd470e9
2017-03-08 12:10:16 +11:00
L. David Baron
37f705d303 Bug 1333158 - Remove StyleSheet::GetDocument in favor of the identical GetAssociatedDocument. r=bz
(GetAssociatedDocument was recently renamed in bug 1332353.)

Note that the inconsistency between the Rule and CSSParser method names
is slightly bothersome.

MozReview-Commit-ID: L1SBIV86H4s

--HG--
extra : transplant_source : %60%BE%A8%B9%2BP9%8E_%8AX%28%DE%E7%12%83%1A%0E%FF%FD
2017-01-23 13:12:03 -08:00
Boris Zbarsky
41da750c3e Bug 851892 part 20. Remove the remaining bits we added to support a mix of WebIDL and non-WebIDL rules. r=peterv 2017-01-13 10:41:05 -05:00
Boris Zbarsky
7f64e99cc4 Bug 851892 part 9. Add a CSSRule Web IDL interface. r=peterv,heycam
Note that this explicitly drops CSSRule.UNKNOWN_RULE.
2017-01-13 10:41:03 -05:00
Boris Zbarsky
0da388ba25 Bug 851892 part 8. Get rid of css::Rule::GetDOMRule. r=heycam 2017-01-13 10:41:03 -05:00
Boris Zbarsky
4fe3d0c6dd Bug 851892 part 7. Push the nsIDOMCSSRule implementation up to css::Rule. r=heycam 2017-01-13 10:41:02 -05:00
Boris Zbarsky
1d545c87da Bug 851892 part 6. Make css::Rule inherit from nsIDOMCSSRule. r=heycam 2017-01-13 10:41:02 -05:00
Boris Zbarsky
637e48e6e3 Bug 851892 part 4. Make css::Rule wrappercached. r=heycam,peterv,smaug
Note that this increases the size of css::Rule by three words, unfortunately.
2017-01-13 10:41:02 -05:00
Boris Zbarsky
6e795d159b Bug 851892 part 2. Remove the now-unused GetExistingDOMRule method. r=heycam 2017-01-13 10:41:02 -05:00
Boris Zbarsky
65f894384a Bug 851892 part 1. Make all CSS rules cycle-collected. r=heycam,smaug 2016-11-30 18:18:14 -05:00
Sebastian Hengst
3c9c348769 Backed out changeset 9a4b96c10b23 (bug 851892) for build bustage. r=backout on a CLOSED TREE 2017-01-20 19:31:31 +01:00
Sebastian Hengst
c2dff8d692 Backed out changeset 795ebf4423ba (bug 851892) 2017-01-20 19:30:59 +01:00
Sebastian Hengst
63caf1fba9 Backed out changeset 3be6690b9f0a (bug 851892) 2017-01-20 19:30:50 +01:00
Sebastian Hengst
7f2820fd7b Backed out changeset 271c7cd7b59a (bug 851892) 2017-01-20 19:30:41 +01:00
Sebastian Hengst
24246c7ba1 Backed out changeset 659550973d4d (bug 851892) 2017-01-20 19:30:37 +01:00
Sebastian Hengst
bcb6968086 Backed out changeset 9ef39356f62c (bug 851892) 2017-01-20 19:30:32 +01:00
Sebastian Hengst
6a2dfd7d83 Backed out changeset b975a988fb33 (bug 851892) 2017-01-20 19:30:28 +01:00
Sebastian Hengst
d310ee3521 Backed out changeset c79e8bee853e (bug 851892) 2017-01-20 19:29:38 +01:00
Boris Zbarsky
7b5144e947 Bug 851892 part 20. Remove the remaining bits we added to support a mix of WebIDL and non-WebIDL rules. r=peterv 2017-01-13 10:41:05 -05:00
Boris Zbarsky
7d89c9b854 Bug 851892 part 9. Add a CSSRule Web IDL interface. r=peterv,heycam
Note that this explicitly drops CSSRule.UNKNOWN_RULE.
2017-01-13 10:41:03 -05:00
Boris Zbarsky
4cc8d36e13 Bug 851892 part 8. Get rid of css::Rule::GetDOMRule. r=heycam 2017-01-13 10:41:03 -05:00
Boris Zbarsky
e1ec75387e Bug 851892 part 7. Push the nsIDOMCSSRule implementation up to css::Rule. r=heycam 2017-01-13 10:41:02 -05:00
Boris Zbarsky
18c01c8290 Bug 851892 part 6. Make css::Rule inherit from nsIDOMCSSRule. r=heycam 2017-01-13 10:41:02 -05:00
Boris Zbarsky
ec2fad773f Bug 851892 part 4. Make css::Rule wrappercached. r=heycam,peterv,smaug
Note that this increases the size of css::Rule by three words, unfortunately.
2017-01-13 10:41:02 -05:00
Boris Zbarsky
5bb4a84030 Bug 851892 part 2. Remove the now-unused GetExistingDOMRule method. r=heycam 2017-01-13 10:41:02 -05:00
Boris Zbarsky
e92f7dfbdc Bug 851892 part 1. Make all CSS rules cycle-collected. r=heycam,smaug 2016-11-30 18:18:14 -05:00
Phil Ringnalda
686006613e Backed out 20 changesets (bug 851892) for load failures in Android crashtest-4
Backed out changeset b9c4115cdeac (bug 851892)
Backed out changeset 5f491bf49b85 (bug 851892)
Backed out changeset 9bf5bcb3e8c5 (bug 851892)
Backed out changeset a9cab46e8b45 (bug 851892)
Backed out changeset 73858e15c8c0 (bug 851892)
Backed out changeset a25638588b6b (bug 851892)
Backed out changeset d58e0e5069ef (bug 851892)
Backed out changeset d8da2a3d8f10 (bug 851892)
Backed out changeset a8da3c34983f (bug 851892)
Backed out changeset 29cf8acbd21e (bug 851892)
Backed out changeset c53cd7bdf8b3 (bug 851892)
Backed out changeset e841a2796375 (bug 851892)
Backed out changeset 2eab85b00159 (bug 851892)
Backed out changeset ca4b1fb9cae4 (bug 851892)
Backed out changeset 74c0ba66f108 (bug 851892)
Backed out changeset 719bb9f41e5b (bug 851892)
Backed out changeset d6aa4c6192df (bug 851892)
Backed out changeset dc81a167a75d (bug 851892)
Backed out changeset 65422477b3a5 (bug 851892)
Backed out changeset 3089dd379077 (bug 851892)
2017-01-15 11:50:10 -08:00
Boris Zbarsky
2e450c06d0 Bug 851892 part 20. Remove the remaining bits we added to support a mix of WebIDL and non-WebIDL rules. r=peterv 2017-01-13 10:41:05 -05:00
Boris Zbarsky
cea6088d45 Bug 851892 part 9. Add a CSSRule Web IDL interface. r=peterv,heycam
Note that this explicitly drops CSSRule.UNKNOWN_RULE.
2017-01-13 10:41:03 -05:00
Boris Zbarsky
13b4594e28 Bug 851892 part 8. Get rid of css::Rule::GetDOMRule. r=heycam 2017-01-13 10:41:03 -05:00
Boris Zbarsky
52920d72fc Bug 851892 part 7. Push the nsIDOMCSSRule implementation up to css::Rule. r=heycam 2017-01-13 10:41:02 -05:00
Boris Zbarsky
f7a5133a06 Bug 851892 part 6. Make css::Rule inherit from nsIDOMCSSRule. r=heycam 2017-01-13 10:41:02 -05:00
Boris Zbarsky
56e3ade4f8 Bug 851892 part 4. Make css::Rule wrappercached. r=heycam,peterv
Note that this increases the size of css::Rule by three words, unfortunately.
2017-01-13 10:41:02 -05:00