Commit Graph

10880 Commits

Author SHA1 Message Date
serge-sans-paille
58903aaa06 Bug 1856988 - Vendor libfuzzer using mach vendor r=decoder
We hit some limitations of the globbing system in exclude file, which
relies on glob.iglob and skips dotfiles...

As a side effect update the license to the one actually shipped with
libfuzzer.

Differential Revision: https://phabricator.services.mozilla.com/D190068
2023-10-05 18:45:40 +00:00
Emilio Cobos Álvarez
5e24b302c6 Bug 1857282 - Add a layout try preset. r=dshin
This is roughly what I use for a common sanity-check. Does it feel
useful? Am I missing something?

Differential Revision: https://phabricator.services.mozilla.com/D190213
2023-10-05 17:29:55 +00:00
Cristian Tuns
39cbd706eb Backed out changeset 6b3aa93d1a33 (bug 1856988) for causing lint failures in moz.yaml CLOSED TREE 2023-10-05 10:13:05 -04:00
serge-sans-paille
e9ccf17041 Bug 1856988 - Vendor libfuzzer using mach vendor r=decoder
We hit some limitations of the globbing system in exclude file, which
relies on glob.iglob and skips dotfiles...

As a side effect update the license to the one actually shipped with
libfuzzer.

Differential Revision: https://phabricator.services.mozilla.com/D190068
2023-10-05 13:23:46 +00:00
Christian Holler
53368507cb Bug 1855915 - Make IPCFuzzController less verbose when actors are destroyed. r=truber
Differential Revision: https://phabricator.services.mozilla.com/D189631
2023-10-04 10:01:27 +00:00
Julien Cristau
93630da8b8 Bug 1851988 - fix some python string escape sequences r=webdriver-reviewers,perftest-reviewers,whimboo,afinder,releng-reviewers,firefox-build-system-reviewers,ahal,sergesanspaille
Use r-strings or escape backslashes to avoid a deprecation warning.

Differential Revision: https://phabricator.services.mozilla.com/D187655
2023-10-04 09:49:09 +00:00
Mike Hommey
ae92ce00f6 Bug 1856532 - Upgrade builders to clang 17.0.2. r=firefox-build-system-reviewers,sergesanspaille
Differential Revision: https://phabricator.services.mozilla.com/D189899
2023-10-03 20:48:31 +00:00
Greg Mierzwinski
1a79922213 Bug 1856379 - [perfdocs] Produce a lint error when no files were changed. r=perftest-reviewers,kshampur
This patch fixes an issue where the PerfDocLogger only produced an error when any file was changed which results in some odd behaviours. Now, when no files are changed, we produce a lint error that doesn't specify the file that contains the error. At the same time, a test is added for this.

Differential Revision: https://phabricator.services.mozilla.com/D189934
2023-10-03 18:56:34 +00:00
Connor Sheehan
8c8624b6dd Bug 1856588: clarify --push-to-lando pushes stack plus one try commit r=zeid
The statement "pushed 3 commits" can be confusing because the user has
actually pushed 2 of their own commits, plus one try config commit. Clarify
this in the command output.

Differential Revision: https://phabricator.services.mozilla.com/D189944
2023-10-03 15:08:54 +00:00
Rob Wu
98a3343ddf Bug 1856473 - Add webextensions-tests preset r=extension-reviewers,zombie
The path of GeckoView extension tests [1] are not included in the query,
because they would not be run anyway (bug 1826909).

[1]: mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/WebExtensionTest.kt

Differential Revision: https://phabricator.services.mozilla.com/D189869
2023-10-03 09:34:15 +00:00
Sylvestre Ledru
73b18f5ab7 Bug 1856530 - enable file-perm on toml files r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D189898
2023-10-03 09:22:19 +00:00
Sylvestre Ledru
f8cfe7202a Bug 1856530 - enable file-whitespace on toml files r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D189897
2023-10-03 09:22:19 +00:00
Sylvestre Ledru
4c29c24344 Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Connor Sheehan
c1c2126fce Bug 1835962: add support for mach try to submit to Lando r=zeid,mach-reviewers,ahochheiden
Add support for submitting stacks of commits to Lando for queueing
on Try, instead of pushing to hg.mozilla.org directly. This patch
implements the Device Code Authorization flow for Auth0, simple changeset
discovery and patch gathering, and submissing to Lando via HTTP POST.

Add a `try.txt` virtualenv site that contains packages from the common
virtualenv as well as the `auth0-python` package for verifying Auth0
JWTs. Use this new virtualenv for `mach try` and related subcommands.
Add a `--push-to-lando` flag that controls whether the push will be made
via the Lando API or using the VCS to hg.mozilla.org directly.

Create a `lando.py` module in the `tryselect` package that handles the
details around submitting to Lando. Authentication is handled by the
Device Code Authorization flow, and the returned access token is saved
to the mozbuild state directory. Auth0 details are added to the `.lando.ini`
file in the repo root, and a `LANDO_TRY_USE_DEV` environment variable can
be set to control submitting to the prod or dev Lando environments.
This module also includes patch stack gathering and discovery via `mozversioncontrol`.

mozversioncontrol's `Repository` subclass is extended with helper functions
to gather patch files from Mercurial and Git. We also add a `try_config_commit`
context manager that creates a temporary commit to hold try syntax commit
messages and/or a `try_task_config.json` file, which is removed from version
control on submission.

The `mach try` cram tests now use a separate virtualenv that must be built
before running, causing unexpected output in the tests. Run `mach try --help`
in the test setup to force the virtualenv to be built before running any
test.

`mach try chooser` would previously install packages for a small web application
from a `requirements.txt` file when run. Install these via the new `try.txt`
site environment instead. The required dependencies are also added to the
`python-test.txt` site since they will cause some tests to fail due to the
missing dependencies.

Differential Revision: https://phabricator.services.mozilla.com/D187641
2023-10-02 14:31:43 +00:00
Mark Banner
bed6c05a75 Bug 1774888 - Remove XPCOMUtils.defineLazyModuleGetter. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D189722
2023-10-02 09:48:01 +00:00
Andi-Bogdan Postelnicu
72276f379c Bug 1855848 - fix infra bust for static-analysis autotest. r=sylvestre DONTBUILD
This is because the std is not located in the default location where the compiler
searches.
This is normal, but for autotest we don't generate a compile commands through the build
system, we generate a dummy one, with dummy paths so we need to transplant definitions
from std to the test files.

Differential Revision: https://phabricator.services.mozilla.com/D189619
2023-09-29 22:01:46 +00:00
Joel Maher
60cffb40ee Bug 1853245 - Migrate .ini to .toml browser-chrome (batch 7.75). r=aryx,extension-reviewers,application-update-reviewers,credential-management-reviewers,places-reviewers,profiler-reviewers,nalexander,canaltinova,Standard8,robwu,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D189382
2023-09-29 20:40:10 +00:00
Narcis Beleuzu
33ed26cf06 Backed out changeset 8265e6272d20 (bug 1853245) for breaking the Decision Task. CLOSED TREE 2023-09-29 19:45:01 +03:00
Joel Maher
56f31dc67a Bug 1853245 - Migrate .ini to .toml browser-chrome (batch 7.75). r=aryx,extension-reviewers,application-update-reviewers,credential-management-reviewers,places-reviewers,profiler-reviewers,nalexander,canaltinova,Standard8,robwu,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D189382
2023-09-29 16:27:29 +00:00
Mike Hommey
83f4904aca Bug 1855631 - Upgrade bindgen to 0.68.1. r=emilio,supply-chain-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189457
2023-09-29 00:06:10 +00:00
Jan Varga
c458754592 Bug 1855134 - Move existing MOZ_TRY macros to a dedicated header file; r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D189226
2023-09-28 20:46:07 +00:00
Sylvestre Ledru
1ee8840016 Bug 1855672 - Enable some new clang-tidy checkers r=andi DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D189486
2023-09-28 16:03:55 +00:00
Tim Huang
051088939f Bug 1834274 - Part 1: Implement nsIRFPService.idl for nsRFPService. r=emilio
To allow remote settings client to set fingerprinting overrides from
Javascript, we need to implement nsIRFPService for nsRFPService.

This patch changes the return format of nsRFPService::GetOrCreate() to
match the singleton implementation of nsIRFPService. As a result of it,
we need to change the first init call in nsContentUtils because we
cannot forward a already_AddRefed<> to mozilla::Unused. It will cause a
memory leak.

Differential Revision: https://phabricator.services.mozilla.com/D182809
2023-09-27 14:58:25 +00:00
Mark Banner
03c088d08d Bug 1851632 - Add ESLint documentation about adding rules and plugins. r=Gijs,mossop
Differential Revision: https://phabricator.services.mozilla.com/D187475
2023-09-26 21:27:40 +00:00
Yury Delendik
8667790959 Bug 1846534 - Track unwind info for tail calls. r=jseward,mstange,profiler-reviewers
Tail calls are doing some stack data manipulations, and profiler (iterator) needs to know how to find where caller RA and FP stored. A platform now preserves temporary registers used to store FP/RA using collapse frame operations.

Differential Revision: https://phabricator.services.mozilla.com/D183269
2023-09-26 21:08:00 +00:00
Sandor Molnar
b15dd3b0d9 Backed out 4 changesets (bug 1834274) Mn failures on browser/components/tests/marionette/test_no_errors_clean_profile.py CLOSED TREE
Backed out changeset c28b3520f3d7 (bug 1834274)
Backed out changeset e57a1b1b05c8 (bug 1834274)
Backed out changeset aae42550c449 (bug 1834274)
Backed out changeset 79b200c1060e (bug 1834274)
2023-09-26 19:10:23 +03:00
Tim Huang
d68f687593 Bug 1834274 - Part 1: Implement nsIRFPService.idl for nsRFPService. r=emilio
To allow remote settings client to set fingerprinting overrides from
Javascript, we need to implement nsIRFPService for nsRFPService.

This patch changes the return format of nsRFPService::GetOrCreate() to
match the singleton implementation of nsIRFPService. As a result of it,
we need to change the first init call in nsContentUtils because we
cannot forward a already_AddRefed<> to mozilla::Unused. It will cause a
memory leak.

Differential Revision: https://phabricator.services.mozilla.com/D182809
2023-09-26 14:07:47 +00:00
Mark Banner
adc07ece4e Bug 1854913 - Turn off ESLint rule mozilla/use-chromeutils-generateqi for plain mochitests as it should not apply there. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D189099
2023-09-26 13:38:20 +00:00
Andi-Bogdan Postelnicu
b7b3a15bfc Bug 1855169 - static-analysis autotest fix. r=marco
Fixed fallout from migration to clang-17 where clang-tidy checker
bugprone-swapped-arguments has its message changed a bit.

Differential Revision: https://phabricator.services.mozilla.com/D189211
2023-09-26 10:32:13 +00:00
Mike Hommey
b11b9075c4 Bug 1836193 - Update builders to clang 17. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D188634
2023-09-26 00:17:17 +00:00
Markus Stange
b474c8da56 Bug 1853720 - Add a "hot" variant of AUTO_PROFILER_LABEL, for lower overhead when the profiler is disabled. r=aabh,profiler-reviewers
The overhead is showing up in Speedometer 3, especially in the innerHTML setter
when it calls into the frame constructor.

Full breakdown of callers across sp3 is here: https://share.firefox.dev/3rfckTG

Time spent in AutoProfilerLabel during TodoMVC-jQuery innerHTML:
Before: https://share.firefox.dev/3Znlydp 378 sampes
After: https://share.firefox.dev/45VdVgr 71 samples

Differential Revision: https://phabricator.services.mozilla.com/D188487
2023-09-25 19:36:41 +00:00
Markus Stange
abfc9f5199 Bug 1853720 - Inline-away AutoProfilerLabel::Push. r=aabh,profiler-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D188486
2023-09-25 19:36:41 +00:00
Mark Banner
c2782050e8 Bug 1854948 - Remove support for Cu.import and XPCOMUtils.defineLazyModuleGetter from most of ESLint. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D189132
2023-09-25 14:26:43 +00:00
Julien Cristau
5e4f6d4866 Bug 1854364 - add common options to "empty" try selector. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D188824
2023-09-25 11:52:24 +00:00
Mark Banner
3b817161dd Bug 1854783 - Remove some unnecessary ESLint globals and exports declarations. r=mossop,extension-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D189046
2023-09-25 11:11:54 +00:00
Christian Holler
2740047e37 Bug 1853933 - Make IPCFuzzController less verbose. r=truber
Differential Revision: https://phabricator.services.mozilla.com/D188593
2023-09-21 08:26:27 +00:00
serge-sans-paille
a6838d00a5 Bug 1836901 - Use taskcluster-built python for source-test task r=glandium
Because we use an older version of Python than the one generally used on
the host system, this implied enforcing a few package requirements.

Differential Revision: https://phabricator.services.mozilla.com/D180057
2023-09-20 04:49:03 +00:00
Haik Aftandilian
298f1ffaed Bug 1593072 - Patch 3 - Add parent process, plugin-container, media-plugin-container, and utility entitlement files as v2 versions r=spohl
Add separate entitlement lists for the parent process, plugin-container, and media-plugin-helper executables. Add a utility entitlement list to use for non-browser executables in developer builds to support debugging. For production codesigning versions, only allow loading of unsigned libraries by the media-plugin-helper executable. Limit most entitlements to the parent process executable.

A subsequent fix to taskcluster code will enable the new entitlements.

Other executables in the bundle will have no entitlements.

Differential Revision: https://phabricator.services.mozilla.com/D187245
2023-09-18 15:00:10 +00:00
Haik Aftandilian
245f70f05b Bug 1593072 - Patch 2 - Move existing entitlement files into a v1 directory r=spohl
Move existing entitlement files into a v1 directory and removed unused versions.

Differential Revision: https://phabricator.services.mozilla.com/D187244
2023-09-18 15:00:10 +00:00
Marco Bonardo
70fdad6676 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Masatoshi Kimura
a19297dc5d Bug 1852806 - Remove macros for older Windows SDK from tools/profiler/. r=profiler-reviewers,florian
Depends on D188029

Differential Revision: https://phabricator.services.mozilla.com/D188030
2023-09-15 03:19:28 +00:00
Cosmin Sabou
f8c16a8f94 Backed out 15 changesets (bug 1852806) for causing mda failures on test_video_low_power_telemetry.html. CLOSED TREE
Backed out changeset faea1f4cb9a9 (bug 1852806)
Backed out changeset 4db93c374f9b (bug 1852806)
Backed out changeset 7e40e0e04921 (bug 1852806)
Backed out changeset b0a66c4269ce (bug 1852806)
Backed out changeset 4ff3545936f9 (bug 1852806)
Backed out changeset 02c0a8eb3fd6 (bug 1852806)
Backed out changeset ae2c7b33acfb (bug 1852806)
Backed out changeset 2b89ba254a1a (bug 1852806)
Backed out changeset dfa4f73fc548 (bug 1852806)
Backed out changeset daffcc4c1877 (bug 1852806)
Backed out changeset 33855bcdf15e (bug 1852806)
Backed out changeset 694f29707f3e (bug 1852806)
Backed out changeset 1891eda22a59 (bug 1852806)
Backed out changeset 1b854941389c (bug 1852806)
Backed out changeset 2f7cfe04be59 (bug 1852806)
2023-09-15 09:48:27 +03:00
Masatoshi Kimura
61acede0f2 Bug 1852806 - Remove macros for older Windows SDK from tools/profiler/. r=profiler-reviewers,florian
Depends on D188029

Differential Revision: https://phabricator.services.mozilla.com/D188030
2023-09-15 03:19:28 +00:00
Sandor Molnar
950a3c620d Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo
61f8ecc425 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
Benjamin De Kosnik
3a6200ddc3 Bug 1830181 - Add PerfStats for DocAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D185615
2023-09-13 19:28:00 +00:00
Tom Marble
9e40a719f2 Bug 1850545 - convert .ini manifests to .toml: batch 3 chrome.ini (bis) r=jmaher,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,places-reviewers,profiler-reviewers,m_kato,mak,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D187597
2023-09-13 18:28:32 +00:00
Yannis Juglaret
b8a4d1cccb Bug 1836225 - Prevent stack walking deadlock with background hang monitor. r=handyman,florian
InitializeWin64ProfilerHooks is called by the profiler to avoid deadlock
situations that can occur during stack walking. Actually, this is needed
not only for the profiler, but for any code that relies on stack
walking; and in particular the background hang monitor. So, let's move
this part outside of profiler code, and call it from the background
hang monitor.

Depends on D181435

Differential Revision: https://phabricator.services.mozilla.com/D181436
2023-09-13 14:32:51 +00:00
Yannis Juglaret
33453c44ab Bug 1836225 - Prevent stack walking deadlock on Windows aarch64. r=handyman,florian
On Windows aarch64 and x64 builds, stack walking relies on
RtlLookupFunctionEntry. This can lead to deadlock, which we avoid in x64
builds by adding stack walking suppressions. We must do the same in
aarch64 builds to avoid the same deadlock situation, but we are
missing some stack walk suppression paths. Let's fix that.

Differential Revision: https://phabricator.services.mozilla.com/D181435
2023-09-13 14:32:50 +00:00
Bob Owen
a25c682e3b Bug 1851555: Add line for PATH env var to Windows ASan build instructions mozconfig. r=glandium DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D187582
2023-09-12 11:54:07 +00:00