Commit Graph

556 Commits

Author SHA1 Message Date
Jean-Luc Bonnafoux
def3549f1a Bug 1428860 - XULDocument::GetElementsByAttributeNS may leak memory r=peterv
MozReview-Commit-ID: 5NjViIoivG1

--HG--
extra : rebase_source : 84d73b3df33c07dbf1b0d8edbf6db5580c7aef52
2018-02-25 12:07:52 +01:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Eric Rahm
e8e3e9a5e7 Bug 1440808 - Cleanup error handling in nsXULPrototypeDocument::Read. r=mccr8
This converts from the odd `tmp` for `rv` pattern and just returns immediately
on failure instead.

--HG--
extra : rebase_source : 1ad5882c1411e9e10f99201b6233ed87c71a20cc
2018-02-22 11:33:20 -08:00
Emilio Cobos Álvarez
3d6d2d9586 Bug 1440682: Make the XUL tooltip stuff saner. r=enn
We never removed the event listeners (the code was there, lol, but the function
that was supposed to call into the tooltip listener returned
NS_ERROR_NOT_IMPLEMENTED instead).

Furthermore, we added an event listener each time we reframed an element, which
is insane. Basically, each time an element with tooltip / tooltiptext gets its
frame tree reconstructed, we add the even listener, again, and we never free it.

Xidorn pointed out that this is not such a huge deal because we deduplicate
event listeners per spec, but still...

Move the code from the RestyleManager and the frame constructor to AfterSetAttr
/ BindToTree / UnbindFromTree in nsXULElement to hopefully make this saner.

MozReview-Commit-ID: 6BQbIQJ87qt
2018-02-26 15:44:48 +01:00
Eric Rahm
7337adec45 Bug 1439047 - Part 1: Make StartupCache::PutBuffer take ownership of the buffer. r=froydnj
This avoids a redundant alloc and copy in `PutBuffer`. All existing callers
were destroying the passed in buffer after the call.

--HG--
extra : rebase_source : 065505219d70d26bad49c7eba2cec8edf0e9939d
extra : amend_source : 118eddad4dc901da02817c788fb98f6f4c85a3f0
extra : source : 7f0cedfb4bd85bfe1a523168019864c9c6c0e665
2018-02-16 15:30:47 -08:00
Sebastian Hengst
bfb77aa998 merge mozilla-central to mozilla-inbound on a CLOSED TREE 2018-02-24 03:11:04 +02:00
Narcis Beleuzu
01dffd73eb Backed out 2 changesets (bug 1439047) for Android build bustages. CLOSED TREE
Backed out changeset 718961d941d4 (bug 1439047)
Backed out changeset 7f0cedfb4bd8 (bug 1439047)
2018-02-24 01:10:22 +02:00
Adrian Wielgosik
35f8ed790f Bug 1440741 - Remove all members from nsIDOMHTMLFormElement. r=qdot
MozReview-Commit-ID: 2UcUy4MkVsM

--HG--
extra : rebase_source : ddc6c18c5015ebc5569defa09b32c40e83939886
2018-02-23 19:28:08 +01:00
Eric Rahm
9aa668c2a4 Bug 1439056 - Properly handle failure in nsXULPrototypeDocument::Read. r=bz
We currently don't break out of a parsing loop on a read failure. This leads
to us using a junk value further down.

--HG--
extra : rebase_source : 95e67e45478920eab086b203537fb9c152447430
extra : histedit_source : d4ba15d2b64ae78e37fbd924c2258d4c49d1ac80
2018-02-16 18:14:54 -08:00
Eric Rahm
8b8acc64f2 Bug 1439047 - Part 1: Make StartupCache::PutBuffer take ownership of the buffer. r=froydnj
This avoids a redundant alloc and copy in `PutBuffer`. All existing callers
were destroying the passed in buffer after the call.

--HG--
extra : rebase_source : 39a21686becedf32c38e58fa832ae47845b2f5e0
2018-02-16 15:30:47 -08:00
Emilio Cobos Álvarez
432d45b460 Bug 1439027: Simplify PresShell::Initialize. r=bz
Most of the callers pass the already-existing pres-context visible area. The few
that don't can set it themselves.

MozReview-Commit-ID: KRi4ShrgOrE
2018-02-21 12:42:17 +01:00
Hiroyuki Ikezoe
1b0cba9367 Bug 1417354 - Introduce nsIDocument::GetPresContext(). r=smaug
It would be convenient to get nsPresContext from nsIDocument.

MozReview-Commit-ID: Ei6V3UE8XGr

--HG--
extra : rebase_source : 8d2a917eb62cf341e4e1810451fd01c01dbc3bad
2018-02-21 07:00:10 +09:00
Xidorn Quan
a0c9e1acaa Bug 1438497 part 3 - Add XUL prototype cache to memory report. r=njn
MozReview-Commit-ID: 7CSEJKFkm7B

--HG--
extra : rebase_source : fe10ebd0d3b5538565e6e9692feb1cb993ef01a8
2018-02-19 21:07:44 +11:00
Dorel Luca
f41b03eca9 Backed out changeset 38577c007450 (bug 1424371) for Marionett test failure on testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py. CLOSED TREE 2018-02-19 22:15:23 +02:00
Milan Sreckovic
7571df7e7c Bug 1424371: Use BaseRect access methods instead of member variables in dom/ r=qdot
MozReview-Commit-ID: HXWhggOMIEK

--HG--
extra : rebase_source : 9c9eacf80d2b7f78faa82a1549170b98d12cdaa8
2018-02-19 12:56:10 -05:00
Chris Peterson
d09123f248 Bug 1436263 - Part 1: Replace final override virtual function specifiers with just final. r=froydnj
MozReview-Commit-ID: DE5HkIhsZ6D

--HG--
extra : rebase_source : 94831c1e13a840dd2ea0600f64bcf70c2bf938d9
extra : source : cf9283bf1b0bca3a6311c98e227329d451f80ecb
2018-02-05 22:46:57 -08:00
Adrian Wielgosik
6c854a7275 Bug 1438270 - Remove nsIDOMDocumentXBL. r=bz
MozReview-Commit-ID: 4TsjUaEdDP2

--HG--
extra : rebase_source : ab61d1832113a8c7b126b8856de59056fcf5ec5e
2018-02-14 20:10:45 +01:00
Boris Zbarsky
3660ff5632 Bug 1436508 part 13. Remove nsIDOMMutationEvent constants. r=masayuki
MozReview-Commit-ID: Anl5QJZknJL
2018-02-09 11:17:10 -05:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Boris Zbarsky
478687c2e8 Bug 1434686 part 4. Use IgnoreErrors() in dom/. r=mystor
MozReview-Commit-ID: GwVDrTLPTOb
2018-02-01 14:21:14 -05:00
Cameron McCormack
d02e54b79b Bug 1430014 - Part 5: Stop building old style system classes when MOZ_OLD_STYLE is not defined. r=xidorn
MozReview-Commit-ID: CIHyPdF7Exl

--HG--
extra : source : 78a2fc781eead47af3923efcde58569c5d882ab1
2018-02-01 15:04:04 +11:00
Cameron McCormack
cc7db5c40c Bug 1430014 - Part 4: #ifdef out unnecessary code when the old style system is not built. r=xidorn
MozReview-Commit-ID: 1FZ9VzjcPzN

--HG--
extra : source : de22d220635f8c059834b76f769d5215ab1a8b5b
2018-02-01 15:04:04 +11:00
Boris Zbarsky
65bf16222e Bug 1434399 part 19. Remove nsIXULDocument. r=mystor
MozReview-Commit-ID: 9jQu4sjOhb2
2018-01-31 14:49:29 -05:00
Boris Zbarsky
5ed1930118 Bug 1434399 part 18. Remove nsIXULDocument::ResetDocumentLWTheme. r=mystor
MozReview-Commit-ID: 9z4HAVJAl7R
2018-01-31 14:49:29 -05:00
Boris Zbarsky
7608960cee Bug 1434399 part 17. Remove nsIXULDocument::ResetDocumentDirection. r=mystor
MozReview-Commit-ID: 18rQOWg8zvs
2018-01-31 14:49:29 -05:00
Boris Zbarsky
84d7176a8b Bug 1434399 part 16. Remove nsIXULDocument::OnDocumentParserError. r=mystor
MozReview-Commit-ID: 7LbPTqKzkO4
2018-01-31 14:49:29 -05:00
Boris Zbarsky
0bff2380b3 Bug 1434399 part 15. Remove nsIXULDocument::OnPrototypeLoadDone. r=mystor
MozReview-Commit-ID: 9LDh2QByUNV
2018-01-31 14:49:28 -05:00
Boris Zbarsky
439174ece2 Bug 1434399 part 14. Remove add/remove subtree bits from nsIXULDocument. r=mystor
MozReview-Commit-ID: 987df30BZHq
2018-01-31 14:49:28 -05:00
Boris Zbarsky
8d91b52952 Bug 1434399 part 13. Remove C++ uses of nsIDOMXULDocument. r=mystor
MozReview-Commit-ID: KSsXLra5DQk
2018-01-31 14:49:28 -05:00
Boris Zbarsky
96e47c0319 Bug 1434399 part 11. Remove nsIDOMXULDocument::LoadOverlay. r=mystor
MozReview-Commit-ID: 4ad9AbkMcl0
2018-01-31 14:49:28 -05:00
Boris Zbarsky
006423b188 Bug 1434399 part 10. Remove nsIDOMXULDocument::GetBoxObjectFor. r=mystor
MozReview-Commit-ID: AvUdAtCMRRq
2018-01-31 14:49:28 -05:00
Boris Zbarsky
703e27ac8a Bug 1434399 part 9. Remove nsIDOMXULDocument::Persist. r=mystor
MozReview-Commit-ID: 8LKgjwt5Yi6
2018-01-31 14:49:28 -05:00
Boris Zbarsky
59398e9cad Bug 1434399 part 8. Remove nsIDOMXULDocument's broadcast listener bits. r=mystor
MozReview-Commit-ID: Auj7Lfu6ex3
2018-01-31 14:49:27 -05:00
Boris Zbarsky
f35c2bc77d Bug 1434399 part 7. Remove nsIDOMXULDocument's getElementsByAttribute(NS) methods. r=mystor
MozReview-Commit-ID: HN1le8EkeGr
2018-01-31 14:49:27 -05:00
Boris Zbarsky
cf38d244a2 Bug 1434399 part 6. Remove nsIDOMXULDocument's width/height attributes. r=mystor
MozReview-Commit-ID: 1pYKNXwqnGq
2018-01-31 14:49:27 -05:00
Boris Zbarsky
ee62abf47b Bug 1434399 part 5. Remove nsIDOMXULDocument's commandDispatcher attribute. r=mystor
MozReview-Commit-ID: BjRVr3ScuK5
2018-01-31 14:49:27 -05:00
Boris Zbarsky
173cf8462b Bug 1434399 part 4. Remove nsIDOMXULDocument's tooltipNode attribute. r=mystor
MozReview-Commit-ID: 4j1xDBAHHof
2018-01-31 14:49:27 -05:00
Boris Zbarsky
46a787b972 Bug 1434399 part 3. Remove nsIDOMXULDocument's popupRangeParent/popupRangeOffset attributes. r=mystor
MozReview-Commit-ID: dU65u8Hx2V
2018-01-31 14:49:27 -05:00
Boris Zbarsky
ae5bc0e5e3 Bug 1434399 part 2. Remove nsIDOMXULDocument's popupNode attribute. r=mystor
MozReview-Commit-ID: 5x0Fa12jBvg
2018-01-31 14:49:27 -05:00
Boris Zbarsky
99c47399c4 Bug 1434399 part 1. Switch to nsINode for the popup node on windowroot. r=mystor
MozReview-Commit-ID: HyiHElDnmSH
2018-01-31 14:49:26 -05:00
Cosmin Sabou
94617f91cf Backed out 19 changesets (bug 1434399) for build bustages on nsXULPopupManager.cpp on a CLOSED TREE
Backed out changeset 499f6dffd9cb (bug 1434399)
Backed out changeset 018290612415 (bug 1434399)
Backed out changeset f4c3179f8e59 (bug 1434399)
Backed out changeset f3ce2826b857 (bug 1434399)
Backed out changeset 6d2391af01dd (bug 1434399)
Backed out changeset dc98ed8c609a (bug 1434399)
Backed out changeset 8eaa395d6200 (bug 1434399)
Backed out changeset 19b18f4a53be (bug 1434399)
Backed out changeset 8ff378a6e96a (bug 1434399)
Backed out changeset 60fe73be1a26 (bug 1434399)
Backed out changeset faefb2751fdc (bug 1434399)
Backed out changeset 55cdf8b3a959 (bug 1434399)
Backed out changeset b578cc8efb92 (bug 1434399)
Backed out changeset 54cc4cb2fca1 (bug 1434399)
Backed out changeset f5343ef34d6c (bug 1434399)
Backed out changeset 8fb30e066cbd (bug 1434399)
Backed out changeset 21341b656b0f (bug 1434399)
Backed out changeset fab1f8b087a2 (bug 1434399)
Backed out changeset 55250a54852a (bug 1434399)
2018-01-31 22:45:26 +02:00
Boris Zbarsky
ede65cfa38 Bug 1434318 part 8. Remove nsIDOMDocument::GetElementById. r=mystor
MozReview-Commit-ID: IzjmFqySBpB
2018-01-31 15:18:10 -05:00
Boris Zbarsky
95e268e32f Bug 1434399 part 19. Remove nsIXULDocument. r=mystor
MozReview-Commit-ID: 9jQu4sjOhb2
2018-01-31 14:49:29 -05:00
Boris Zbarsky
3347e08790 Bug 1434399 part 18. Remove nsIXULDocument::ResetDocumentLWTheme. r=mystor
MozReview-Commit-ID: 9z4HAVJAl7R
2018-01-31 14:49:29 -05:00
Boris Zbarsky
3e1fd1a5ab Bug 1434399 part 17. Remove nsIXULDocument::ResetDocumentDirection. r=mystor
MozReview-Commit-ID: 18rQOWg8zvs
2018-01-31 14:49:29 -05:00
Boris Zbarsky
b209de830f Bug 1434399 part 16. Remove nsIXULDocument::OnDocumentParserError. r=mystor
MozReview-Commit-ID: 7LbPTqKzkO4
2018-01-31 14:49:29 -05:00
Boris Zbarsky
8e2fc8e6f0 Bug 1434399 part 15. Remove nsIXULDocument::OnPrototypeLoadDone. r=mystor
MozReview-Commit-ID: 9LDh2QByUNV
2018-01-31 14:49:28 -05:00
Boris Zbarsky
3ee8d239ea Bug 1434399 part 14. Remove add/remove subtree bits from nsIXULDocument. r=mystor
MozReview-Commit-ID: 987df30BZHq
2018-01-31 14:49:28 -05:00
Boris Zbarsky
467ed0721d Bug 1434399 part 13. Remove C++ uses of nsIDOMXULDocument. r=mystor
MozReview-Commit-ID: KSsXLra5DQk
2018-01-31 14:49:28 -05:00
Boris Zbarsky
550b138859 Bug 1434399 part 11. Remove nsIDOMXULDocument::LoadOverlay. r=mystor
MozReview-Commit-ID: 4ad9AbkMcl0
2018-01-31 14:49:28 -05:00