Zack Weinberg
d47e0f433b
Bug 497495 part 3: Add methods to every nsFrame subclass that expose the as-allocated identity of every frame object. Also some cleanups to the QueryFrame implementation. r=dbaron sr=roc
2009-09-12 17:49:24 +01:00
Benjamin Smedberg
3498a5f86e
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
73a6fab34b
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
Benjamin Smedberg
802d1a10c7
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
L. David Baron
4690547534
Stop using nsAreaFrame for anything other than xul:label, which is the only thing for which it does anything different from nsBlockFrame, and rename it accordingly. (Bug 471356) r+sr=roc
...
--HG--
rename : layout/generic/nsAreaFrame.cpp => layout/xul/base/src/nsXULLabelFrame.cpp
rename : layout/generic/nsAreaFrame.h => layout/xul/base/src/nsXULLabelFrame.h
2008-12-29 10:07:38 -05:00
Taras Glek
cfb7b89b10
bug 454292:prbool fixes for layout r+sr=dbaron
2008-09-09 10:07:26 -07:00
Robert O'Callahan
519c75bf87
Bug 331088. Handle file-control frame being torn down while the dialog is up. r=smaug,sr=mats
2008-08-15 22:21:31 +12:00
aaronleventhal@moonset.net
c773b68f7e
bug 397644. File control not exposed correctly to a11y apis. r+sr+a=roc
2007-09-27 18:09:14 -07:00
dbaron%dbaron.org
9d7f938b99
Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc
2007-02-24 18:33:33 +00:00
asqueella%gmail.com
284a5ea424
bug 257868 - remove the nsIPresShell::SetAnonymousContentFor() API, make the frames store strong refs to the anonymous content instead. Decomtaminate nsIAnonymousContentCreator.
...
r+sr=roc
2007-02-18 17:34:09 +00:00
dbaron%dbaron.org
31f1898810
Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213.
2006-12-08 05:38:33 +00:00
bzbarsky%mit.edu
c4e415d4a7
Don't use frames to implement interfaces, dammit. Just don't! Bug 355931, r+sr=roc
2006-11-13 22:05:25 +00:00
mats.palmgren%bredband.net
47bd18fde6
Remove the special painting code for a 165-twips checkbox. Move the remaining parts of nsFormControlHelper to its consumers and remove nsFormControlHelper.{cpp,h} from the tree. b=343495 r+sr=roc (r=me on roc's part)
2006-07-06 10:43:51 +00:00
cvshook%sicking.cc
e9a820078f
Bug 334977. Separate mFileName from mValue. r/sr=bz
2006-04-25 09:18:42 +00:00
roc+%cs.cmu.edu
a7f03736a9
Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc
2006-04-10 00:16:29 +00:00
roc+%cs.cmu.edu
0a10a79f62
Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc
2006-03-26 21:30:36 +00:00
pavlov%pavlov.net
131e8794e2
backing out roc's patch for bug 328926 due to crash running tests on vc8 machines.
2006-03-15 06:43:36 +00:00
roc+%cs.cmu.edu
557b089a47
Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc
2006-03-15 03:14:02 +00:00
roc+%cs.cmu.edu
c2801ebbd7
Bug 328926. Remove aPresContext from nsIFrame::Init and nsIFrame::DidSetStyleContext. r+sr=roc, patch by Marc Liddell
2006-03-09 18:55:21 +00:00
roc+%cs.cmu.edu
77bca74243
Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others
2006-01-26 02:29:17 +00:00
roc+%cs.cmu.edu
b65c655ed9
Bug 254755. deCOMtaminate nsIFormControlFrame. patch by jpl24, r+sr=roc
2005-12-12 23:53:06 +00:00
roc+%cs.cmu.edu
fed343c43a
Bug 108310. Make GetFrameForPoint take frame-relative coordinates, not bogus relative-to-some-view-or-other, and simplify the signature. r+sr=roc, patch by Eli Friedman.
2005-09-19 02:15:54 +00:00
bzbarsky%mit.edu
cf64715ae5
Remove the pointless nsIContent arg of nsIFrame::AttributeChanged. Bug 281390,
...
patch by Vidar Braut Haarr <vhaarr+bmo@gmail.com>, r+sr=bzbarsky
2005-09-07 16:49:21 +00:00
bzbarsky%mit.edu
8e208eced1
Make frames know whether they're leaves or not from the frame construction
...
point of view; use this in the frame constructor. Bug 265367, r+sr=dbaron
2005-08-16 22:52:48 +00:00
gavin%gavinsharp.com
6655b13eac
Bug 301313 : Remove mPresContext in /layout/forms/, patch by Andreas Lange <mozilla@lange.cx>, r+sr=roc
2005-08-16 12:20:58 +00:00
jst%mozilla.jstenback.com
50de4a3e1d
Fixing bug 289940. Make chrome event handlers only receive trusted events by default. r=jonas@sicking.cc, sr=peterv@propagandism.org, a=chofmann@mozilla.org
2005-04-28 23:48:28 +00:00
bryner%brianryner.com
d94c0df713
Remove nsIPresState (bug 279699). r+sr=roc.
2005-01-27 22:52:53 +00:00
neil%parkwaycc.co.uk
74e2aa375a
Bug 276100 GetOriginToView has unused PresContext argument p=bugmail@q1n.org r+sr=dbaron
2005-01-01 17:26:29 +00:00
bugzilla%arlen.demon.co.uk
3d7261604c
Bug 270708 remove nsPresContext variable from AttributeChanged and cleaned up comment in nsIFrame.h
...
p=bugmail@q1n.org r=pkwarren sr=bzbarsky
2004-12-31 01:13:27 +00:00
bryner%brianryner.com
5c02a6978c
Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc
2004-07-31 23:15:21 +00:00
rbs%maths.uq.edu.au
e2527bce29
Cleanup font usage in form input controls, b=251637, r=jshin, sr=bzbarsky
2004-07-21 01:05:44 +00:00
cbiesinger%web.de
da9c6f3b04
AddRef/Release return a refcount, not an nsresult
2004-05-22 20:01:11 +00:00
bryner%brianryner.com
033c0812b5
Fix crashes when dynamically removing input type=file elements by not calling GetValue() during Destroy() since that re-adds the frame to the primary frame map. Bug 203041, 238906, patch originally by mats.palmgren@bredband.net, updated by me, r+sr=bzbarsky.
2004-05-22 01:17:00 +00:00
gerv%gerv.net
708b56cff4
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-18 14:30:37 +00:00
roc+%cs.cmu.edu
17f81274ba
Bug 227838. Remove unused RequiresWidget method from nsIFormControlFrame. r+sr=bzbarsky
2004-04-13 03:11:05 +00:00
peterv%propagandism.org
8f4e566b42
Miscellaneous cleanup. r/sr=jst.
2004-01-18 14:53:32 +00:00
uid502
d81619b4fa
Bug 190735. DeCOMtaminate nsIFrame::GetFrameType. r+sr=bzbarsky
2003-10-31 20:19:18 +00:00
dbaron%dbaron.org
d85698fd40
Remove hint parameter from AttributeChanged methods and simplify style hint mechanism. b=211308 r+sr=bzbarsky
2003-07-11 21:16:12 +00:00
bryner%netscape.com
e43f5a49fd
Remove nsIStyleContext (bug 114713), r/sr=dbaron. Changed lots of methods to use nsStyleContext* or already_AddRefed<nsStyleContext> as return values, depending on whether a reference is returned. Turn on nsRefPtr (bug 104346), and change nsDerivedSafe to not declare AddRef and Release explicitly virtual, r=jag, sr=dbaron.
2003-02-22 00:32:13 +00:00
jkeiser%netscape.com
dd17c242ec
Make input type=file work with display: none (bug 152844), r=sicking@bigfoot.com, sr=jst@netscape.com
2002-12-20 05:40:37 +00:00
jkeiser%netscape.com
cb84e04c70
Make GetType() return int instead of nsresult (bug 167762), r=peterl@netscape.com, sr=kin@netscape.com
2002-12-18 23:38:09 +00:00
jkeiser%netscape.com
78b069a372
Change ns(I)GfxTextControlFrame(2) -> ns(I)TextControlFrame (bug 129909), r=rods
...
@netscape.com, sr=bzbarsky@mit.edu , a=asa
2002-07-26 20:57:24 +00:00
jkeiser%netscape.com
f58b85e424
Make input type=file disabled work properly and look right. bug 92858, r=rods@netscape.com, sr=roc+moz
2002-06-12 07:58:26 +00:00
jkeiser%netscape.com
4d507d3aff
Remove nsFormFrame forever. bug 125578, r=alexsavulov@netscape.com, sr=jst@netscape.com
2002-06-04 00:44:04 +00:00
jkeiser%netscape.com
e95bf883e6
Move save/restore form control state to content (bug 108309). r=rods@netscape.com, sr=jst@netscape.com, a=asa@mozilla.org
2002-03-31 10:14:01 +00:00
jkeiser%netscape.com
31e41094ef
Backing out 108308 due to pageload spike
2002-03-29 07:35:09 +00:00
jkeiser%netscape.com
39fe8af27c
Move save/restore of form controls to content (bug 108309) (r=rods@netscape.com, sr=jst@netscape.com, a=asa@mozilla.org)
2002-03-29 05:35:47 +00:00
dbaron%fas.harvard.edu
66238732c8
Convert users of nsAReadable[C]String and nsAWritable[C]String typedefs to [const] nsA[C]String. b=131899 r=scc sr=jag a=asa
2002-03-23 22:26:36 +00:00
dbaron%fas.harvard.edu
5d88648182
Backing out Bernd's checkin for bug 110596 to fix crashes / weird display. b=118991 r=bernd
2002-01-09 19:17:46 +00:00
bernd.mielke%snafu.de
17e7536dd9
add form frames to debug reflow bug 115096 r=karnaze sr=attinasi
2002-01-07 19:55:56 +00:00
