Commit Graph

25246 Commits

Author SHA1 Message Date
criss
3dd6f50995 Backed out changeset ac6b6390147e (bug 1779164) for causing mochitest failures on browser_net_filter-value-preserved.js. CLOSED TREE 2022-07-12 19:25:40 +03:00
Nicolas Chevobbe
75984617a6 Bug 1779164 - [devtools] Don't override CodeMirror search UI in netmonitor response panel. r=bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D151577
2022-07-12 13:32:46 +00:00
Alexandre Poirot
922cfee9b0 Bug 1778647 - [devtools] Store source's framework only once, in symbols. r=bomsy
We are currently duplicated source's framework in symbols and tabs reducers.
This is uncessary and confusing. And this possibly lead to more state/component updates.

This is mostly used to computed the source icon.
I extented test coverage to better cover the behavior of SourceIcon,
while simplifying a few things around this component by unifying the various places
where we compute the final icon, so that now it is only done by getSourceClassnames
and modifier.

Differential Revision: https://phabricator.services.mozilla.com/D151358
2022-07-12 11:55:43 +00:00
Alexandre Poirot
f51d0a4a69 Bug 1778514 - [devtools] Avoid mutating source objects because of relative url computation. r=bomsy
While I'm around QuickOpen modal, I also cleanup a few things around formatSources
and avoid computing more formatting than what the modal will display.

Differential Revision: https://phabricator.services.mozilla.com/D151285
2022-07-12 11:55:43 +00:00
Alexandre Poirot
506e9307bc Bug 1778078 - [devtools] Move blackbox state to a dedicated reducer and selectors. r=bomsy
This allows to make the reducer Source object fully immutable.
`isBlackBoxed` was the last mutable attribute of it.

Doing this help pass along source object without having to care if it will ever update.
This should also help reduce the number of unecessary update to components
which manipulate sources but ignore their blackbox state.

Differential Revision: https://phabricator.services.mozilla.com/D151005
2022-07-12 11:55:42 +00:00
Julian Descottes
a5ef0bcfcc Bug 1772124 - [devtools] Remove extra console.log in devtools/server/actors/network-monitor/network-observer.js r=devtools-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D151589
2022-07-12 10:57:15 +00:00
Sebastian Zartner
245d56e9c5 Bug 1734840 - Added parsing for custom formatters. r=devtools-backward-compat-reviewers,nchevobbe
The first step of parsing custom formatters for objects is checking a website for a global array called `devtoolsFormatters`.
If this array exists, it is looped over to find a custom formatter that can handle the object.
In case there is one, its `header` and `hasBody` methods are executed using `makeSideeffectFreeDebugger()` to ensure to get a result without causing any negative side effects.
Those results are then returned together with the index of the custom formatter.
This index is used in case the custom formatter's body is expandedö. In that case the `body` property is also executed in a safe way and its value then returned.

A test covers basic support of custom formatting for objects. More advanced tests will be added in bug 1752759.

Differential Revision: https://phabricator.services.mozilla.com/D146389
2022-07-12 06:29:48 +00:00
Tooru Fujisawa
6907e51f5c Bug 1777486 - Part 4: Migrate XPCOMUtils.jsm consumers with CommonJS require. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D151216
2022-07-12 04:21:35 +00:00
Tooru Fujisawa
b6bce4ef39 Bug 1777486 - Part 3: Migrate XPCOMUtils.jsm consumers with manual rewrite. r=kmag
Migrate some files that's not covered by ./mach esmify

Differential Revision: https://phabricator.services.mozilla.com/D151215
2022-07-12 04:21:35 +00:00
Tooru Fujisawa
54623364da Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Tooru Fujisawa
7a765c385a Bug 1777486 - Part 0: Use AppConstants.jsm in Cu.getGlobalForObject consumer. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D151337
2022-07-12 04:21:33 +00:00
mleclair
f15f91dc56 Bug 1772124 - Added Glean metrics to track different type of resources for Early Hints r=dragana,mbucher,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D148741
2022-07-11 22:46:22 +00:00
Andreea Pavel
b328806a08 Backed out changeset 47dea14575f1 (bug 1764349) for failing devtools at browser_net_stacktraces-visibility.js on a CLOSED TREE 2022-07-11 22:42:09 +03:00
Andreea Pavel
7738a75fdd Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Hubert Boma Manilla
1bf7326c9f Bug 1764349 - [devtools] Add clear functionality for network resources r=ochameau
Enable clearing of network resources on all layers(frontend, resource layer, server) when the
user click the clear button.

Differential Revision: https://phabricator.services.mozilla.com/D148694
2022-07-11 16:33:03 +00:00
Tooru Fujisawa
2244a9c200 Bug 1777486 - Part 4: Migrate XPCOMUtils.jsm consumers with CommonJS require. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D151216
2022-07-11 15:09:14 +00:00
Tooru Fujisawa
f06a07101b Bug 1777486 - Part 3: Migrate XPCOMUtils.jsm consumers with manual rewrite. r=kmag
Migrate some files that's not covered by ./mach esmify

Differential Revision: https://phabricator.services.mozilla.com/D151215
2022-07-11 15:09:14 +00:00
Tooru Fujisawa
8cd6ed7409 Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
fe1f9b330b Bug 1777486 - Part 0: Use AppConstants.jsm in Cu.getGlobalForObject consumer. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D151337
2022-07-11 15:09:12 +00:00
Tooru Fujisawa
83cffbf4a5 Bug 1667455 - Part 23: Update DevTools TypeScript support. r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D151270
2022-07-11 12:41:58 +00:00
Tooru Fujisawa
5e5a4576f6 Bug 1667455 - Part 17: Update devtools stub. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D150906
2022-07-11 12:41:55 +00:00
Tooru Fujisawa
c26c3f5551 Bug 1667455 - Part 14: Stop importing Services.jsm in documents. r=kmag,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D150903
2022-07-11 12:41:54 +00:00
Tooru Fujisawa
7539547097 Bug 1667455 - Part 8: Stop importing Services.jsm from chrome-priv JS code, other cases. r=kmag,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D150897
2022-07-11 12:41:52 +00:00
Tooru Fujisawa
c2a1238034 Bug 1667455 - Part 7: Stop importing Services.jsm from chrome-priv JS code, lazy cases. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D150896
2022-07-11 12:41:51 +00:00
Tooru Fujisawa
47c8f80432 Bug 1667455 - Part 6: Stop importing Services.jsm from chrome-priv JS code, non-top-level or multi-line cases. r=kmag,perftest-reviewers,AlexandruIonescu,sparky
Differential Revision: https://phabricator.services.mozilla.com/D150895
2022-07-11 12:41:51 +00:00
Tooru Fujisawa
bf93d07148 Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Tooru Fujisawa
f3a8c52c53 Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Tooru Fujisawa
a8a2af4b5c Bug 1667455 - Part 2.6: Export Services from Devtools require("chrome"). r=kmag,devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D150908
2022-07-11 12:41:49 +00:00
Tooru Fujisawa
31b421254e Bug 1667455 - Part 2.5: Update DevTools TypeScript support. r=devtools-reviewers,julienw
Differential Revision: https://phabricator.services.mozilla.com/D150909
2022-07-11 12:41:49 +00:00
Tooru Fujisawa
badd55d158 Bug 1667455 - Part 2: Add Services to system globals in ESLint. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D150891
2022-07-11 12:41:48 +00:00
Julian Descottes
af89313931 Bug 1767679 - [devtools] Wait for element to be ready in browser_rules_colorpicker-and-image-tooltip_01.js r=Honza
No conclusive results on try. Waiting for the property container to be ready should at least help invsestigate if we get more failures

Differential Revision: https://phabricator.services.mozilla.com/D151425
2022-07-11 09:34:33 +00:00
Nicolas Chevobbe
c8b4947fdc Bug 1759458 - [devtools] Make Netmonitor Clear/Send buttons always visible. r=bomsy.
The container is turned into a footer and moved outside of
its current parent so it always stick to the bottom.
CSS was tweaked to keep it nice.

Differential Revision: https://phabricator.services.mozilla.com/D151284
2022-07-08 09:47:14 +00:00
lyavor
dfd3fc0633 Bug 1778442 - Update devtools/client/shared test files to use https r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D151243
2022-07-08 08:14:33 +00:00
Nicolas Chevobbe
2b6a1911f7 Bug 1777587 - [devtools] Preview support for URLSearchParams objects. r=ochameau.
Also add an `<entries>` node in the ObjectInspector for URLSearchParams instances.

Differential Revision: https://phabricator.services.mozilla.com/D150810
2022-07-08 05:46:47 +00:00
Nicolas Chevobbe
5d103461fc Bug 1695382 - [devtools] Add color swatches inside color-mix(). r=jdescottes.
This is done by adding `color-mix` to `COLOR_TAKING_FUNCTIONS`.
Test case is added, alongside with cases for other functions in which we
should show color swatches.

Differential Revision: https://phabricator.services.mozilla.com/D151224
2022-07-08 05:02:03 +00:00
Julian Descottes
d6eac88099 Bug 1778432 - [devtools] Guard against missing Services.profiler in Actor:_sendEvent r=nchevobbe
The Services object is replaced by a mock in the worker loader so Services.profiler might be undefined.

Differential Revision: https://phabricator.services.mozilla.com/D151211
2022-07-07 13:43:56 +00:00
Julian Descottes
c5f7c7111f Bug 1777296 - [devtools] Bail out of getAddonIdForWindowGlobal for geckoview windowglobals missing principal r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D151177
2022-07-07 13:34:30 +00:00
Tooru Fujisawa
cdedb463df Bug 1778314 - Support system ESM in devtools loader. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D151212
2022-07-07 11:54:06 +00:00
Emilio Cobos Álvarez
2c2f20586e Bug 1778396 - Add color-mix to DevTools autocomplete. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D151180
2022-07-07 10:29:59 +00:00
Emilio Cobos Álvarez
d6817e2c7f Bug 1778281 - Don't override effective color-scheme if there's no theme. r=jdescottes
In the browser toolbox window, we include common.css, but we don't
apply the theme-dark/theme-light classes, so we end up overriding the
color-scheme to light.

Instead, only override color-scheme for theme-light/theme-dark, so that
context menus and so have the right appearance.

Differential Revision: https://phabricator.services.mozilla.com/D151131
2022-07-07 10:11:19 +00:00
Butkovits Atila
da2b7986d0 Backed out changeset 8cc6f6f552a3 (bug 1772124) for causing failures at browser_103_preload.js. CLOSED TREE 2022-07-07 03:56:04 +03:00
mleclair
2ff75f9613 Bug 1772124 - Added Glean metrics to track different type of resources for Early Hints r=dragana,mbucher,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D148741
2022-07-06 23:16:41 +00:00
Hubert Boma Manilla
5f3826ec54 Bug 1778113 - Use thicker icons for Watch expressions and breakpoints r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D151023
2022-07-06 21:57:31 +00:00
Hubert Boma Manilla
53f8a54f71 Bug 1742774 - [devtools] Add button to remove all XHR Breakpoints r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D150351
2022-07-06 21:57:30 +00:00
Hubert Boma Manilla
4644b088bf Bug 1742774 - [devtools] Add remove all breakpoints button in breakpoints header r=nchevobbe
In this patch
 - Added remove all breakpoints button in the Breakpoints list header bar
 - Start clearing `asyncStore.pendingBreakpoints` when we remove all the breakpoints
 - Add jest tests

Differential Revision: https://phabricator.services.mozilla.com/D150350
2022-07-06 21:57:30 +00:00
Emilio Cobos Álvarez
4d2c8e40bc Bug 1778062 - Update some test expectations.
MANUAL PUSH: Orange fix CLOSED TREE
2022-07-06 15:24:00 +02:00
Ziran Sun
435c380565 Bug 1778062 - Add support for parsing the contain-intrinsic-size property from the CSS-sizing specification. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D151001
2022-07-06 11:47:51 +00:00
Julian Descottes
3047c5cfeb Bug 1775071 - [devtools] Guard profiler markers for DevTools actor events behind a profiler.IsActive check r=ochameau
DevTools actor events can be a very hot path and we should avoid computing the marker label if possible.

Differential Revision: https://phabricator.services.mozilla.com/D150996
2022-07-06 09:38:53 +00:00
Nicolas Chevobbe
cbbceb9106 Bug 1775295 - Fix browser_browser_toolbox_netmonitor.js intermittent. r=bomsy.
The test seemed to fail because the browsers was firing requests we weren't expecting.
To fix this, we set a few preferences that should prevent such requests to be made.

Differential Revision: https://phabricator.services.mozilla.com/D150953
2022-07-06 09:16:26 +00:00
Alexandre Poirot
080a36d30c Bug 1777459 - [devtools] Set final group name for Webpack and Angular sources. r=bomsy
See previous changeset. This applies the same simplification for Webpack and Angular groups.

Differential Revision: https://phabricator.services.mozilla.com/D150746
2022-07-05 12:26:10 +00:00