2742 Commits

Author SHA1 Message Date
Bobby Holley
3e308bd38d Bug 1389385 - Rearrange dirty noting to operate on the element rather than the parent. r=emilio
This will allow us to scope restyle roots more tightly.

MozReview-Commit-ID: 2t2lp5sKBHH
2017-08-11 18:18:22 -07:00
Boris Zbarsky
efd62c0c96 Bug 1388877. Fix insertions under a ::first-line in stylo. r=heycam
MozReview-Commit-ID: CDolJpTtGki

--HG--
extra : rebase_source : dbef95a652491fbfee0a462995938b4801a785ad
2017-08-11 09:11:23 -04:00
Hiroyuki Ikezoe
7940b76630 Bug 1389440 - Replace pseudo style with the one having animations before generating elements corresponding to content propery. r=emilio
This needs for content property animations.

MozReview-Commit-ID: C7ViMQTczJx

--HG--
extra : rebase_source : 3a4cd3b4b656fa5c1f24f0b1ca28fe4a1034aeef
2017-08-11 19:49:56 +09:00
Sebastian Hengst
6ad2efe360 Backed out changeset 6c2389558858 (bug 1388877) for asserting at ServoRestyleManager.cpp:1450 in stylo reftests and crashtests. r=backout 2017-08-11 12:24:37 +02:00
Boris Zbarsky
00efaf7f30 Bug 1388877. Fix insertions under a ::first-line in stylo. r=heycam
MozReview-Commit-ID: CDolJpTtGki

--HG--
extra : rebase_source : 8a2fb19de65cd4dcf708382df844a6bbf81441c9
2017-08-11 03:12:44 -04:00
Boris Zbarsky
a3410dfccf Bug 1385656. Fix the interaction of RecoverLetterFrames and ::first-line. r=heycam
MozReview-Commit-ID: BUt5FDI0IV1

--HG--
extra : rebase_source : 907a1f84a90ee36a777c4eae9b4073a0c3ec756f
2017-08-10 18:59:06 -04:00
Boris Zbarsky
0dd7bb3d5e Bug 1388625 part 6. Flag the in-flow frames of kids of various wrapper frames during frame construction, so we know to restyle the wrapper frames. r=heycam
MozReview-Commit-ID: 8KNug88sGp

--HG--
extra : rebase_source : 02cd19bcab6595a5fe86ea076207a8c84da4229e
2017-08-11 00:10:27 -04:00
Boris Zbarsky
60cd46bdce Bug 1388626. Restyle ::-moz-xul-anonymous-block as needed with stylo. r=heycam
MozReview-Commit-ID: KZ0s1x60VBx

--HG--
extra : rebase_source : d7103464e7563ae7105417f254609cb22481e0e3
2017-08-09 16:43:47 -04:00
Jonathan Watt
0802c22f8d Bug 1388939, part 7 - Give clear names to the nsFrameManager methods for unregistering undisplayed style contexts. r=dholbert
MozReview-Commit-ID: EFtKqKBOPQH
2017-08-01 17:12:44 +01:00
Jonathan Watt
26a2ad3013 Bug 1388939, part 5 - Rename nsFrameManager::GetUndisplayedContent to GetDisplayNoneStyleFor. r=dholbert
MozReview-Commit-ID: Kpe6DcBP8yX
2017-08-01 15:27:59 +01:00
Jonathan Watt
bde9e960a3 Bug 1388939, part 4 - Give clear names to the nsFrameManager methods for updating the registered undisplayed style contexts. r=dholbert
MozReview-Commit-ID: LZuleDSt6LR
2017-08-01 15:11:02 +01:00
Jonathan Watt
b1c7a0f236 Bug 1388939, part 3 - Give clear names to the nsFrameManager methods for registering undisplayed style contexts. r=dholbert
MozReview-Commit-ID: 1i2ilfWXcvo
2017-08-01 15:04:36 +01:00
Hiroyuki Ikezoe
5bf9f97e61 Bug 1384120 - Replace old pseudo style context with a new style context including animations. r=emilio
When a reframe happens on the parent of a pseudo element which has animations,
we need to grab style for the pseudo element that includes the animations'
style and also *replace* old style context (that does not include animations'
style) with it. Otherwise, we will use the old style context that has *no*
animations style, as a result, we will see a flicker right after the reframe.

Two reftests in this patch fail without this fix.  One is for CSS transitions,
the other one is for CSS animations.

MozReview-Commit-ID: 6pCdnQ1DGUY
2017-08-08 11:35:23 +09:00
Nicholas Nethercote
f941156987 Bug 1386600 - Change nsIStringBundle methods to return |AString| instead of |wstring|. r=emk,sr=dbaron.
This removes about 2/3 of the occurrences of nsXPIDLString in the tree. The
places where nsXPIDLStrings are null-checked are replaced with |rv| checks.

The patch also removes a couple of unused declarations from
nsIStringBundle.idl.

Note that nsStringBundle::GetStringFromNameHelper() was merged into
GetStringFromName(), because they both would have had the same signature.

--HG--
extra : rebase_source : ac40bc31c2a4997f2db0bd5069cc008757a2df6d
2017-08-04 14:40:52 +10:00
Emilio Cobos Álvarez
1a47c01765 Bug 1384542: Move GetParent and IsLinkContext to GeckoStyleContext. r=heycam
MozReview-Commit-ID: C19yGcphixX
2017-07-31 14:32:59 +02:00
Emilio Cobos Álvarez
de41f4068e Bug 1384542: Remove usage of GetParentAllowServo in the frame constructor. r=bz
MozReview-Commit-ID: HPMzM8p3GSO
2017-07-31 14:29:18 +02:00
Kyle Machulis
ffa9be1bed Bug 1279218 - Remove Applet tag; r=bz
Removes applet tag interfaces, and changes HTML5 parser to output
HTMLUnknownElement when tag is found. Removes tag process from various
places in the browser.

MozReview-Commit-ID: 2zHhK2U2esX

--HG--
extra : rebase_source : d06ecaffd1cb656301e29b900bafde4c68a4606e
2017-07-10 16:00:30 -07:00
Sebastian Hengst
e7f78bec18 merge mozilla-central to autoland. r=merge a=merge 2017-07-29 11:48:40 +02:00
Sebastian Hengst
22f1bfd79d Backed out changeset 9a7b90cf8a63 (bug 1361618) for frequently failing accessible/tests/browser/states/browser_test_link.js (bug 1385498). r=backout a=backout
MozReview-Commit-ID: DK2CuaYBPbj
2017-07-29 11:42:39 +02:00
Boris Zbarsky
510ea95ba9 Bug 1324619 part 1. Skip reparenting style contexts in the frame constructor when it's not needed. r=emilio
We don't need to reparent when moving things in/out of anonymous boxes and using the stylo backend.

MozReview-Commit-ID: 8C6ScqTuR9z

--HG--
extra : rebase_source : 0f180647a39a051e2a5aabe642031134852bf95b
2017-07-28 21:11:18 -04:00
J. Ryan Stinnett
b7151cc577 Bug 1361618 - Remove unnecessary calls to FlushPendingLinkUpdates. r=dbaron
This removes the two calls to `FlushPendingLinkUpdates` in nsCSSFrameConstructor
and GeckoRestyleManager, which appear to have no effect.

Looking through what the pending link code is attempting to do:

* When a new anchor is bound in `BindToTree` we do:
  1. Link::ResetLinkState(false, Link::ElementHasHref());
    * Set link's mLinkState to default (either unvisited or not link)
    * Set element's link mState bits to default (either unvisited or not link)
  2. doc->RegisterPendingLinkUpdate(this);
    * Schedules idle dispatch to run `FlushPendingLinkUpdates` within 1 sec
* In `FlushPendingLinkUpdates`:
  * For each pending link, call element->UpdateLinkState(link->LinkState());
    1. Register link for async history update to get potential future visited
       state
    2. mLinkState is still unvisited / not link until we hear from history, so
       element state is unchanged

Thus, there seems to be no need to call `FlushPendingLinkUpdates` outside of
`BindToTree`, since visited state is always applied async anyway (so it doesn't
work as an optimization to avoid restyling if visited, since that will trigger
later).

MozReview-Commit-ID: KbFuKve1KUi

--HG--
extra : rebase_source : fdc098397d2fe9963ff82566f7a6b7c8c4656d63
2017-06-29 11:31:52 -07:00
Bobby Holley
12955e0dde Bug 1384769 - Pass TraversalFlags from C++ into Rust. r=emilio
MozReview-Commit-ID: EVUzgnL5coN
2017-07-27 17:49:38 -07:00
Emilio Cobos Álvarez
2b7de51623 Bug 1381844: Be more explicit about the kind of style context we handle all the time. r=bholley
MozReview-Commit-ID: E0mdkhU3XBz
2017-07-22 18:02:57 +02:00
Manish Goregaokar
9e805b0538 Bug 1382017 part 2 Gecko piece - Remove usage of ServoComputedValues from binding functions; r=xidorn
MozReview-Commit-ID: 3KygTIIMVvF
2017-07-18 23:17:34 -07:00
Wes Kocher
02de79cf14 Backed out changeset 14868b3c13e3 (bug 1373767) for android reftest failures in font-inflation-1.html a=backout CLOSED TREE
MozReview-Commit-ID: 5cpCdxuXNin

--HG--
extra : amend_source : a9a3f49d7d9414a4395f6d4d0d80aee7f578ceeb
2017-07-18 22:40:00 -07:00
Wes Kocher
f537872046 Merge m-c to autoland, a=merge CLOSED TREE
MozReview-Commit-ID: 1XYfqTZv3GF
2017-07-18 18:24:49 -07:00
Manish Goregaokar
dc28c48ef5 Bug 1382019 - stylo: Don't crash on null parent contexts in nsCSSFrameConstructor::AddFrameConstructionItemsInternal ; r=emilio a=crashfix CLOSED TREE
MozReview-Commit-ID: 93fXjEnLVLI
2017-07-18 15:14:21 -07:00
Manish Goregaokar
f33beecc59 Bug 1367904 - Part 10: stylo: Switch Gecko over to ServoStyleContext; r=bholley
MozReview-Commit-ID: EmopKVjEzlz
2017-07-17 21:00:46 -07:00
Ting-Yu Lin
b87b2c1649 Bug 1381017 - Set NODE_DESCENDANTS_NEED_FRAMES from flatten tree parent. r=emilio,tnikkel
MozReview-Commit-ID: 3CBP8vc6OxB

--HG--
extra : rebase_source : edefbf78c564dc328b265496044171a71c77fb2f
2017-07-17 11:31:31 +08:00
Daniel Holbert
4aff74aee9 Bug 1373767: Always make nsMathMLmathBlockFrame a block formatting context. r=bz
(This makes it behave a bit more like a normal CSS block, and it ensures that
it can provide a float manager to its descendants.)

MozReview-Commit-ID: FmnQYjzD2eD

--HG--
extra : rebase_source : fe5bc96985b0e13a805b014653c422a83b27cfc0
2017-07-13 15:34:20 -07:00
Emilio Cobos Álvarez
55d4dddb1d Bug 1379505: Less fishyness when resolving the style of the document element. r=heycam
Previous to these patches, the style resolution happening on [1] made the style
data stick on the element, so we'd never think it was the initial style, even if
it was.

This was wallpapering the fact that, if that was the initial style, we'd never
have another chance of traversing the document when [2] kicked in.

This somehow just happened to work, but is a very fishy way to get it to work.
Instead, call StyleDocument() properly _before_, and rely on the fact that it
will stop when it has a non-null binding, and only if it fails explicitly style
the children.

This fixes the few XBL test-cases with this patch series that exercise
-moz-bindings on the root element without the root being styled, and makes the
-moz-binding code more consistent in both places of the frame constructor.

[1]: http://searchfox.org/mozilla-central/rev/5dadcbe55b4ddd1e448c06c77390ff6483aa009b/layout/base/nsCSSFrameConstructor.cpp#2526
[2]: 3330653dc8/components/style/traversal.rs (L439)

MozReview-Commit-ID: HbjsD6nYsvX

--HG--
extra : rebase_source : 0f9be9665faf6a5e32f527c12dbd00f35a89b986
2017-07-10 14:32:39 +02:00
Emilio Cobos Álvarez
a847138643 Bug 1377902: Trivially cleanup a bit of the FC code. r=mats
MozReview-Commit-ID: HJKVk7lWp4p

--HG--
extra : rebase_source : 8745f9ea8d4a5cd2ddc5bcb0313fb053743ab107
2017-07-05 16:30:24 +02:00
Carsten "Tomcat" Book
6a0985654f Backed out changeset 9b2f0f827468 (bug 1377902) for bustage 2017-07-05 16:56:22 +02:00
Emilio Cobos Álvarez
dfa6bdea00 Bug 1377902: Trivially cleanup a bit of the FC code. r=mats
MozReview-Commit-ID: HJKVk7lWp4p

--HG--
extra : rebase_source : 29a1b91602ef52e02869a028487fde67f815d6ec
2017-07-05 16:30:24 +02:00
Hiroyuki Ikezoe
1da5513453 Bug 1377648 - Check summary frame instead of summary element on removing the summary. r=heycam
In case of removing summary element, we need to check details *frame* children
instead of details *element* children since the summary element has been
already removed from details element children list.

MozReview-Commit-ID: GEzDId9CYf9

--HG--
extra : rebase_source : 50834606413b916a3c0d6074a7a52e8bdbe845a0
2017-07-05 15:52:37 +09:00
Hiroyuki Ikezoe
ee7e6f49d2 Bug 1377648 - Use inFlowFrame to check the target frame is summary and its parent is details. r=heycam
Considering the case where the summary element has position:absolute, we need
to use inFlowFrame and its parent instead of aFrame itself.

MozReview-Commit-ID: Ds8xxyBuyO5

--HG--
extra : rebase_source : 6254dae16e0371c55ae469390a5aaafa300b740c
2017-07-05 12:39:32 +09:00
Boris Zbarsky
5bd9b06ca0 Bug 1376640. Fix dynamic updates when an inline that sits between a first-letter and its block changes style. r=heycam
MozReview-Commit-ID: 8osMUpYVRvR
2017-06-28 22:19:35 -07:00
Carsten "Tomcat" Book
f32372e861 Backed out changeset 2992d5af6251 (bug 1376640) for assertion failures like Assertion failure: mOwner == ExpectedOwnerForChild(aFrame) (Missed some frame in the hierarchy?) 2017-06-29 08:22:08 +02:00
Boris Zbarsky
991d1134d8 Bug 1376640. Fix dynamic updates when an inline that sits between a first-letter and its block changes style. r=heycam
MozReview-Commit-ID: 8osMUpYVRvR
2017-06-28 22:19:35 -07:00
Bobby Holley
7f8bab3fa9 Bug 1376245 - Hand the already-resolved style directly to servo when creating generated content. r=emilio,r=birtles
This avoids a lot of expensive machinery when we've already computed the style.
2017-06-27 11:39:53 -07:00
Boris Zbarsky
3966a1a2ea Bug 1324618 part 8. Implement restyling for first-letter frames. r=emilio
MozReview-Commit-ID: IPUDD1Q6AFq
2017-06-26 23:35:08 -07:00
Boris Zbarsky
955487f7ab Bug 1324618 part 4. Implement a way to get the first-letter frame, if any, for a block. r=heycam
MozReview-Commit-ID: 1o0d5ugJ1hj
2017-06-26 23:35:07 -07:00
Carsten "Tomcat" Book
bb1fe1fc10 Backed out changeset 049b20a12429 (bug 1324618) for bustage 2017-06-27 10:39:58 +02:00
Carsten "Tomcat" Book
d4cd7abe0a Backed out changeset 169cafc2d5f9 (bug 1324618) 2017-06-27 10:39:39 +02:00
Boris Zbarsky
f9aed5db67 Bug 1324618 part 8. Implement restyling for first-letter frames. r=emilio
MozReview-Commit-ID: IPUDD1Q6AFq

--HG--
extra : rebase_source : e7f1b97fc43825de4617195edb4d9ed6bfbb12f2
2017-06-26 23:35:08 -07:00
Boris Zbarsky
af8c5f3819 Bug 1324618 part 4. Implement a way to get the first-letter frame, if any, for a block. r=heycam
MozReview-Commit-ID: 1o0d5ugJ1hj

--HG--
extra : rebase_source : 6b6900ab2c6fdb3ae07af6e7915b1ecce8cf051d
2017-06-26 23:35:07 -07:00
Boris Zbarsky
094b059bbf Bug 1374761 part 2. Properly restyle the various paginated-presentation anonymous boxes. r=heycam
MozReview-Commit-ID: LJqWbyRKp3b

--HG--
extra : rebase_source : fbd246cded64dc1d05c8617ae4f2e5cf022f190f
2017-06-21 11:45:14 -04:00
Boris Zbarsky
7a8cb34ac0 Bug 1374761 part 1. Properly restyle the viewport and its child anonymous box when we do a restyle. r=heycam
The child anon box may be an nsHTMLScrollFrame, a nsRootBoxFrame, or a
nsSimplePageSequenceFrame.   nsHTMLScrollFrame already knows how to deal with
its anonymous box kids, nsRootBoxFrame doesn't have any, and the next changeset
will deal with anon box kids of nsSimplePageSequenceFrame.

MozReview-Commit-ID: 2ZV061EhRmc

--HG--
extra : rebase_source : 43084315454284fc6d7353ccdb20137611b2ee46
2017-06-21 11:45:12 -04:00
cku
c0d6329f0c Bug 265894 - Part 6. Create symbol frame in nsCSSFrameConstructor. r=heycam
MozReview-Commit-ID: LgO1WKo46Pu

--HG--
extra : rebase_source : 291aaeddb7162bfa69384fb02a8fd9ba16fb59d5
2017-06-14 21:53:34 +08:00
Manish Goregaokar
02ab46c24d Bug 1373018 - Part 8: stylo: Move nsStyleContext::SetStyle to GeckoStyleContext; r=bholley
MozReview-Commit-ID: ycXu95whnG

--HG--
extra : rebase_source : 852051aa074cc8ed8f11f0d68c26fe4f0a6962b6
2017-06-10 22:27:45 -07:00