Commit Graph

693407 Commits

Author SHA1 Message Date
Sylvestre Ledru
6b925c7d59 no bug - reviews doc: Add some missing groups + polish r=glob DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D64373

--HG--
extra : moz-landing-system : lando
2020-02-26 16:01:08 +00:00
Nicolas Chevobbe
53f7daba4b Bug 1609942 - Display autocomplete popup at the top of the input. r=jdescottes,Honza.
This prevents the popup to cover the eager evaluation result.
In order for the popup to be able to appear outside of the
toolbox, we pass the useXulWrapper option to the HTMLTooltip.

Differential Revision: https://phabricator.services.mozilla.com/D62431

--HG--
extra : moz-landing-system : lando
2020-02-26 14:46:45 +00:00
Nicolas Chevobbe
0283a587d3 Bug 1616847 - When xulWrapper is visible move it instead of trying to show it again. r=jdescottes.
If the XUL wrapper was opened and a consumer called show again,
the panel wouldn't update its position. This can be fixed by checking the
state of the element, and if it's open move the panel using `_moveXulWrapperTo`.

With this change in place, we can remove the updateContainerBounds methods,
as it has the same arguments and is only used in one place.

Differential Revision: https://phabricator.services.mozilla.com/D63488

--HG--
extra : moz-landing-system : lando
2020-02-26 13:03:41 +00:00
Chun-Min Chang
eb3b669f6b Bug 1614971 - Update cubeb-coreaudio to 4acd802. r=padenot
Pick commits:
- 4acd802: Destroy the stream properly
- 54d950a: Run the tests in the subcrate (#51)
- 132d209: Clean up clippy warnings and errors (#49)

Differential Revision: https://phabricator.services.mozilla.com/D63725

--HG--
extra : moz-landing-system : lando
2020-02-26 15:25:36 +00:00
Steve Fink
9b7d17bb03 Bug 1599295 - Account for the full mapped size of shared array buffer mappings. r=jonco
Depends on D64275

Differential Revision: https://phabricator.services.mozilla.com/D64276

--HG--
extra : moz-landing-system : lando
2020-02-26 16:09:12 +00:00
Steve Fink
366160cb21 Bug 1599295 - Report out of memory errors in shared array buffer creation path. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D64275

--HG--
extra : moz-landing-system : lando
2020-02-26 14:54:28 +00:00
Tom Ritter
fb62c6e68a Bug 1578742 - Let the privileged mozilla content process ride the trains. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D63555

--HG--
extra : moz-landing-system : lando
2020-02-26 16:16:16 +00:00
Emilio Cobos Álvarez
42b235642d Bug 1346893 - Move the Geckoview UA sheet to layout/style. r=snorp
Make it a regular stylesheet.

This allows it to be cached in shared memory if possible, and will allow me to
stop adding the stylesheet based on a pref for bug 1618202.

Differential Revision: https://phabricator.services.mozilla.com/D64377

--HG--
rename : mobile/android/themes/geckoview/content.css => layout/style/res/geckoview.css
extra : moz-landing-system : lando
2020-02-26 15:46:58 +00:00
Emilio Cobos Álvarez
9f4ca6a71f Bug 1470709 - Stop using CSS variables from android UA stylesheets. r=snorp
Just inline them, they're not that many.

Using CSS variables is observable from content, which is not good. It also means
that we need an @import.

For bug 1618202, I plan to move this stylesheet to the global stylesheet cache.

This is so that I can add them based on prefs, but should also have memory
improvements (the stylesheet would be shared in memory across processes, see bug
1474793).

Differential Revision: https://phabricator.services.mozilla.com/D64375

--HG--
extra : moz-landing-system : lando
2020-02-26 15:22:34 +00:00
Andrew Halberstadt
029550abce Bug 1616879 - [reftest] Add some selftests for invalid manifests, r=dbaron
Adds some tests to cover error cases in reftest manifests. This is far from
comprehensive, but gives us an easy place to add more in the future.

Differential Revision: https://phabricator.services.mozilla.com/D63718

--HG--
rename : layout/tools/reftest/selftest/files/defaults-invalid.list => layout/tools/reftest/selftest/files/invalid-defaults.list
extra : moz-landing-system : lando
2020-02-26 14:15:14 +00:00
Andrew Halberstadt
4ebb46cb17 Bug 1616879 - [reftest] Exit gracefully when there is an error parsing the manifests, r=dbaron
Currently a parsing error causes reftest.jsm to hang, leaving the browser open.
Once the browser is manually closed, the Python side then emits an unrelated
traceback (since it assumes that parsing was succesful).

This ensures we both quit Firefox and check that parsing was successful (and
exit gracefully if not).

Differential Revision: https://phabricator.services.mozilla.com/D63728

--HG--
extra : moz-landing-system : lando
2020-02-26 14:25:46 +00:00
Coroiu Cristina
a4bb946bff Backed out changeset 901b3eec4eb6 (bug 1618130) for xpcshell failures at netwerk/test/unit/test_dns_override.js on a CLOSED TREE 2020-02-26 18:25:03 +02:00
Coroiu Cristina
24486add05 Backed out changeset 4dfd98d37804 (bug 1589299) for Wr failures at css/css-writing-modes/wm-propagation-svg-root-scrollbar.svg on a CLOSED TREE 2020-02-26 18:12:29 +02:00
Coroiu Cristina
9d56d9389b Backed out 4 changesets (bug 1589493) for multiple failures and crashes on CrashReporterHost on a CLOSED TREE
Backed out changeset 59fc685edca2 (bug 1589493)
Backed out changeset 275b66a8c77a (bug 1589493)
Backed out changeset 23601d10e69d (bug 1589493)
Backed out changeset e8e7bc5c8a00 (bug 1589493)
2020-02-26 18:11:44 +02:00
David Teller
048a2c638e Bug 1605072 - Updating assertion check in MinTabSelect;r=nika
Forgot a negation in the assertion check. Ideally, this should be squashed with a previous patch
but this would require backouting a patch for a one-character change, so adding this patch separately.

Differential Revision: https://phabricator.services.mozilla.com/D63321

--HG--
extra : moz-landing-system : lando
2020-02-26 15:10:50 +00:00
David Teller
f2d70e332f Bug 1605072 - Make CanonicalBrowsingContext::ChangeFrameRemoteness use async process launching;r=kmag,nika
Differential Revision: https://phabricator.services.mozilla.com/D57775

--HG--
extra : moz-landing-system : lando
2020-02-26 15:10:50 +00:00
Andi-Bogdan Postelnicu
7120bcdd99 Bug 1583999 - Use non-unified sources in CompileDB. r=jwatt
Originally authored in part by Botond Ballo <botond@mozilla.com>.

Differential Revision: https://phabricator.services.mozilla.com/D64284

--HG--
extra : moz-landing-system : lando
2020-02-26 15:08:49 +00:00
Brindusan Cristian
298fec1282 Backed out changeset e343d3722e84 (bug 1583999) as requested by Andi on slack for landing with the wrong author name. CLOSED TREE 2020-02-26 17:05:12 +02:00
Kershaw Chang
61ff3dedce Bug 1618173 - Don't set NS_HTTP_REFRESH_DNS for TRR service channel r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D64370

--HG--
extra : moz-landing-system : lando
2020-02-26 14:44:54 +00:00
Valentin Gosu
0e83b1640f Bug 1618130 - Add DNS override service r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D64325

--HG--
extra : moz-landing-system : lando
2020-02-26 14:51:28 +00:00
David Teller
dff8adaa9a Bug 1589493 - Testing ipc:content-shutdown's support for isLikelyOOM;r=gsvelto
Depends on D54700

Differential Revision: https://phabricator.services.mozilla.com/D54702

--HG--
extra : moz-landing-system : lando
2020-02-26 14:52:55 +00:00
David Teller
4544eed59f Bug 1589493 - Extending BrowserTestUtils.crashFrame to allow crashing with an OOM;r=mconley
BrowserTestUtils.crashFrame now accepts additional `options`, with an argument `crashType` that may
take "CRASH_OOM" or "CRASH_INVALID_POINTER_DEREF"|null to specify the nature of the crash. The names
are taken from CrashTestUtils.jsm but this module cannot be imported as such as it has non-trivial
binary dependencies.

Depends on D54130

Differential Revision: https://phabricator.services.mozilla.com/D54700

--HG--
extra : moz-landing-system : lando
2020-02-26 14:51:45 +00:00
David Teller
d35076d793 Bug 1589493 - Expose isLikelyOOM to Content crash handlers;r=gsvelto
Depends on D54129

Differential Revision: https://phabricator.services.mozilla.com/D54130

--HG--
extra : moz-landing-system : lando
2020-02-25 18:16:31 +00:00
David Teller
c15218401c Bug 1589493 - Expose CrashReporterHost::isLikelyOOM();r=gsvelto
We'll use this method to expose additional information to the front-end for recovering from OOM.

Differential Revision: https://phabricator.services.mozilla.com/D54129

--HG--
extra : moz-landing-system : lando
2020-02-25 18:16:33 +00:00
Botond Ballo
d670a75ef4 Bug 1583999 - Use non-unified sources in CompileDB. r=jwatt
Originally authored by Botond Ballo <botond@mozilla.com>.

Differential Revision: https://phabricator.services.mozilla.com/D64284

--HG--
extra : moz-landing-system : lando
2020-02-26 13:27:37 +00:00
Gijs Kruitbosch
b63e4c7636 Bug 1617011 - handle errors in get()/list() when they get called in the middle of shutdown, r=leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D64329

--HG--
extra : moz-landing-system : lando
2020-02-26 14:42:52 +00:00
Micah Tigley
59b1a9bb5b Bug 1604726 - Use a ResizeObserver to responsively size the toolbar. r=bgrins
The RDM toolbar currently scrolls with the page when there is overflow in `.browserStack`. This is because the browser viewport can be set to a size larger than browser window. The solution here sets makes the toolbar `position: fixed` and utilizes the `ResizeObserver` to adjust the size of the device modal/selector to take up the size of the browser stack.

Differential Revision: https://phabricator.services.mozilla.com/D63245

--HG--
extra : moz-landing-system : lando
2020-02-26 14:46:58 +00:00
Alphan Chen
82df008ac9 Bug 1589299 - Force scrollbars flag to be always enabled for new windows. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D64126

--HG--
extra : moz-landing-system : lando
2020-02-26 14:15:57 +00:00
Benjamin Bouvier
227931695d Bug 1618181: Skip wasm gc tests if GC isn't supported; r=lth
Differential Revision: https://phabricator.services.mozilla.com/D64356

--HG--
extra : moz-landing-system : lando
2020-02-26 14:03:14 +00:00
Emilio Cobos Álvarez
5824297570 Bug 1617600 - Remove no-longer-used argument to pseudo-class-list-macro. r=firefox-style-system-reviewers,jwatt
This used to be needed for Gecko interop, but now all this is in the Rust side
so we no longer need it.

Depends on D63861

Differential Revision: https://phabricator.services.mozilla.com/D63863

--HG--
extra : moz-landing-system : lando
2020-02-26 14:16:27 +00:00
Emilio Cobos Álvarez
de54b68ce7 Bug 1617600 - Prototype :focus-visible behind a flag. r=smaug
The heuristic is that we show focus outlines for unknown or key focus, and not
for mouse / touch.

This is probably not the final heuristic we take, but this allows people to play
with it and file bugs.

Once this is mature enough we should remove :-moz-focusring in favor of
:focus-visible.

Differential Revision: https://phabricator.services.mozilla.com/D63861

--HG--
extra : moz-landing-system : lando
2020-02-26 14:16:20 +00:00
Brindusan Cristian
cec1932e5b Backed out changeset 270d0ffaf825 (bug 1615259) for build bustages at BasePrincipal.h. CLOSED TREE 2020-02-26 16:21:03 +02:00
Sebastian Streich
d694e543b1 Bug 1615259 - Refactor GetUri in WorkerLoadInfo.cpp r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D62737

--HG--
extra : moz-landing-system : lando
2020-02-26 13:52:01 +00:00
Jon Coppeard
43803c34ee Bug 1617902 - Move GCParallelTask methods from vm/HelperThreads.cpp to new gc/GCParallelTask.cpp file r=sfink
This moves some GC-specific code to a new file under the GC directory.

Differential Revision: https://phabricator.services.mozilla.com/D64148

--HG--
extra : moz-landing-system : lando
2020-02-26 14:00:41 +00:00
Jon Coppeard
dbc25fc9f0 Bug 1617902 - Make AutoRunParallelTask take a pointer to a GCRuntime member function and remove static methods r=sfink
Rather than having AutoRunParallelTask call a function that mostly has to interact with GCRuntime, it's more sensible to make this call a GCRuntime method via member function pointer.  The syntax is a little gross but this means we can get rid of a few friend declarations that were only necessary to allow these functions access to GCRuntime again.

Differential Revision: https://phabricator.services.mozilla.com/D64147

--HG--
extra : moz-landing-system : lando
2020-02-26 14:00:08 +00:00
Jon Coppeard
8ddbf6c1fe Bug 1617902 - Make GCParallelTask work function back into a virtual method r=sfink
This was previously turned from a virtual method into a function pointer because of threading concerns (destroying an instance of a class with virtual methods will write to the vtable before calling superclass destructors which may cause race conditions).  However this concern is moot since we made runTask() virtual so that it could be used by XPCOM thread pools.  The concern about race conditions is handled by an assertion in the GCParallelTask destructor.

Differential Revision: https://phabricator.services.mozilla.com/D64146

--HG--
extra : moz-landing-system : lando
2020-02-26 13:59:24 +00:00
Ted Campbell
d286a3d930 Bug 1615710 - Remove Debugger::ScriptQuery::lazyScriptVector. r=jandem
Once we use BaseScript as the root type, we can combine the ScriptQuery
result vectors which will be concatenated anyways.

Depends on D64124

Differential Revision: https://phabricator.services.mozilla.com/D64125

--HG--
extra : moz-landing-system : lando
2020-02-26 08:03:43 +00:00
Ted Campbell
0ac67e20a4 Bug 1615710 - Remove the Debugger::lazyScripts weakmap. r=jandem
This can be combined with the Debugger::scripts map since keys will not
conflict. This is now all possible since we use js::BaseScript as the root
type.

Depends on D64123

Differential Revision: https://phabricator.services.mozilla.com/D64124

--HG--
extra : moz-landing-system : lando
2020-02-26 13:52:18 +00:00
Ted Campbell
5603c8e0b3 Bug 1615710 - Remove Debugger::wrapLazyScript. r=jandem
Replace with calls to wrapScript instead. Within wrapScript we now check if
script is lazy or not. This paves way to removing LazyScript* from the
DebuggerReferentVariant.

Depends on D64122

Differential Revision: https://phabricator.services.mozilla.com/D64123

--HG--
extra : moz-landing-system : lando
2020-02-26 07:52:08 +00:00
Ted Campbell
e68ab58cf6 Bug 1615710 - Use BaseScript in Debugger ScriptWeakMap. r=jandem
This lets us eventually combine the lazy and non-lazy lists. To make this
work, we need to explicitly pass the expected type of variant element instead
of deducing it from the map.

Differential Revision: https://phabricator.services.mozilla.com/D64122

--HG--
extra : moz-landing-system : lando
2020-02-26 07:48:09 +00:00
Ted Campbell
8e142f7202 Bug 1615710 - Use BaseScriptVector in Debugger. r=jandem
Replace the uses of ScriptVector and LazyScriptVector.

Depends on D64120

Differential Revision: https://phabricator.services.mozilla.com/D64121

--HG--
extra : moz-landing-system : lando
2020-02-26 07:57:00 +00:00
Ted Campbell
7cee9e4c9c Bug 1615710 - Simplify parts of debugger affecting LazyScript. r=jandem
- Simplify js::CheckDebugeeThing
- Simplify DelazifyScript
- Inline js::EnsureFunctionHasScript into callers and avoid using
  JSFunction::nonLazyScript() method.

Depends on D64119

Differential Revision: https://phabricator.services.mozilla.com/D64120

--HG--
extra : moz-landing-system : lando
2020-02-26 07:42:37 +00:00
Ted Campbell
2d1aa63ece Bug 1615710 - Simplify debugger usage of BaseScript::sourceObject. r=jandem
In Bug 1512509 we simplified BaseScript::sourceObject() to never use
cross-compartment edges. As a result we can simplify the debugger access of
sourceObject within this patch.

Differential Revision: https://phabricator.services.mozilla.com/D64119

--HG--
extra : moz-landing-system : lando
2020-02-26 07:38:23 +00:00
Florens Verschelde
b5994c2d76 Bug 1616343 - Align EagerEvaluation vertical spacing to message spacing; r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D63243

--HG--
extra : moz-landing-system : lando
2020-02-26 13:49:53 +00:00
Julien Wajsberg
8d66af6027 Bug 1497403 - Account for cases where the buffer gets full during the run of the test r=gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D64098

--HG--
extra : moz-landing-system : lando
2020-02-25 16:58:00 +00:00
Jon Coppeard
75df4ae4ff Bug 1618131 - Poison moved GC thing contents sooner r=jandem
This makes sure we will detect use of the contents of moved GC things during the update phase of the GC, not just when we return to the mutator as previously. Annoyingly we need to preserve contents for native objects with fixed elements because the elements flags are stored there and these may be accessed from other objects if they are COW elements.

This caught a use of unforwarded scripts during invalidation caused by OOM during sweeping type information.

Differential Revision: https://phabricator.services.mozilla.com/D63872

--HG--
extra : moz-landing-system : lando
2020-02-26 13:36:45 +00:00
Jon Coppeard
7556ab1743 Bug 1618131 - Assert that compacting GC only ever updates unmoved GC things or new copies of moved things and never the old copy r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D63871

--HG--
extra : moz-landing-system : lando
2020-02-26 13:36:12 +00:00
Jan de Mooij
7b9484a975 Bug 1617564 part 2 - Add minimal WarpBuilder prototype. r=iain
This has just enough code to be able to compile a "return 0;" function,
including off-thread MIR building.

The new builder consists of two parts:
* WarpOracle: runs on the main thread, produces a WarpSnapshot.
* WarpBuilder: can run off-thread, uses the WarpSnapshot to generate MIR.

WarpOracle will make a lot of the optimization decisions (which scripts can be
compiled, which ICs are copied, which functions we want to inline). WarpBuilder
will do 'just' MIR building.

This is an early prototype; the code is expected to change significantly the
coming weeks/months.

Differential Revision: https://phabricator.services.mozilla.com/D64013

--HG--
extra : moz-landing-system : lando
2020-02-26 13:30:21 +00:00
Jan de Mooij
124d08ccb2 Bug 1617564 part 1 - Add a --warp shell flag. r=iain
Differential Revision: https://phabricator.services.mozilla.com/D64012

--HG--
extra : moz-landing-system : lando
2020-02-26 09:21:44 +00:00
Dão Gottwald
65e9ed9d0a Bug 1617899 - gBrowserInit._delayedStartup shouldn't call SessionStore in the middle of announcing that delayed startup has finished. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D64088

--HG--
extra : moz-landing-system : lando
2020-02-25 15:59:35 +00:00