Commit Graph

209 Commits

Author SHA1 Message Date
Bastien Orivel
3eb765c7e3 Bug 1463251 - Part 1. Update regex in both webdriver and geckodriver. r=ato,jgraham
Also bump webdriver's version so it can be released and updated in servo

MozReview-Commit-ID: 7jMycZ6t3mm

--HG--
extra : rebase_source : 44d0b436e303d427a8b4c06e5b97538a76fd3f8c
2018-05-21 22:24:30 +02:00
Andreas Tolfsen
4dcf6c50b7 Bug 1401129 - Release webdriver 0.35.0. r=whimboo
MozReview-Commit-ID: lnoyZZbtcF

--HG--
extra : rebase_source : c43d960f793cd3d3eed922ac8ebe31d9a0564d12
2018-03-08 16:05:08 +00:00
Greg Fraley
e6f4df94b9 Bug 1396823 - Use unicode-segmentation to iterate graphemes instead of chars r=ato
MozReview-Commit-ID: 8QsOmtXDnGI

--HG--
extra : rebase_source : 0af1eb0af8d23346a1b20ac6a04964d974232850
2018-03-06 21:31:14 -05:00
Henrik Skupin
a9795130f4 Bug 1442028 - Move webdriver actions into its own module. r=ato
MozReview-Commit-ID: Bf0Ut8AGwtl

--HG--
extra : rebase_source : 4d90cb2c8e1b018a048a76805243eb01a646c326
2018-02-28 22:31:47 +01:00
Andreas Tolfsen
ff9c750728 Bug 1396819 - Improve error messages from capabilities matching. r=whimboo
This patch somewhat marginally improves error messages returned
during capabilities negotiation.

MozReview-Commit-ID: IHTRk7Rl4ZU

--HG--
extra : rebase_source : a669039092d79ec2fb3b66f7e9ef6c3ed21bfd44
2018-02-14 15:43:56 +00:00
Gurzau Raul
ff2c916927 Backed out changeset 1f94fa48c7dc (bug 1396819) for build bustage 2018-02-19 14:21:12 +02:00
Andreas Tolfsen
e963826d1c Bug 1396819 - Improve error messages from capabilities matching. r=whimboo
This patch somewhat marginally improves error messages returned
during capabilities negotiation.

MozReview-Commit-ID: IHTRk7Rl4ZU

--HG--
extra : rebase_source : 0fdca046ad69f732d70d5a23145578697cc2fb61
2018-02-14 15:43:56 +00:00
Bastien Orivel
5473571aa5 Bug 1438195 - Update log to 0.4 in webdriver and bump version. r=ato
MozReview-Commit-ID: 4lkBqe4EzEI

--HG--
extra : rebase_source : 4f8319f2cad1e33cebf3596fb4bf2a2f83534dfb
2018-02-15 13:01:10 +01:00
Henrik Skupin
7e2ab8502e Bug 1403923 - Safely shutdown Firefox from in delete_session. r=jgraham
With the request to shutdown the browser, a given amount of time
has to be waited to allow the process to shutdown itself. Only
if the process is still running afterward it has to be killed.

Firefox has an integrated background monitor which observes
long running threads during shutdown, and kills those after
65s. To allow Firefox to shutdown on its own, geckodriver
has to wait that time, and some additional seconds.

MozReview-Commit-ID: 4LRLQE0jZzw

--HG--
extra : rebase_source : c33c163d4d06768ea6616b97a25f986f5ea37e5d
2017-10-05 23:49:17 +02:00
Cosmin Sabou
92439c6859 Backed out changeset 34faef444ae3 (bug 1403923) for WD failures on Linux debug and x64 debug at /webdriver/tests/execute_async_script/user_prompts.py r=backout on a CLOSED TREE 2017-12-15 21:02:58 +02:00
Henrik Skupin
cdfdfae097 Bug 1403923 - Safely shutdown Firefox from in delete_session. r=jgraham
With the request to shutdown the browser, a given amount of time
has to be waited to allow the process to shutdown itself. Only
if the process is still running afterward it has to be killed.

Firefox has an integrated background monitor which observes
long running threads during shutdown, and kills those after
120s. To allow Firefox to shutdown on its own, geckodriver
has to wait that time, and some additional seconds.

MozReview-Commit-ID: 4LRLQE0jZzw

--HG--
extra : rebase_source : 62422c609131dfe23e547967bcfc5dfb34f30172
2017-10-05 23:49:17 +02:00
Matt Brubeck
d9343cf41b Bug 1422366 - Update webdriver Rust crate to cookie-0.10. r=jgraham
MozReview-Commit-ID: 3gJPSBSNTxF

--HG--
extra : rebase_source : faccf0c8acd73c478b5bf5578f99233445023384
2017-12-01 10:12:07 -08:00
Steve Armand
6c2bd362a0 Bug 1414256 - [webdriver] Fix spelling error for unknown capabilities. r=jgraham,whimboo
MozReview-Commit-ID: 5mrQLw81loK

--HG--
extra : rebase_source : 745790bf6f9abbbdca4218b9e0493cad7f1c8763
2017-11-04 19:00:48 -04:00
Andreas Tolfsen
54380b0c6a Bug 1410799 - Fix HTTP status for stale element reference error r=jgraham
The HTTP status for the "stale element reference" error in WebDriver
should be 404 (Not Found).

MozReview-Commit-ID: CBb7Ds8AEY3

--HG--
extra : rebase_source : 9b4309d43118730e20cb4ba17312a49cc203c58b
2017-11-01 18:02:15 +00:00
Andreas Tolfsen
ea4dbaf7a9 Bug 1413292 - Remove backtrace crate dependency from geckodriver. r=jgraham
Made this a separate commit from that which actually removes the
in-tree vendored dependencies to make it easier to review.

MozReview-Commit-ID: 9xbkM0EfOOL

--HG--
extra : rebase_source : 6686dc07a25df1a820914eb715fb733778f092cb
2017-10-31 20:31:53 +00:00
Andreas Tolfsen
a1b7e2cd46 Bug 1413292 - Stop sending geckodriver backtrace with errors. r=jgraham
The Rust backtrace from geckodriver is  not useful since any error
we actually return is by-definition handled by the code, and we
can probably get more information just by looking at the error type
and string.

At the same time, it runs the risk of confusing users into thinking
there was a bug in the driver when actually it's perfectly normal
handling of invalid input.

MozReview-Commit-ID: 9S5IaioA5AA

--HG--
extra : rebase_source : 0d98188c263d51402c2330a6b730752487dcc7fc
2017-10-31 20:30:18 +00:00
Joel Maher
34110f34d0 Bug 1412904 - fill in missing bugzilla_components in testing/webdriver. r=ato 2017-10-31 12:27:48 -04:00
Andreas Tolfsen
f056551b50 Bug 1412037 - Release webdriver crate 0.32.0. r=jgraham
A release of the webdriver crate is necessary for the release build
to pass on Travis, since testing/geckodriver/Cargo.toml cannot
depend on testing/webdriver as it is exported to the GitHub repository.

MozReview-Commit-ID: 1S2aAtg50t4

--HG--
extra : rebase_source : 53ef155537a44ef2bc141ea30a635e4144625118
2017-10-26 18:05:29 +01:00
Andreas Tolfsen
b2ef602242 Bug 1411026 - Provide String type conversion for ErrorStatus. r=whimboo
This allows us to construct an ErrorStatus variant from a String.
This is useful if the remote end implementation uses the string
codes for transport.

The new From<String> trait for ErrorStatus is a reverse lookup of
ErrorStatus::error_code.

It currently handles two cases of Selenium errors, which are "element
not visible" and "invalid element coordinates".  Both these have
been deprecated in the WebDriver standard and we need to figure
out a deprecation strategy for them.

MozReview-Commit-ID: 48MAVNQoiKy

--HG--
extra : rebase_source : 80c0932e3d42cfe19faa673d558790c83762dba1
2017-10-23 21:46:44 +01:00
Andreas Tolfsen
fe6ba66d6c Bug 1409438 - Make references to mutable variables immutable. r=whimboo
References to mutable variables do not need mutable themselves.
This fixes a series of mutable variable warnings emitted by the
Rust compiler.

MozReview-Commit-ID: EosL5XNRRX4

--HG--
extra : rebase_source : 62aa86b2c6c87a5f39ee228dcad6b5e4162779d8
2017-10-17 17:04:11 +01:00
Andreas Tolfsen
cc5abdb455 Bug 1407000 - Lint match_browser. r=automatedtester
No functional changes here, but the indentation was wrong in many
places, making it very hard to read the code.

MozReview-Commit-ID: Iku7yPD30QV

--HG--
extra : rebase_source : 31aa77135ca7f89eab60335b5bb968c4d6f1294a
2017-10-09 19:11:31 +01:00
Andreas Tolfsen
6034b21f96 Bug 1407000 - Prefer error messages in the present. r=automatedtester
s/was/is/ in various error messages for harmony.

MozReview-Commit-ID: IrRw4Vl8bIK

--HG--
extra : rebase_source : 2e4a26077733fc4a182dca0feedd14291675d6ad
2017-10-09 19:08:46 +01:00
Andreas Tolfsen
4c2629b200 Bug 1407000 - Fix error for string WebDriver capabilities. r=automatedtester
MozReview-Commit-ID: I4Il8CoUBiz

--HG--
extra : rebase_source : 8c128eb9b5a9a4130816eed4227ff39b6566e2d2
2017-10-09 19:05:59 +01:00
Henrik Skupin
884db29fa1 Bug 1403503 - Remove obsolete socksUsername and socksPassword capabilities. r=automatedtester
MozReview-Commit-ID: bHqc96uzsm

--HG--
extra : rebase_source : 633bcc11d85addf837abca71120959b4b5f6aeb5
2017-09-28 09:28:13 +02:00
Andreas Tolfsen
1c41d7c2a0 Bug 1391605 - Release webdriver 0.31.0. r=me
MozReview-Commit-ID: O3cTr5t58F
2017-09-16 15:13:50 +01:00
Sebastian Hengst
cf8b6a9dcf Backed out changeset 82b8e6f1b4d9 (bug 1391605) for build bustage. r=backout 2017-09-16 14:22:54 +02:00
Andreas Tolfsen
e7a12573ad Bug 1391605 - Release webdriver 0.31.0. r=me
MozReview-Commit-ID: O3cTr5t58F
2017-09-16 11:45:07 +01:00
Andreas Tolfsen
7050aaf58b Bug 1396866 - Relax WindowRectResponse typing. r=jgraham
The WindowProxy screenX/screenY/outerWidth/outerHeight fields are
platform-independent longs, meaning the bitness of the system is not
taken into account.  This is defined in WebIDL as "a signed integer type
that has values in the range [−2147483648, 2147483647]".  This can be
represented with an i32 internally.

Additionally, the WebDriver specification says that we should accept
JSON Numbers as input.  This means the input value can be either a float
or an integer.  rustc_serialize handles this very badly and we first
need to extract the input as f64 because this is the most liberal type
(i.e. an integer can be coerced to a float without problem).

We then we cast the number to an i64 which trims off any decimals without
worrying that the number wraps.  We then run bounds checks of an i32
and error if the number will not fit within the set range.

This patch expects the output from Marionette to be conforming.

MozReview-Commit-ID: CVdUZWh2t8X

--HG--
extra : rebase_source : 6780985703d5d5291eae508f9eb2fdec16c261cc
2017-09-09 12:21:50 +01:00
Andreas Tolfsen
5a76982786 Bug 1396838 - Drop WindowState. r=jgraham
The window state concept was removed from WebDriver level 1.

MozReview-Commit-ID: 6cogstpDc0a

--HG--
extra : rebase_source : 539df9fed0761b8e9609f60c3f9b77b946829147
2017-09-05 14:50:06 +01:00
Andreas Tolfsen
ad8630684d Bug 1396831 - Align HTTP status codes with specification. r=jgraham
Some of the HTTP status codes have changed in the WebDriver specification,
as shown in:

	d678562e3d

MozReview-Commit-ID: 4DLkYDXckew

--HG--
extra : rebase_source : 37c595265ead9591a6618ca44000bfb0f401da75
2017-09-05 14:42:12 +01:00
Andreas Tolfsen
88efb4d67b Bug 1396831 - Improve readability of error_code and http_status. r=jgraham
No semantic changes.

MozReview-Commit-ID: F4TJI2i5bJo

--HG--
extra : rebase_source : 703abf5278a7cf46393f9b720cea6e0948a5c1dd
2017-09-05 14:39:32 +01:00
Andreas Tolfsen
3646b7ae00 Bug 1368265 - Add testing/webdriver hgignore file. r=automatedtester
MozReview-Commit-ID: A2JHz2Eqdv5

--HG--
extra : rebase_source : b6dc8a5eaad3410bb658671bab540f441a2e298c
2017-09-03 17:19:37 +01:00
Andreas Tolfsen
f5e4748beb Bug 1368265 - Remove unnecessary license files. r=automatedtester
Since both these Rust programs are hosted in mozilla-central,
they are governed by the top-level LICENSE file.  See also
toolkit/content/license.html.

MozReview-Commit-ID: 4C0fEAeJZ6h

--HG--
extra : rebase_source : f8beebd578cd816d974cc9416c6bdb1bdfa37b12
2017-09-03 17:17:13 +01:00
Andreas Tolfsen
783b9e7701 Bug 1368265 - Provide a webdriver README. r=automatedtester
Documentation is the hallmark of a good software library and this isn't
great, but it is a step in the right direction.

MozReview-Commit-ID: IHDwp2pjXom

--HG--
extra : rebase_source : 9f5d488705cb97510ce051f1530002fffd302aaf
2017-09-03 17:15:03 +01:00
Andreas Tolfsen
c722f88ac8 Bug 1368265 - Update geckodriver and webdriver Cargo.tomls. r=automatedtester
MozReview-Commit-ID: 6MsrxinrYEp

--HG--
extra : rebase_source : c0f5b076183c53c86aae0e757b6ef391f1eba8c1
2017-09-03 16:24:55 +01:00
Andreas Tolfsen
0305a12b3d webdriver: move crate to m-c
IGNORE BAD COMMIT MESSAGES
2017-09-03 15:56:42 +01:00
Henrik Skupin
ace1170369 webdriver: Add "noProxy" support for manual proxy type (#121)
Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: 89df5f92278488697460b279eea0708e482c3813

committer: GitHub <noreply@github.com>

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : c9cff2069fccc117f9bc3f95b1267b7f65c1670a
2017-08-30 21:02:55 +02:00
David Burns
5ff5b691d4 webdriver: Add Tag Name as a valid location strategy. (#118)
* Add Tag Name as a valid location strategy.

While creating WDSpec for Find Element and similar commands it showed
that we do not support Tag Name as a valid selector. Tests can be found
at https://reviewboard.mozilla.org/r/172110/

Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: 5cd49eb129f4ae1ae7e047f274cfa31092353d65

committer: jgraham <james@hoppipolla.co.uk>

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : a2245a52d6ad17184dc8b105cd2082899707bdda
2017-08-24 14:22:02 +01:00
Andreas Tolfsen
4c3170d857 webdriver: cargo: release 0.30.0
Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: bd7c82e977ddf0f2f90e9300fef70d0d2eb7ff33

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : 6794f7ce256468a1c434134949c84222283c3d74
2017-08-18 13:27:38 +01:00
Henrik Skupin
6df788afcf webdriver: Add support for socksVersion (#115)
To add a socks proxy the socks version is a required capability.
This patch adds the handling of the capability.

Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: 94cdfcbb8e92bc070f144ad13bc1f074f0761eb5

committer: David Burns <david.burns@theautomatedtester.co.uk>

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : d555f9bcb03b61434b83973ee5736ca771926183
2017-08-18 12:49:34 +01:00
Henrik Skupin
dac7fbd059 webdriver: Make proxy port an optional suffix for all *Proxy capabilities (#115)
As given by the spec the proxy port is no longer a separate capability,
but an optional part of ftpProxy, httpProxy, sslProxy, and socksProxy.

Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: f42568128d5a4218cc9f71d727ca3550c99c012e

committer: David Burns <david.burns@theautomatedtester.co.uk>

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : 11bda39133f9e0d2e67987b693fd44e0c249c23e
2017-08-18 12:49:34 +01:00
Henrik Skupin
6071140e1b webdriver: Fix invalid check for scheme in proxy host. (#114)
Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: 12e62a7956219ca4ebb3d6161e4ce9c853e82217

committer: jgraham <james@hoppipolla.co.uk>

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : fffe353f879f73c03225355001d5547924fa73e8
2017-08-08 15:27:32 +01:00
Andreas Tolfsen
806c215eb8 webdriver: cargo: release 0.29.0
Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: 7d2bf526b6ed9c45e06b5b2abd395c996328d3ca

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : 52dfc7e137ca51ba0e8d49286bbe2d09db7c2a41
2017-08-08 14:51:02 +01:00
Henrik Skupin
89de54cf9d webdriver: Add support to format values with {:?} (#111)
For debugging purposes it is helpful when enum and struct
definitions are using derive Debug.

Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: 989cfcb7ab23ab356b2bf77ff37a37ab1c7be89d

committer: jgraham <james@hoppipolla.co.uk>

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : 5d1bcd860f19a0275cc110d8e86d62788ce5319a
2017-08-08 11:14:55 +01:00
Andreas Tolfsen
e9a9bb7bc1 webdriver: common, response: add window state to window rect response (#109)
The WebDriver specification recently introduced an additional "state"
field for the window rect.

Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: 2b54d3d8ad30f25b0df9b186661be15de4e280fb

committer: jgraham <james@hoppipolla.co.uk>

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : bc62b14208282b2725e3c3ef476f840b16315418
2017-08-07 19:28:32 +01:00
Henrik Skupin
00d5bdfa84 webdriver: capabilities: use proxyType "direct" instead of "noproxy" (#107)
The WebDriver spec has been changed a while ago to support "direct"
as proxyType.  So "noproxy" is no longer a valid proxy type.

Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: d4c7c73af12a38c3723750f32370197ab6130c67

committer: Andreas Tolfsen <ato@sny.no>

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : fd64dcba6fd8742cdac87d4d00aa42baa6b31b75
2017-08-03 17:47:22 +01:00
James Graham
a84d0851ff webdriver: Update version number for release
Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: 2746c4f91f1c3582fe0ce5dea91f8971f8f20390

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : 4029c44236409e9a4ceb4e3174aa2e7782e7168c
2017-07-18 16:42:19 +01:00
SimonP
5cf6ff6879 webdriver: Implement the minimize window for webdriver-rust (#105)
* Implement the minimize window for webdriver-rust

Symptom: Now webdriver-rust cannot minimize window
Root Cause: No minimize command
Solution: Add the minimize command
Project: webdriver-rust
Note: After add this patch
      Then add one in geckodriver
      Then add support in firefox(marionette)
      At last add patch in selenium(firefox webdriver)

Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: 37b661f0d103ecde3f4bb87962142d054812f767

committer: jgraham <james@hoppipolla.co.uk>

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : 282e0b54fb349de5df15c05a2fb530af18931ed8
2017-07-06 15:03:13 +01:00
Andreas Tolfsen
685509aaee webdriver: cargo: release 0.27.0
Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: 1b8863b569ef6efe5f20f7a084e5910f1280285f

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : 1a9db5d4470a84c94269047f68b4df5ee9284857
2017-06-19 13:14:44 +01:00
Jon Gjengset
dd5ce4bd02 webdriver: cargo: bump cookie dependency to 0.9 (#104)
Fixes: #103
Source-Repo: https://github.com/mozilla/webdriver-rust
Source-Revision: 107a60caf001239e69a14fed292f9177e3279e81

committer: Andreas Tolfsen <ato@sny.no>

--HG--
extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000
extra : subtree_revision : 19bf1ffcae926e21f250c667a38234ed33c5f61b
2017-06-17 00:04:34 +01:00