Commit Graph

3248 Commits

Author SHA1 Message Date
Olli Pettay
85a74a85cd Bug 1507495, Enable Pointer events on GeckoView by default, r=droeh
Differential Revision: https://phabricator.services.mozilla.com/D39965

--HG--
extra : moz-landing-system : lando
2019-07-31 01:02:32 +00:00
Kris Maglione
87884612c0 Bug 1568035: Part 4 - Update test expections for Fission. r=mccr8
Some failures crept in and out after my last sets of annotations landed. This
patch updates most of the annotations to deal with them.

MANUAL PUSH: Lando won't let me land.

Differential Revision: https://phabricator.services.mozilla.com/D39462

--HG--
extra : rebase_source : 4cfccf95c5bb2521533a9f5c4c25d67f414fb6f5
extra : histedit_source : c19187a3b3002e0eebdd809738b57641e1e432cd
2019-07-24 13:06:57 -07:00
Kris Maglione
ef02b3cbd8 Bug 1568035: Part 1 - Skip tests which cause shutdown leaks under Fission. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D39459

--HG--
extra : rebase_source : 594e7c17a8aa81f9b212ff1fa492a8ab8f40d5ee
2019-07-19 15:31:16 -07:00
Kris Maglione
e40b418215 Bug 1566952: Part 2 - Update Fission failure annotations after skipping crashes. r=mccr8
When a test crashes, the harness skips all of the remaining tests in the
directory. That means that with crashes skipped, we now try to run a whole lot
more tests than we did before, and a lot of them fail under Fission.

This patch adds annotations to the new failures that show up after part 1.

Differential Revision: https://phabricator.services.mozilla.com/D38726

--HG--
extra : rebase_source : 292157039c88fc615f5de41679e96e72766ac4db
2019-07-19 12:30:10 -07:00
Kris Maglione
4bd4d680d4 Bug 1566952: Part 1 - Annotate mochitests that crash with Fission enabled. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D38725

--HG--
extra : rebase_source : 3e8b32b86b12b22d038baa770070a5c8095043c9
2019-07-17 13:37:48 -07:00
Kris Maglione
0962c2b731 Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.

There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.

Differential Revision: https://phabricator.services.mozilla.com/D38247

--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
2019-07-15 16:19:32 -07:00
Niklas Hambüchen
b1eb1b43ef Bug 1564930 - Improve "XHR must not be LOADING or DONE" error messages. r=baku
The previous error message suggested that this is an internal error message
pointing out a bad state in the XHR state machine, when in fact this is
a user error (calling `overrideMimeType()` or setting `responseType()` after
`send()`).

This commit improves and disambiguates the error messages, pointing out to
the user what they did wrong, like other browsers do.

Differential Revision: https://phabricator.services.mozilla.com/D37659

--HG--
extra : moz-landing-system : lando
2019-07-12 22:51:10 +00:00
Kagami Sascha Rosylight
8d91017fdb Bug 928150: Implement canvas getTransform() and setTransform() r=bzbarsky
Adds getTransform() and setTransform() to CanvasRenderingContext2D.

Differential Revision: https://phabricator.services.mozilla.com/D36871

--HG--
extra : moz-landing-system : lando
2019-07-11 06:14:58 +00:00
arthur.iakab
973b98aac6 Backed out changeset 0aea246d01bb (bug 928150) for causing build bustages on DOMMatrix.h CLOSED TREEE 2019-07-11 06:31:59 +03:00
Kagami Sascha Rosylight
b65864cf84 Bug 928150: Implement canvas getTransform() and setTransform() r=bzbarsky
Adds getTransform() and setTransform() to CanvasRenderingContext2D.

Differential Revision: https://phabricator.services.mozilla.com/D36871

--HG--
extra : moz-landing-system : lando
2019-07-11 02:43:46 +00:00
Junior Hsu
187b616b4e Bug 1424076 - P4 Update sendBeacon origin header test r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D33386
2019-07-09 23:20:02 +02:00
Oana Pop Rus
b0ba88239d Backed out 4 changesets (bug 1424076) for mochitests failures in test_iframe_sandbox_navigation.html on a CLOSED TREE
Backed out changeset 67239c7df87c (bug 1424076)
Backed out changeset 2b4487c6403d (bug 1424076)
Backed out changeset c002ddb976e9 (bug 1424076)
Backed out changeset 50fbc0cec01a (bug 1424076)
2019-07-09 23:48:37 +03:00
Junior Hsu
5e98826855 Bug 1424076 - P4 Update sendBeacon origin header test r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D33386

--HG--
extra : moz-landing-system : lando
2019-07-09 18:23:38 +00:00
Dorel Luca
06b684f035 Backed out 4 changesets (bug 1424076) for ESlint failure
Backed out changeset c6299be2356c (bug 1424076)
Backed out changeset f567bf2904c9 (bug 1424076)
Backed out changeset 6127a13715c9 (bug 1424076)
Backed out changeset 743605a9b0ac (bug 1424076)

--HG--
extra : rebase_source : a20ab3fc782b376dd091e18b647a2ef12d7e4aca
2019-07-09 21:17:22 +03:00
Junior Hsu
6d2253ba30 Bug 1424076 - P4 Update sendBeacon origin header test r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D33386

--HG--
extra : moz-landing-system : lando
2019-07-09 17:14:39 +00:00
Jonathan Kingston
31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
Alex Catarineu
a8b667f825 Bug 467035 - Avoid leaking browser language via DTD r=Gijs,bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D34187

--HG--
extra : moz-landing-system : lando
2019-07-08 10:47:05 +00:00
Jan-Ivar Bruaroey
4736d10ce8 Bug 1528031 - Update tests to work with [SecureContext] navigator.mediaDevices. r=pehrsons,smaug
Differential Revision: https://phabricator.services.mozilla.com/D35970

--HG--
extra : moz-landing-system : lando
2019-07-05 21:21:38 +00:00
Victor Porof
0a8ff0ad85 Bug 1561435 - Format dom/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35951

--HG--
extra : source : 62f3501af4bc1c0bd1ee1977a28aee04706a6663
2019-07-05 10:44:55 +02:00
Kris Maglione
b459f53a11 Bug 1561061: Move SpecialPowers pref env code to parent and make sane-ish. r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D35706

--HG--
extra : rebase_source : ec33af8c17048c3828d4ca4643e2e17bd2a854c0
extra : source : c2d0956f41d82e76c682f829807e818863cd802a
2019-06-24 13:47:53 -07:00
Kris Maglione
f180f12646 Bug 1560400: Part 1 - Support remote frames in Window indexed getters. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D35471

--HG--
extra : rebase_source : b326799f8ced75068f7e7fec6edbd39455cdb9b1
extra : source : 84633034590f2d1a4c336f9653e6c542f3a09039
2019-06-20 13:52:55 -07:00
Kris Maglione
3e44c16cf9 Bug 1541557: Part 5 - Update callers of ChromeScript.sendSyncMessage to use sendQuery instead. r=nika
Since JSWindowActors don't have direct access to synchronous messaging,
ChromeScript callers are going to need to migrate to asynchronous messaging
and queries instead.

Since there's no comparable API to sendQuery for frame message managers, this
patch adds a stub that uses synchronous messaging, but makes the API appear
asynchronous, and migrates callers to use it instead of direct synchronous
messaging. This will be replaced with a true synchronous API in the actor
migration.

Fortunately, most of the time, this actually leads to simpler code. The
`sendQuery` API doesn't have the odd return value semantics of
`sendSyncMessage`, and can usually just be used as a drop-in replacement. Many
of the `sendSyncMessage` callers don't actually use the result, and can just
be changed to `sendAsyncMessage`. And many of the existing async messaging
users can be changed to just use `sendQuery` rather than sending messages and
adding response listeners.

However, the APZ code is an exception. It relies on intricate properties of
the event loop, and doesn't have an easy way to slot in promise handlers, so I
migrated it to using sync messaging via process message managers instead.

Differential Revision: https://phabricator.services.mozilla.com/D35055

--HG--
extra : rebase_source : d5707e87f293a831a5cf2e0b0a7e977090267f78
extra : source : 75ebd6fce136ab3bd0e591c2b8b2d06d3b5bf923
2019-06-12 12:40:51 -07:00
Kris Maglione
f70e67ad2d Bug 1541557: Part 4 - Stop relying on synchronous preference getters/setters. r=nika
The SpecialPowers set*Pref/get*Pref APIs currently use synchronous messaging
to set and get preference values from the parent process. Aside from directly
affecting callers of those APIs, it also affects callers of `pushPrefEnv`,
which is meant to be asynchronous, but is in practice usually synchronous due
to the synchronous messaging it uses.

This patch updates the getPref APIs to use the in-process preference service
(which most callers are expecting anyway), and also updates the callers of
the setPref and pushPrefEnv APIs to await the result if they're relying on it
taking effect immediately.

Unfortunately, there are some corner cases in tests that appear to only work
because of the quirks of the current sync messaging approach. The synchronous
setPref APIs, for instance, trigger preference changes in the parent
instantly, but don't update the values in the child until we've returned to
the event loop and had a chance to process the notifications from the parent.
The differnce in timing leads some tests to fail in strange ways, which this
patch works around by just adding timeouts.

There should be follow-ups for test owners to fix the flakiness.

Differential Revision: https://phabricator.services.mozilla.com/D35054

--HG--
extra : rebase_source : 941298157e7c82f420cf50ce057154ce9b85301c
extra : source : 189dc8a359815e059a4a217f788d183260bb2bfe
2019-06-13 09:34:39 -07:00
Kagami Sascha Rosylight
509d2d30b6 Bug 1366738: Implement [LegacyWindowAlias] r=bzbarsky
Add [LegacyWindowAlias] extended attribute support for WebKitCSSMatrix and webkitURL.

Differential Revision: https://phabricator.services.mozilla.com/D35601

--HG--
extra : moz-landing-system : lando
2019-07-03 08:37:01 +00:00
Kagami Sascha Rosylight
e8b452e9d2 Bug 1560119: Remove DOMMatrix scaleNonUniformSelf() r=bzbarsky
We probably just can remove it given that no other implementations are there.

Differential Revision: https://phabricator.services.mozilla.com/D36491

--HG--
extra : moz-landing-system : lando
2019-07-01 21:07:20 +00:00
Kagami Sascha Rosylight
5e70c0e2ab Bug 1397945: Align DOMMatrix scale* operations to the spec r=bzbarsky
Adjusted scale() to receive six arguments, scale3d() to allow zero argument, and scaleNonUniform to support only two arguments.  Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6484802f1961c7fe881b4d1d7f4309ec19110a7

Differential Revision: https://phabricator.services.mozilla.com/D36147

--HG--
extra : moz-landing-system : lando
2019-06-28 15:11:00 +00:00
Makoto Kato
c2694625b5 Bug 1444847 - part 4: Implement mozilla::dom::StaticRange and static factory methods r=smaug
This patch is based on Makoto Kato-san's patch.

This patch implements `mozilla::dom::StaticRange` class and creating some
static factory methods.

Then, makes `AbstractRange` has a utility method of `SetStartAndEnd()`
method of `nsRange` and `StaticRange` for sharing same logic in one place.
However, there are some additional work is required only in `nsRange`, e.g.,
`nsRange` needs to start observing mutation of the range, but `StaticRange`
does not it.  Therefore, it's implemented as a template method which takes
`nsRange*` or `StaticRange*` as a parameter.  Then, each `DoSetRange()`
method of them can do different things without virtual calls.

Note that `StaticRange` does not have any properties, methods nor constructor.
Therefore, we need additional API to test it.

Differential Revision: https://phabricator.services.mozilla.com/D35143

--HG--
extra : moz-landing-system : lando
2019-06-28 07:48:52 +00:00
Makoto Kato
5f9abd3366 Bug 1444847 - part 1: Create mozilla::dom::AbstractRange r=smaug
This patch is based on the patch created by Makoto Kato-san.

`Range` and `StaticRange` have common base interface, `AbstractRange`.
https://dom.spec.whatwg.org/#abstractrange

This interface has simply returns `startContainer`, `endContainer`,
`startOffset`, `endOffset` and `collapsed`.

Different from the original patch's approach, this patch moves related
members in `nsRange` to `AbstractRange` since this approach avoids
virtual call cost.  Additionally, this patch makes them not throw as
declared by the spec.  As far as I know, the destruction cost of
`ErrorResult` may appear in profile so that we should avoid creating
the instance if we can avoid it.

Unfortunately, the instance size of `nsRange` becomes larger with this
patch.  The size is changed from 176 to 184.  I.e., now, `nsRange`
requires bigger chunk.

Differential Revision: https://phabricator.services.mozilla.com/D35140

--HG--
extra : moz-landing-system : lando
2019-06-28 07:46:35 +00:00
Gabriele Svelto
74276da797 Bug 1536221 - Re-enable mochitests and xpcshell tests that depend on the crash reporter on Windows/AArch64 r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D35995

--HG--
extra : moz-landing-system : lando
2019-06-26 13:15:24 +00:00
Brendan Dahl
62645647cf Bug 1558980 - Convert all XUL mochitest plain tests to chrome. r=mossop
Two benefits:

1) Align test setup with shipping Firefox - We don't allow content
privilege XUL in shipping versions of Firefox, so having the tests be
chrome would be more realistic to our use case.

2) Support the XUL to XHTML migration. These files will soon become XHTML
files, but will still need to load XUL elements, so they'll need to be
marked as chrome privileged to continue working.

Differential Revision: https://phabricator.services.mozilla.com/D35870

--HG--
rename : dom/xul/test/test_bug486990.xul => dom/xul/test/test_bug486990.xhtml
rename : layout/base/tests/file_bug465448.html => layout/base/tests/chrome/file_bug465448.html
rename : layout/base/tests/test_bug465448.xul => layout/base/tests/chrome/test_bug465448.xul
extra : moz-landing-system : lando
2019-06-26 18:00:53 +00:00
Mihai Alexandru Michis
c4808ba596 Backed out changeset 7a0ba8a3de05 (bug 1558980) for mochitest-chrome failures. CLOSED TREE
--HG--
rename : layout/base/tests/chrome/test_bug465448.xul => layout/base/tests/test_bug465448.xul
2019-06-27 05:48:11 +03:00
Mihai Alexandru Michis
cc9e91253e Backed out 2 changesets (bug 1528031) for causing crashtests to time out. CLOSED TREE
Backed out changeset 27ce9b212d26 (bug 1528031)
Backed out changeset 0a18aa212ee6 (bug 1528031)
2019-06-27 05:45:20 +03:00
Brendan Dahl
c7f754871d Bug 1558980 - Convert all XUL mochitest plain tests to chrome. r=mossop
Two benefits:

1) Align test setup with shipping Firefox - We don't allow content
privilege XUL in shipping versions of Firefox, so having the tests be
chrome would be more realistic to our use case.

2) Support the XUL to XHTML migration. These files will soon become XHTML
files, but will still need to load XUL elements, so they'll need to be
marked as chrome privileged to continue working.

Differential Revision: https://phabricator.services.mozilla.com/D34782

--HG--
rename : layout/base/tests/test_bug465448.xul => layout/base/tests/chrome/test_bug465448.xul
extra : moz-landing-system : lando
2019-06-20 21:29:50 +00:00
Jan-Ivar Bruaroey
8fd4637236 Bug 1528031 - Update tests to work with [SecureContext] navigator.mediaDevices. r=pehrsons,smaug
Differential Revision: https://phabricator.services.mozilla.com/D35970

--HG--
extra : moz-landing-system : lando
2019-06-26 18:15:50 +00:00
Eden Chuang
44bb94af31 Bug 1427396 - Twice the dom.serviceWorkers.idle_timeout value for tests under dom/tests/mochitest/fetch/ to reduce the impact SW termination by timeout. r=perry
The ServiceWorker is terminated by idleWorkerTimer timeout, and in slow platforms/machines, it would cancel the uncompleted fetching and make unexpected behavior during running tests.

The SW idle termination implementation has no defects, so the fix would just double the dom.serviceWorkers.idle_timeout to let fetchings have more chance to finish before idleWorkerTimer timeout.

Differential Revision: https://phabricator.services.mozilla.com/D35555

--HG--
extra : moz-landing-system : lando
2019-06-25 15:21:15 +00:00
Mirko Brodesser
db8f5b7184 Bug 1551425: Part 1) Test reference to childNodes' NodeList keeps its items alive. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D32836

--HG--
extra : moz-landing-system : lando
2019-06-25 06:56:01 +00:00
Edwin Gao
407cdf5dc3 Bug 1558642 - disable test_bug1224790 on macosx1014 due to persistent failures r=arai,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D35489

--HG--
extra : moz-landing-system : lando
2019-06-21 17:09:43 +00:00
Kagami Sascha Rosylight
795d0eebcc Bug 1559874: Always create 3D DOMMatrix from 16 elements r=bzbarsky
Currently Firefox creates a 2D DOMMatrix when certain values of 16 elements are zero, so this change fixes it to align with the spec.

Differential Revision: https://phabricator.services.mozilla.com/D35326

--HG--
extra : moz-landing-system : lando
2019-06-20 03:59:59 +00:00
Kagami Sascha Rosylight
a235dfa68b Bug 1558387: Remove DOMError constructor r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D35184

--HG--
extra : moz-landing-system : lando
2019-06-17 15:43:38 +00:00
Mark Banner
201255ab84 Bug 1558485 - Turn on ESLint for all of dom/ disabling most of the failing rules. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D34761

--HG--
extra : moz-landing-system : lando
2019-06-13 20:21:46 +00:00
Boris Chiou
36f22dc0e1 Bug 1543839 - Update test_interfaces.js for ResizeObserver. r=smaug
Drop nightly true because it is enabled on all versions.

Differential Revision: https://phabricator.services.mozilla.com/D34757

--HG--
extra : moz-landing-system : lando
2019-06-12 18:29:46 +00:00
Sean Feng
36865676e1 Bug 1512388 - Add loading cross domain iframes in background r=smaug
This patch adds the ability to load cross domain iframes in the
background to make the top level documents finish earlier.

This is an experiment feature that we'll keep it disabled by default.

Differential Revision: https://phabricator.services.mozilla.com/D24938

--HG--
extra : moz-landing-system : lando
2019-06-11 20:43:40 +00:00
Edgar Chen
1ea67058f6 Bug 1525554 - Enable promise rejection event and update tests result; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D31734

--HG--
extra : moz-landing-system : lando
2019-06-04 12:55:57 +00:00
Edgar Chen
6c45f02a32 Bug 1553852 - Mark eCompositionChange as composed event; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D33387

--HG--
extra : moz-landing-system : lando
2019-06-03 09:18:47 +00:00
Daosheng Mu
fc4437c39c Bug 1523351 - Part 2: Add tests for GamepadTouch and GamepadLightIndicator. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29289

--HG--
extra : moz-landing-system : lando
2019-05-29 22:15:25 +00:00
Daosheng Mu
7b8a1cc7ba Bug 1523351 - Part 1: GamepadTouch and GamepadLightIndicator WebAPI implementation. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D20744

--HG--
extra : moz-landing-system : lando
2019-05-29 22:44:24 +00:00
Daniel Varga
b173205f5e Backed out 5 changesets (bug 1523351) for build bustage at builds/worker/workspace/build/src/dom/gamepad/GamepadRemapping.cpp on a CLOSED TREE
Backed out changeset 723d0a919d71 (bug 1523351)
Backed out changeset 13dcba81ff07 (bug 1523351)
Backed out changeset 6209717410be (bug 1523351)
Backed out changeset 80b34e6ce876 (bug 1523351)
Backed out changeset 7bdb7982c3af (bug 1523351)
2019-05-30 01:10:11 +03:00
Daosheng Mu
304abbd74d Bug 1523351 - Part 2: Add tests for GamepadTouch and GamepadLightIndicator. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29289

--HG--
extra : moz-landing-system : lando
2019-05-29 20:48:29 +00:00
Daosheng Mu
f1193f9f17 Bug 1523351 - Part 1: GamepadTouch and GamepadLightIndicator WebAPI implementation. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D20744

--HG--
extra : moz-landing-system : lando
2019-05-29 21:44:28 +00:00
Daniel Varga
943f938b03 Backed out 5 changesets (bug 1523351) for causing build bustage at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h on a CLOSED TREE
Backed out changeset 607b23dcc62a (bug 1523351)
Backed out changeset b8169dcf0631 (bug 1523351)
Backed out changeset 982cd43dc8d9 (bug 1523351)
Backed out changeset 053540f0b00a (bug 1523351)
Backed out changeset cac2a77abd09 (bug 1523351)
2019-05-29 23:45:15 +03:00