The traverse method no longer traverses the JS val, because that will
now be automatically traced by the CC using the trace method.
The purple methods are unused.
I marked a few methods that regular callers shouldn't use protected.
Differential Revision: https://phabricator.services.mozilla.com/D156977
This patch was made to guard Update functionality from being called in BrowserGlue.jsm if Firefox was not built with support for the Updater. However, it also ended up touching the updater build configuration. I discovered while testing this patch that building with `--disable-updater` does not imply `--disable-maintenance-service` or `--disable-update-agent`. So I fixed that issue as well. Once that was fixed, I could change some other code that checked `AppConstants.MOZ_UPDATER && AppConstants.MOZ_UPDATE_AGENT` since that is now equivilant to `AppConstants.MOZ_UPDATE_AGENT`.
Differential Revision: https://phabricator.services.mozilla.com/D156902
Because the number of telemetry events we get back can vary we can't
use the existing Telemetry Test functions, and need to introduce a
new one. It does duplicate some code, but because the functions differ
in a few ways it's not straightforward or clean to refactor it in a shared
way.
Differential Revision: https://phabricator.services.mozilla.com/D155622
This new method return an array of `nsIPermission` whose type are included in the
array of permission types parameter.
This will help the implementation of Bug 1778959 where we need to get all the permission
of a given Set of (gated) permission types.
Differential Revision: https://phabricator.services.mozilla.com/D156951
On Android, SurfaceTextures provide a transform matrix that should be
applied to texture coordinates when sampling from the texture. Prior
to bug 1731980 we ignored this value, and simply y-flipped the video
instead. On most devices the transform is just a y-flip, so this
produced the correct results. However, on some devices the transform
included a scale as well as the y-flip, meaning that we rendered
videos at an incorrect size.
The fix for bug 1731980 was to correctly apply the transformation.
However, it now appears that on Mediatek 6735 devices the transform
provided by the system is incorrect. On these devices, videos were
rendered correctly when we ignored the transform and just did a
y-flip, and now that we apply the transform videos are rendered at the
wrong size.
This patch makes it so that we override the system-provided transform
on these devices with a simple y-flip. The existing mIgnoreTransform
flag has been changed to an optional "transform override" value to
achieve this. We ensure that we only override the transform for
SurfaceTextures that are output from a MediaCodec, to ensure that we
don't accidentally apply the wrong transform to SurfaceTextures
attached to other sources.
Differential Revision: https://phabricator.services.mozilla.com/D155706
Now that the script is run on automation, there's no need to have
a (different) version in tree.
The documentation is also updated to explain the current setup.
Differential Revision: https://phabricator.services.mozilla.com/D156930
The test is exceeding the timeout threshold. I've separated the file
so that it's really only loading URLs to check if the search term is
shown.
modifiedUrl has tests that take SERP-like urls and modifies them at
different points in time.
searchMode just tries to conduct a search with a search engine in
searchMode. I got rid of the additional test that changes the engine
to default and checks it because all these tests kind of test that
as loading the test suite requires changing the search engine.
Differential Revision: https://phabricator.services.mozilla.com/D156822
While this introduces some redundancy, the advantage to spelling out the error message IDs like
this explicitly is that if the string ever needs to be updated (which requires a message ID
change), then we have a single place to remap the error code strings to the message IDs.
Differential Revision: https://phabricator.services.mozilla.com/D156553