Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-26 11:45:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
384,483 Commits 615 Branches 98 Tags 5.9 GiB
402eaa8531
Commit Graph

33831 Commits

Author SHA1 Message Date
Jonathan Watt
7d2ad21e7e Bug 1063073 - Make sure embedding elements that rely on an embedded SVG's intrinsic dimensions are resized if the SVG is late in loading. r=dholbert 2014-09-04 20:09:51 +01:00
Jacek Caban
06efc6492d Bug 1063511 - Fix mingw builds after bug 1027906. r=tabraldes 2014-09-08 10:35:24 +02:00
Boris Zbarsky
2f75825ec4 Bug 1017424 part 3. Remove the now-unnecessary nsIDocument::WrapObject. r=peterv 2014-09-05 14:28:44 -04:00
Jean-Yves Avenard
67fea6cd17 Bug 1063255 - Revert fix from bug 1062098. r=rillian 2014-09-05 12:29:08 +10:00
Kilik Kuo
6b7ffc4559 Bug 1022524 - Set up audio track and video track information for Ogg files. r=rillian 2014-09-03 11:01:37 +08:00
Kilik Kuo
f9a8f31cb4 Bug 1022524 - Mochitest for Bug 1022524. r=rillian 2014-08-26 14:33:08 +08:00
Matthew Gregan
4335ec1e50 Bug 1062669 - Consider only SourceBuffers created before the first initialization segment is appended as essential for parent decoder initialization. r=cajbir 2014-09-05 12:04:54 +12:00
Ehsan Akhgari
d289d3a9b1 Bug 1063086 - Fix more bad implicit constructors in DOM; r=baku 2014-09-04 23:22:49 -04:00
Matthew Gregan
8b2ba8781f Bug 1062733 - Keep track of all TrackBuffer decoders rather than only fully initialized ones. r=cajbir 2014-09-04 19:35:01 +12:00
Matthew Gregan
96aeda8fdc Bug 1064826 - Disable test_FrameSelection.html on OS X. 2014-09-10 18:25:50 +12:00
Mats Palmgren
2c38b0b6b7 Bug 1061468 - Notify the editor when removing the focused element is its ancestor limiter. r=ehsan 2014-09-09 23:27:56 +00:00
Matthew Gregan
58f9ec31b0 Bug 1064699 - Update mLastVideoFrameTime after it's used for computing the frame duration. r=cajbir 2014-09-08 23:20:00 +12:00
Boris Zbarsky
a5de334278 Bug 716491. Return a .status of 200 and .statusText of "OK" for successful non-HTTP XHR loads. r=smaug 2014-09-04 15:26:58 -04:00
Boris Zbarsky
0884032212 Bug 1057176. Don't try to use the document's window for regexp evaluation in nsContentUtils::IsPatternMatching, since there might not be one. Just use the unprivileged junk scope. r=bholley 2014-09-04 15:26:39 -04:00
Alfredo Yang
9d9c06aae5 Bug 1041393 - ImageCapture - add test case. r=roc 2014-08-18 23:39:00 +02:00
JW Wang
8d74b8027a Bug 1029372 - clear AudioQueue only after shutting down audio thread to avoid race in accessing AudioQueue. r=kinetik 2014-09-03 20:05:00 +02:00
Kyle Huey
1e8e0c575a Bug 982212: Part 3 - Now that nsTArray::AppendElement supports r-value references, remove the workarounds added in Bug 967364. r=nfroyd 
--HG--
extra : rebase_source : 1e6188d26b745f6dc9bdf2accc0abf7f07351510
 2014-03-15 18:56:00 +01:00
Peter Van der Beken
73d234512e Bug 849567 - Automatically handle raw and already_AddRefed return values in Paris bindings and remove resultNotAddRefed, make all Constructor methods return already_AddRefed<...>. r=bz. 
--HG--
extra : rebase_source : 726702eb39e627d74ddb3adf6059569d077089d4
 2014-08-28 00:43:55 +02:00
Alfredo Yang
6957a19320 Bug 916643 - ImageCapture webidl and implementation. r=roc, r=smaug 2013-09-16 10:50:24 +08:00
Alfredo Yang
1d9ecb16df Bug 916643 - Refactory ImageEncoder. r=roc 
--HG--
rename : dom/canvas/ImageEncoder.cpp => dom/base/ImageEncoder.cpp
rename : dom/canvas/ImageEncoder.h => dom/base/ImageEncoder.h
 2014-09-04 02:08:00 +02:00
Alfredo Yang
eca5c8a6d7 Bug 916643 - Refactory black image. r=roc 2014-09-04 02:08:00 +02:00
Matthew Gregan
2903132a69 Bug 1059058 - Introduce abstraction to manager mapping between SourceBuffers and SourceBufferDecoders for the MediaSourceReader. r=cajbir 2014-09-04 13:57:06 +12:00
Christoph Kerschbaumer
68de320099 Bug 1062529 - Split GetChannelPrincipal into GetChannelResultPrincipal and GetChannelURIPrincipal. r=bz 2014-08-06 16:05:40 -07:00
Mike Hommey
0060683747 Bug 1059090 - Don't require SOURCES to be set for CPP_UNIT_TESTS and SIMPLE_PROGRAMS. r=mshal 2014-09-03 14:16:37 +09:00
Mike Hommey
ed70c5f377 Bug 1041941 - Use templates for programs, simple programs, libraries and C++ unit tests. r=gps 2014-09-03 14:10:54 +09:00
Ryan VanderMeulen
bc55829916 Merge m-c to inbound. a=merge 2014-09-03 16:40:18 -04:00
Ryan VanderMeulen
f5859a2048 Merge inbound to m-c. a=merge 2014-09-03 16:38:57 -04:00
Jean-Yves Avenard
99c0be8755 Bug 1062098: Do not attempt to output dropped frames. r=rillian 2014-09-03 18:13:35 +10:00
Ryan VanderMeulen
9a0cf4ca0c Backed out 3 changesets (bug 1059058) for mochitest-1 leaks. 
Backed out changeset 3a343c27fc7a (bug 1059058)
Backed out changeset 8808324ba834 (bug 1059058)
Backed out changeset c8f0afffca59 (bug 1059058)
 2014-09-03 13:55:55 -04:00
JW Wang
4210e2571b Bug 1062116 - MediaDecoderStateMachine::FlushDecoding() should call AssertCurrentThreadInMonitor(). r=kinetik 2014-09-03 00:01:00 -04:00
Anuj Agarwal
c197954a8c Bug 1036052 - Privatize public destructor of DOMRect. r=baku 2014-09-02 11:47:00 -04:00
Paul Adenot
9ea3573709 Bug 1062293 - Ensure the graph stays alive when doing driver switches and audio stream shutdown operations. r=jesup 
This basically gets a grip on the graph while doing driver switches operations
on another thread (system thread or audio thread), because those can take time.
Because the graph is refcounted, it'll be freed when the last operation
finishes, which is what we want.

This patch also only allows driver switching when the graph is in state
LIFECYCLE_RUNNING, which is what we want anyway.

--HG--
extra : rebase_source : 76365981ec909796509bd21e616b1ff8602406bd
 2014-09-03 15:52:43 +02:00
Paul Adenot
2635504554 Bug 1062293 - Add specialized logging to track the lifetime state change of MediaStreamGraphs r=jesup 
As noted in the comment, it is very useful to have this interleaved with the ADB
logcat on Android/b2g, because this way we can correlate gecko state with the
state of the Android HAL.

--HG--
extra : rebase_source : 80df45d0851a06daac3abeab2ea4b5bc7e58a21d
 2014-08-31 14:19:48 +02:00
Matthew Gregan
5c6916c713 Bug 1059058 - Test bustage fix. 
--HG--
extra : rebase_source : 8a9d1e62beaa3921884a70aae3f8fd23322fda68
 2014-09-04 03:56:37 +12:00
Boris Zbarsky
68c7235a15 Bug 1061202. Make sure to not double-add app-theme-changed observers when a document has OnPageShow called on it twice without an OnPageHide call in between. r=khuey 2014-09-03 00:09:42 -04:00
Ryan VanderMeulen
1e2f0c6e0f Backed out changeset 483f0a6a540e (bug 1061202) for mochitest-bc asserts/crashes. 2014-09-03 11:21:02 -04:00
Matthew Gregan
a35791b9d4 Bug 1059058 - Tweak mochitest to avoid timeout. 
--HG--
extra : rebase_source : 04b6fdee34462c0098917ebf22db1675235f8915
 2014-09-04 03:14:10 +12:00
Matthew Gregan
f0d67ef6b1 Bug 1059058 - Introduce abstraction to manager mapping between SourceBuffers and SourceBufferDecoders for the MediaSourceReader. r=cajbir 2014-08-28 20:18:01 +12:00
Carsten "Tomcat" Book
6d09ecb72d Backed out changeset f9ecc7e71689 (bug 1059058) for bustage on a CLOSED TREE 2014-09-03 16:14:25 +02:00
Matthew Gregan
3893f1c156 Bug 1062101 - Compute WebM frame duration from Δt of last frame. r=cajbir 2014-09-03 17:26:19 +12:00
Matthew Gregan
1b5287358f Bug 1059058 - Introduce abstraction to manager mapping between SourceBuffers and SourceBufferDecoders for the MediaSourceReader. r=cajbir 2014-08-28 20:18:01 +12:00
Chris Double
99d4d51c31 Bug 1062020 - Set video/audio sample discontinuity flag in MSE after seek - r=kinetik 2014-09-03 21:56:22 +12:00
Jonathan Watt
70bcb4d122 Bug 932771, part 1 - Remove the "Skipping eUserSpaceToParent transforms makes no sense" asserts in PrependLocalTransformsTo implementations. r=longsonr 2014-08-19 21:58:06 +01:00
Jonathan Watt
0376ecf416 Bug 1061920 - Fix bugs in PrependLocalTransformsTo implementations where we forget to prepend to the matrix that is passed in. r=longsonr 2014-08-19 09:31:19 +01:00
Bill McCloskey
757ebcfbe3 Bug 1061013 - Disable various browser chrome tests when running with e10s. r=jimm 2014-09-02 13:47:12 -05:00
JW Wang
bf2077a6de Bug 1061447 - bail out if NS_NewChannel() fails to avoid crashing on |mChannel| below. r=roc 2014-09-02 00:36:00 +02:00
JW Wang
e1edda90ea Bug 1057954 - MediaDecoder::PlaybackEnded() should do nothing in dormant state. r=kinetik. 2014-09-02 20:07:00 +02:00
Boris Zbarsky
7dce463506 Bug 1061202. Make sure to not double-add app-theme-changed observers when a document has OnPageShow called on it twice without an OnPageHide call in between. r=khuey 2014-09-03 00:09:42 -04:00
Chris Double
249c875c64 Bug 1062018 - MSE Audio decoder reaching EOS stops decoding - r=kinetik 2014-09-03 15:20:02 +12:00
Matthew Gregan
0678bd0d40 Bug 1061007 - Only start new decoder on media segment boundary. r=cajbir 2014-09-01 18:00:00 +12:00
Matthew Gregan
e72940f877 Bug 1061007 - Handle unaligned appends by retaining WebM parser state across calls. r=cajbir 2014-09-01 02:17:00 +12:00
John Schoenick
e92bc397ce Bug 1061995 - Restore bug 923745 workaround for windowless flash in e10s mode. r=jst 2014-09-02 17:13:07 -07:00
Ralph Giles
687648d0da Bug 1055694 - Disable mac mp4 hardware acceleration. r=ajones 
Works around crashes initializing multiple sessions.
 2014-09-02 12:56:00 -07:00
Julian Seward
240a858fc3 Bug 1057274 - SourceMediaStream::SourceMediaStream does not initialise mNeedsMixing. r=karlt. 
--HG--
extra : rebase_source : 141860dcecbcdea3af2b1672a18cac5cc83b2316
 2014-09-02 22:55:11 +02:00
Trevor Saunders
d75ed5bf7f bug 1059490 - mark more classes MOZ_FINAL r=froydnj 2014-08-27 14:26:48 -04:00
Ehsan Akhgari
1b1d6ffebf Bug 1061023 - Fix more bad implicit constructors in DOM; r=baku 
--HG--
extra : rebase_source : c80c5f9d7ae28286513cdb52ad76b46c240bdd5d
 2014-09-01 18:26:43 -04:00
Ehsan Akhgari
8b978389de Bug 1061252 - Fix more bad implicit constructors in media code; r=roc 2014-09-02 09:46:56 -04:00
Carsten "Tomcat" Book
81d2189d35 Backed out changeset 9678f9a596d8 (bug 877072) for B2G ICS Emulator Debug m3 and m5 test failures 2014-09-02 14:54:22 +02:00
Randell Jesup
05a80b0af1 Bug 1061475: fix crash in Loop calls on Macs due to Refresh() change r=gcp 2014-09-02 04:52:45 -04:00
Gabor Krizsanits
ad89b8776c Bug 877072 - Script execution order for imports. r=mrbkap 2014-09-02 12:13:45 +02:00
Blake Wu
fba8a86224 Bug 1036775 - Add one more define check to separate omx decoder mp4 decoder. r=edwin 2014-09-01 13:32:47 +08:00
Andrea Marchesini
4954f26ac4 Bug 1046578 - HTMLMediaElement has to change the audioChannel of the MediaStream, r=roc 2014-09-02 08:36:48 +01:00
Bruce Sun
fc62c263b0 Bug 1033915 - Integrate MP3FrameParser into MediaCodecReader. r=cajbir 2014-09-01 18:04:36 +08:00
Phil Ringnalda
638b24cdad Backed out changeset b9e3a9f5d04a (bug 1036849) for build bustage, a=backout 2014-09-01 19:22:06 -07:00
Anthony Jones
ddb7bc3130 Bug 1061131 - Disable MSE/WebM on Firefox OS; r=cajbir; a=philor 2014-09-02 13:43:03 +12:00
Anthony Jones
917364ecaf Bug 1036849 - Share a single MediaSourceReader; r=edwin; a=philor 2014-09-02 13:42:39 +12:00
Ehsan Akhgari
0653303071 Bug 1060987 - Fix more bad implicit constructors in DOM; r=baku 
--HG--
extra : rebase_source : 01709017e97fdc96d1d53eb881efc1792118edc4
 2014-09-01 20:49:25 -04:00
Phil Ringnalda
117bb1a341 Backed out 6 changesets (bug 1060982, bug 1061058, bug 1060987, bug 1061060, bug 1060930) for build bustage 
CLOSED TREE

Backed out changeset c23b8418e6be (bug 1060987)
Backed out changeset a8cddc6bdffc (bug 1061060)
Backed out changeset b5af5cbdac3f (bug 1060982)
Backed out changeset 4912d451011a (bug 1060930)
Backed out changeset bdacbf453238 (bug 1061058)
Backed out changeset da6c71a8f5ae (bug 1060987)
 2014-09-01 16:48:51 -07:00
Ehsan Akhgari
c4a0d89440 Fix the build bustage from bug 1060987 landed on a CLOSED TREE 2014-09-01 18:28:29 -04:00
Ehsan Akhgari
6c932dea6c Bug 1060987 - Fix more bad implicit constructors in DOM; r=baku 2014-09-01 18:00:53 -04:00
Carsten "Tomcat" Book
2797ec766c Backed out changeset 67b286d214e3 (bug 877072) for m1 test failures 2014-09-01 12:01:09 +02:00
Jean-Yves Avenard
65d00bd2fd Bug 1055843 - Do not pause when playbackRate = 0. Instead don't play anything. r=padenot 2014-09-01 14:52:39 +10:00
Gabor Krizsanits
5d97edf128 Bug 877072 - Script execution order for nested imports. r=mrbkap 2014-09-01 10:51:40 +02:00
Anthony Jones
43708c49c3 Bug 1060704 - Save MP4 init segment for later; r=kinetik 2014-09-01 20:45:48 +12:00
Anthony Jones
99b765d459 Bug 1060182 - Cache MP4 buffered ranges; r=cpearce 2014-09-01 20:45:46 +12:00
Ehsan Akhgari
6b95ac13c0 Bug 1061051 - Fix more bad implicit constructors in the media code; r=roc 
--HG--
extra : rebase_source : c3d5f6a1cc95f4a7f123129e14a9a0c57d00ef38
 2014-08-31 23:50:59 -04:00
Ehsan Akhgari
f76451d2e9 Bug 1060980 - Fix more bad implicit constructors in the media code; r=roc 
--HG--
extra : rebase_source : 14da50f7d2e37e04452445dea575ea4d582e8efd
 2014-08-31 23:50:23 -04:00
Ehsan Akhgari
3bbbbb50f0 Bug 1060983 - Fix more bad implicit constructors in the SVG code; r=smaug 2014-08-31 21:08:04 -04:00
Paul Adenot
9edc44ff65 Bug 1060311 - Force the use of an AudioCallbackDriver when at least an AudioNodeStream is present in the graph. r=jesup 
This prevent a bug where the graph would be using a SystemClockDriver even if it
was rendering Web Audio API content.

It went like this:
- An AudioContext was created.
- Some AudioNodeStream (Web Audio API MediaStreams) were created, but their
MediaStreamTrack was not added yet
- During the stream ordering, we would see that we were running an
AudioCallbackDriver (because the MSG was created using an AudioContext, and we
pass in hints regarding the type of MediaStreams that will be added in the
future, to open the audio stream as early as we can, because it can take some
time, the MSG was created directly using an AudioCallbackDriver)
- Also during the stream ordering, we see that none of our MediaStream have an
MediaStreamTrack with an audio track. This triggers a switch to a
SystemClockDriver, because the graph thinks there is no audio.
- During CreateAndDestroyAudioNode, we would not switch to an
AudioCallbackDriver on the first iteration (right after the UpdateStreamOrder
call), because we would be switching, and not during the iteration after,
because we thought we already switched (the first patch makes this more robust).

This basically forces an AudioCallbackDriver if there is an AudioNodeStream,
which prevents unnecessary GraphDriver switches (and save threads creation
destruction, audio stream create and destruction, and all other resources
associated with a GraphDriver).
 2014-08-29 20:26:29 +02:00
Andrea Marchesini
eee60d5ec4 Bug 1058470 - Blob URL should contain the origin as part of the URI, r=bz 2014-08-31 11:40:11 +01:00
Matthew A. Miller
b659301233 Bug 1056213 - Window title in "windows or screen to share" list is not updated when navigating to another page r=rjesup 2014-08-27 16:32:28 -06:00
Timothy Nikkel
ed38359aee Bug 1008942. When a network request for an image finishes during paint suppression and the image doesn't have a frame don't start a decode. r=mats 
Either the image won't get a frame, or it will get a frame very soon and that frame will check its own visibility and kick off a decode if needed.
 2014-06-25 23:45:08 -05:00
Daniel Holbert
c1ad232fef Bug 1056166 followup: move margin{SIDE} and textAlign atoms out of '#ifdef ACCESSIBILITY' section, to fix --disable-accessibility builds. r=ehsan 2014-08-31 00:56:26 -07:00
Randell Jesup
10774030a9 Backed out changeset ef2bf9308ed7 (bug 1056213) 2014-08-30 12:11:27 -04:00
Matthew A. Miller
f36ccb7397 Bug 1056213 - Window title in "windows or screen to share" list is not updated when navigating to another page r=rjesup 2014-08-27 16:32:28 -06:00
Tim Abraldes
ba6539ecd7 bug 1027906. Set delayed token level for GMP plugin processes to USER_RESTRICTED. Whitelist certain files and registry keys that are required for EME plugins to successfully load. r=bobowen. r=jesup. r=bent. 2014-08-29 17:34:26 -07:00
Tanvi Vyas
95718593db Bug 1058836 - Set aDecision parameter to block by default and update cases where it wasn't initially set in nsMixedContentBlocker.cpp. r=smaug 2014-08-29 12:57:08 -07:00
Ryan VanderMeulen
f4e712f3f6 Merge m-c to inbound. a=merge 
--HG--
extra : rebase_source : 3282a3113131b9cdc5b808ad75a834516c43ef73
 2014-08-29 15:39:48 -04:00
Neil Rashbrook
a0446d2a55 Bug 1054289 Scroll to the current ref, not the original one r=smaug 2014-08-29 20:34:35 +01:00
Neil Rashbrook
1c56da8a40 Bug 1059707 Don't print a deprecation warning for theme XBL binding documents r=smaug 2014-08-29 20:33:16 +01:00
Ryan VanderMeulen
f9e1c75706 Merge b2g-inbound to m-c. a=merge 2014-08-29 15:26:40 -04:00
Paul Adenot
a6a05ae91e Backed out changeset aaa4cf41cade (bug 1060311) on a CLOSED TREE 2014-08-29 18:25:35 +02:00
Paul Adenot
5d031aff93 Backed out changeset 36cedce0c8b3 (bug 1060311) 2014-08-29 18:23:12 +02:00
Carsten "Tomcat" Book
22a02d91d0 Merge mozilla-central to b2g-inbound a=merge 2014-08-29 15:41:02 +02:00
Paul Adenot
12585467d5 Bug 1060311 - Force the use of an AudioCallbackDriver when at least an AudioNodeStream is present in the graph. r=jesup 
This prevent a bug where the graph would be using a SystemClockDriver even if it
was rendering Web Audio API content.

It went like this:
- An AudioContext was created.
- Some AudioNodeStream (Web Audio API MediaStreams) were created, but their
MediaStreamTrack was not added yet
- During the stream ordering, we would see that we were running an
AudioCallbackDriver (because the MSG was created using an AudioContext, and we
pass in hints regarding the type of MediaStreams that will be added in the
future, to open the audio stream as early as we can, because it can take some
time, the MSG was created directly using an AudioCallbackDriver)
- Also during the stream ordering, we see that none of our MediaStream have an
MediaStreamTrack with an audio track. This triggers a switch to a
SystemClockDriver, because the graph thinks there is no audio.
- During CreateAndDestroyAudioNode, we would not switch to an
AudioCallbackDriver on the first iteration (right after the UpdateStreamOrder
call), because we would be switching, and not during the iteration after,
because we thought we already switched (the first patch makes this more robust).

This basically forces an AudioCallbackDriver if there is an AudioNodeStream,
which prevents unnecessary GraphDriver switches (and save threads creation
destruction, audio stream create and destruction, and all other resources
associated with a GraphDriver).

--HG--
extra : rebase_source : 3c79c64a5dffee4c059d286125f0446c04a07a01
 2014-08-29 15:18:03 +02:00
Paul Adenot
96b0bfded6 Bug 1060311 - Always use an AudioCallbackDriver when there is and AudioOutputStream. r=jesup 
This makes the driver switching logic more robust against other bugs.

--HG--
extra : rebase_source : 556c2c80e1f5901b26f8bb56ea1cebfed3259412
 2014-08-29 15:16:41 +02:00
JW Wang
effb885bd5 Bug 1059052 - centralize state transitions of MediaDecoderStateMachine. r=cpearce 2014-08-28 02:46:00 +02:00
John Lin
1462ca80fc Bug 968109 - Add test for recording audio node output. r=roc 2014-08-27 23:43:00 +02:00
John Lin
a445c99d14 Bug 968109 - Add new constructor to support recording from any web audio node. r=roc,smaug 2014-08-27 23:40:00 +02:00
Jean-Yves Avenard
49d16c2d1a Bug 1058422: Don't immediately request new data r=cajbir 2014-08-29 12:15:40 +12:00
Anthony Jones
1e9b0983f0 Bug 1057911 - Fix libav/ffmpeg drain; r=jya 2014-08-29 14:29:12 +12:00
Matthew Gregan
02b157a66c Bug 1059625 - Bustage fix. 2014-08-29 12:47:14 +12:00
Matthew Gregan
528c5d46d2 Bug 1044498 - Pass saved init segment to decoder's NotifyDataAvailable. r=cajbir 2014-08-27 18:15:36 +12:00
Matthew Gregan
e644765358 Bug 1059625 - Detach MediaSource upon decoder shutdown. r=cajbir 2014-08-28 15:44:58 +12:00
Matthew Gregan
4620d3ab6a Bug 1044498 - Create new decoder if non-consecutive non-overlapped appended occurs. r=cajbir 2014-08-27 16:43:25 +12:00
Matthew Gregan
8520a60601 Bug 1044498 - Improve calculation of init segment region. r=cajbir 2014-08-27 16:28:44 +12:00
Matthew Gregan
ce912cf477 Bug 1044498 - Return a null decoder when CreateSubDecoder is called in Shutdown state. r=cajbir 2014-08-27 12:45:05 +12:00
Matthew Gregan
b2a9bb102f Bug 1044498 - Fix a bunch of WebM buffered range bugs. r=cajbir 2014-08-26 18:23:02 +12:00
Matthew Gregan
66ed0a006b Bug 1044498 - Save init segment for reuse during overlapped appends. r=cajbir 2014-08-26 18:22:20 +12:00
Benjamin Chen
835169b7a8 Bug 1033910 - Enable RTSP capability while using android::MediaCodec. r=cpearce 2014-08-28 18:36:34 +08:00
Aryeh Gregor
4ba29d6526 Bug 1056166 part 4 - Remove nsEditProperty; r=ehsan 2014-08-29 14:43:24 +03:00
Matthew Gregan
e345463316 Bug 1044498 - Handle overlapped SourceBuffer appends by spinning up a new decoder. Only implemented for WebM so far. r=cajbir 2014-08-19 17:13:27 +12:00
Matthew Gregan
ac6e77eeba Bug 1059035 - Check IsAttached() before accessing mMediaSource in SourceBuffer::Remove. r=cajbir 2014-08-27 14:24:01 +12:00
Matthew Gregan
357b803b92 Bug 1058418 - Make SBR::GetNextCachedData return a sane value, add more unimplemented function logging in MSE, drop unused mPrincipal from SBR. r=cajbir 2014-08-25 18:05:48 +12:00
Fabrice Desré
4533961b74 Bug 1011738 - Theme support for b2g/gaia, Part 4 : security checks r=bent,bz 2014-08-28 17:20:27 -07:00
Fabrice Desré
3acf50131b Bug 1011738 - Theme support for b2g/gaia, Part 2 : stylesheet reloading r=bz,seth 2014-08-28 17:20:27 -07:00
Botond Ballo
a5db405d9f Bug 1057642 - Revert [Int]::PointTyped::[x|y] to be of primitive type. r=kats 
--HG--
extra : rebase_source : 55e56423f6c8f5278315a6dc9dfcb9fb983c9309
 2014-08-28 12:45:48 -04:00
Timothy Nikkel
a62ab754b7 Bug 1051530. Update the nsImageLoadingContent state when we get a decode complete notification so that decode errors are recorded in our image state. r=bzbarsky 
In nsImageLoadingContent whether a decode error put our image state into error depends on when the decode starts in relation to the network load event for the image. In nsImageLoadingContent::OnStopRequest if a decode has been started then we wait until the decode is complete to fire the load/error event. When we fire this event we also update the image state. However if a decode has not started by the time OnStopRequest runs, but a decode does happen later then when it completes nsImageLoadingContent::Notify does nothing, and our image state stays as non-error.
 2014-08-28 13:43:21 -05:00
Paul Adenot
5a8c3cfd7a Bug 1059132 - Bustage fix: fix printf format. 2014-08-28 19:34:35 +02:00
Paul Adenot
98e21670d3 Bug 1059601 - Make sure we don't try to play audio with a system driver. r=jesup 
--HG--
extra : rebase_source : 7142e0d9baf38491637d40d66375d92a0aaa9e9e
 2014-08-27 19:13:15 +02:00
Paul Adenot
aff40f8800 Bug 1059132 - Log a message and continue when we found our clock went backward while using a system clock. r=jesup 
--HG--
extra : rebase_source : d808c5f8f32dfa1746c9f0b19828dba9b8ecdc30
 2014-08-27 11:48:27 +02:00
Paul Adenot
4de1a07547 Bug 909925 - Disable crashtest test 691096-1.html on windows. r=jesup 
--HG--
extra : rebase_source : fed9ee61b50c411125714d5b68075d20b5adb699
 2014-08-28 19:07:03 +02:00
Martijn Wargers
5a33dfdd37 Bug 1058451 - Intermittent test_CSP_bug885433.html | Inline script should be allowed - Result logged after SimpleTest.finish(). r=sstamm 2014-08-26 17:59:42 +02:00
Olli Pettay
8dfe1d7cf5 Bug 1059705 - revert the change which made nsIEditor builtinclass, r=masayuki 2014-08-28 17:33:35 +03:00
Tapas Das
7f6e43c8dc Bug 1048171 - Add variable to prevent the Audio Channel Toggle during Fast/Continous seek. r=baku 2014-08-28 04:07:00 -04:00
Gabor Krizsanits
839b3e4df8 Bug 1056841 - Always nulling mContainingShadow in Element::UnbindFromTree. r=wchen 2014-08-28 13:53:21 +02:00
Jean-Yves Avenard
298a741d8d Bug 1059569 - Check that GetTaskQueue() doesn't return NULL. r=cpearce 2014-08-28 11:56:32 +12:00
Chris Pearce
7db0e437f7 Bug 861090 - Create media.play-stand-alone pref to prevent loading videos as video documents. r=kinetik 2014-08-28 15:33:14 +12:00
Chris Pearce
b17d73814a Bug 1059523 - Make codecs/mimetypes supported by MP4Decoder/Reader less inaccurate. r=kinetik 2014-08-28 15:32:34 +12:00
Nicholas Nethercote
4f2031c28d Bug 1059056 - Instantiate nsDOMAttributeMap::mAttributeCache lazily. r=bz. 
--HG--
extra : rebase_source : 081273d98319c24e770a45ca4c146adfc21c2287
 2014-08-26 22:46:24 -07:00
Trevor Saunders
d2a8337475 bug 1049758 - fixup copy and move ctors for children iterators r=wchen 2014-08-06 14:21:28 -04:00
Ralph Giles
ccedb97186 Bug 1043710 - Reorder frames by comparing pts to dts. r=ajones 
Pull frames out of the reorder queue in presentation
timestamp order when those timestamps are prior to
the latest decode timestamp.

The idea here is that when we see a frame with a decode
timestamp after the presentation timestamp of a frame
in the reorder buffer, that buffered frame can't be a
dependency of any more frames, and so decode timestamp
sample ordering ensures we've buffered all the frames
which need reordering up to that point.
 2014-08-27 15:17:00 -07:00
Ralph Giles
8853744c3f Bug 1043710 - Pass dts to VideoToolbox decoder. r=ajones 2014-08-27 14:08:00 -07:00
Anthony Jones
9d6e322813 Bug 1043710 - Expose decode timestamp. r=edwin 2014-08-27 14:08:00 -07:00
Andrea Marchesini
00a821edf6 Bug 1059215 - Get rid of nsIDOMFile::GetInternalUrl, r=bz 2014-08-27 17:16:31 +01:00
Randell Jesup
f4e1c39bb7 Bug 1057955: Stop the backend capture when the MSG track is stopped r=jib 2014-08-27 01:03:50 -04:00
Randell Jesup
029d04d8e4 Bug 1057955: Support MediaStreamTrack.stop() r=roc,smaug 2014-08-27 01:03:49 -04:00
Robert O'Callahan
8170bc9501 Bug 1057955: Adjust TrackUnion TrackID mapping to be 1:1 whenever possible with source tracks r=jesup,padenot 2014-08-27 01:03:49 -04:00
Jacek Caban
319bc9cc73 Bug 1042426 - Added --disable-sandbox option that disables building sandbox code. r=glandium 2014-08-27 16:32:55 +02:00
Blake Wu
b0b1364786 Bug 1057172 - Add one more length check for valid decoded frame. r=sotaro 2014-08-26 10:57:19 +08:00
JW Wang
1352a84f62 Bug 1057978 - do nothing in MediaDecoderStateMachine::Seek() while shutting down. r=cpearce 2014-08-25 00:58:00 +02:00
Chris Pearce
96c25b7728 Bug 1057171 - Implement MediaKeySession.getUsableKeyIds. r=bz 2014-08-27 20:46:56 +12:00
Chris Pearce
2e05a3f6ba Bug 1057170 - Update MediaKey* Uint8Arrays to be ArrayBuffer. r=bz 2014-08-27 20:46:56 +12:00
Chris Pearce
e753a1dd45 Bug 1057173 - Rename MediaKeyNeededEvent to MediaEncryptedEvent. r=bz 
--HG--
rename : content/media/eme/MediaKeyNeededEvent.cpp => content/media/eme/MediaEncryptedEvent.cpp
rename : content/media/eme/MediaKeyNeededEvent.h => content/media/eme/MediaEncryptedEvent.h
rename : dom/webidl/MediaKeyNeededEvent.webidl => dom/webidl/MediaEncryptedEvent.webidl
 2014-08-27 20:46:56 +12:00
Ahmed Kachkach
6b3a8a8b37 Bug 1057558 - Fix IPC test results not being reported in first iframe. r=drno 2014-08-26 15:53:00 +02:00
Alexandre Poirot
ba2baecf47 Bug 848954 - Disable webaudio tests on mulet on CLOSED TREE. r=jesup a=tomcat 
--HG--
extra : amend_source : 448213f90bc8e4929aa1e98b2606d2c906cfba5e
 2014-08-27 00:22:00 +02:00
Carsten "Tomcat" Book
cc333b7b8f Backed out changeset a7e4ef74441d (bug 1057955) for Crashtest failures (crashes/assertions) on a CLOSED TREE 2014-08-27 08:40:50 +02:00
Carsten "Tomcat" Book
ea7d74a01c Backed out changeset ef1c321a4a32 (bug 1057955) 2014-08-27 08:40:11 +02:00
Carsten "Tomcat" Book
3717cdb2c7 Backed out changeset 0edf5afdc13c (bug 1057955) 2014-08-27 08:40:09 +02:00
Randell Jesup
cb5632ec09 Bug 1057955: Stop the backend capture when the MSG track is stopped r=jib 2014-08-27 01:03:50 -04:00
Randell Jesup
485ac49e04 Bug 1057955: Support MediaStreamTrack.stop() r=roc,smaug 2014-08-27 01:03:49 -04:00
Robert O'Callahan
5031235171 Bug 1057955: Adjust TrackUnion TrackID mapping to be 1:1 whenever possible with source tracks r=jesup 2014-08-27 01:03:49 -04:00
Randell Jesup
e6fa29bd01 Bug 848954 - Part 32 - Disable MSG sleep. r=padenot 
This has a race somewhere, so we disable it for now.

The real fix will come from the Web Audio API Suspend API [0]

[0]: https://github.com/WebAudio/web-audio-api/issues/317
 2014-08-26 17:12:41 +02:00
Randell Jesup
4ce3c4269e Bug 848954 - Part 31 - Temporarily disable a web audio api test. r=padenot 
This will be reenabled in bug 1058586
 2014-08-26 17:04:39 +02:00
Randell Jesup
61652f721c Bug 848954 - Part 29 - Make the MSG in stable state event ref counted. r=padenot 2014-08-26 17:04:39 +02:00
Randell Jesup
fadcfae452 Bug 848954 - Part 29 - Make sure to clear the right boolean flag when dispatching a stable state event. r=padenot 2014-08-25 14:13:14 +02:00
Paul Adenot
2d2000e11a Bug 848954 - Part 28 - Properly stop the driver when shutting down the graph. r=jesup 
(this was originaly present, probably caused by a bad rebase)
 2014-08-26 17:04:38 +02:00
Paul Adenot
120af395c2 Bug 848954 - Part 28 - Allow to set a driver twice per iteration iff the second driver is an audio driver. r=jesup 
This should not happen, but does. Somehow, we detect that there is no track with
audio in the graph, during the graph updates (after having ran the messages),
and then, during CreateOrDestroyAudioStream, there is a track with audio.
 2014-08-26 17:04:38 +02:00
Paul Adenot
fe687bd537 Bug 848954 - Part 27 - Only attempt to sleep if the graph is still running. r=jesup 2014-08-26 17:04:36 +02:00
Paul Adenot
8c90fe46b5 Bug 848954 - Part 26 - Prevent a race when the MSG is going to sleep mode. r=roc 2014-08-26 17:02:31 +02:00
Paul Adenot
1f6d49a3b7 Bug 848954 - Part 25 - Add documentation on some driver's members. r=roc 2014-08-26 17:02:31 +02:00
Paul Adenot
f408b70e40 Bug 848954 - Part 24 - Clean up the clock getter, because the right thing is now done by the GraphDriver. r=roc 2014-08-26 17:02:31 +02:00
Paul Adenot
e2c00fc640 Bug 848954 - Part 23 - Refcount the AudioOutputObserver. r=jesup 2014-08-26 17:02:31 +02:00
Paul Adenot
a487cecd3f Bug 848954 - Part 22 - Port the osx panning code to live in the AudioCallbackDriver. r=jesup 2014-08-26 17:02:31 +02:00
Paul Adenot
2618f0a77f Bug 848954 - Part 21 - Fix sleep/wake up code for the MSG. r=roc 2014-08-26 17:02:30 +02:00
Paul Adenot
a3533d7c93 Bug 848954 - Part 20 - Remove the now useless DriverHolder class. r=roc 2014-08-26 17:02:28 +02:00
Paul Adenot
633b616eea Bug 848954 - Part 19 - Delete the mixer callbacks on removal. r=roc 2014-08-26 17:02:09 +02:00
Paul Adenot
86c51354d2 Bug 848954 - Part 18 - Start the thread after having processed the messages to make sure there are messages in the queue when processing starts. r=roc 2014-08-26 17:02:09 +02:00
Paul Adenot
2dc4962f29 Bug 848954 - Part 16 - Make AudioCallbackDriver respect the AudioChannelType. r=roc 2014-08-26 17:02:08 +02:00
Paul Adenot
4dffa09424 Bug 848954 - Part 15 - Allow an AudioCallbackDriver to sleep to save power. r=roc 2014-08-26 17:02:08 +02:00
Paul Adenot
a61c50b315 Bug 848954 - Part 14 - Run all blocking cubeb operations off-main-thread. r=roc 2014-08-26 17:02:07 +02:00
Paul Adenot
d73a6771b0 Bug 848954 - Part 13 - Add an RAII class to ensure another thread is not in the audio callback when shutting down. r=roc 2014-08-26 17:01:35 +02:00
Paul Adenot
94dff88eb5 Bug 848954 - Part 11 - When deciding to block a MediaStream due to a speculative data underrun, don't block if we have exactly the right number of frames buffered. r=roc 2014-08-26 17:01:35 +02:00
Paul Adenot
d410cae05a Bug 848954 - Part 10 - Add a MediaStreamGraph driver based on an audio callback. r=roc 2014-08-26 17:01:33 +02:00
Paul Adenot
64e239b778 Bug 848954 - Part 9 - Allow to pass in hints when getting a reference to a MediaStreamGraph to get the right driver started as soon as possible. r=roc 
This is useful because some platform have rather slow audio stream
initialization time, especially the first time an audio stream is created for
the process.

We put in telemetry probes to measure that:
First stream opened for the process:
http://telemetry.mozilla.org/#filter=nightly%2F33%2FAUDIOSTREAM_FIRST_OPEN_MS&aggregates=multiselect-all!Submissions!Mean!5th%20percentile!25th%20percentile!median!75th%20percentile!95th%20percentile&evoOver=Builds&locked=true&sanitize=true&renderhistogram=Graph

Subsequent streams:
http://telemetry.mozilla.org/#filter=nightly%2F33%2FAUDIOSTREAM_LATER_OPEN_MS&aggregates=multiselect-all!Submissions!Mean!5th%20percentile!25th%20percentile!median!75th%20percentile!95th%20percentile&evoOver=Builds&locked=true&sanitize=true&renderhistogram=Graph
 2014-08-25 15:27:25 +02:00
Paul Adenot
499c632d13 Bug 848954 - Part 8 - Implement classes to ensure safe audio buffer manipulation. r=roc 2014-08-25 15:26:34 +02:00
Paul Adenot
5856b1e3a4 Bug 848954 - Part 7 - Get rid of the stack allocated message queue. r=roc 
In the next patches, when the AudioDriver will be implemented, the audio backend
thread (that we don't control), will return from the stack frame where the
nsTArray that allows the MSG thread to exchange message queues in a efficient
manner with the main thread. We put it in the MediaStreamGraph to avoid adding
an allocation/deallocation per iteration on the MSG thread.

In addition, the graph will be able to run on different threads during its
lifetime, so we can't guarantee a stable stack frame to allocate things on
anymore.

The array are renamed with meaningful names, explaining the double-buffering
pattern: the back queue is filled by the main thread, and is swapped with the
front queue that is processed by the MSG thread.

Arrays accesses are synchronized using the driver's monitor.
 2014-08-25 15:26:21 +02:00
Paul Adenot
bf1afe6d99 Bug 848954 - Part 6 - Put cubeb-related static functions in their own file. r=kinetik 2014-08-25 15:26:09 +02:00
Paul Adenot
735258f143 Bug 848954 - Part 5 - Mix down all audio and only output a single stream. r=roc 2014-08-25 15:25:49 +02:00
Paul Adenot
7e987d0735 Bug 848954 - Part 4 - Factor behavior for drivers that manage their thread. r=roc 2014-04-25 18:04:53 +02:00
Paul Adenot
f6e2e2b753 Bug 848954 - Part 3 - Separate interval time calculation and actual processing, and give an audio-callback compatible interface to the Process function. r=roc 2014-04-25 18:04:23 +02:00
Paul Adenot
abc95a4adc Bug 848954 - Part 2 - Put the thread management in the driver. r=roc 2014-04-25 18:03:04 +02:00
Paul Adenot
f4c5b13dbd Bug 848954 - Part 1 - Factor out clocks and scheduling of MSG iterations. r=roc 2014-04-25 16:09:30 +02:00
Paul Adenot
6010fdc4cd Bug 989921 - Allow the MediaStreamGraph mixer to send data back to multiple consumers. r=jesup 2014-08-25 14:13:08 +02:00
William Chen
79093724dc Bug 887541 - Implement web components event path and event retargeting. r=smaug 2014-08-26 20:19:56 -07:00
Nicholas Nethercote
df1c26a45e Bug 1057912 - Privatize most of PLDHashTable's fields. r=roc. 
--HG--
extra : rebase_source : 0f55e70b63d9c191fbd9418cb1177ff534deeed9
 2014-08-25 16:56:33 -07:00
Jean-Yves Avenard
7d82bae00d Bug 1058428 - Ensure all in-use decoders contain the target range - r=cajbir 2014-08-27 14:08:33 +12:00
Matthew Gregan
069cc7f6c4 Bug 1055967 - Log "discarding video frame" message only when we discard frames. r=cpearce 2014-08-27 13:51:40 +12:00
Wes Kocher
4cd0da25ab Merge m-c to inbound a=merge 2014-08-26 18:19:08 -07:00
Chris Double
6a88105e74 Bug 1058549 - Implement SourceBufferDecoder::GetEndMediaTime - r=kinetik 2014-08-27 11:45:48 +12:00
Ralph Giles
df5cd34a6e Bug 1058400 - Fix AppleCMLinker assertion. r=cpearce 
We call Unlink() from the failure cleanup code in Link() when
the dlopen call fails, so it's incorrect to assert that sLink
is non-null. We've already incremented the refcount, so that
check is fine.
 2014-08-26 13:26:00 -07:00
Ralph Giles
b50a25ed3d Bug 1058399 - Fix VideoData leak on osx fmp4 seek. r=cpearce 
Calling Clear() on the reorder queue doesn't call delete on
the stored pointer elements. Do this explicitly to avoid leaking
decoded frames when ::Flush() is called.
 2014-08-26 14:22:00 -07:00
Matt Woodrow
db134e8fe5 Bug 936690 - Remove nsIContentView and nsIContentViewManager. r=roc 2014-08-27 10:56:24 +12:00
Ting-Yu Chou
1e4229ad97 Bug 1057065 - Remove obsolete code causes extra preallocated process to complement the patch of bug 1033618. r=khuey 
--HG--
extra : rebase_source : 243e1288e44bd1d6560bdf8de479af0f9888f95e
 2014-08-26 10:22:21 +08:00
JW Wang
df65a5a044 Bug 1054831 - Improve state transition about decoding metadata by removing |mDispatchedDecodeMetadataTask|. r=cpearce 
--HG--
extra : rebase_source : 23e040a5d35954e10f65029f5550e4440aeb4117
 2014-08-20 23:37:00 -04:00
Kearwood (Kip) Gilbert
9edca3c9e4 Bug 1022818 - Part 2: Implement Smooth Scrolling. r=bz 
- Updated ScrollTo method in nsGlobalWindow to accept a
  mozilla::dom::ScrollOptions parameter to select between the instant
  and smooth MSD motion.
- Updated WebIDL binding boilerplate scrolling functions in nsGlobalWindow
  to pass the correct value of mozilla::dom::ScrollBehavior to the
  implementation and functions, activating smooth scrolling.
- These functions will need to be updated again to support the scroll-behavior
  CSS property in Bug 1010538.

--HG--
extra : rebase_source : 7c9ce94d09fed5c4aea63442d683876c0a9a2e50
 2014-08-05 15:01:34 -07:00
Kearwood (Kip) Gilbert
351eec0b98 Bug 1022818 - Part 1: Update webidl interfaces. r=bz 
- Extended the Element and Window webidl interfaces as described in the
  CSSOM-View smooth-scrolling specification.
- The Element.scrollTop and Element.scrollLeft changes have been omitted
  until either WebIDL is extended to allow properties to have union datatypes
  that contain dictionaries or the CSSOM-View smooth-scroll specification
  is upddated.  This will not prevent the other interface changes from being
  useful.
- Implemented wrapper functions for the nsGlobalWindow to connect to the new
  WebIDL bindings.  The ScrollOptions parameters are ignored in this patch,
  and used in Part 3 of this patch series.

--HG--
extra : rebase_source : db617cb63780e039ad69e4ed100c13042c676949
 2014-08-05 15:01:32 -07:00
Wes Kocher
d10230338d Backed out changeset 1ed271ffb59c (bug 786419) bug causing bug 786419 a=backout 2014-08-26 16:34:46 -07:00
Benjamin Chen
cce12ee77d Bug 1050664 - 1. Fix IsDormantNeeded() function. 2. Invoke mSource->stop at the suspend code path that will rewind the sampletable implicitly. r=cpearce 2014-08-26 16:17:08 +08:00
Chris Double
43a9f89ea6 Bug 1041374 - Fix deadlock in MSE reading vs data adding - r=kinetik 2014-08-26 19:26:03 +12:00
Chris Double
6f9cde4d22 Bug 1058364 - MediaSource streams don't correctly handle the end of sub decoders - r=kinetik 2014-08-26 19:25:09 +12:00
Anthony Jones
6a8b1c9fef Bug 1057203 - Parse timestamps for MP4 fragments; r=kinetik 2014-08-26 16:53:50 +12:00
Anthony Jones
b5c59c078b Bug 1057203 - Remove MoofParser dependency on stagefright; r=edwin 2014-08-26 16:53:48 +12:00
Randell Jesup
f9ab847e99 Bug 1032839: Backend support for PeerConnection ReplaceTrack() r=padenot,jib 2014-08-25 21:20:44 -04:00
Johnny Stenback
ee06071a0f Bug 798188. Use NS_WRAPPERCACHE_INTERFACE_TABLE_ENTRY in table based QI implementations. r=peterv 
---
 content/base/src/Attr.cpp                                  | 2 +-
 content/base/src/DOMRect.cpp                               | 2 +-
 content/base/src/FragmentOrElement.cpp                     | 2 +-
 content/base/src/nsContentList.cpp                         | 2 +-
 content/base/src/nsDOMAttributeMap.cpp                     | 2 +-
 content/base/src/nsDocument.cpp                            | 2 +-
 content/html/content/src/HTMLFormControlsCollection.cpp    | 2 +-
 content/html/content/src/HTMLOptionsCollection.cpp         | 2 +-
 content/html/content/src/HTMLPropertiesCollection.cpp      | 4 ++--
 content/html/content/src/HTMLTableElement.cpp              | 2 +-
 content/media/webspeech/synth/SpeechSynthesisUtterance.cpp | 1 -
 dom/events/PaintRequest.cpp                                | 2 +-
 dom/xbl/XBLChildrenElement.cpp                             | 2 +-
 13 files changed, 13 insertions(+), 14 deletions(-)
 2014-08-25 16:21:35 -07:00
Ralph Giles
f62b87692b Bug 1057877 - Account for fmp4 not working on MacOS X 10.6. r=cpearce 
Consolidate the various fmp4-related checks in their own function;
the ad hoc logic was getting complicated and we'll want to add
more such checks as we enable more platforms.
 2014-08-25 13:48:00 -07:00
L. David Baron
c1d3740db7 Bug 839812 - Add clip-path style for fullscreen override, which was probably originally intended ("SVG masking, clipping, or filtering"). r=dholbert 2014-08-25 15:32:03 -07:00
Wes Kocher
e2de5d0275 Backed out changeset 59f193167901 (bug 1049758) for build bustage on a CLOSED TREE 2014-08-25 14:26:12 -07:00
Trevor Saunders
e96abc463e bug 1049758 - fixup copy and move ctors for children iterators r=wchen 2014-08-06 14:21:28 -04:00
Ryan VanderMeulen
f290da4831 Merge m-c to inbound. a=merge 2014-08-25 16:28:25 -04:00
Ryan VanderMeulen
8683265d27 Merge inbound to m-c. a=merge 2014-08-25 16:15:23 -04:00
Ryan VanderMeulen
67f8f5b10e Merge b2g-inbound to m-c. a=merge 2014-08-25 16:13:21 -04:00
Steven Michaud
dfc4c053b1 Bug 1056936 - Specify full path to plugin-container in sandbox rules. r=rjesup 2014-08-25 15:01:04 -05:00
Ryan VanderMeulen
65ac61e6af Merge m-c to b2g-inbound. a=merge 
CLOSED TREE
 2014-08-25 13:07:41 -04:00
Ryan VanderMeulen
e1772e9f6b Merge m-c to fx-team. a=merge 
CLOSED TREE
 2014-08-25 12:54:46 -04:00
Ryan VanderMeulen
81342753e0 Merge inbound to m-c. a=merge 
CLOSED TREE
 2014-08-25 11:49:37 -04:00
Ryan VanderMeulen
e29307ef98 Merge m-c to inbound. a=merge 
CLOSED TREE
 2014-08-25 12:51:20 -04:00
Qeole
45d26eb52c Bug 1045209 - Remove media.gmp-gmpopenh264.path pref and set install path for OpenH264 plugin to <profile-dir>/<gmp-plugin-id>/<version>. r=unfocused,jesup 
Certain usage scenarios, like enterprise roaming profile setups, lead to the installed OpenH264 plugin not being found anymore.
We install the plugin into the profile directory, so the fix here is to just store the install path relative the profile and not an absolute path.
We also now store the plugin in a version-specific subdirectory, which avoids further issues like e.g. Windows preventing updates due to locking loaded DLLs.
 2014-08-25 17:23:34 +02:00
Andrea Marchesini
2076b14085 Bug 1055467 - Rename MozNamedAttrMap to NamedNodeMap, r=smaug 
--HG--
rename : dom/webidl/MozNamedAttrMap.webidl => dom/webidl/NamedNodeMap.webidl
 2014-08-25 10:25:34 +01:00
Daniel Holbert
52d061077a Bug 1055977 part 2: Add mochitest to verify that ancestors of a fullscreen element are fixed at the initial values of any properties that can create stacking contexts. r=cpearce 
--HG--
rename : content/html/content/test/file_fullscreen-hidden.html => content/html/content/test/file_fullscreen-ancestor-stacking-context.html
 2014-08-24 22:11:17 -07:00
Sotaro Ikeda
e49b1d978d Bug 1055991 - Eeach OMXCodec uses each OMXClient r=cajbir 2014-08-25 06:36:07 -07:00
Georgios Kontaxis
d6ca4b7a06 Bug 1043803: checkIdentity following onSecurityChange now shows doorhanger on STATE_LOADED_MIXED_ACTIVE_CONTENT. Doorhanger now acknowledges this new state. r=adw 2014-08-22 20:26:03 -07:00
Georgios Kontaxis
529502822e Bug 1043797: extended popup notifications to create a generic doorhanger for all security notifications incl. mixed content r=adw 
--HG--
rename : browser/themes/linux/mixed-content-blocked-16.png => browser/themes/linux/bad-content-blocked-16.png
rename : browser/themes/linux/mixed-content-blocked-64.png => browser/themes/linux/bad-content-blocked-64.png
rename : browser/themes/osx/mixed-content-blocked-16.png => browser/themes/osx/bad-content-blocked-16.png
rename : browser/themes/osx/mixed-content-blocked-16@2x.png => browser/themes/osx/bad-content-blocked-16@2x.png
rename : browser/themes/osx/mixed-content-blocked-64.png => browser/themes/osx/bad-content-blocked-64.png
rename : browser/themes/osx/mixed-content-blocked-64@2x.png => browser/themes/osx/bad-content-blocked-64@2x.png
rename : browser/themes/windows/mixed-content-blocked-16.png => browser/themes/windows/bad-content-blocked-16.png
rename : browser/themes/windows/mixed-content-blocked-64.png => browser/themes/windows/bad-content-blocked-64.png
 2014-08-22 15:34:25 -07:00
JW Wang
7a1eb3c738 Bug 1050947 - AudioStream::Pause() should do nothing when |mState| is ERRORED. r=kinetik 2014-08-22 02:36:00 -04:00
Wes Kocher
c725a726be Merge inbound to m-c a=merge 2014-08-22 16:47:32 -07:00
Botond Ballo
a5100b1cac Bug 1053975 - Take device scale into account when calculating default viewport size. r=kats,mbrubeck 2014-08-15 11:58:03 -04:00
Ted Clancy (:tedders1)
208aa7f675 Bug 1055427 - Add KillChild() method to nsIMessageManager. r=sicking 
Patch originally from bug 1000313.
 2014-08-12 08:59:47 -04:00
Birunthan Mohanathas
77bfad00a6 Bug 1045801 - Rename SafeCast to AssertedCast. r=Waldo 2014-08-25 12:17:32 -07:00
C.J. Ku
8b5a1dfe38 Bug 974242 - Bring FullZoom into nsDocument::GetViewportInfo. r=mbrubeck, r=kats 
--HG--
extra : rebase_source : 4fd84defb47c9eb5bcea849fde61e6e09dc5e9a3
 2014-08-10 02:50:07 +08:00
Christoph Kerschbaumer
d9219d706a Bug 1049289 - CSP: Test that fragments are stripped in csp-reports (r=sstamm) 2014-08-07 12:51:50 -07:00
Christoph Kerschbaumer
240a361c70 Bug 1049289 - CSP: Strip uri fragments before sending csp-reports (r=sstamm) 2014-08-05 16:12:16 -07:00
Christoph Kerschbaumer
ce11d17474 Bug 1053028 - Remove remaining relicts of deprecated X-CSP header (r=sstamm) 2014-08-12 21:15:56 -07:00
Steven Michaud
933391c696 Bug 1055308 - GMP Fake plugin keeps crashing in mochitests. r=rjesup 2014-08-21 13:23:02 -05:00
Ehsan Akhgari
feb900f72c Bug 1056460 - Move AudioEventTimeline.h to webaudio; r=roc 
--HG--
rename : content/media/AudioEventTimeline.h => content/media/webaudio/AudioEventTimeline.h
 2014-08-21 10:54:03 -04:00
Julian Seward
ad864791fd Bug 1055838 - MediaEngineDefaultVideoSource::MediaEngineDefaultVideoSource fails to initialise mCb, mCr. r=tterribe. 2014-08-21 16:26:33 +02:00
JW Wang
5db5af6491 Bug 1054829 - Add debugging logs to MediaDecoder. r=cpearce 2014-08-20 20:13:00 -04:00
Blake Wu
332b9df7e2 Bug 1049325 - Part 2: Notify MediaCodec input EOS and report EOS when getting the last frame. r=edwin 2014-08-21 14:22:39 +08:00
Blake Wu
88bb55ef9f Bug 1049325 - Part 1: Notify decoder for input EOS and report MP4Reader when output EOS is reached. r=cpearce 2014-08-21 14:22:25 +08:00
JW Wang
40cd8eafa2 Bug 832768 - Add logs to debug DirectShowReader::ReadMetadata() failures. r=cpearce 2014-08-24 20:54:00 -04:00
Carsten "Tomcat" Book
1013e0722d Backed out changeset 7a3ee3395e46 (bug 1055427) for wrong commit message 2014-08-25 14:52:11 +02:00
Ted Clancy
4b4225411e Date: Tue Aug 12 08:59:47 2014 -0400 
Bug 1055427 - Part 1: Adding KillChild() method to nsIMessageManager. r=sicking
 2014-08-23 14:21:00 +02:00
Robert O'Callahan
43fa3946ce Bug 1048579. Always sniff for media loads. r=bzbarsky 
--HG--
extra : rebase_source : 39b6d37dbbf138095856954bee583e84cfd971b5
 2014-08-23 00:08:14 +12:00
Ryan VanderMeulen
0b6826aac5 Backed out changeset ecf04c6eb4dd (bug 1048579) for xpcshell failures. 2014-08-22 10:08:10 -04:00
Robert O'Callahan
d82cede239 Bug 1048579. Always sniff for media loads. r=bzbarsky 
--HG--
extra : rebase_source : 067e99eaad781dec78a772405870b02c195a42e2
 2014-08-23 00:08:14 +12:00
Chris Pearce
be16c7d14b Bug 1057201 - Don't dispatch to the MP4Reader's decode task queue to update buffered index, as that confuses the MediaDataDecoders. r=kentuckyfriedtakahe 2014-08-22 18:28:06 +12:00
Ralph Giles
7eaae1d4be Bug 1057110 - Don't log h.264 sample sha1 by default. r=cpearce 
This was useful for comparing input between different demuxers
but isn't really necessary now that things are running. Can be
removed when things are more stable.
 2014-08-21 16:21:00 -07:00
Ralph Giles
765b1012ad Bug 1057110 - Add separate PRLogModule for AppleDecoderModule. r=cpearce 
The apple media decoders are quite noisy. Switching them to their
own "AppleMedia" log module simplifies the output when debugging
demuxer-specific issues.
 2014-08-21 16:20:00 -07:00
Matthew Gregan
31342c931e Bug 1056537 - Bustage fix: move DecodeToFirstVideoData back to MediaDecoderReader for now. r=UNDISCLOSED TREETOPS 2014-08-22 15:11:58 +12:00
Matthew Gregan
ac394eccf2 Bug 1056537 - Move MediaDecoderReader::FindStartTime down to only remaining user, OggReader. r=cpearce 2014-08-21 01:16:00 +12:00
Matthew Gregan
1db9ea982a Bug 1056534 - Add logging to stubbed out member functions to speed up debugging. r=cajbir 
--HG--
rename : content/media/mediasource/SubBufferDecoder.cpp => content/media/mediasource/SourceBufferDecoder.cpp
rename : content/media/mediasource/SubBufferDecoder.h => content/media/mediasource/SourceBufferDecoder.h
rename : content/media/BufferDecoder.cpp => content/media/webaudio/BufferDecoder.cpp
rename : content/media/BufferDecoder.h => content/media/webaudio/BufferDecoder.h
 2014-08-22 14:14:36 +12:00
Chris Pearce
53a822ef94 Bug 1055974 - Enable MP3 decoding in WMF PDM. r=padenot 2014-08-22 13:37:57 +12:00
Trevor Saunders
fd5e9d1fcc bug 1047696 - mark a number of classes MOZ_FINAL to get compilers to devirtualize more r=froydnj 2014-08-05 13:33:55 -04:00
Matt Woodrow
c2d79a26ff Bug 1056427 - Stop PRenderFrame from managing PLayerTransaction since it hasn't worked since the layers refactoring. r=roc 
--HG--
extra : rebase_source : 38c86648bb8e59a6b992bd377acb9aacb418c98b
 2014-08-22 12:16:44 +12:00
Bobby Holley
e9fb2caf27 Bug 981218 - Remove default compartment objects. r=luke 
\o/
 2014-08-21 17:13:51 -07:00
Ryan VanderMeulen
ddfaced990 Bug 906752 - Disable test_audioBufferSourceNodeOffset.html on debug builds. a=test-only 2014-08-21 13:34:19 -04:00
Nathan Froyd
a088ec81d5 Bug 1055281 - check for existence of paths in LOCAL_INCLUDES in moz.build; r=mshal 2014-08-20 11:51:33 -04:00
Nathan Froyd
36f456593a Bug 1055114 - convert GMPVideo{Encoder,Decoder} methods to take UniquePtr arguments where appropriate; r=cpearce 2014-08-18 13:11:11 -04:00
Paul Adenot
ea2808de47 Bug 1056032 - Put the test disabling in the right file. 2014-08-21 13:49:54 +02:00
Paul Adenot
af6bd3a2c3 Bug 1056032 - Test that we can decode an mp3 using decodeAudioData. r=ehsan 
--HG--
rename : content/media/test/small-shot.mp3 => content/media/webaudio/test/small-shot.mp3
 2014-08-20 17:23:24 -04:00
Paul Adenot
3177326fa1 Bug 1056032 - Make sure COM is initialized when trying to decode an mp3 using decodeAudioData. r=cpearce 2014-08-20 17:23:22 -04:00
Matthew Gregan
7b785ec741 Bug 1056455 - Move ResourceQueue to a separate header. r=cajbir 2014-08-20 20:14:00 +12:00
Matthew Gregan
358af04c61 Bug 1056452 - Make MediaSource::GetBuffered more readable w.r.t the spec. Improve logging of TimeRanges. r=cajbir 2014-08-20 20:07:00 +12:00
Chris Pearce
909328d103 Bug 1055907 - Delete output sent to MP4Reader while it's flushing, prevents leaks. r=kentuckyfriedtakahe 2014-08-21 16:10:57 +12:00
Chris Pearce
4576b4e87f Bug 1055907 - Ensure HasAudio() works earlier in MP4Reader::ReadMetadata(). r=kentuckyfriedtakahe 2014-08-21 16:10:34 +12:00
Chris Pearce
4a69989063 Bug 1054824 - Detect GMP death in EMEDecryptors. r=edwin 2014-08-21 16:10:11 +12:00
Matthew Gregan
4c8e2f8646 Bug 1055899 - Handle audio decoder resets from a SourceBuffer by switching to the new decoder. r=cajbir 2014-08-21 15:14:48 +12:00
Matthew Gregan
fec10283e4 Bug 1055967 - Log "discarding video frame" message only when we discard frames. r=cpearce 2014-08-20 01:13:00 +12:00
Matthew Gregan
67a276ab9f Bug 1055967 - Fix logging in AudioSink. r=cpearce 2014-08-20 01:12:00 +12:00
Ralph Giles
fa812dc154 Bug 1056408 - Flush local task queues in AppleDecoderModule. r=cpearce 
We could still have data pending submission on the local task queue
which would be submitted after we were supposed to have flushed.
 2014-08-20 16:38:00 -07:00
Bobby Holley
aeed365b08 Bug 1056271 - Switch to GetEntryGlobal in DOMParser::Init. r=smaug 2014-08-20 17:45:04 -07:00
Ralph Giles
6906403c04 Bug 1056371 - Fix AppleATDecoder dtor counting. r=cpearce 
Typo affecting leak detection.
 2014-08-20 15:28:00 -07:00
Wes Kocher
b0307a3784 Backed out 2 changesets (bug 1056032) for bustage 
Backed out changeset 18b0e0c795d4 (bug 1056032)
Backed out changeset 15caaf563783 (bug 1056032)
 2014-08-20 15:30:23 -07:00
Ralph Giles
cd407de8d0 Bug 1056232 - Expect fmp4 pref in canPlayType. r=cpearce 
The media.fragmented-mp4.exposed pref affects the support status
of video/mp4 reported by canPlayType. Take this into account
in the mochitest.
 2014-08-20 11:06:00 -07:00
Ralph Giles
6855ed43dd Bug 1056288 - Remove unused OggPacketQueue::PushBack. r=cpearce 2014-08-20 13:27:00 -07:00
Nathan Froyd
2faebf4212 Bug 1056288 - Fix thinko in OggPacketQueue. r=cpearce. 2014-08-20 12:44:00 -07:00
Paul Adenot
78eba23820 Bug 1056032 - Test that we can decode an mp3 using decodeAudioData. r=ehsan 
--HG--
rename : content/media/test/small-shot.mp3 => content/media/webaudio/test/small-shot.mp3
 2014-08-20 17:23:24 -04:00
Paul Adenot
44d5b51305 Bug 1056032 - Make sure COM is initialized when trying to decode an mp3 using decodeAudioData. r=cpearce 2014-08-20 17:23:22 -04:00
Ryan VanderMeulen
baca1ac7b9 Merge m-c to inbound. a=merge 
CLOSED TREE
 2014-08-20 16:23:04 -04:00
Ryan VanderMeulen
556b135ea8 Merge inbound to m-c. a=merge 2014-08-20 16:14:23 -04:00
Roberto A. Vitillo
3eb77a08ed Bug 559505 - Deprecate localstore.rdf and replace it with xulstore. r=enn, sr=bsmedberg 
CLOSED TREE
 2014-08-19 10:31:00 -04:00
Ed Morley
aae02d523c Merge mozilla-central and fx-team 2014-08-20 15:18:31 +01:00
Ed Morley
acd103862f Merge latest green b2g-inbound changeset and mozilla-central; a=merge 2014-08-20 14:46:55 +01:00
Mike Conley
36148f8108 Bug 961362 - DOM Fullscreen API support for e10s. r=smaug,billm. 2014-08-19 16:58:00 -04:00
Ryan VanderMeulen
c6e10de0e1 Merge inbound to m-c. a=merge 2014-08-19 16:09:47 -04:00
Fabrice Desré
eabd72e065 Bug 899322 - Convert the mozApps API to use webidl r=marco,bholley 2014-08-19 09:30:54 -07:00
Ehsan Akhgari
662027abfa Bug 1055511 - Add a test case for ScriptProcessorNode.passThrough; r=roc 2014-08-20 00:57:37 -04:00
Ehsan Akhgari
c689dbd103 Bug 1055367 - Move the code for AudioNodeStream and AudioNodeEngine to webaudio; r=roc 
This code is specific to Web Audio, and is not really part of the
MediaStreamGraph code.  I've always hated how these files being in
two directories gets in the way while hacking on this code.

--HG--
rename : content/media/AudioNodeEngine.cpp => content/media/webaudio/AudioNodeEngine.cpp
rename : content/media/AudioNodeEngine.h => content/media/webaudio/AudioNodeEngine.h
rename : content/media/AudioNodeEngineNEON.cpp => content/media/webaudio/AudioNodeEngineNEON.cpp
rename : content/media/AudioNodeEngineNEON.h => content/media/webaudio/AudioNodeEngineNEON.h
rename : content/media/AudioNodeExternalInputStream.cpp => content/media/webaudio/AudioNodeExternalInputStream.cpp
rename : content/media/AudioNodeExternalInputStream.h => content/media/webaudio/AudioNodeExternalInputStream.h
rename : content/media/AudioNodeStream.cpp => content/media/webaudio/AudioNodeStream.cpp
rename : content/media/AudioNodeStream.h => content/media/webaudio/AudioNodeStream.h
 2014-08-20 00:56:31 -04:00
Nigel Babu
493e418c84 Backed out changeset 55ea2c2fb857 (bug 1034368) for bustage 2014-08-19 12:07:01 +05:30
Nigel Babu
2f0df889d5 Backed out changeset 3b0d1e17cad0 (bug 1055408) for bustage 2014-08-19 12:06:42 +05:30
Chris Pearce
b0a8524ff0 Bug 1055408 - Kill GMP timers when entering shutdown. r=jesup 2014-08-19 17:03:11 +12:00
Chris Pearce
f511aad305 Bug 1034368 - Add storage capabilities to GMPs. r=jesup 2014-08-19 17:03:04 +12:00
Anthony Jones
2acb0169a4 Bug 1054153 - Fix MP4 demuxer is init vs buffered range race; r=edwin 2014-08-19 14:13:56 +12:00
Anthony Jones
09a1c22d2a Bug 1049133 - Calculate eviction offset for MP4 instead of guessing; r=kinetik,edwin 2014-08-19 14:13:55 +12:00
Lynn Tran
7bec1a6b6d Bug 1041335 - Add a mozilla::services getter for nsIServiceWorkerManager; r=ehsan 2014-08-18 21:13:14 -04:00
Ehsan Akhgari
aa072a423f Bug 1055286 - Flatten editor/libeditor/text to editor/libeditor; r=poiru 
--HG--
rename : editor/libeditor/text/crashtests/403965-1.xhtml => editor/libeditor/crashtests/403965-1.xhtml
rename : editor/libeditor/text/crashtests/580151-1.xhtml => editor/libeditor/crashtests/580151-1.xhtml
rename : editor/libeditor/text/nsInternetCiter.cpp => editor/libeditor/nsInternetCiter.cpp
rename : editor/libeditor/text/nsInternetCiter.h => editor/libeditor/nsInternetCiter.h
rename : editor/libeditor/text/nsPlaintextDataTransfer.cpp => editor/libeditor/nsPlaintextDataTransfer.cpp
rename : editor/libeditor/text/nsPlaintextEditor.cpp => editor/libeditor/nsPlaintextEditor.cpp
rename : editor/libeditor/text/nsPlaintextEditor.h => editor/libeditor/nsPlaintextEditor.h
rename : editor/libeditor/text/nsTextEditRules.cpp => editor/libeditor/nsTextEditRules.cpp
rename : editor/libeditor/text/nsTextEditRules.h => editor/libeditor/nsTextEditRules.h
rename : editor/libeditor/text/nsTextEditRulesBidi.cpp => editor/libeditor/nsTextEditRulesBidi.cpp
rename : editor/libeditor/text/nsTextEditUtils.cpp => editor/libeditor/nsTextEditUtils.cpp
rename : editor/libeditor/text/nsTextEditUtils.h => editor/libeditor/nsTextEditUtils.h
rename : editor/libeditor/text/tests/test_bug1026397.html => editor/libeditor/tests/test_bug1026397.html
rename : editor/libeditor/text/tests/test_bug318065.html => editor/libeditor/tests/test_bug318065.html
rename : editor/libeditor/text/tests/test_bug471319.html => editor/libeditor/tests/test_bug471319.html
rename : editor/libeditor/text/tests/test_bug471722.html => editor/libeditor/tests/test_bug471722.html
rename : editor/libeditor/text/tests/test_bug483651.html => editor/libeditor/tests/test_bug483651.html
rename : editor/libeditor/text/tests/test_bug527935.html => editor/libeditor/tests/test_bug527935.html
rename : editor/libeditor/text/tests/test_bug569988.html => editor/libeditor/tests/test_bug569988.html
rename : editor/libeditor/text/tests/test_bug590554.html => editor/libeditor/tests/test_bug590554.html
rename : editor/libeditor/text/tests/test_bug596001.html => editor/libeditor/tests/test_bug596001.html
rename : editor/libeditor/text/tests/test_bug596333.html => editor/libeditor/tests/test_bug596333.html
rename : editor/libeditor/text/tests/test_bug596506.html => editor/libeditor/tests/test_bug596506.html
rename : editor/libeditor/text/tests/test_bug597331.html => editor/libeditor/tests/test_bug597331.html
rename : editor/libeditor/text/tests/test_bug600570.html => editor/libeditor/tests/test_bug600570.html
rename : editor/libeditor/text/tests/test_bug602130.html => editor/libeditor/tests/test_bug602130.html
rename : editor/libeditor/text/tests/test_bug603556.html => editor/libeditor/tests/test_bug603556.html
rename : editor/libeditor/text/tests/test_bug604532.html => editor/libeditor/tests/test_bug604532.html
rename : editor/libeditor/text/tests/test_bug625452.html => editor/libeditor/tests/test_bug625452.html
rename : editor/libeditor/text/tests/test_bug629172.html => editor/libeditor/tests/test_bug629172.html
rename : editor/libeditor/text/tests/test_bug636465.xul => editor/libeditor/tests/test_bug636465.xul
rename : editor/libeditor/text/tests/test_bug638596.html => editor/libeditor/tests/test_bug638596.html
rename : editor/libeditor/text/tests/test_bug641466.html => editor/libeditor/tests/test_bug641466.html
rename : editor/libeditor/text/tests/test_bug645914.html => editor/libeditor/tests/test_bug645914.html
rename : editor/libeditor/text/tests/test_bug681229.html => editor/libeditor/tests/test_bug681229.html
rename : editor/libeditor/text/tests/test_bug692520.html => editor/libeditor/tests/test_bug692520.html
rename : editor/libeditor/text/tests/test_bug740784.html => editor/libeditor/tests/test_bug740784.html
rename : editor/libeditor/text/tests/test_bug757771.html => editor/libeditor/tests/test_bug757771.html
rename : editor/libeditor/text/tests/test_bug830600.html => editor/libeditor/tests/test_bug830600.html
rename : editor/libeditor/text/tests/test_dom_input_event_on_texteditor.html => editor/libeditor/tests/test_dom_input_event_on_texteditor.html
rename : editor/libeditor/text/tests/test_texteditor_keyevent_handling.html => editor/libeditor/tests/test_texteditor_keyevent_handling.html
 2014-08-18 20:59:37 -04:00
Ehsan Akhgari
42de58dbf7 Bug 1007778 - Add a devtools API to make some Web Audio nodes pass through their inputs; r=roc,smaug 2014-08-18 20:12:50 -04:00
Vasanthakumar Pandurangan
3898f15d2e Bug 1053186 - AudioOffloadPlayer: Avoid glitch during start of playback. r=roc 2014-08-18 05:49:51 -07:00
Guilherme Goncalves
d59255b1c1 Bug 1052775 - Abort speech recognition after test_call_start_from_end_handler. r=smaug 2014-08-18 10:25:00 -04:00
Matthew Gregan
46d2b153e2 Bug 1055407 - Accumlate SBR length rather than recomputing on each call. r=cajbir 2014-08-18 21:17:00 +12:00
Matthew Gregan
224c97f923 Bug 1050652 - WebM cluster offset calculation accounted for size of ID incorrectly. r=cajbir 2014-08-18 21:13:00 +12:00