Commit Graph

1940 Commits

Author SHA1 Message Date
Jonathan Kingston
4248b4c554 Bug 1490257 - Pass triggeringPrincipal to test code. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D10882

--HG--
extra : moz-landing-system : lando
2018-11-05 14:05:47 +00:00
Marco Zehe
a7b776042d Bug 1501273 - Expose an html:form element as a landmark role if it has an accessible name, r=Jamie
If html:form has a name given via ARIA, expose it as a landmark to platform APIS that require it. At the time of this submission, this is the case for ATK.

Differential Revision: https://phabricator.services.mozilla.com/D9552

--HG--
extra : moz-landing-system : lando
2018-11-02 01:06:56 +00:00
Marco Zehe
50ba1dd30c Bug 1104947 - Complete the accessibility mapping for aria-current, r=Jamie
We already mapped aria-current to the correct attribute, but we did so unconditionally unless the value was false or undefined. However, if the value was an invalid token, it would not be mapped to "true" as per spec. Now, any bogus value for aria-current will be mapped as if the author had specified "true".

In addition, this patch adds aria-current to the known set of attributes with rules, which causes NSAccessibilityService::MustBeAccessible to make sure an accessible gets created if aria-current is set, even if that accessible is a html:span element. This fixes bug 1365904.

Differential Revision: https://phabricator.services.mozilla.com/D10331

--HG--
extra : moz-landing-system : lando
2018-11-02 06:40:47 +00:00
Daniel Varga
77036132f7 Merge autoland to mozilla-central. a=merge 2018-11-02 00:26:12 +02:00
Julian Descottes
079a123093 Bug 1467712 - Simplify calls to ok to use only 2 arguments;r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D10416

--HG--
extra : moz-landing-system : lando
2018-11-01 13:48:48 +00:00
Csoregi Natalia
faba2c8c15 Backed out 4 changesets (bug 1467712) for multiple failures with: Too many arguments passed to ok. CLOSED TREE
Backed out changeset 9ce0ac2b9d71 (bug 1467712)
Backed out changeset 026eb1f6dc6e (bug 1467712)
Backed out changeset 0088a09d869a (bug 1467712)
Backed out changeset 1b19ea76aad6 (bug 1467712)
2018-11-01 15:22:52 +02:00
Julian Descottes
b50a5ba4dc Bug 1467712 - Simplify calls to ok to use only 2 arguments;r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D10416

--HG--
extra : moz-landing-system : lando
2018-11-01 11:09:48 +00:00
Gurzau Raul
424b125b93 Backed out changeset 523ff2753dea (bug 1490257) for causing Bug 1503757 a=backout 2018-11-01 15:27:30 +02:00
Jonathan Kingston
873b26107e Bug 1490257 - Add asserts into loadURI where we imply SystemPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D10221

--HG--
extra : moz-landing-system : lando
2018-10-31 18:00:40 +00:00
Julian Descottes
f6a4b55fda Bug 1503169 - Remove missing layout.js loadScript calls;r=yzen
Depends on D10191
I would like to update browser-test.js to stop swallowing exceptions
when calling loadSubScript from head.js.

It looks like those head files are trying to load a layout.js helper
that I could not find in any revision. Can you check it can be
removed?

Differential Revision: https://phabricator.services.mozilla.com/D10193

--HG--
extra : moz-landing-system : lando
2018-10-30 14:13:25 +00:00
Alexander Surkov
08eb9dff6a Bug 1487311 - accessibility doesn't assosiate ids in shadow DOM, r=jamie, sr=smaug 2018-10-30 08:17:04 +08:00
Alexander Surkov
4536232292 Bug 1052866 - Expose IAccessibleText on tables, rows, etc., r=tbsaunde. Bustage fix by MarcoZ. 2018-10-26 11:07:27 +02:00
Brindusan Cristian
a663055a3b Backed out changeset a69a426bdb14 (bug 1052866) for mochitest failures on test_selection.html. CLOSED TREE 2018-10-26 11:51:22 +03:00
Alexander Surkov
cda4486cbb Bug 1052866 - Expose IAccessibleText on tables, rows, etc., r=tbsaunde
--HG--
extra : rebase_source : 993e03d0f304a02654e11d1c3d7c9abfd85da273
2018-10-26 09:54:20 +02:00
Marco Zehe
d66ed81dfa Bug 1501595 - Return the correct region-specific role for named html:section elements, r=Jamie
Bug 1210630 introduced a mapping of the html:section element to roles::LANDMARK, however roles::REGION is more appropriate since that is also used by the WAI-ARIA role mapping and contains specific mappings for regions, e. g. on Mac.

Differential Revision: https://phabricator.services.mozilla.com/D9651

--HG--
extra : moz-landing-system : lando
2018-10-25 01:41:15 +00:00
Margareta Eliza Balazs
77db58fd5a Backed out changeset 02d8210b8904 (bug 1501353) on request from MarcoZ
--HG--
extra : rebase_source : c8ac92b3ed860b783b1cc87b5ef8c231ac75101e
2018-10-24 11:36:25 +03:00
Marco Zehe
c5581dfc0f Bug 1210630 - Section elements with accessible names should be mapped the same as ARIA role region, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D9480

--HG--
extra : moz-landing-system : lando
2018-10-24 05:34:22 +00:00
Marco Zehe
5104d78a7d Bug 1501353 - Change the exposed accessible role for a named region from region to landmark, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D9554

--HG--
extra : moz-landing-system : lando
2018-10-24 00:34:21 +00:00
Ciure Andrei
09e4040e94 Merge autoland to mozilla-central. a=merge 2018-10-23 19:48:47 +03:00
Julian Descottes
2fcd6cb020 Bug 1499096 - Update tests using ok() to is();r=Standard8
This changeset updates all the test that were wrongly using ok() and wanted to
use is() AND for which the assert is still passing without any modification
required.

Differential Revision: https://phabricator.services.mozilla.com/D8739

--HG--
extra : moz-landing-system : lando
2018-10-23 07:12:23 +00:00
Marco Zehe
f1a7d75388 Bug 614572 - Expose the correct new landmark role for HTML aside, header, footer, main and nav elements, r=Jamie
According to the HTML Accessibility API mappings spec, aside, footer, header, main and nav elements should be mapped to the WAI-ARIA landmark role exposure. For footer and header, this is only true if scoped to the body element.

This patch changes the exposed roles to the new landmark mapping for the various platforms.

Differential Revision: https://phabricator.services.mozilla.com/D9413

--HG--
extra : moz-landing-system : lando
2018-10-23 06:11:59 +00:00
Margareta Eliza Balazs
bd786693fb Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-10-23 12:33:44 +03:00
Paolo Amadini
42c8938dfc Bug 1493844 - Part 2 - Remove the "caption" and "groupbox" bindings. r=bgrins,dao,jaws,johannh,surkov
Proper native "groupbox" styling depends on the structure of the XBL binding. By restyling the Page Info dialog, the native styling is now unused except for the Print Page Setup dialog on Windows. The native apperance is thus not applied by default anymore, and the "groupbox" element can just be used semantically for accessibility. The Print Page Setup dialog applies the native styling on its own in a way that still works on Windows.

The only other consumers of "groupbox" are the in-content Preferences pages and dialogs. These are updated to use simpler styles that don't depend on the binding structure.

Differential Revision: https://phabricator.services.mozilla.com/D8752

--HG--
extra : rebase_source : af36d911980517f9b53036f4cd4f800c5e20ad22
2018-10-23 10:14:06 +01:00
Emilio Cobos Álvarez
93668f7672 Bug 1500416 - Fixup to avoid triggering the trailing commas lint on a CLOSED TREE. 2018-10-22 09:35:40 +02:00
Emilio Cobos Álvarez
ba51516ba5 Bug 1500416 - Account for display: contents in ScheduleContentInsertion. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D9338
2018-10-22 09:17:18 +02:00
Sebastian Hengst
15bd86014b No bug - update code after eslint change from merge and remove files removed by 1451484 and restored during merge 2018-10-20 14:32:35 +03:00
Daniel Varga
9a610a8759 Merge mozilla-central to mozilla-inbound. a=merge
--HG--
rename : mobile/android/extensions/webcompat/webextension/background.js => mobile/android/extensions/webcompat/injections.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug0000000-dummy-js-injection.js => mobile/android/extensions/webcompat/injections/js/bug0000000-dummy-js-injection.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug1452707-window.controllers-shim-ib.absa.co.za.js => mobile/android/extensions/webcompat/injections/js/bug1452707-window.controllers-shim-ib.absa.co.za.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug1457335-histography.io-ua-change.js => mobile/android/extensions/webcompat/injections/js/bug1457335-histography.io-ua-change.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug1472075-bankofamerica.com-ua-change.js => mobile/android/extensions/webcompat/injections/js/bug1472075-bankofamerica.com-ua-change.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug1472081-election.gov.np-window.sidebar-shim.js => mobile/android/extensions/webcompat/injections/js/bug1472081-election.gov.np-window.sidebar-shim.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug1482066-portalminasnet.com-window.sidebar-shim.js => mobile/android/extensions/webcompat/injections/js/bug1482066-portalminasnet.com-window.sidebar-shim.js
2018-10-20 13:32:54 +03:00
Emilio Cobos Álvarez
5ebe7949ae Bug 1487312 - Fix content insertion accessibility notifications in Shadow DOM. r=Jamie,surkov
The issue was specific to content insertion directly under a shadow root, the
rest should work (see bug 1427825 for the fix for other similar occurrences).

The removal of the aContainer argument follows the same pattern as bug 1442207.

Differential Revision: https://phabricator.services.mozilla.com/D6431
2018-10-20 01:19:08 +02:00
Mark Banner
ceaeb93550 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389

--HG--
extra : moz-landing-system : lando
2018-10-19 12:55:39 +00:00
Marco Zehe
c90a496216 Bug 1492393 - Make our table index methods aware of cells spanning multiple columns, r=surkov
Sometimes, when cells have display:block, and a different cell in the same row has a column span, our index methods did not take these into account. Also, when regular tables encounter such a cell, index calculation failed.

Differential Revision: https://phabricator.services.mozilla.com/D7867

--HG--
extra : moz-landing-system : lando
2018-10-19 08:18:04 +00:00
Dorel Luca
451e26f0c6 Backed out changeset 8d7987ea4fb1 (bug 1490257) for causing android failures. CLOSED TREE 2018-10-15 14:39:00 +03:00
Jonathan Kingston
8bcd10a7ab Bug 1490257 - Add asserts and remove implied system triggering principal code r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D8368

--HG--
extra : moz-landing-system : lando
2018-10-15 06:29:45 +00:00
Eitan Isaacson
5c76903078 Bug 1479037 - Remove virtual content node, js autofill, and event support 2/4. r=jchen,yzen
Disabled most jsunit tests temporarily in this patch. Will modify and bring them
back up in later patches, as stuff is reimplemented.

Disabled most jsat mochitests. Will have a followup for but reënabling or
porting, depending on the test.

Depends on D6681

Differential Revision: https://phabricator.services.mozilla.com/D6682

--HG--
extra : moz-landing-system : lando
2018-10-11 16:21:01 +00:00
Dorel Luca
92a3152cee Backed out 4 changesets (bug 1479037) on dev's request for causing android crashes. a=backout
Backed out changeset 85f8ca59f747 (bug 1479037)
Backed out changeset 630601f0663e (bug 1479037)
Backed out changeset c926c6470235 (bug 1479037)
Backed out changeset f8a20bd86895 (bug 1479037)
2018-10-10 18:52:59 +03:00
Eitan Isaacson
3d1cc19600 Bug 1479037 - Remove virtual content node, js autofill, and event support 2/4. r=jchen,yzen
Disabled most jsunit tests temporarily in this patch. Will modify and bring them
back up in later patches, as stuff is reimplemented.

Disabled most jsat mochitests. Will have a followup for but reënabling or
porting, depending on the test.

Depends on D6681

Differential Revision: https://phabricator.services.mozilla.com/D6682

--HG--
extra : moz-landing-system : lando
2018-10-09 17:20:46 +00:00
Tim Nguyen
6e26790a43 Bug 1416363 - Remove colorpicker binding and related code. r=bgrins,surkov
Depends on D7575

Differential Revision: https://phabricator.services.mozilla.com/D7576

--HG--
extra : moz-landing-system : lando
2018-10-04 01:03:19 +00:00
Marco Zehe
9998d72afc Bug 1494707 - Add a null check for a retrieved row accessible in HTMLTableAccessible::CellAt, r=surkov
When checking for an accessible if it is a table row instead of a table cell, when retrieving the actual row at the given index, null check it to make sure we don't pass an invalid accessible to the TableAccessible::CellInRowAt method. I accidentally omitted that null check in the updated patch for bug 1486668.

Differential Revision: https://phabricator.services.mozilla.com/D7162

--HG--
extra : moz-landing-system : lando
2018-10-04 06:30:06 +00:00
Alexander Surkov
ff145aa9c4 Bug 1491197 - replace progressmeter XBL binding by a custom element, r=paolo
--HG--
rename : toolkit/content/widgets/progressmeter.xml => toolkit/content/widgets/progressmeter.js
2018-10-03 11:13:05 +05:00
arthur.iakab
e1e94e3d20 Merge mozilla-central to autoland 2018-09-26 15:57:12 +03:00
Marco Zehe
aa436fb77a Bug 1486668 - <td> with display: block doesn't get table cell semantics, r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D6158

--HG--
extra : moz-landing-system : lando
2018-09-26 08:47:35 +00:00
Alexander Surkov
afc9faadbe Bug 1463962 - crash near null in [@ mozilla::a11y::DocAccessible::BindToDocument], r=jamie 2018-09-26 12:06:57 +08:00
Chris Peterson
eaa59c7fc4 Bug 1336712 - a11y: Drop test check for OS X 10.6. r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D6577

--HG--
extra : source : 96447888db56e219bbb44f066b08344f50946f77
extra : histedit_source : 7d1234f2564f00bb594f436c1530d6ba60544412
2018-09-13 21:47:36 -07:00
Eitan Isaacson
dc59a7f112 Bug 1489324 - Add 'child-item-count' and 'hierarchical' attributes to collection containers. r=Jamie 2018-09-21 13:02:20 -07:00
Bogdan Tara
e7c653959c Merge inbound to mozilla-central. a=merge 2018-09-20 00:58:18 +03:00
Narcis Beleuzu
04ab391b65 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-19 19:44:24 +03:00
Eitan Isaacson
c712a2aaaa Bug 1490840 - Only delete text in ReplaceText if the string is empty. r=Jamie 2018-09-18 16:16:00 -04:00
Timothy Guan-tin Chien
bfae552010 Bug 1484048 - Part III, Wait for audio source to load before starting a11y tests r=surkov
Appearently with UA Widget the page loads quicker, so the tests must now
explicitly wait for the audio source to load to test on the video controls
UI in its stable state.

Depends on D3840

Differential Revision: https://phabricator.services.mozilla.com/D3841

--HG--
extra : moz-landing-system : lando
2018-09-17 20:49:16 +00:00
Narcis Beleuzu
94e37e71ff Merge inbound to mozilla-central. a=merge 2018-09-19 13:00:20 +03:00
James Teh
1999ca1f89 Bug 1485097: When handling aria-owns relocation and an owned child doesn't yet have an accessible, skip it if the owned child is actually an ancestor of its owner. r=surkov
This can easily be reproduced if the ancestor being owned has role="presentation", but there are other cases as well.
If we don't prevent this, we end up with a loop.

Differential Revision: https://phabricator.services.mozilla.com/D4051

--HG--
extra : moz-landing-system : lando
2018-09-19 02:15:55 +00:00
Alexander Surkov
ed5f3a33f3 Bug 1491210 - stop using nsIDOMXULLabeledControlElement, r=jamie 2018-09-19 09:06:31 +08:00