Commit Graph

21683 Commits

Author SHA1 Message Date
Kershaw Chang
c7dc3fd5c1 Bug 1688092 - Make sure mTrrA and mTrrAAAA are set properly before dispatching them r=necko-reviewers,valentin
See [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1694628#c1 | bug 1694628 ]] for details.

Differential Revision: https://phabricator.services.mozilla.com/D106415
2021-02-25 13:07:04 +00:00
Kershaw Chang
ef06b68b6c Bug 1688092 - Update ODoHConfigs when the TTL expires r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D106075
2021-02-25 13:07:04 +00:00
Kershaw Chang
61d4a64bb0 Bug 1688864 - P2: Add more tests for ODoH r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D106074
2021-02-25 13:07:04 +00:00
Valentin Gosu
40eb1379d9 Bug 1694457 - Add pref for reporting confirmation event telemetry r=nhnt11,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D106264
2021-02-25 12:52:28 +00:00
Valentin Gosu
86622ba6a3 Bug 1694604 - Fix static analysis warnings in netwerk/dns r=necko-reviewers,dragana
Depends on D106262

Differential Revision: https://phabricator.services.mozilla.com/D106263
2021-02-24 16:37:04 +00:00
Valentin Gosu
ff32c214b6 Bug 1694604 - Move TRRSkippedReason out of nsHostResolver.h r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D106262
2021-02-24 16:37:03 +00:00
Nihanth Subramanya
b88988a027 Bug 1460314 - TRR: add telemetry probe for used HTTP version. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D100519
2021-02-22 14:43:15 +00:00
Valentin Gosu
a9cce9ac08 Bug 1646452 - Key TRR telemetry by domain of DoH server r=nhnt11,necko-reviewers,dragana
This allows us to separate general TRR performance issues from "this user's
custom DoH server is slow or malfunctioning".
Any DoH servers domains that are not shipped by Firefox are reported as (other).

Differential Revision: https://phabricator.services.mozilla.com/D105602
2021-02-22 13:51:44 +00:00
M. Sirringhaus
6ac7a0e8be Bug 1693493 - Add test for gvfs integration r=valentin,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D105604
2021-02-22 12:21:58 +00:00
Simon Giesecke
7c931c97c4 Bug 1689218 - Rename nsBaseHashtable::GetAndRemove to Extract. r=necko-reviewers,dragana
First, it should be called "Lookup" rather than "Get" because it returns
DataType (rather than UserDataType), but that would still be confusing,
since as opposed to other Lookup* methods, it does not return a DataType&
(and obviously, it can't). So "Extract" seems to be a better name, cf.
mozilla::Maybe::extract.

Differential Revision: https://phabricator.services.mozilla.com/D105471
2021-02-22 12:07:48 +00:00
Simon Giesecke
c5f7800f35 Bug 1691913 - Rename nsClassHashtable::LookupOrAdd to GetOrInsertNew. r=xpcom-reviewers,nika
It should be called "Get" rather than "Lookup" because it returns
UserDataType. "Add" is called "Insert" in the other methods.

Differential Revision: https://phabricator.services.mozilla.com/D105470
2021-02-22 12:07:47 +00:00
Simon Giesecke
d2caea36fa Bug 1691894 - Simplify uses of WithEntryHandle that only use OrInsert(With) by using GetOrInsertWith. r=xpcom-reviewers,necko-reviewers,jgilbert,nika
Differential Revision: https://phabricator.services.mozilla.com/D104676
2021-02-22 12:07:46 +00:00
Valentin Gosu
63e49eada8 Bug 1692494 - TRR_NXDOMAIN no longer recorded when 0x03 rcode is set in the TRR response header r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D105311
2021-02-22 09:12:22 +00:00
Henri Sivonen
37e52696cd Bug 1693295 - Cap the Windows version in the User-Agent to 10.0. r=cpeterson
Differential Revision: https://phabricator.services.mozilla.com/D105605
2021-02-22 08:56:40 +00:00
Dragana Damjanovic
b529ea9b90 Bug 1692569 - Make sure that we still can write 0RTT data before trying to write them. r=necko-reviewers,valentin
nss and necko may be out of sync about 0RTT state because IsAlive drives the handshake, but nsHttpConnection is not informed about the handshake progress.

Differential Revision: https://phabricator.services.mozilla.com/D105842
2021-02-20 21:04:00 +00:00
Dragana Damjanovic
66692fa536 Bug 1693738 - Extend HTTP3_CONNECTION_CLOSE_CODE telemetry and add more detail codes for the internal errors r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105725
2021-02-19 20:37:24 +00:00
Valentin Gosu
c33fe1fe47 Bug 1264117 - Limit length of hostnames to 253 characters r=nhnt11,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D105609
2021-02-19 17:02:34 +00:00
Dragana Damjanovic
f06f0b9886 Bug 1687264 - Do not use mChannelChild if CreateBackgroundChannel fails r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105687
2021-02-19 15:04:45 +00:00
Butkovits Atila
67c4ae9c97 Backed out changeset 0b48f6f8e965 (bug 1264117) for causing failures on test_dns_service.js. CLOSED TREE 2021-02-19 16:41:04 +02:00
Valentin Gosu
b6c3ecbc99 Bug 1264117 - Limit length of hostnames to 253 characters r=nhnt11,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D105609
2021-02-19 11:45:05 +00:00
ffxbld
782a30533f No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=jcristau
Differential Revision: https://phabricator.services.mozilla.com/D105627
2021-02-19 10:22:03 +00:00
Butkovits Atila
9fd21f67da Backed out changeset fd00d1b7fd67 (bug 1264117) for causing failures on test_dns_service_wrap.js. 2021-02-19 12:20:49 +02:00
Valentin Gosu
b3e6410990 Bug 1264117 - Limit length of hostnames to 253 characters r=nhnt11,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D105609
2021-02-19 09:17:42 +00:00
Dragana Damjanovic
dcaa89a55d Bug 1692734 - If FastFallbackToIPv4 is set disable IPv6 on backup connections. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105482
2021-02-18 20:42:03 +00:00
Dragana Damjanovic
f51b25f77b Bug 1511151 - Add a flag to allow client certs on CORS preflight connections r=necko-reviewers,keeler,valentin,kershaw
This is only used for CORS preflight requests. It is controlled by a pref.
Connections that server such request will be isolated from other anonymous connections.

Differential Revision: https://phabricator.services.mozilla.com/D96775
2021-02-18 18:58:17 +00:00
Kershaw Chang
27c050e058 Bug 1689987 - Fix build error. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D105648
2021-02-18 16:39:30 +00:00
Alexis Beingessner
1d8964049c Bug 1686616 - make SocketTransport use Components instead of Services. r=kmag,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105534
2021-02-18 13:26:34 +00:00
Alexis Beingessner
fc3bf87d11 Bug 1686616 - make StreamTransport use Components instead of Services. r=kmag,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105533
2021-02-18 13:26:33 +00:00
Alexis Beingessner
0df92fdb83 Bug 1686616 - make CacheStorage use Components instead of Services. r=kmag,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105532
2021-02-18 13:26:33 +00:00
Alexis Beingessner
3f1a425606 Bug 1686616 - make IO use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105530
2021-02-18 13:26:32 +00:00
Alexis Beingessner
972f085576 Bug 1686616 - make HttpActivityDistributor use Components instead of Services. r=kmag,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105525
2021-02-18 13:26:30 +00:00
Alexis Beingessner
bd14ca539e Bug 1686616 - make ThirdPartyUtil use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105523
2021-02-18 13:26:29 +00:00
Alexis Beingessner
92afde7986 Bug 1686616 - register all Services.py services with components.conf. r=kmag,necko-reviewers,valentin
These services had their name added to components.conf:

* GfxInfo
* ThirdPartyUtil
* History
* HttpActivityDistributor
* UUIDGenerator
* ServiceWorkerManager
* PermissionManager

These services were added to componenets.conf under a different name:

* DirectoryService => Directory
* IOService => IO
* StringBundleService => StringBundle
* CacheStorageService => CacheStorage
* StreamTransportService => StreamTransport
* SocketTransportService => SocketTransport

These services weren't migrated to components.conf because only Rust
code uses them:

* RemoteAgent
* XULRuntime
* PrefService

These services weren't migrated to components.conf because they're unused:

* ToolkitChromeRegistry (used as ChromeRegistry)
* XULChromeRegistry (used as ChromeRegistry)
* Bits (completely unused)

These services were already available in components.conf but are still
used by rust code:

* URIFixup

These services weren't migrated because they will be handled in
subsequent patchsets:

* ObserverService

For the record, the following Services are being used by Rust code
and must remain until a Rust version of Components.h is written:

* RemoteAgent
* XULRuntime
* PrefService
* URIFixup
* ObserverService
* DirectoryService
* ThirdPartyUtil

Also the cocoa GfxInfo service was changed to use components.conf instead
of registering it at runtime, as all the other widgets were already doing
it this way.

Differential Revision: https://phabricator.services.mozilla.com/D105521
2021-02-18 13:26:28 +00:00
Kershaw Chang
3d66c37e76 Bug 1689987 - P5: Add probes to collect DNS lookup time when ODoH is used r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105215
2021-02-18 12:50:04 +00:00
Kershaw Chang
36d1df148d Bug 1689987 - P4: Add a telemetry probe to collect channel success rate when ODoH is used r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105214
2021-02-18 12:50:03 +00:00
Kershaw Chang
9795f890cc Bug 1689987 - P3: Add some ODoH specific skip reasons r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D104831
2021-02-18 12:50:03 +00:00
Kershaw Chang
782c896152 Bug 1689987 - P2: Add DNS_ODOH_LOOKUP_TIME and ODOH_SKIP_REASON_ODOH_FIRST probes r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D104800
2021-02-18 12:50:02 +00:00
Kershaw Chang
a2532cb1f3 Bug 1689987 - P1: Don't mess up TRR telemetry when ODoH is used r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D104799
2021-02-18 12:50:02 +00:00
Kershaw Chang
67fbb1e79d Bug 1692120 - Avoid accessing nsSocketTransport::mCondition on main thread r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105596
2021-02-18 10:52:59 +00:00
Kershaw Chang
41aee156c6 Bug 1692886 - Record HTTP_TRANSACTION_RESTART_REASON correctly r=necko-reviewers,dragana
- Make sure we set the restart reason before calling Restart().
- Extend TRANSACTION_RESTART_REASON to also record the case for fast fallback.

Differential Revision: https://phabricator.services.mozilla.com/D105212
2021-02-18 10:42:50 +00:00
Chris Peterson
ac4fc500b3 Bug 1679929 - Cap the User-Agent string's reported macOS version at 10.15 like Safari does. r=valentin,necko-reviewers,hsivonen
Fixes webcompat bugs like bug 1680516. Some UA-sniffing sites assume the User-Agent string's macOS version always begin with "10." and they break if the User-Agent string reports version 11.0 on macOS Big Sur (11.0 aka 10.16).

Differential Revision: https://phabricator.services.mozilla.com/D99856
2021-02-17 17:48:32 +00:00
Valentin Gosu
efa654d3d5 Bug 1691408 - Record confirmation event telemetry r=nhnt11,dragana,necko-reviewers
- Adds new TRR* argument to CompleteLookup so we can extract the channel
  status from the TRR request.
- Record event whenever the confirmation context changes
- NetworkID is recorded whenever we start a new confirmation attempt
- Captive portal status is updated based on observer notifications
- We keep a buffer of the last 32 confirmation results.

Differential Revision: https://phabricator.services.mozilla.com/D105173
2021-02-17 10:26:41 +00:00
Valentin Gosu
e5e0b8d7a7 Bug 1691408 - Move DNS_TRR_NS_VERFIFIED2 accumulation out of conditional block r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D105172
2021-02-17 10:26:40 +00:00
Valentin Gosu
50bee9f5dd Bug 1691933 - Increase timeout for TRR confirmation request r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104677
2021-02-17 10:26:39 +00:00
Valentin Gosu
dbc436b39f Bug 1675540 - Perform URL sanity checks when changing it r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D104541
2021-02-17 08:54:03 +00:00
Valentin Gosu
1eabd8106b Bug 1692862 - Null out mSession pointer when closing Http2Stream r=dragana,necko-reviewers
The Http2Stream holds a raw pointer to the Http2Session which gets initialized in the constructor and is never changed.
We should null out the member so we don't attempt to use it after it has been destroyed.

Differential Revision: https://phabricator.services.mozilla.com/D105188
2021-02-17 08:00:53 +00:00
Markus Stange
5257db6695 Bug 1692391 - Remove the word ABORT from the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_RETURN macros, because these macros don't abort. r=haik,necko-reviewers
This patch was generated automatically with the commands below:

```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_RETURN/NS_OBJC_END_TRY_BLOCK_RETURN/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D104955
2021-02-16 22:55:20 +00:00
Paul Zuehlcke
0379f315c7 Bug 1693000 - Updated CookiePartitionedForeign console message to refer to State Partitioning. r=timhuang,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D105343
2021-02-16 19:50:18 +00:00
Simon Giesecke
661e25bf09 Bug 1692880 - Make Put accept DataType instead of wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D104850
2021-02-16 15:53:33 +00:00
Gerald Squelart
2416d881e2 Bug 1691589 - Reduce reliance on GeckoProfiler.h when only labels (and maybe markers) are needed - r=necko-reviewers,geckoview-reviewers,sg,agi,florian
There are no code changes, only #include changes.
It was a fairly mechanical process: Search for all "AUTO_PROFILER_LABEL", and in each file, if only labels are used, convert "GeckoProfiler.h" into "ProfilerLabels.h" (or just add that last one where needed).
In some files, there were also some marker calls but no other profiler-related calls, in these cases "GeckoProfiler.h" was replaced with both "ProfilerLabels.h" and "ProfilerMarkers.h", which still helps in reducing the use of the all-encompassing "GeckoProfiler.h".

Differential Revision: https://phabricator.services.mozilla.com/D104588
2021-02-16 04:44:19 +00:00