Commit Graph

75 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
c228998b4f Bug 1410578: Make <link rel="stylesheet"> work in shadow trees. r=heycam
Summary: Somewhat straight-forward, mostly removing special-casing.

Differential Revision: https://phabricator.services.mozilla.com/D1761

MozReview-Commit-ID: 6f8duD4pGrl
2018-06-22 04:15:56 +02:00
Boris Zbarsky
bea3100e53 Bug 1455676 part 14. Remove most use of nsIDOMNode in dom/. r=qdot 2018-05-29 22:58:49 -04:00
Emilio Cobos Álvarez
cb56e2c9f3 Bug 1459529: Remove UPDATE_STYLE. r=heycam
Now that BeginUpdate is useless for the UPDATE_STYLE case, we don't need the
update mechanism at all. Just ensure that ApplicableStylesChanged is called on
the pres shell via the relevant RuleChanged, etc. notifications.

There's a big hidden gotcha here. nsIDocument::BeginUpdate does put a script
blocker on the stack for these updates. However it's not needed, since no script
can run during these notifications (only the stylesheet events we post for
devtools, but those use AsyncEventDispatcher and PostDOMEvents, so they don't
try to run immediately).

nsIDocument::BeginUpdate also does XBL binding attached queue stuff, but we
can't change bindings during these notifications anyway, so it also doesn't
matter.

MozReview-Commit-ID: HJvK6zQfloh
2018-05-15 18:44:29 +02:00
Emilio Cobos Álvarez
50a8a26470 Bug 1447009: Ignore title if the element is not in the document. r=heycam
Turns out this was well specified, see the linked bits.

MozReview-Commit-ID: HjdbFS78Mwj
2018-05-10 00:37:50 +02:00
Emilio Cobos Álvarez
17a92ff99b Bug 1459844: Share more code and fix some inconsistencies between html / svg style elements. r=heycam
MozReview-Commit-ID: IkTrIfJI1iK
2018-05-10 00:21:27 +02:00
Emilio Cobos Álvarez
9509853a38 Bug 1459498: Rename nsIStyleSheetLinkingElement::StyleSheetInfo to SheetInfo. r=heycam
MozReview-Commit-ID: FeOmISAxWBk
2018-05-08 10:07:46 +02:00
Emilio Cobos Álvarez
91b6cb40dc Bug 1459498: Use StyleSheetInfo more. r=heycam
Not as much as I'd like, because we have all the internal loads and child
sheets, but...

MozReview-Commit-ID: 7402w8vxCel
2018-05-08 10:07:43 +02:00
Emilio Cobos Álvarez
96600d2b9a Bug 1459498: Use a different enum to differentiate IsAlternate from HasAlternateRel. r=heycam
MozReview-Commit-ID: 6pwR8t6fzSD
2018-05-08 10:07:42 +02:00
Emilio Cobos Álvarez
5b6f2bdee0 Bug 1459498: Refactor nsStyleLinkElement so that all the stylesheet information comes from one place. r=heycam
I've kept the nsAutoStrings in the StyleSheetInfo class on the hopes that the
compiler does RVO, but if it doesn't I can remove I guess.

MozReview-Commit-ID: 2vN6BSEhYcw
2018-05-08 10:07:41 +02:00
Emilio Cobos Álvarez
37eed71b1c Bug 1425866: Just null-check the CSS Loader for now. r=heycam
After discussing with Olli there isn't any kind of severe problem out of this.
Shadow subtrees will be disconnected just like the rest, and they shouldn't
assume that the document hasn't been disconnected first.

MozReview-Commit-ID: CX4fXOqEIFj

--HG--
extra : rebase_source : cd30cb8b8199fb73120c0bcade68986454090005
2018-04-27 01:46:50 +02:00
Emilio Cobos Álvarez
31aff796a0 Bug 1456435: Make the loader a bit less outparam-happy. r=heycam
Returning the same type and UpdateStyleSheet.

This hopefully helps seeing how the data flows between the methods, instead of
the messy bits we had before.

MozReview-Commit-ID: C6THNRi8bbg
2018-04-26 16:43:58 +02:00
Emilio Cobos Álvarez
5618bcfb59 Bug 1456435: Less bool outparam in Loader too. r=heycam
MozReview-Commit-ID: D5A2BxwHGjn
2018-04-26 16:43:54 +02:00
Emilio Cobos Álvarez
a00f507b72 Bug 1456435: Make UpdateStyleSheet less bool-happy. r=heycam
MozReview-Commit-ID: FlTD390lMhg
2018-04-26 16:43:52 +02:00
Emilio Cobos Álvarez
e0fb59363f Bug 1456435: Don't clone a URI for sheet loading. r=heycam
nsIURI is immutable now.

MozReview-Commit-ID: 1eMikl399Fd
2018-04-26 16:43:45 +02:00
Dragana Damjanovic
d9148a8a51 Bug 1441246 - Move preload cod from nsStyleLinkElement to HTMLLinkElement. r=smaug
--HG--
extra : rebase_source : 01cb8b69aa1187abb83b36098d81df1d96c7d79c
2018-04-20 12:47:00 +03:00
Xidorn Quan
1cf8082e67 Bug 1447828 part 3 - Remove StyleBackendType uses from MediaList. r=emilio
MozReview-Commit-ID: 9sG73iLeBw4

--HG--
extra : rebase_source : a2626f6d1f8af02caeb7f3d37b7d258b4544b62d
extra : source : 2f443463446897080b85ac0da5b7a9ea6ccc9de2
2018-03-29 02:31:46 +11:00
Boris Zbarsky
4fa4d2a7f5 Bug 1446598 part 2. Get rid of nsIDOMComment. r=mystor
MozReview-Commit-ID: GGXPQnlwuUM
2018-03-19 15:15:39 -04:00
Emilio Cobos Álvarez
de099db7bd Bug 1444905: Remove scoped style support from the old style system. r=xidorn,smaug
Summary: It uses two node bits that can be better suited for something else.

Reviewers: xidorn, smaug

Bug #: 1444905

Differential Revision: https://phabricator.services.mozilla.com/D709

MozReview-Commit-ID: HIPDtHm6xpM
2018-03-13 10:26:13 +01:00
Hiroyuki Ikezoe
1b0cba9367 Bug 1417354 - Introduce nsIDocument::GetPresContext(). r=smaug
It would be convenient to get nsPresContext from nsIDocument.

MozReview-Commit-ID: Ei6V3UE8XGr

--HG--
extra : rebase_source : 8d2a917eb62cf341e4e1810451fd01c01dbc3bad
2018-02-21 07:00:10 +09:00
Boris Zbarsky
c32290c3d7 Bug 1435132 part 3. Remove the last NS_IMETHOD bit from nsIStyleSheetLinkingElement. r=mccr8
MozReview-Commit-ID: K7mnYXOJOK6
2018-02-02 08:21:32 -05:00
Boris Zbarsky
69cbdecca9 Bug 1435132 part 2. Make nsIStyleSheetLinkingElement::GetCharset infallible. r=mccr8
MozReview-Commit-ID: 2maFIxR2HkS
2018-02-02 08:21:32 -05:00
Boris Zbarsky
54a6506018 Bug 1435132 part 1. Remove NS_IMETHOD noise from never-failing nsIStyleSheetLinkingElement methods. r=mccr8
MozReview-Commit-ID: EibysYsW1rv
2018-02-02 08:21:32 -05:00
Cameron McCormack
cc7db5c40c Bug 1430014 - Part 4: #ifdef out unnecessary code when the old style system is not built. r=xidorn
MozReview-Commit-ID: 1FZ9VzjcPzN

--HG--
extra : source : de22d220635f8c059834b76f769d5215ab1a8b5b
2018-02-01 15:04:04 +11:00
Nika Layzell
a0d1f16079 Bug 1383876 - Part 1: Remove GroupedSHistory and Prerendering logic from C++ code, r=freesamael, r=smaug
MozReview-Commit-ID: 2aHA6NcQPGk
2018-01-12 17:52:52 -05:00
Cameron McCormack
e3549b2d1c Bug 1427512 - Part 22: Remove nsIDOMStyleSheet. r=xidorn,bz
MozReview-Commit-ID: KO2mWX4P8lI
2018-01-11 16:17:57 +08:00
Emilio Cobos Álvarez
c8eb630ebe Bug 1423990: Move the last few attribute-related methods outside of nsIContent. r=bz
MozReview-Commit-ID: 8JZuS6O8f8W
2017-12-25 17:50:10 +01:00
Emilio Cobos Álvarez
ffdf5d2cb5 Backout changeset e43f568b3e9a (bug 1423990) because some OSX-only code still doesn't build. r=me 2017-12-25 12:55:45 +01:00
Emilio Cobos Álvarez
c0959b2955 Bug 1423990: Move the last few attribute-related methods outside of nsIContent. r=bz
MozReview-Commit-ID: 8JZuS6O8f8W

--HG--
extra : rebase_source : 09b82acb4f3d69e8a4345457ab217443bc28d6e2
2017-12-07 19:13:50 +01:00
Kris Maglione
1653b08073 Bug 1415352: Part 4c - Use subject principal as the triggering principal for inline <style> nodes. r=bz
This change captures the subject principal when a scripted caller sets the
textContent or innerHTML property of a <style> node, and uses it as the
triggering principal for the resulting stylesheet.

If the node contents are modified in any way other than through textContent or
innerHTML, the triggering principal is forgotten (which is an intentional
design feature).

MozReview-Commit-ID: GacZFIB5BzS

--HG--
extra : rebase_source : 04926f30b8e2831d18d3fb64b850f670f006eb85
2017-11-07 14:25:45 -08:00
Kris Maglione
bd57fba62b Bug 1415352: Part 2 - Exempt inline CSS from extension principals from CSP. r=bz
MozReview-Commit-ID: D0dofgOaLXZ

--HG--
extra : rebase_source : ee649c83191e64f5f0370e61a54b506f4767ac71
2017-11-05 12:19:34 -08:00
Kris Maglione
9c145b38f6 Bug 1406278: Part 8b - Use subject principal as triggering principal in style <link> "href" attribute. r=bz
MozReview-Commit-ID: LWMkBcB4WIg

--HG--
extra : rebase_source : fa2daf25c58190cee7e55798347d4eaffa0d5250
extra : histedit_source : f2887c9e53c572aa5e675600cd1aeb6c5a72becc%2Ce7a84ac505319ca24e65c73a4df13014a0a0cdc0
2017-10-05 19:40:48 -07:00
Kris Maglione
6d422a0fcd Bug 1406278: Part 8a - Cleanup some uses of CallQueryInterface. r=bz
MozReview-Commit-ID: 20yDJiKLJav

--HG--
extra : rebase_source : 6ec35274aacb0bda12d6a25b1aeaa993d5cc49f8
2017-10-05 19:06:54 -07:00
Bobby Holley
2a5c1f23e1 Bug 1398982 - Remove style scoped warnings for stylo. r=me
We're unshipping stylo scoped anyway.

MozReview-Commit-ID: IeZLzX3ZU9i
2017-09-15 16:40:33 -07:00
Wes Kocher
ed7085cec0 Backed out changeset 3b21f5d72f54 (bug 1398982) for unexpected passes in reftests a=backout
MozReview-Commit-ID: E4svy69pFIz
2017-09-15 15:50:14 -07:00
Bobby Holley
76cc5d68ad Bug 1398982 - Remove style scoped warnings for stylo. r=me
We're unshipping stylo scoped anyway.

MozReview-Commit-ID: IeZLzX3ZU9i
2017-09-15 12:20:22 -07:00
Thomas Nguyen
33fb4a1505 Bug 1384493 - LoadStyleLink and LoadInlineStyle should use correct referrer policy. r=heycam
If the link element has referrerpolicy attribute, we should use policy in the
attribute with higher priority

MozReview-Commit-ID: GZZeRaoxPUw
2017-08-15 00:05:00 -04:00
Masatoshi Kimura
866d87ee67 Bug 1361579 - Remove nsISimpleContentPolicy. r=Ehsan
MozReview-Commit-ID: BsjkGpTpe8I

--HG--
extra : rebase_source : 640807623fc70797932a0ee592b887d5c134b5f9
2017-08-03 17:50:00 +09:00
Dragana Damjanovic dd.mozilla@gmail.com
0bd7a2c931 Bug 1222633 - Add rel=preload - dom part. r=smaug 2017-07-10 15:05:56 +02:00
Sylvestre Ledru
4e9cf83ee8 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG

--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Cameron McCormack
fab1072b7f Bug 1291515 - Part 1: Introduce a pref for <style scoped>. r=bholley,dbaron
MozReview-Commit-ID: 1J9IvPrC0xh

--HG--
extra : rebase_source : 4a3da0dc41ec71d2804e6f8a778613e8749940be
2017-06-21 09:25:43 +08:00
Wes Kocher
913ce205d2 Backed out 2 changesets (bug 1291515) for reftest assertions in textarea-fieldset-legend-ref-2.html a=backout CLOSED TREE
Backed out changeset 4fac24cc0437 (bug 1291515)
Backed out changeset 4e8b918dc410 (bug 1291515)

MozReview-Commit-ID: F4yQK5ujqLP
2017-06-25 05:18:22 -07:00
Cameron McCormack
deae2413d6 Bug 1291515 - Part 1: Introduce a pref for <style scoped>. r=bholley,dbaron
MozReview-Commit-ID: 1J9IvPrC0xh

--HG--
extra : rebase_source : 2c3a139cc5e4e223e5b9b7892020c96df2cf264c
2017-06-21 09:25:43 +08:00
Ben Kelly
bd95903746 Bug 1197401 Remove the disabled HTML imports implementation. r=wchen 2017-06-12 07:36:02 -07:00
Michael Layzell
0fa642800b Bug 1315105 - Part 2: Implement <link rel=prerender> behind a pref, r=smaug
MozReview-Commit-ID: ARET98o1FTU

--HG--
extra : rebase_source : fd549baa1a4a180db1ca6701191f081033811d0f
2016-12-19 15:05:31 +08:00
Carsten "Tomcat" Book
51614d31e4 Backed out changeset 059753ec9117 (bug 1315105) for test failures in own test
--HG--
extra : rebase_source : de2846d1205d3e885c1040379f2816629a925d22
2016-12-19 15:59:14 +01:00
Michael Layzell
b5fd619e72 Bug 1315105 - Part 2: Implement <link rel=prerender> behind a pref, r=smaug
MozReview-Commit-ID: ARET98o1FTU
2016-12-19 15:05:31 +08:00
Xidorn Quan
2f49a48a09 Bug 1304302 part 10 - Replace all uses of StyleSheetHandle. r=heycam
This commit is generated by the following commands with some minor
manual adjustment:

find . \( -name '*.h' -or -name '*.cpp' \) -not -path './layout/style/StyleSheet*' -exec sed -i -b \
  -e '/^\(#include\|using\)/s/StyleSheetHandle/StyleSheet/g' \
  -e 's/\(mozilla::\)\?StyleSheetHandle::RefPtr/RefPtr<\1StyleSheet>/g' \
  -e 's/StyleSheetHandle()/nullptr/g' \
  -e 's/->AsStyleSheet()//g' \
  -e 's/StyleSheetHandle/StyleSheet*/g' {} +
sed -i -b 's/sheet->AsVoidPtr()/sheet.get()/' layout/style/Loader.cpp
sed -i -b 's/AsHandle()/this/' layout/style/StyleSheet.cpp

MozReview-Commit-ID: 7abdvlKHukd

--HG--
extra : source : e5682242db07203b5a91810fe1e243c955310588
2016-09-26 22:03:25 +10:00
Bobby Holley
83d2ff11d1 Bug 1291891 - Switch to NS_WARNING for unimplemented <style scoped>. r=emilio 2016-08-03 18:30:57 -07:00
Thomas Nguyen
545e22fb16 Bug 1264165 - Implement link referrerPolicy attribute. r=josh, r=khuey
MozReview-Commit-ID: GxMtNB23eD8
2016-06-24 10:38:47 +08:00
Boris Zbarsky
63d528aa43 Bug 1257849 part 4. Pass in the right set of supported tokens to the <link> relList implementation. r=bkelly 2016-05-04 23:41:24 -04:00