Commit Graph

92 Commits

Author SHA1 Message Date
Michael Yoshitaka Erlewine
442d8150a9 Bug 591715: Utils.log: add option to use dump instead of console and add timing info [r=dao, a=gavin] 2010-09-01 16:04:12 -04:00
Michael Yoshitaka Erlewine
d9156f1337 Bug 586455: Separate structural versus visual CSS [r+a=dolske] 2010-09-01 16:14:37 -04:00
Michael Yoshitaka Erlewine
0743383614 Bug 589224 - Drag.snapBounds stationaryCorner default is broken [r=gavin,a=gavin]
--HG--
extra : rebase_source : 041579a7f6f2ff3527d4a87bd82324db1e32def9
2010-08-27 01:23:23 -04:00
Michael Yoshitaka Erlewine
91b0235f38 Bug 591087: Remove GroupItem.setNewTabButtonBounds which is not used [r=gavin, a=gavin]
--HG--
extra : rebase_source : a10f47ec13bb91204d0124e49093d7644420773b
2010-08-26 19:57:39 -04:00
Raymond Lee
5dd46a92bd Bug 588478 - Escape should not open tab from fan view of stacked tabs [r=dolske a=dolske]
--HG--
extra : rebase_source : 1a77634fa20cc1bfb42d816dfe2551809f03f116
2010-08-19 17:13:58 +08:00
Raymond Lee
ba01e8292d Bug 588295 - Zoom out doesn't work for the same tab [r=dolske a=dolske]
--HG--
extra : rebase_source : 269329afabc8de08036eb9a476c7a61dffd67b8d
2010-08-18 15:06:20 +08:00
Raymond Lee
22dc8a625c Bug 588260 - Control + Shift + ' doesn't switch to the correct group [r=dolske a=dolske]
--HG--
extra : rebase_source : ddd8c78a15bbe7aebace9b62cfb14ad1a6e3d7e3
2010-08-18 10:51:43 +08:00
Raymond Lee
28141e030a Bug 586719 - Use proper constants in setTabViewFrameKeyHandlers [r=dolske a=dolske]
--HG--
extra : rebase_source : 1af40c4905b3866e1c08cf21759c0e1468a993dd
2010-08-13 15:18:29 +08:00
Raymond Lee
0ea0ab343f Bug 586712 - Lighten tabOnFocus (and rename it), [r=dolske a=dolske]
--HG--
extra : rebase_source : 737e30c88ff59739149aa238dad1d558c580c783
2010-08-17 22:13:45 +08:00
Raymond Lee
a872b75d02 Bug 585855 - Test that the bookmark all tabs command is disabled when we have one visible and one hidden tab [r=dão sr=vlad a=gavin]
--HG--
extra : rebase_source : 728aa27e7ffdf08359c26fe709cac925c0d0f344
2010-08-14 02:36:40 +08:00
Edward Lee
a020f66689 Bug 586198 - Incorrect placement of tab after Undo Close Tab in Tab Candy [r=dolske a=blocking2.0:beta4]
Explicitly wipe out tab storage data on close so that undo close tab acts like a brand new tab.

--HG--
extra : rebase_source : f05ab57dff8a10be9df9e93bb128a4b716336c7a
2010-08-16 16:56:28 -07:00
Frank Yan
36b65f9ee1 Bug 587267 - Display the Firefox button when in TabView; r=dao approval2.0=gavin.sharp 2010-08-16 16:33:32 -04:00
Raymond Lee
d1bdb74d87 Bug 586693 - Do we still need to marshal browser events? [r=dolske a=blocking2.0]
* Removed some timeouts and fixed some broken user interactions that fixes various other bugs and test failures.
Bug 587029 - Tab Candy : closing last tab of a group leads to an isolated tab
Bug 586552 - GroupItem.newTab feedback should be immediate
* Init TabItems before handling firstrun tab grouping
* Removed _stopZoomPreparation related code since we are not using it anymore.
* Fixed the issue related to using move to other group feature. The moved tab is still visible in the tab bar after moving it to other group.

--HG--
extra : rebase_source : 9784acd2df5be4be5016cf15d52dabaccd68e2a5
2010-08-16 12:46:22 +08:00
Frank Yan
8f7e4eb440 Bug 581820 - Minimize/Maximize/Close buttons missing when Firefox is in TabView [r=dolske a=dolske]
Give some margin to show the buttons even when in TabView.

--HG--
extra : rebase_source : 45918646e8b111deb67a1695faaaaada6c5ff6e8
2010-08-13 19:36:47 -07:00
Edward Lee
64262f7d4f Bug 586777 - Restore ctrl-space activation for on windows/linux [r=dolske a=dolske]
Switch back to ctrl-space and check for certain nodes where we shouldn't handle it.

--HG--
extra : rebase_source : 8ee74987148606472893f5230eaf4486f431c1fc
2010-08-12 15:00:39 -07:00
Ian Gilman
f395962d2c Bug 586834 - Reinstate the Tab Candy bounce [r=dolske a=dolske]
--HG--
extra : rebase_source : c855277103725aa905c4adba18b1f0b6cc65e2ad
2010-08-12 17:37:22 -07:00
Ian Gilman
44f06cfe7b + partial fix for 586721: Kill dev menu [r=dolske a=dolske]
--HG--
extra : rebase_source : 9ee847d90a3f517474e6982e6d0b3ae8a8f2ec9c
2010-08-12 17:28:45 -07:00
Michael Yoshitaka Erlewine
0154d3137a Bug 586685: All user-facing strings in JS are now localizable via stringbundle [r=dolske a=dolske]
NOT.
Everything but user facing strings being localized.
Random whitespace fixes.
Random styling changes.
Also has Bug 587158 - Update intro-video URL to CDN'ed version
And string changes.
And Bug 586814 - Unable to close Tab groups

--HG--
extra : rebase_source : 75a5ef7e1cedfd180358b0fb2e6ea02b1ecb8f0e
2010-08-12 18:32:18 -05:00
Edward Lee
c15ca2c814 Backout changesets a8b5109c2a6c to 6281bc7f1bbf. 2010-08-13 21:51:48 -07:00
Frank Yan
dccf3c6d0e Bug 581820 - Minimize/Maximize/Close buttons missing when Firefox is in TabView [r=dolske a=dolske]
Give some margin to show the buttons even when in TabView.
2010-08-13 19:36:47 -07:00
Raymond Lee
0ea48b6fb8 Bug 587029 - Tab Candy : closing last tab of a group leads to an isolated tab [r=dolske a=dolske]
--HG--
extra : rebase_source : eb46ebd833b5014bb8536c8570a9e727cf16ddbe
2010-08-14 03:58:25 +08:00
Edward Lee
316abb68a2 Bug 586777 - Restore ctrl-space activation for on windows/linux [r=dolske a=dolske]
Switch back to ctrl-space and check for certain nodes where we shouldn't handle it.

--HG--
extra : rebase_source : 4b27a80e90b3e3d9bbfd98150a977dcc853f2180
2010-08-12 15:00:39 -07:00
Ian Gilman
263229541f Bug 586834 - Reinstate the Tab Candy bounce [r=dolske a=dolske]
--HG--
extra : rebase_source : c7351eee04263119ea4ef692a2b89e1719c20da0
2010-08-12 17:37:22 -07:00
Ian Gilman
800cbccd7e + partial fix for 586721: Kill dev menu [r=dolske a=dolske]
--HG--
extra : rebase_source : 484290df6e525072053f5cb7786908e90fe2e0a0
2010-08-12 17:28:45 -07:00
Michael Yoshitaka Erlewine
df9910a872 Bug 586685: All user-facing strings in JS are now localizable via stringbundle [r=dolske a=dolske]
NOT.
Everything but user facing strings being localized.
Random whitespace fixes.
Random styling changes.
Also has Bug 587158 - Update intro-video URL to CDN'ed version
And string changes.
And Bug 586814 - Unable to close Tab groups

--HG--
extra : rebase_source : bc46adb3b3acc2e4daee067e9209d049fe1a8970
2010-08-12 18:32:18 -05:00
Michael Yoshitaka Erlewine
779e5ffd4c Bug 574875: First run experience: tabs are put together into a single group--now without unnecessary animation! [r=dolske a=dolske]
--HG--
extra : rebase_source : 4f06fbe6cd2e0a4463f33ba0d8f13f494126ec83
2010-08-12 16:20:59 -05:00
Edward Lee
0d25364cc2 Bug 586753 - Use ctrl-alt-space for win/linux to avoid ctrl-space 2010-08-12 12:43:31 -07:00
Edward Lee
7c7c81e3da Bug 581813 - Firefox with Tab Candy caused the Title and Tab Bars or the Menu and Tab Bars to appear black in colour
Push the TabView iframe down behind the tabbrowser when hiding TabView and restore the max height on show. This has slight issues in that it squishes the iframe contents as well as flashes black as we animate. Followup in bug 586679.
2010-08-12 09:38:21 -07:00
Raymond Lee
6131928ba1 Change a var to let. 2010-08-12 14:46:16 +08:00
Raymond Lee
ccd83c0cbc Bug 586522 - Leaks in Tab Candy 2010-08-12 14:39:12 +08:00
Raymond Lee
290ca06e3a Release some resources on unload 2010-08-12 12:36:58 +08:00
Michael Yoshitaka Erlewine
ebcfb5ec75 Bug 574217: Some touchups based on comments from dolske 2010-08-11 23:08:33 -04:00
Michael Yoshitaka Erlewine
8a35f21530 Fixes for Dolske's strict JS warnings 2010-08-11 22:01:29 -04:00
Michael Yoshitaka Erlewine
6610075e44 GroupItem: unify title-setting to use setTitle (which in turn uses iQ.val). Note TabItem titles are set using iQ.text, so there is no security issue there. 2010-08-11 21:35:29 -04:00
Ian Gilman
7e50a7ea97 + I forgot to update the references to the newly renamed tabview.css files; fixed 2010-08-11 17:00:15 -07:00
Ian Gilman
fa7425a33f + Fixes for dolske and dao comments on bug 574217:
++ Unnecessary double if in tabbrowser.xml
++ moved body styling into CSS file and simplified
++ CSS comma style
++ Renamed platform.css files to tabview.css

--HG--
rename : browser/themes/gnomestripe/browser/tabview/platform.css => browser/themes/gnomestripe/browser/tabview/tabview.css
rename : browser/themes/pinstripe/browser/tabview/platform.css => browser/themes/pinstripe/browser/tabview/tabview.css
rename : browser/themes/winstripe/browser/tabview/platform.css => browser/themes/winstripe/browser/tabview/tabview.css
2010-08-11 16:51:39 -07:00
Ian Gilman
5e4fbc7f19 + More dolske comments for 574217
++ Initial developer
++ Cc, Ci, Cu
++ Spacing
++ Commented out code in storage.js
++ DOCTYPE
2010-08-11 15:28:45 -07:00
Michael Yoshitaka Erlewine
132535ac01 Bug 582023: making changes requested by Dao. Now iQ + Utils are ready for m-c with r=dao! 2010-08-11 13:06:49 -04:00
Ian Gilman
e3885fcbb9 + removed profiling code
--HG--
extra : rebase_source : 690f1d46c2833ec2e122b53b2fbbc3b5a0e50aec
2010-08-10 18:10:21 -07:00
Ian Gilman
5c85620cf4 + addressing dao's comments in iQ
--HG--
extra : rebase_source : 9fd229f468514fb08326fe292434de45e6167bfb
2010-08-10 16:31:12 -07:00
Michael Yoshitaka Erlewine
4aae5fd392 Bug 582023 cleanup based on comments from Dao on things that are not iQ:
- typeof() is not a function
- formatting of && and || at the end of the line
- declaring variables more locally using let in Utils.extend
- the Initial Developer is the Mozilla Foundation

--HG--
extra : rebase_source : d1f9699fb0014c95e336c34d777ce354b141739a
2010-08-10 19:20:05 -04:00
Ian Gilman
c6453dd70a + removed the "beforeclose" event from TabItem and cleaned up the "close" event
+ Removed the "urlChanged" event from TabItem; inlining that code instead.

--HG--
extra : rebase_source : a48f380dd98eaaa971e7e0529b6c17b674a02b9f
2010-08-10 15:36:56 -07:00
Ian Gilman
cfc86e11be + TabView actions that require loading the frame (if not loaded) now wait properly until the frame is loaded before continuing. These actions are show, context menu, and "next group" key combo.
+ TabView now has explicit show and hide in addition to toggle
+ Cleaned out unused "ui" parameter to the Item drag callback

--HG--
extra : rebase_source : e8ffd468406fe1d0690e29a15ce4b431a0596371
2010-08-10 14:23:53 -07:00
Raymond Lee
abbac1f541 Fixed Bug 584627 - Tests for group 2010-08-11 02:39:28 +08:00
Ian Gilman
ade1e56471 + reversed the argument order for Utils.assert and Utils.assertThrow, per Dao's review 2010-08-10 11:13:10 -07:00
Raymond Lee
6e4c1327c6 Removed the remaining Utils.timeout 2010-08-11 00:19:08 +08:00
Michael Yoshitaka Erlewine
ce44fba261 Bug 582023: rm Utils.timeout 2010-08-10 09:30:23 -04:00
Michael Yoshitaka Erlewine
c97c36089e Bug 582023: move to use getBoundingClientRect instead of reading off the computed CSS for bounds; simplify getPropertyValue usage (based on comments from Dao) 2010-08-10 09:22:38 -04:00
Edward Lee
bd41000053 Address review comments from bug 584532 comment 18: !listeners, event.target, observers function. 2010-08-10 03:05:10 -07:00
Ehsan Akhgari
3002c5320c Bug 585850 - Rename TabCandy modules from *.js to *.jsm (like the rest of js modules)
--HG--
rename : browser/base/content/tabview/modules/AllTabs.js => browser/base/content/tabview/modules/AllTabs.jsm
rename : browser/base/content/tabview/modules/groups.js => browser/base/content/tabview/modules/groups.jsm
rename : browser/base/content/tabview/modules/utils.js => browser/base/content/tabview/modules/utils.jsm
2010-08-09 23:51:23 -04:00