Xidorn Quan
38152a41e1
Bug 1460192 - Rename pointing to inherited_ui. r=heycam
...
And also merge values::*::pointing into values::*::ui.
MozReview-Commit-ID: FM4gWEszahB
--HG--
rename : servo/components/style/properties/longhand/pointing.mako.rs => servo/components/style/properties/longhand/inherited_ui.mako.rs
rename : servo/components/style/values/generics/pointing.rs => servo/components/style/values/generics/ui.rs
extra : rebase_source : c69db288acdf60b2e480a61dc6637b427aa9a5e3
2018-05-09 16:07:36 +10:00
Xidorn Quan
8de2621296
Bug 1454591 part 3 - Consistently use top-right-bottom-left order for physical sides. r=heycam
...
MozReview-Commit-ID: 6pLRSO8YNDI
--HG--
extra : rebase_source : 4c8ce8560c2112d2378a12b34ae2241e2e25eed4
2018-05-04 15:15:56 +10:00
Emilio Cobos Álvarez
0baa408319
Bug 1459436
: Remove a useless unit test that no longer compiles. r=emilio
...
We have WPT and integration tests for the functionality in mozilla-central.
MozReview-Commit-ID: L0vdF3tfT83
2018-05-05 18:07:56 +02:00
Emilio Cobos Álvarez
71a7af886c
Bug 1459436
: Remove some unneeded cfg(..). r=emilio
...
The less not-compiled code in common builds, the better for everybody.
MozReview-Commit-ID: 3JQfz6AYhPG
2018-05-05 18:07:46 +02:00
Emilio Cobos Álvarez
d6f79cd48e
Bug 1459436
: Implement Debug for KeyframeAnimationStyle by hand. r=emilio
...
The ComputedValues format is huge and unneeded.
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
MozReview-Commit-ID: 44OuCMWJPLk
2018-05-05 18:07:37 +02:00
Emilio Cobos Álvarez
6ee6a58a0f
Bug 1459436
: Fix servo build. r=emilio
...
MozReview-Commit-ID: Ex5RKgPgd8x
2018-05-05 18:07:28 +02:00
Emilio Cobos Álvarez
68affa51a4
Bug 1459436
: Fix tidy issues. r=emilio
...
MozReview-Commit-ID: KXInHzAiiD8
2018-05-05 18:07:18 +02:00
Emilio Cobos Álvarez
73331875c7
Bug 1458814: followup: remove some unused imports. r=me
...
MozReview-Commit-ID: KMmH0ATu5Df
2018-05-05 17:55:52 +02:00
Emilio Cobos Álvarez
27ca8b58c8
Bug 1458814: Remove code that is no longer called. r=hiro
...
Au revoir!
MozReview-Commit-ID: DjqszUSIzXs
2018-05-05 16:31:20 +02:00
Emilio Cobos Álvarez
ceca84ff64
Bug 1458814: Remove a bit of trivially dead code. r=hiro
...
MozReview-Commit-ID: GG41v4TejBU
2018-05-05 16:31:19 +02:00
Emilio Cobos Álvarez
d7f92df0f2
Bug 1458814: Make SMIL values not roundtrip through strings. r=hiro
...
MozReview-Commit-ID: DpbFSutIv3t
2018-05-05 16:31:17 +02:00
Xidorn Quan
5bba37b212
Bug 1457524 part 4 - Allow 16% false positives in test bloom::create_and_insert_some_stuff. r=heycam
...
It seems that the result of hash algorithm used in bloom filter depends
on the pointer length. On 64bit platforms, there are 135 false positives
in the first part of that test, and 8 in the second part. However, on
32bit platforms, the numbers become 157 and 16 correspondingly.
16 is still less than 20% in the second part, so all fine, but 157 is
slightly larger than 15% in the test assertion. Given it is what we are
shipping, we probably should just accept this and loosen the assertion.
MozReview-Commit-ID: 9kFXBzLFAzE
--HG--
extra : rebase_source : 41fa45dc3c59b2f44d33bdbe86b3eb2e29a31319
2018-05-02 21:07:07 +10:00
shindli
8fad8a2218
Merge inbound to mozilla-central. a=merge
2018-05-04 11:35:37 +03:00
Noemi Erli
6e6ddaaf1f
Backed out 4 changesets (bug 1458814) for failres in builds/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/smil/style/anim-css-strokewidth-1-to-pct-pct.svg on a CLOSED TREE
...
Backed out changeset d0990dff4fc4 (bug 1458814)
Backed out changeset c61d211a9f1d (bug 1458814)
Backed out changeset e7f7ea7ab4af (bug 1458814)
Backed out changeset 9ac18a3eeaa5 (bug 1458814)
2018-05-04 08:39:52 +03:00
Ciure Andrei
9be98c9d63
Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE
2018-05-04 00:56:01 +03:00
Jonathan Watt
cfe84bdd1c
Bug 1458219 - Remove the 'property_name' macro. r=xidorn
2018-04-25 14:54:26 +01:00
Emilio Cobos Álvarez
391b338b94
Bug 1457678: Make the font canvas code not mess with the rule tree. r=xidorn,hiro
...
Inserting a lot of rules in the root level is super-inefficient. This fixes it
by not doing it.
It gives the root rule node to the style, but that's fine, since it's useless.
All this code-path is already pretty messy.
MozReview-Commit-ID: GoGHI4YJbKr
2018-05-04 05:50:21 +02:00
Emilio Cobos Álvarez
a3a9886c6b
Bug 1458814: Remove code that is no longer called. r=hiro
...
Au revoir!
MozReview-Commit-ID: DjqszUSIzXs
--HG--
extra : rebase_source : b81bb905449eb1e4d7cbc1094da9a151011b0350
2018-05-03 18:47:47 +02:00
Emilio Cobos Álvarez
0566c42687
Bug 1458814: Remove a bit of trivially dead code. r=hiro
...
MozReview-Commit-ID: GG41v4TejBU
--HG--
extra : rebase_source : 5dc1f255178ae723eed47ec3fdbd6595fa84da62
2018-05-03 18:41:17 +02:00
Emilio Cobos Álvarez
d97d041be2
Bug 1458814: Make SMIL values not roundtrip through strings. r=hiro
...
MozReview-Commit-ID: DpbFSutIv3t
--HG--
extra : rebase_source : 034bb584fcb3f6b67a6b38f70149e167ba0c300c
2018-05-03 18:27:44 +02:00
Emilio Cobos Álvarez
da45aa5fed
Bug 1458927: Fix perspective squared distance computation. r=hiro
...
MozReview-Commit-ID: YwjTheRonB
--HG--
extra : rebase_source : d3734aad5d37dda1ccaf24f1f84e2f0972e45f5d
2018-05-03 17:43:30 +02:00
Emilio Cobos Álvarez
b448f93568
Bug 1458715: followup: don't fix distance computation so fast. r=me
...
On a CLOSED TREE
MozReview-Commit-ID: 1Y3As81hnRx
2018-05-03 17:38:42 +02:00
Emilio Cobos Álvarez
b22479d43d
Bug 1458715: Fix perspective interpolation. r=hiro
...
It's not sound to insert random matrices in random positions in the transform
operation list.
I cannot make any sense of what the old code was trying to do.
MozReview-Commit-ID: 5BtCiueEPlR
2018-05-03 16:45:07 +02:00
Emilio Cobos Álvarez
c556ec7ad0
Bug 1457920: Remove ServoStyleSheet usage. r=xidorn
...
MozReview-Commit-ID: LIBkovuQ6MB
2018-05-02 04:13:26 +02:00
Emilio Cobos Álvarez
2a42c4ed18
Bug 1457920: Merge ServoStyleSheet and StyleSheet. r=xidorn
...
These are the most minimal changes I could make. More cleanups incoming.
MozReview-Commit-ID: AdMOA1acQIH
2018-05-02 04:13:10 +02:00
Emilio Cobos Álvarez
adc46229a3
Bug 1018269: Handle Shadow DOM in keyframes lookup. r=heycam
...
MozReview-Commit-ID: AeUmsOHOUYR
2018-05-01 13:01:23 +02:00
Emilio Cobos Álvarez
8da32ee8b3
Bug 1457635
: Remove values::Verbatim. r=xidorn
...
No point of having two things that do the same.
MozReview-Commit-ID: Do1L4bvOeVQ
2018-04-30 05:10:48 +02:00
Emilio Cobos Álvarez
3058209ae5
Bug 1457635
: Move represents_keyword to the css attributes. r=xidorn
...
MozReview-Commit-ID: 21yuU4h34AQ
2018-04-30 05:10:37 +02:00
Emilio Cobos Álvarez
42257e0c21
Bug 1457332: Derive ToCss for Counters. r=xidorn
...
MozReview-Commit-ID: 1jOglcqt1Dd
2018-04-30 05:10:22 +02:00
Xidorn Quan
f2ba299166
Bug 1448759 part 1 - Make KTableEntry an independent type. r=heycam
...
MozReview-Commit-ID: oZfJAigThN
--HG--
extra : rebase_source : 6a0efbf40fed8c9eaba7bb3af74d281b536677c8
2018-04-29 21:17:26 +10:00
Emilio Cobos Álvarez
b52948e2af
No bug - Fix tidy issues and Servo build, and fix unit test bustage. r=me
...
MozReview-Commit-ID: 7MFLnVZmZUg
2018-04-29 05:20:27 +02:00
Emilio Cobos Álvarez
c2ca86b566
No bug - Change the configuration of some properties for servo. r=me
...
MozReview-Commit-ID: FxJQrXziRK0
2018-04-29 02:43:47 +02:00
Emilio Cobos Álvarez
289dbdc04a
No bug - Derive an attribute for servo. r=me
...
MozReview-Commit-ID: DQBJeg3xbuM
2018-04-29 02:30:59 +02:00
Emilio Cobos Álvarez
4fa6110947
No bug - Reorder an import to sync with servo. r=me
...
MozReview-Commit-ID: 4BLELl3T54p
2018-04-29 02:29:39 +02:00
Emilio Cobos Álvarez
3485ba7bff
No bug - Get rid of an import and sync with servo. r=me
...
MozReview-Commit-ID: 5aGNna6ulsM
2018-04-29 02:29:36 +02:00
Emilio Cobos Álvarez
afc1297f6d
No bug - sync some changes from servo. r=me
...
MozReview-Commit-ID: HyRI5CfZh5w
2018-04-29 01:59:00 +02:00
Xidorn Quan
9d288a4ae2
Bug 1434130 part 12 - Manually implement collect_completion_keywords for some types. r=emilio
...
MozReview-Commit-ID: 6T35uylxgho
--HG--
extra : source : b638793227b9f6317b540670227d68ad90a76173
2018-04-29 09:03:31 +10:00
Xidorn Quan
c873376fd5
Bug 1434130 part 11 - Add some attributes for SpecifiedValueInfo to help deriving more from types. r=emilio
...
MozReview-Commit-ID: IyohSTbUO31
--HG--
extra : source : 2af95ecd7e1f48bf54a93573a68a9d3f29393e42
2018-04-29 09:03:31 +10:00
Xidorn Quan
cd8a6cc5fc
Bug 1434130 part 10 - Handle keywords for color values. r=emilio
...
MozReview-Commit-ID: 5GvIHSeQuCX
--HG--
extra : source : 524796e355b2221343b96a77c7a00abd2eb41af7
2018-04-29 09:03:31 +10:00
Xidorn Quan
bb381a4356
Bug 1434130 part 9 - Use unified list for TextDecorationLine and implement its SpecifiedValueInfo. r=emilio
...
MozReview-Commit-ID: 2sCnK1AecFk
--HG--
extra : source : adc038d9c64ae32ca74ecaa46ca5cf0b9d5fdb77
2018-04-29 09:03:31 +10:00
Xidorn Quan
ab9de25533
Bug 1434130 part 8 - Have TextAlign derive ToCss and unship char value from it. r=emilio
...
MozReview-Commit-ID: CXDnyqzjQkq
--HG--
extra : source : a78f97b583f55fb2373d9629b16883584d93cfd1
2018-04-29 09:03:31 +10:00
Xidorn Quan
2cddea6516
Bug 1434130 part 7 - Have Parse derive respect #[css(skip)] on variant as well and derive Parse for KeywordSize. r=emilio
...
MozReview-Commit-ID: evSvk1RQGe
--HG--
extra : source : 19f96541b1c1d147d92bf055b36abe4a7ed5c43d
2018-04-29 09:03:31 +10:00
Xidorn Quan
46ea7a41bd
Bug 1434130 part 6 - Allow shorthands to specify their own impl of SpecifiedValueInfo and manual impl it for font and border. r=emilio
...
MozReview-Commit-ID: 3B9OfkWU0Eq
--HG--
extra : source : fe72d293e8420ddb903883fb6c0b5970aead6a26
2018-04-29 09:03:31 +10:00
Xidorn Quan
7fc9b978c6
Bug 1434130 part 5 - Derive ToCss for values::generics::font::KeywordSize. r=emilio
...
MozReview-Commit-ID: 9ek3PcqYiU3
--HG--
extra : source : 29990f9171efe771ea4d09fd129d37a4a1ec3870
2018-04-29 09:03:31 +10:00
Xidorn Quan
af03b6b3eb
Bug 1434130 part 4 - Use unified lists to impl several bitflag font-variant properties. r=emilio
...
This also changes their ToCss impl to use SequenceWriter instead of
checking has_value manually.
SpecifiedValueInfo for those types are also implemented in this patch.
MozReview-Commit-ID: 23h2VWS417H
--HG--
extra : source : f2c10917b105912bbe5fa06a986bbce08ebceac4
2018-04-29 09:03:31 +10:00
Xidorn Quan
9842a32733
Bug 1434130 part 3 - Add SequenceWriter::item_str for writing str items. r=emilio
...
This will be used in the next patch for font-variant bitflag types.
MozReview-Commit-ID: 2IvcsnYBNqA
--HG--
extra : source : a4cd0a8db99c2a46af183d44807dffb2a1a88e3f
2018-04-29 09:03:31 +10:00
Xidorn Quan
aa75ec745f
Bug 1434130 part 2 - Add collect_values function to SpecifiedValueInfo trait for collecting possible values. r=emilio
...
This is the basic structure of the stuff. Following patches will fill
the gap between Gecko and Servo on value generating, and finally hook
it into InspectorUtils.
MozReview-Commit-ID: KNLAfFBiY6e
--HG--
extra : source : e9e5d72857746710ead3cd42481b805efc771389
2018-04-29 09:03:31 +10:00
Xidorn Quan
0192f05add
Bug 1434130 part 1 - Skip system font variant for ToCss in font subproperties. r=emilio
...
System font keywords are not a valid value for those properties.
The newly-added #[css(skip)] would be reused by deriving algorithm of
SpecifiedValueInfo to skip them as well.
MozReview-Commit-ID: EmnhkaA9RR5
--HG--
extra : source : d2fc92ed32f497ff6826228181b19787c1b48cc4
2018-04-29 09:03:31 +10:00
Emilio Cobos Álvarez
1915a41571
Bug 1457652: Fix serialization order of the outline shorthand. r=xidorn
...
This is going to be tested in
https://github.com/w3c/web-platform-tests/pull/10700 .
MozReview-Commit-ID: 7Oi1it70YFw
2018-04-28 15:41:17 +02:00
Dorel Luca
69408b00d8
Backed out changeset 2a03e9effe84 (bug 1457652) for WPT failures on /css/cssom/shorthand-values.html
2018-04-28 14:54:16 +03:00