Commit Graph

289 Commits

Author SHA1 Message Date
Greg Tatum
45bc20f472 Bug 1734679 - Fix regression for XSLT sorting with an invalid language tag; r=platform-i18n-reviewers,dminor
This includes an integration test as well as a unit test, so hopefully
this will not regress again in the future.

Differential Revision: https://phabricator.services.mozilla.com/D127983
2021-10-08 19:10:48 +00:00
Andi-Bogdan Postelnicu
2fc4f70e9b Bug 1725145 - Preparation for the hybrid build env. r=necko-reviewers,firefox-build-system-reviewers,valentin,glandium
Automatically generated path that adds flag `REQUIRES_UNIFIED_BUILD = True` to `moz.build`
when the module governed by the build config file is not buildable outside on the unified environment.

This needs to be done in order to have a hybrid build system that adds the possibility of combing
unified build components with ones that are built outside of the unified eco system.

Differential Revision: https://phabricator.services.mozilla.com/D122345
2021-08-25 10:46:17 +00:00
Greg Tatum
418e9b4700 Bug 1719550 - Remove nsCollation; r=platform-i18n-reviewers,nordzilla
All the call sites now use mozilla::intl::Collator

Differential Revision: https://phabricator.services.mozilla.com/D121435
2021-08-10 16:01:19 +00:00
Narcis Beleuzu
daed5248e2 Backed out 12 changesets (bug 1719550) for bustages on TestCollator.cpp . CLOSED TREE
Backed out changeset 3b2735a29138 (bug 1719550)
Backed out changeset 5e2019335244 (bug 1719550)
Backed out changeset 105676dd2d6f (bug 1719550)
Backed out changeset b4b0d58778e9 (bug 1719550)
Backed out changeset 3ef5792020bb (bug 1719550)
Backed out changeset 389a77da6ddc (bug 1719550)
Backed out changeset 48f39b5ef77f (bug 1719550)
Backed out changeset bd125cc5b9b4 (bug 1719550)
Backed out changeset a8b778ca2375 (bug 1719550)
Backed out changeset b14702168fb9 (bug 1719550)
Backed out changeset 7b46b5cc7424 (bug 1719550)
Backed out changeset 6b04162618a1 (bug 1719550)
2021-08-10 17:46:34 +03:00
Greg Tatum
e7657ad036 Bug 1719550 - Remove nsCollation; r=platform-i18n-reviewers,nordzilla
All the call sites now use mozilla::intl::Collator

Differential Revision: https://phabricator.services.mozilla.com/D121435
2021-08-10 11:46:38 +00:00
JMM
22f3732905 Bug 1672548 - Add weekday skeleton to DateTimeFormat::FormatDateTime(). r=gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D119545
2021-07-09 19:54:56 +00:00
Dan Minor
db62540452 Bug 1706318 - Rename connector pattern override preference; r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D112815
2021-04-26 18:11:59 +00:00
Dan Minor
05acd763f8 Bug 1676137 - Remove intl.uidirection pref; r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D108789
2021-03-29 14:22:52 +00:00
Dan Minor
57ae936f38 Bug 1420335 - Make OSPreferences::ReadDateTimePattern check 12h/24h on Android; r=zbraniecki
As is the case with GTK, Android provides an OS override to display times in
AM/PM or 24 hour format. This moves the code for rewriting skeletons from the
GTK specific code to OSPreferences, and calls it from the Android OSPreferences
implementation.

This was tested manually by visiting the file:/// uri. I don't believe this is
feasible to test from automation, as it would require changing Android OS settings
from within our test code.

Differential Revision: https://phabricator.services.mozilla.com/D101641
2021-01-15 19:28:12 +00:00
Bogdan Tara
60482b14fc Backed out changeset dc9229077eaa (bug 1420335) for security/manager* and toolkit/mozapps/* xpc failures CLOSED TREE 2021-01-14 18:43:19 +02:00
Dan Minor
487bcdd4ea Bug 1420335 - Make OSPreferences::ReadDateTimePattern check 12h/24h on Android; r=zbraniecki
As is the case with GTK, Android provides an OS override to display times in
AM/PM or 24 hour format. This moves the code for rewriting skeletons from the
GTK specific code to OSPreferences, and calls it from the Android OSPreferences
implementation.

This was tested manually by visiting the file:/// uri. I don't believe this is
feasible to test from automation, as it would require changing Android OS settings
from within our test code.

Differential Revision: https://phabricator.services.mozilla.com/D101641
2021-01-14 13:45:40 +00:00
Dan Minor
1465995b22 Bug 1685804 - Use nsIGSettingsService in OSPreferences_gtk; r=zbraniecki
This switches over to using nsIGSettingsService. This makes the gtest results
on gtk based systems depend on the current OS settings, so the test expectations
are adjusted to accept both AM/PM and 24h settings.

Differential Revision: https://phabricator.services.mozilla.com/D101362
2021-01-12 14:20:07 +00:00
Dan Minor
0790cac85a Bug 1681357 - Use regional prefs locale if locale is not specified in GetDateTimePattern; r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D99241
2020-12-09 16:50:14 +00:00
Dan Minor
57441aa8cc Bug 1673054 - Migrate uses of intl.uidirection to intl.l10n.pseudo; r=Gijs,zbraniecki
This also removes pref overrides from methods like LocaleService::IsLocaleRTL or
IntlService.getLocaleInfo, because it doesn't really make sense to override the
result of checking an arbitrary locale, the relevant use case is overriding the
result for the current app locale.

Removal of the intl.uidirection pref completely will be done in a separate bug.

Differential Revision: https://phabricator.services.mozilla.com/D96235
2020-11-09 15:33:39 +00:00
Dan Minor
492a70088c Bug 1674212 - Add override pref for date time connector pattern; r=zbraniecki
This adds an override pref for the connector pattern used when combining dates
and times. It also fixes a test which was relying upon a hard-coded connector
pattern.

Differential Revision: https://phabricator.services.mozilla.com/D95278
2020-11-02 12:36:04 +00:00
Dan Minor
429ae74074 Bug 1426907 - Add OSPreferences::OverrideDateTimePattern method; r=zbraniecki
This new method allows for the user to override the long and short date and
time patterns by prefs. If no overrides are set or it fails while processing
the prefs, it will fallback to the existing methods for determining the patterns.
Since the user may have only overriden one of date or time, it is necessary to
be able to look up the other separately and combine the results.

This adds a prefix callback that watches the new prefs and flushes the cache if
they change. Otherwise, the user would have to restart the browser to see the
results of changing a pref, and would make testing more difficult. Unregistering
this callback required changes to the destructor, which was previously defined
separately on each operating system. A new RemoveObservers method has been added
to handle OS specific cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D94433
2020-10-27 20:41:58 +00:00
Dan Minor
686b723d0d Bug 1426907 - Update OSPreferences API to use UTF-8 rather than UTF-16; r=zbraniecki
We'll want to use UTF-8 when we switch to using ICU4x because Rust is all UTF-8. We
can switch the external facing APIs now, and update the internal implementations
later.

Differential Revision: https://phabricator.services.mozilla.com/D94850
2020-10-27 20:45:19 +00:00
Dan Minor
f66c096d75 Bug 1426907 - Rework DateTimeFormat gtests to not rely on hard-coded connector patterns; r=zbraniecki
The connector patterns can change over time, we should instead check for the date time components
that we expect to be present.

Differential Revision: https://phabricator.services.mozilla.com/D94849
2020-10-27 20:39:57 +00:00
Ricky Stewart
02a7b4ebdf Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
c0cea3b0fa Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
50762dacab Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Dan Minor
a67119a8ad Bug 1669573 - Replace kDateFormatYearMonth/kDateFormatYearMonthLong with FormatDateTime; r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D93013
2020-10-15 12:19:42 +00:00
Dan Minor
c7c8e3f274 Bug 1669573 - Rename kTimeFormatSeconds and kTimeFormatNoSeconds; r=zbraniecki
This renames kTimeFormatSeconds to kTimeFormatLong and kTimeFormatNoSeconds to
kTimeFormatShort. This is consistent with the naming used for date format
selectors.

Differential Revision: https://phabricator.services.mozilla.com/D93011
2020-10-15 12:20:15 +00:00
Dan Minor
9cd711db66 Bug 1669573 - Replace kDateFormatMonthLong/kDateFormatWeekday with GetCalendarSymbol; r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D93010
2020-10-15 12:19:52 +00:00
Dan Minor
da71b8a478 Bug 1669573 - Call DeleteCache when changing locale in TestDateTimeFormat; r=zbraniecki
The formatters in mFormatCache are only valid for the locale in which they were
created. Currently the tests change mLocale directly but leave the cache in
place which can lead to incorrect test results depending upon which tests are
executed. This is not a problem outside of the tests because mLocale is normally
only set once during the call to Initialize() which will not change the current
locale once it is set.

Differential Revision: https://phabricator.services.mozilla.com/D93009
2020-10-15 12:19:47 +00:00
Zibi Braniecki
51dd2eebad Bug 1662309 - Update fluent-rs to 0.12. r=kamidphish
Differential Revision: https://phabricator.services.mozilla.com/D88942
2020-09-02 20:06:41 +00:00
Makoto Kato
7472376d24 Bug 1650698 - Convert test_collation.js to gtest. r=jfkthame
test_collation.js uses nsICollation and nsICollationFactory from script, but
I would like to make it non-scriptable. Actually, it is only used from
xpcshell tests.

Differential Revision: https://phabricator.services.mozilla.com/D82310
2020-07-06 07:55:32 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Zibi Braniecki
1722cb0755 Bug 1645045 - Don`t assume the last fallback is the last locale in gtest. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D79313
2020-06-11 18:40:35 +00:00
Ed Lee
acb960676c Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128

--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
Zibi Braniecki
9d26727a4e Bug 1607052 - Unify language identifier canonicalization in LocaleService and OSPreferences to use unic_langid, and extend GTK's RegionalPrefs reading to fallback on SystemLocales. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D63393

--HG--
extra : moz-landing-system : lando
2020-02-21 00:39:18 +00:00
Noemi Erli
04fcf27147 Backed out changeset 4f406ca4f899 (bug 1607052) for causing xpcshell failures in test_localeService.js CLOSED TREE
--HG--
extra : rebase_source : c91f40748db91ac3563bd0215f4e707912553502
2020-02-21 02:19:32 +02:00
Zibi Braniecki
374e0856d0 Bug 1607052 - Unify language identifier canonicalization in LocaleService and OSPreferences to use unic_langid, and extend GTK's RegionalPrefs reading to fallback on SystemLocales. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D63393

--HG--
extra : moz-landing-system : lando
2020-02-20 22:19:42 +00:00
Noemi Erli
27e963773a Backed out changeset c3e43b7b1376 (bug 1607052) for causing leaks CLOSED TREE 2020-02-20 20:17:46 +02:00
Zibi Braniecki
c7b7faf558 Bug 1607052 - Unify language identifier canonicalization in LocaleService and OSPreferences to use unic_langid, and extend GTK's RegionalPrefs reading to fallback on SystemLocales. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D63393

--HG--
extra : moz-landing-system : lando
2020-02-20 17:35:06 +00:00
Mark Banner
0007396a1a Bug 1613139 - Enable ESLint for intl/locale and intl/strres (manual changes). r=zbraniecki
Depends on D61580

Differential Revision: https://phabricator.services.mozilla.com/D61581

--HG--
extra : moz-landing-system : lando
2020-02-04 15:33:24 +00:00
Mark Banner
c4d713de2b Bug 1613139 - Enable ESLint for intl/locale and intl/strres (automatic changes). r=zbraniecki
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D61580

--HG--
extra : moz-landing-system : lando
2020-02-05 09:04:33 +00:00
Gabriele Svelto
69790bc62e Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55443

--HG--
extra : moz-landing-system : lando
2019-12-06 09:16:44 +00:00
Zibi Braniecki
85728020f5 Bug 1581960 - Use fluent-locale-rs for LocaleService::NegotiateLanguages. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D49991

--HG--
extra : moz-landing-system : lando
2019-11-19 23:07:08 +00:00
Zibi Braniecki
39cfaa9784 Bug 1571915 - Switch MozLocale to use unic-langid. r=emilio,jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D49668

--HG--
extra : moz-landing-system : lando
2019-11-19 23:04:06 +00:00
Moritz Birghan
975648e245 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-11-18 13:03:58 +00:00
Boris Zbarsky
59e9c84c17 Bug 1588260 part 2. Switch nsICollation away from using xpidl [array]. r=peterv,emk
Differential Revision: https://phabricator.services.mozilla.com/D49052

--HG--
extra : moz-landing-system : lando
2019-11-11 18:03:42 +00:00
Coroiu Cristina
27a753cc4a Backed out changeset 96048cce4b80 (bug 1571656) for xpcshell failures at toolkit/components/places/tests/unifiedcomplete/test_autofill_origins.js on a CLOSED TREE 2019-11-06 22:59:45 +02:00
Moritz Birghan
70c7a633fb Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-11-06 18:07:54 +00:00
Geoff Brown
dcb380399e Bug 1582785 - Enable some xpcshell tests on Android; r=geckoview-reviewers,agi
Most of these tests have been disabled for a long time; they run well
in the current test environment.

Differential Revision: https://phabricator.services.mozilla.com/D46642

--HG--
extra : moz-landing-system : lando
2019-09-23 22:43:55 +00:00
Ciure Andrei
9a123fb597 Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE 2019-08-19 13:00:44 +03:00
Moritz Birghan
240771fa29 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-08-19 07:17:12 +00:00
Masatoshi Kimura
d729945e0b Bug 1557930 - Stop using ACString parameters in mozILocaleService and tests. r=zbraniecki
* `negotiateLanguages` should not silently truncate non-Latin1 chars.
* `setCharPref` will silently truncate non-Latin1 chars.
* Fixed JS extra warnings while I am here.

Differential Revision: https://phabricator.services.mozilla.com/D34273

--HG--
extra : moz-landing-system : lando
2019-06-08 17:21:58 +00:00