Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 21:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
765,936 Commits 615 Branches 98 Tags 6 GiB
4607b0e1be
Commit Graph

10987 Commits

Author SHA1 Message Date
Makoto Kato
49cc605308 Bug 1719110 - Don't use sync IPC to show suggestion by spellchecker. r=Gijs 
CheckCurrentWord on content process causes sync IPC, so I would like to remove
this call on content process. New nsIEditorSpellChecker.suggest method can
avoid it.

Differential Revision: https://phabricator.services.mozilla.com/D119937
 2021-08-10 03:55:25 +00:00
Makoto Kato
a6944a1428 Bug 1719110 - Add nsIEditorSpellCheck.suggest to get rid of PRemoteSpellcheckEngine.CheckAndSuggest. r=masayuki 
When getting suggestions from spellchecker's result, we use sync IPC
(`PRemoteSpellcheckEngine.CheckAndSuggest`). This is used by showing context
menu only on Gecko. So I think that we can remove this IPC if we add async API
to get spellchecker suggestions.

And in comm-central's code, `CheckCurrentWord` and `GetSuggestedWord` seems to
use on spellchecker dialog (content/dialogs/EdSpellCheck.js in mail and suite)
that runs on parent process. So c-c won't use this IPC method.

So I would like to add the promise version of getting spellchecker's
suggestion.

Differential Revision: https://phabricator.services.mozilla.com/D119936
 2021-08-10 03:55:25 +00:00
Paul Zuehlcke
f6f5a3bca5 Bug 1721665 - Do not overwrite private browsing permission lifetime when removing permissions. r=timhuang,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D121749
 2021-08-09 14:46:07 +00:00
Paul Zuehlcke
e5b57b5d4c Bug 1706292 - Do not clone principal for CookieJarSettings cookie permission check. r=timhuang,ckerschb 
For every cookie permission check CookieJarSettings::CookiePermission has to create a new principal.
This is slow. It uses a cloned principal so it can strip the origin attributes which should not be
used for the permission check.
With this patch we no longer need to clone the principal. We pass in the original principal and perform
the OA stripping on an OA copy in BasePrincipal::EqualsForPermission.
Before, EqualsForPermission was guaranteed to get a content principal, because ClonePrincipalForPermission
enforced it. BasePrincipal::EqualsForPermission was refactored to account for non content principals.

Differential Revision: https://phabricator.services.mozilla.com/D120834
 2021-07-30 15:01:07 +00:00
Michelle Goossens
c638f51ce3 Bug 1718292 - Part 1: Disable failing xpcshell tests on Windows 10 2004 r=jmaher,necko-reviewers,dragana 
Differential Revision: https://phabricator.services.mozilla.com/D119633
 2021-07-26 16:38:22 +00:00
Mike Hommey
e2a1db5178 Bug 1713735 - Add the bits necessary to build wasm sandbox libs with wasm2c. r=firefox-build-system-reviewers,mhentges 
For the moment, it's opt-in via explicitly setting `LUCETC` to an empty
string.

Differential Revision: https://phabricator.services.mozilla.com/D119939
 2021-07-16 02:38:41 +00:00
Tooru Fujisawa
cc92ef732d Bug 1708448 - Move property and element functions into js/public/PropertyAndElement.h. r=nbp 
Differential Revision: https://phabricator.services.mozilla.com/D119619
 2021-07-13 11:52:42 +00:00
Masayuki Nakano
1fc0882ecc Bug 1718607 - Make TextServicesDocument use uint32_t for offset in DOM node r=m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D118955
 2021-06-30 09:07:35 +00:00
Mike Hommey
744db845c6 Bug 1700534 - Coalesce RLBox wasmboxed libraries. r=firefox-build-system-reviewers,shravanrn,bholley,andi,mhentges 
Differential Revision: https://phabricator.services.mozilla.com/D116440
 2021-06-22 05:31:33 +00:00
Masayuki Nakano
c0624f4771 Bug 1713757 - Make mozInlineSpellChecker, mozInlineSpellWordUtil and TextServicesDocument use EditorBase instead of TextEditor r=m_kato 
Depends on D117117

Differential Revision: https://phabricator.services.mozilla.com/D117118
 2021-06-09 09:02:31 +00:00
Deian Stefan
1030b2a3e3 Bug 1653659 - Part 3: Only allow non-empty paths in RLBoxHunspell r=tjr 
Differential Revision: https://phabricator.services.mozilla.com/D116547
 2021-06-08 17:45:26 +00:00
Julian Descottes
7240e461cc Bug 1715123 - Remove unused method broadcastPermissionsForPrincipalToAllContentProcesses in PermissionManager r=timhuang,necko-reviewers,dragana 
Depends on D116850

Differential Revision: https://phabricator.services.mozilla.com/D116852
 2021-06-08 08:08:48 +00:00
Dylan Roeh
9aee13c478 Bug 1699480 - Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D112042
 2021-06-07 17:57:24 +00:00
Alexandru Michis
e8904db16a Backed out 5 changesets (bug 1699480) for causing lint failures. 
CLOSED TREE

Backed out changeset 5ed626994de6 (bug 1699480)
Backed out changeset e4be23f4dbe9 (bug 1699480)
Backed out changeset 68b5f5c2f1e6 (bug 1699480)
Backed out changeset 425aa354f1ca (bug 1699480)
Backed out changeset e3005001299c (bug 1699480)
 2021-06-07 20:52:25 +03:00
Dylan Roeh
648ddb2f54 Bug 1699480 - Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D112042
 2021-06-07 17:02:26 +00:00
Valentin Gosu
aa5e042347 Bug 1682240 - Kill ntlm_auth process instead of waiting for it to complete r=necko-reviewers,kershaw 
This avoids hangs when the process might be unresponsive.

Differential Revision: https://phabricator.services.mozilla.com/D116715
 2021-06-07 07:15:37 +00:00
Brindusan Cristian
ca49f15f7d Backed out 14 changesets (bug 1705659, bug 472823, bug 669675) as requested by valentin for causing regressions. CLOSED TREE 
Backed out changeset d920aa17a468 (bug 669675)
Backed out changeset adad38c05584 (bug 1705659)
Backed out changeset 361c177ed131 (bug 1705659)
Backed out changeset 46e559f45338 (bug 1705659)
Backed out changeset 3c9556a8df55 (bug 1705659)
Backed out changeset a179695a56c9 (bug 1705659)
Backed out changeset e688986c7011 (bug 1705659)
Backed out changeset de990e6c944d (bug 1705659)
Backed out changeset 0ea348abee78 (bug 1705659)
Backed out changeset 2f0aacbd42b1 (bug 1705659)
Backed out changeset c977551bad6e (bug 1705659)
Backed out changeset 5449d9e08034 (bug 1705659)
Backed out changeset b6b51bc167ac (bug 1705659)
Backed out changeset 27e709923ecb (bug 472823)
 2021-05-31 13:16:34 +03:00
Mirko Brodesser
f271c866cf Bug 1687263: part 4) Defer and in some cases avoid removing spellchecking-ranges. r=smaug 
Removing ranges is expensive. This reduces flickering of the spelling
mistakes and prevents 100% CPU usage of 1 core on slower machines.

The essence of this patch is, that when text doesn't change, all
existing spellchecking ranges are reused.

Before this patch, removing ranges was done as part of the time slice in
`mozInlineSpellChecker::SpellCheckSlice`. That is, slow removals of
ranges contributed to the amount of words to be spellchecked
asynchronously.
Therefore, the amount of words to be spellchecked in one chunk could
increase from the minimum, `INLINESPELL_MINIMUM_WORDS_BEFORE_TIMEOUT` to
the maxium `INLINESPELL_MAXIMUM_CHUNKED_WORDS_PER_TASK`.
Consequently, the asynchronous checking might take longer. If that turns
out to be problematic, reducing
`INLINESPELL_MAXIMUM_CHUNKED_WORDS_PER_TASK` could be a fix.

Differential Revision: https://phabricator.services.mozilla.com/D116096
 2021-05-28 07:56:13 +00:00
Mirko Brodesser
81d2b2a2d9 Bug 1687263: part 3) Move removing ranges into CheckWordsAndUpdateRangesForMisspellings. r=smaug 
This might lead to increased exceeding of the time slice, because the
ranges are removed after the time limit was checked. Therefore, this
change should only be landed together with the following review which
will remove unnecessary remove- and add-operations for ranges. It's a
separate review only to simplify reviewing and potential debugging.

Differential Revision: https://phabricator.services.mozilla.com/D116095
 2021-05-28 07:56:13 +00:00
Mirko Brodesser
80b835b192 Bug 1687263: part 2) Add NodeOffsetRange::operator==(const nsRange& aRange). r=smaug 
The fix of bug 1687263 will require determining which `nsRange`s of a
previous time slice to keep and for which `NodeOffsetRange`s to create
new `nsRange`s. The operator will be used in a following review.

Differential Revision: https://phabricator.services.mozilla.com/D116094
 2021-05-28 07:56:12 +00:00
Mirko Brodesser
ed9c8cebed Bug 1687263: part 1) Add NodeOffset::operator==(const RangeBoundary). r=smaug 
Required for the following review.

Differential Revision: https://phabricator.services.mozilla.com/D116093
 2021-05-28 07:56:12 +00:00
Mirko Brodesser
59984954da Bug 1708422: part 21) Reduce scope of erv variable in mozInlineSpellChecker::SpellCheckerSlice::Execute. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D115687
 2021-05-26 10:04:36 +00:00
Mirko Brodesser
0694578bb0 Bug 1708422: part 20) Const-qualify some variables in mozInlineSpellChecker::SpellCheckerSlice::Execute. r=smaug 
Clearer.

Differential Revision: https://phabricator.services.mozilla.com/D115686
 2021-05-26 10:04:36 +00:00
Mirko Brodesser
93ac6f9a56 Bug 1708422: part 19) Replace output arguments with a single argument in mozInlineSpellWordUtil::GetNextWord. r=smaug 
Clearer and helps to simplify its caller.

Differential Revision: https://phabricator.services.mozilla.com/D115597
 2021-05-26 10:04:35 +00:00
Valentin Gosu
69c6a23516 Bug 1705659 - Static-analysis check auto fix for auth code r=necko-reviewers,dragana 
Depends on D112604

Differential Revision: https://phabricator.services.mozilla.com/D112605
 2021-05-26 09:27:21 +00:00
Valentin Gosu
16a4c26f4c Bug 1705659 - Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana 
Depends on D112601

Differential Revision: https://phabricator.services.mozilla.com/D112603
 2021-05-26 09:27:20 +00:00
Valentin Gosu
1fb3a73493 Bug 1705659 - Make auth code use nsACString instead of raw char pointers r=necko-reviewers,dragana 
Depends on D112597

Differential Revision: https://phabricator.services.mozilla.com/D112598
 2021-05-26 09:27:19 +00:00
Mirko Brodesser
40b6793a72 Bug 1700051: part 45) Remove outdated part of comment in <mozInlineSpellChecker.cpp>. r=smaug 
Depends on D113300

Differential Revision: https://phabricator.services.mozilla.com/D113301
 2021-05-25 10:08:15 +00:00
Masayuki Nakano
ae69b73075 Bug 1540037 - part 18: Move ReplaceTextAsAction() and ReplaceSelectionAsSubAction() to EditorBase r=m_kato 
They are used by setting text value of `TextEditor` or replacing a misspelled
word with a new word in both `TextEditor` and `HTMLEditor`.  Therefore,
they should be in the `EditorBase` rather than `TextEditor`.

Note that the path of the former case may be in a hot path.  Therefore, we need
to keep redirecting to `TextEditor` for keeping the performance only in the
case.

Depends on D115785

Differential Revision: https://phabricator.services.mozilla.com/D115786
 2021-05-25 04:26:14 +00:00
Mirko Brodesser
55db5ff457 Bug 1708422: part 18) Factor mozInlineSpellChecker::SpellCheckerSlice::IsInNoCheckRange out. r=smaug 
Hides details.

Differential Revision: https://phabricator.services.mozilla.com/D115469
 2021-05-20 13:00:01 +00:00
Mirko Brodesser
e74f6c42f1 Bug 1708422: part 17) Rename words to normalizedWords in mozInlineSpellChecker::SpellCheckerSlice::Execute. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D115366
 2021-05-20 09:03:30 +00:00
Mirko Brodesser
b05af40fa3 Bug 1708422: part 16) Rename mozInlineSpellChecker::SpellCheckerTimeSlice to mozInlineSpellChecker::SpellCheckerSlice. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D115352
 2021-05-20 09:03:30 +00:00
Mirko Brodesser
e5983d6bde Bug 1708422: part 14) Extend documentation of mozInlineSpellChecker::SpellCheckerTimeSlice::CheckWordsAndAddRangesForMisspellings. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D114333
 2021-05-20 09:03:29 +00:00
Mirko Brodesser
c080bbd4cc Bug 1708422: part 13) Factor code out to mozInlineSpellChecker::SpellCheckerTimeSlice::RemoveRanges. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D114332
 2021-05-20 09:03:28 +00:00
Mirko Brodesser
a89ff13783 Bug 1708422: part 12) Move some code into mozInlineSpellChecker::SpellCheckerTimeSlice::ShouldSpellCheckRange. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D114331
 2021-05-20 09:03:28 +00:00
Mirko Brodesser
9c30eeb984 Bug 1708422: part 11) Remove unnecessary block scope in mozInlineSpellChecker::SpellCheckerTimeSlice::Execute. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D114105
 2021-05-20 09:03:28 +00:00
Mirko Brodesser
ddbcce9316 Bug 1708422: part 10) Factor ShouldSpellCheckRange out. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D114104
 2021-05-20 09:03:27 +00:00
Mirko Brodesser
882cc710a4 Bug 1708422: part 9) Declare mozInlineSpellChecker::ShouldSpellCheckNode static. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D114103
 2021-05-20 09:03:27 +00:00
Mirko Brodesser
19a242b989 Bug 1708422: part 8) Move mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings. r=smaug 
Simplifies `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute`.

Differential Revision: https://phabricator.services.mozilla.com/D114102
 2021-05-20 09:03:26 +00:00
Mirko Brodesser
a2355f8bc1 Bug 1708422: part 7) Annotate mozInlineSpellChecker::SpellCheckerTimeSlice as MOZ_STACK_CLASS. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D114101
 2021-05-20 09:03:26 +00:00
Mirko Brodesser
92c6fda0fa Bug 1708422: part 6) Change some pointer members of mozInlineSpellChecker::SpellCheckerTimeSlice to references. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D114100
 2021-05-20 09:03:26 +00:00
Mirko Brodesser
d99bbf18cb Bug 1708422: part 5) Surround statements in mozInlineSpellChecker::SpellCheckerTimeSlice::Execute with curly braces. r=smaug 
To match the style guide.

Differential Revision: https://phabricator.services.mozilla.com/D114099
 2021-05-20 09:03:25 +00:00
Mirko Brodesser
4e3d4abbad Bug 1708422: part 4) Break out method object for mozInlineSpellChecker::DoSpellCheck. r=smaug 
Should help to simplify it. Please read the following reviews before
commenting on this one.

Differential Revision: https://phabricator.services.mozilla.com/D114098
 2021-05-20 09:03:25 +00:00
Dylan Roeh
d488467816 Bug 1699480 - Back out permissions changes at AC's request, r=geckoview-reviewers,agi 
Differential Revision: https://phabricator.services.mozilla.com/D115515
 2021-05-19 18:07:28 +00:00
Butkovits Atila
6b729f46ac Backed out 2 changesets (bug 1653659) for causing failures at test_hunspell.js. CLOSED TREE 
Backed out changeset 018859776d85 (bug 1653659)
Backed out changeset b187a1b158df (bug 1653659)
 2021-05-18 04:05:15 +03:00
Deian Stefan
351efdd226 Bug 1653659 - Part 3: Only allow non-empty paths in RLBoxHunspell r=tjr 
Differential Revision: https://phabricator.services.mozilla.com/D114925
 2021-05-17 18:19:27 +00:00
Dylan Roeh
ff4369ad7c Bug 1699480 - Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D112042
 2021-05-17 15:55:21 +00:00
Mirko Brodesser
ff7e90c539 Bug 1708422: part 3) Add some documentation to mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D114097
 2021-05-17 13:46:59 +00:00
Dorel Luca
6bb805571d Backed out 2 changesets (bug 1653659) for Mochitest failures in mochitest/events/test_focus_general.html. CLOSED TREE 
Backed out changeset 523e4bc2aa47 (bug 1653659)
Backed out changeset fac526423ccb (bug 1653659)
 2021-05-14 21:45:58 +03:00
Deian Stefan
a31d580731 Bug 1653659 - Part 3: Safely handle empty strings in RLBoxHunspell r=tjr 
Differential Revision: https://phabricator.services.mozilla.com/D114925
 2021-05-14 13:30:48 +00:00