To match the WebDriver specification error code names, this patch
renames the NoAlertOpenError type to NoSuchAlertError.
Its string error code (the status property) is still correct.
MozReview-Commit-ID: DhWz1tn6DsT
--HG--
extra : rebase_source : dd45387a5869a8df53f20baafe1c683c3af32b25
This drops the tests for Marionette protocol level 2. Protocol levels
below 2 were removed some time ago:
https://bugzilla.mozilla.org/show_bug.cgi?id=1409030
MozReview-Commit-ID: GsrdeldnoNH
--HG--
extra : rebase_source : 522d7a9c71545693ca2b662d0a6c715df0f2cd24
To match the WebDriver specification error code names, this patch
renames the NoAlertOpenError type to NoSuchAlertError.
Its string error code (the status property) is still correct.
MozReview-Commit-ID: DhWz1tn6DsT
--HG--
extra : rebase_source : b3da69e566f190c1a016dad7fccf655966779ab1
If Marionette throws inside try...catch block that spawns the TCP
listener, we fail to reset the altered recommended preferences to
their original state, leaving a possibility of tainting the profile.
By calling the uninitialisation code when an error is thrown we
ensure all relevant state gets reset.
MozReview-Commit-ID: XiiIEFMZQY
--HG--
extra : rebase_source : 1a38e446931c916af7f37ffc928683df47f0bba4
Marionette was previously uninitialised when xpcom-shutdown fired.
This may be too late to reset preferences and other state related
to the browser.
This patch moves Marionette to run uninitialisation code on
xpcom-will-shutdown.
MozReview-Commit-ID: 3ytX2k2rrOp
--HG--
extra : rebase_source : 6b9918515b48b2d1166cc985c5d5aeeb82937db0
Setting the MOZ_MARIONETTE environment variable is not a task that
naturally belongs to the TCP listener. This patch moves it to the
Marionette XPCOM component.
MozReview-Commit-ID: 7896Sv91wFy
--HG--
extra : rebase_source : a43335d289c2568f60be3ecc5a9491b2bee27fe9
Setting the recommended preferences is not a task specific to the
TCP listener. It makes more sense to set these in the Marionette
XPCOM component where we manage the Marionette lifetime.
MozReview-Commit-ID: G2RuLhKnX9X
--HG--
extra : rebase_source : 7b3651a682bf86ffe6435dfc35bfce980601aedb
Automatic update from web-platform-tests
This CL update the wpt test pointerevent_pointerlock_after_pointercapture.
Previously this test request pointer lock on pointermove, it got a
pointerlockerror event because it doesn't request the lock in a user gesture.
This CL change the test to send lock request by a right click.
Bug: 805052
Change-Id: I27b60475ccda94ca59e018ab76550379bc3852e4
Reviewed-on: https://chromium-review.googlesource.com/902450
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534689}
<!-- Reviewable:start -->
<!-- Reviewable:end -->
wpt-commits: 52f14853d759e760f7d39e235ffc43fac2cf76a3
wpt-pr: 9398
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2
Automatic update from web-platform-tests
…nse.
When the server sends something that's not parseable as JSON, the transport
tries to raise an exception with the unparseable response formatted as JSON.
This won't work, so just dump the HTTP response as a string in the exception.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/w3c/web-platform-tests/9399)
<!-- Reviewable:end -->
wpt-commits: 3b0f707a4695805ea7db1caa9b5e163ef7adec09
wpt-pr: 9399
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2
Automatic update from web-platform-tests
HTMLConstructionSite::InsertHTMLHtmlStartTagBeforeHTML() should use
"create an element" algorithm.
Test: Update builtin-coverage.html so that it tests elements parsed by
the document parser if they are unable to be tested with innerHTML
setter. Now it can test <html is=> and <body is=>.
Bug: 808311
Change-Id: I511edfa28750210d39b9e9a0fb711e245dc5737d
Reviewed-on: https://chromium-review.googlesource.com/903345
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534655}
<!-- Reviewable:start -->
<!-- Reviewable:end -->
wpt-commits: f36a06380d54d39ea7f998192eddac631dddb44d
wpt-pr: 9406
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2
Automatic update from web-platform-tests
Currently, we don't have any test coverage over properties. In our
existing tests, we only use 'canonical' test properties like 'width'.
This means that it's possible that other properties (e.g. 'height')
might not work and we still pass the tests.
We add a bunch of new files, each representing a property. Think of
these as metadata for the properties. For example, each file contains
the values that are valid for that property. We then have a test suite
that uses this metadata to generate appropriate tests.
More properties will be coming.
There is a test failure involving setting margin-top to unitless zero.
Bug: 774887
Change-Id: I8f8463c8f608454ef177e81ace21fe1eeb66f897
Reviewed-on: https://chromium-review.googlesource.com/882901
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534623}
<!-- Reviewable:start -->
<!-- Reviewable:end -->
wpt-commits: 7b7b881f37b51f061c6305a43dbd8b233def6796
wpt-pr: 9383
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2
Automatic update from web-platform-tests
In HTML parser, if custom element definition is not found and the
element local name is invalid for custom element name, custom element
state of the element was set to "Uncustomized", which won't be upgraded.
It should be "Undefined" if "is" attribute exists.
Also, CustomElementRegistry::AddCandidate() didn't pick up a correct
name for customized built-in candidates.
A Blink layout test for :defined is upstreamed to WPT.
Bug: 736967
Change-Id: I583073eabc4ac276c6990161516c7b289905909b
Reviewed-on: https://chromium-review.googlesource.com/903423
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534621}
<!-- Reviewable:start -->
<!-- Reviewable:end -->
wpt-commits: 82b5f595768924a47449fab01f75b0322f70c9e8
wpt-pr: 9405
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2
Automatic update from web-platform-tests
This shifts tests tagged to a section that was deferred from L3 to L4 to the section right above it (which covers this functionality).
<!-- Reviewable:start -->
<!-- Reviewable:end -->
wpt-commits: 8669e3b28464beeafeb5f25d5bf0980b95b3df71
wpt-pr: 9403
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2
Automatic update from web-platform-tests
According to https://drafts.csswg.org/cssom/#serialize-a-url, URLs should be serialized as a string (https://drafts.csswg.org/cssom/#serialize-a-string), which includes double quotes on each side. Correct the test to match the spec. Also update the link for the spec; the old link no longer exists.
<!-- Reviewable:start -->
<!-- Reviewable:end -->
wpt-commits: 4fd593f605711577d9046de1ab064ebc0700c229
wpt-pr: 9401
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2
Automatic update from web-platform-tests
CSSSkewX and CSSSkewY was added in spec.
because result of "skew(X,Y)" is different from
"skewX(X) skewY(Y)".
first of all, CSSSkewX was added at this CL.
and CSSSkewY is going to add at next patch.
https://drafts.css-houdini.org/css-typed-om-1/#cssskewx
Bug: 808321
Change-Id: I9214b06047f100c88999cba796d6c803545092c0
Reviewed-on: https://chromium-review.googlesource.com/899883
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#534541}
<!-- Reviewable:start -->
<!-- Reviewable:end -->
wpt-commits: 41d8dca3d059f171c7be7776d65da364812bb32d
wpt-pr: 9394
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2
Without returncode and wait() being overridden the default
implementation of the Runner class takes precedence and will
run the check for the adb command but not the remote process.
This always returns 0 because adb runs or forks itself as daemon.
Instead the remote process has to be checked for existence.
MozReview-Commit-ID: GvuAaMSxBT2
--HG--
extra : rebase_source : e84b52fdc9ce48617102650d6d0ae73e90899538
This is enough to get the stylo-enabled build green.
There's still some orange in WPT with stylo disabled (due to interfaces not
exposed and that) that I'll update tomorrow.
Will send a different patch on top of this for that, though I'll land together.
MozReview-Commit-ID: CsN5CM93RUz
Adds some links to the frontpage and an index that lists all the
internals.
MozReview-Commit-ID: HHk1YCtUMKU
--HG--
extra : rebase_source : 0c281d7f113748509a4d968b947bd460bfe78be1
Takes error descriptions from the WebDriver standard and uses them
to document error types in Marionette. This will make it possible
to generate an internals list of them.
MozReview-Commit-ID: EGxWOjOpjBm
--HG--
extra : rebase_source : e150833cdccb44a5ed7014c4bfe2cba3c8232569
This patch adds RST rules to auto-generate jsdoc in the Sphinx
documentation published to http://firefox-source-docs.mozilla.org/.
Some of the generation rules, especially element.rst, is quite
ugly because it appears JS modules all share the same namespace,
and there is already a conflict for element. We should investigate
this when it becomes a bigger problem.
MozReview-Commit-ID: IfGNMPXmPqG
--HG--
extra : rebase_source : d0db8e14ea68c9f23719dfae3f1579098c9b79e3
In the transport module there are two implementations of
WorkDebuggerTransport: one for the main thread and another that is
suitable for worker threads. This confuses JSDoc because they both
exist in the same anonymous scope.
MozReview-Commit-ID: 2UE4D6K97Qb
--HG--
extra : rebase_source : 7a774320db37a05b6d7a0934e53279af4361b198
This removes the "./mach marionette doc" command in favour of the
Sphinx-powered "./mach doc".
MozReview-Commit-ID: IODqDR4O1Dr
--HG--
extra : rebase_source : cfee834e6d10e59f34fc7d599facdb2eb6f4d363
Instead we will rely on the sphinx-js defaults.
MozReview-Commit-ID: CjcTwpTd4LH
--HG--
extra : rebase_source : fd1202fec9b8961458c75933705f58a682ab26d9
This removes statically generated API documentation for Marionette.
Subsequent commits will embed the API documentation with Sphinx.
DONTBUILD
MozReview-Commit-ID: 13LHrvoWIXT
--HG--
extra : rebase_source : 0d462ba4974bffce999f1a45cbe50c0b59823639
Importing this object is unnecessary after the updates to the WebIDL console from Bug 1425574
and the follow-ups blocking Bug 1430810. There are still callers that access Console.jsm
to create custom ConsoleAPI objects, but those will be handled separately.
MozReview-Commit-ID: 9ojFxtkpPId
--HG--
extra : rebase_source : 971bf99f709b8d2afe300f3693665724f747aa5e
We keep the XBL binding around for <content>, <constructor>, and <destructor>. This can
eventually be migrated to a Custom Element once we have platform support, but in the meantime
this is a way to get the many thousands of LOC into a JS class.
MozReview-Commit-ID: 1dCQp527yF9
--HG--
extra : rebase_source : 26b833413bab71168aa15e03f0f3803884be3f6b
extra : amend_source : 150cef6748ca8a9e819de0c674fac5966dd574cf
We shouldn't really have this problem, and shouting about it early will
make sure that we address issues like multiple instances of omni.ja,
rather than not recording information that we should have been.
Unlike Android installers, installers for desktop versions of Firefox
contain two copies of omni.ja, and the code to check for omni.ja was
ignoring both copies. Let's special-case omni.ja so we get better
numbers for our desktop platforms.
The zipfile and tarfiles paths for finding interesting files in the
installer have duplicated code. We can eliminate this duplicated code
by factoring out a function to just get the paths and sizes for files
contained in the installer. If we need to make changes to how paths are
processed, we now only have to make the change in a single place, and we
can add other kinds of installers easily in the future.
The output formatters provided by mozlog are well-documented in the
online help guide, but this information is not available to users in the
CLI. The `add_logging_group` method extends the consuming project's
command-line interface without referencing mozlog itself. This means
consumers may not have a means to discover the additional information,
and even in cases where they can infer this connection, there is no
indication of the stability of the behavior.
Extend the description of the built-in output formatters to explain
their origin and reference the relevant documentation.
--HG--
extra : histedit_source : 9069af86efc67232e059176f99a877c513644ce2
GTest supports the TEST macro, which just runs a bunch of tests, and the
TEST_F macro, which enables writing custom test fixtures to perform
per-test setup and teardown. The benchmarking framework we have has a
corresponding macro for the former, but no corresponding macro for the
latter. If there's significant work to be done during setup and
teardown, we certainly don't want to be doing that work during the
actual benchmarking! So let's introduce a MOZ_GTEST_BENCH_F macro that
works similarly to the TEST_F macro.
When opening the netmonitor, some pending requests may still occur after the toolbox is opened.
So that we overflow the expected number of requests we except during page reload.
MozReview-Commit-ID: If9okZONF8V
--HG--
extra : rebase_source : f4ca4f80079cbe0ef0d980f5d4a6900d8499dec8
This implements a chunk_by_manifest algorithm. It is similar to chunk_by_slice
in that it tries to make an even number of tests run in each chunk. However,
unlike chunk_by_slice it will guarantee that tests in the same manifest will
all run in the same chunk. This makes it suitable to use with run-by-manifest.
This means the chunks won't be perfect (as manifests are differnet sizes). It
is also prone to more randomization, similar to chunk-by-runtime.
In fact, this algorithm is nearly identical to the chunk-by-runtime one, so it
was refactored out to a base class.
MozReview-Commit-ID: HI2ByxW0i8V
--HG--
extra : rebase_source : e066c034b85222d26bafe6873a80366d5bd9df9e
According to the WebDriver standard the Element Send Keys command
should not run the unfocussing steps. Not blurring the element
causes the DOM "change" event not to fire, but the specification
only expects the "input" event to fire.
The standard does, however, expect the Element Clear command to
run the unfocussing steps and to blur the element for historical reasons.
MozReview-Commit-ID: FHD1whho0jT
--HG--
extra : rebase_source : a03f2befd3373a0e5a167deca012540887546a4b
Pass --appname org.mozilla.geckoview.test to 'mach mochitest' or
'mach reftest'. This runs the tests without e10s currently.
MozReview-Commit-ID: 7TIvA3zRCw2
Set pref datareporting.healthreport.uploadEnabled=false during mochitests
and set pref toolkit.telemetry.server to a dummy server during reftests
(uploadEnabled was already false for reftest and the telemetry server was
already set for mochitests - now these prefs are consistent).
Some mochitests failed with this change; they are updated to
set datareporting.healthreport.uploadEnabled where required.
The output formatters provided by mozlog are well-documented in the
online help guide, but this information is not available to users in the
CLI. The `add_logging_group` method extends the consuming project's
command-line interface without referencing mozlog itself. This means
consumers may not have a means to discover the additional information,
and even in cases where they can infer this connection, there is no
indication of the stability of the behavior.
Extend the description of the built-in output formatters to explain
their origin and reference the relevant documentation.
--HG--
extra : rebase_source : 5e7420f8d1589dccc335b0a48c8967d4928f959f
When tests are run in parallel threads, it is possible for tests that
use logging::set_max_level to cause race conditions in other tests.
This patch ensures that the logging tests that use this function
are guarded by a mutex.
For example, when set_max_level(Level::Info) is called in test_max_level,
test_set_max_level may have also called set_max_level(Level::Fatal).
This causes a race condition between the first line and the second
line in test_max_level because the atomic test level will have been
changed away from Level::Info to Level::Fatal.
MozReview-Commit-ID: KQUpkYx6CCo
--HG--
extra : rebase_source : 790a5a93e6a15d16b2e960a5f21976e4dc5df873
This patch somewhat marginally improves error messages returned
during capabilities negotiation.
MozReview-Commit-ID: IHTRk7Rl4ZU
--HG--
extra : rebase_source : a669039092d79ec2fb3b66f7e9ef6c3ed21bfd44
This patch somewhat marginally improves error messages returned
during capabilities negotiation.
MozReview-Commit-ID: IHTRk7Rl4ZU
--HG--
extra : rebase_source : 0fdca046ad69f732d70d5a23145578697cc2fb61
Also, make them not rebuild the CascadeData synchronously, via the
FlushSkinSheets call, since that's broken. That fixes bug 1413119.
This is a little step in getting rid of XBL usage for Shadow DOM.
MozReview-Commit-ID: HJ7FeUZlRTW
--HG--
extra : rebase_source : 0fcd0ed461856c1e87e45ef63c9e1d2e81281469
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.
MozReview-Commit-ID: De4enbjux3T
--HG--
extra : rebase_source : 2296b84bff8e22f01eeb48cd8614fac5db11136a
Most callers of EventUtils.synthesizeKey() call it only with the first argument,
aKey. Therefore, it should be optional argument.
This patch also fixes a bug of EventUtils.sendChar(). It sets shiftKey to
true even for "0" - "9" and " ". When I replace syntesizeKey() which just
type text with sendString() in the following patch, I hit this bug.
MozReview-Commit-ID: 9ndL9jLho2N
--HG--
extra : rebase_source : d9dc6bd5f9091da674f0481b4b0098694360a125
