Right now we can end up with Source objects with multiple source actors that
share the same ID, since nothing tries to make them unique. This patch
makes sources created in Jest tests each get an incrementing actor ID.
Differential Revision: https://phabricator.services.mozilla.com/D27134
--HG--
extra : moz-landing-system : lando
With the previous commits done, the 'newSources' actions expose implementation details that we want
to keep private within the file. Nothing outside of these actions should be instantiating Source
objects anymore.
Differential Revision: https://phabricator.services.mozilla.com/D27133
--HG--
extra : moz-landing-system : lando
We move source creation into the action itself so that the action can inspect the current
state of the store in order to decide how to create the source, where previously we were
forced to insert the source and have the reducer itself handle cases where the source
already existed.
Differential Revision: https://phabricator.services.mozilla.com/D27132
--HG--
extra : moz-landing-system : lando
We want the source actions to be responsible for creating the Source objects rather than creating
them ahead of time. This means that the action itself can make decisions about how to handle new
sources appearing, where right now that decision is made too early by the logic queueing the items.
Differential Revision: https://phabricator.services.mozilla.com/D27131
--HG--
extra : moz-landing-system : lando
We want the two types of queue items to have different datatypes, so we clearly distinguish the
two types of sources that are queued.
Differential Revision: https://phabricator.services.mozilla.com/D27130
--HG--
extra : moz-landing-system : lando
Reducers should be able to use actions to tell what is happening to the workers, and
by combining them into one action they are unable to know what is being added and
what is being removed. Splitting them up means reducers have more information.
Differential Revision: https://phabricator.services.mozilla.com/D27128
--HG--
extra : moz-landing-system : lando
Introduce `overflow-wrap: break-word` to CSS declarations in Rules view and Changes panel to prevent long strings from causing unwanted horizontal scroll
Differential Revision: https://phabricator.services.mozilla.com/D27120
--HG--
extra : moz-landing-system : lando
Depends on D26920
See Bug 1532993#c12 for the analysis. The extra rendering is due to a window resize that
seems to always happen on ASAN but not on other platforms.
Differential Revision: https://phabricator.services.mozilla.com/D27143
--HG--
extra : moz-landing-system : lando
Depends on D26900
Fixes the blank chart and load issues for the old perf panel in about:devtools-toolbox (or type=content)
Differential Revision: https://phabricator.services.mozilla.com/D26919
--HG--
extra : moz-landing-system : lando
Depends on D26899
This test would timeout with the fix in the previous patch
Differential Revision: https://phabricator.services.mozilla.com/D26900
--HG--
extra : moz-landing-system : lando
Follow up to 1524982. We started using the browserloader to load almost all perf panel files.
However we kept two async methods in the js file loaded by performance/index.xul, which defeated the purpose.
Differential Revision: https://phabricator.services.mozilla.com/D26899
--HG--
extra : moz-landing-system : lando
As we convert more chrome documents away from XUL we end up running
through two different paths in this function. These are going to be
filtered out in later checks anyway, so this change removes the early return.
Differential Revision: https://phabricator.services.mozilla.com/D26574
--HG--
extra : moz-landing-system : lando
Depends on D26900
Fixes the blank chart and load issues for the old perf panel in about:devtools-toolbox (or type=content)
Differential Revision: https://phabricator.services.mozilla.com/D26919
--HG--
extra : moz-landing-system : lando
Depends on D26899
This test would timeout with the fix in the previous patch
Differential Revision: https://phabricator.services.mozilla.com/D26900
--HG--
extra : moz-landing-system : lando
Follow up to 1524982. We started using the browserloader to load almost all perf panel files.
However we kept two async methods in the js file loaded by performance/index.xul, which defeated the purpose.
Differential Revision: https://phabricator.services.mozilla.com/D26899
--HG--
extra : moz-landing-system : lando
Depends on D26320
@miker: We are moving devtools iframes to use type=content, and win.top will no longer be available.
We could use another getter to get the topmost chrome window, but reading the code here, I thought that maybe using the toolbox window would be better.
Today if you open several toolboxes in different tabs of the same window, the events for the various toolboxes will be mixed together, because win.top is the same for all the toolboxes that live in the same window.
It might be better to use an object which is unique to the toolbox?
Differential Revision: https://phabricator.services.mozilla.com/D26324
--HG--
extra : moz-landing-system : lando
