Jean-Yves Avenard
022c57caf3
Bug 1550422
- P23. Remove now unused gfxPrefs. r=jrmuizel
...
And with some tidying some comments and removing stray #include "gfxPrefs.h"
Differential Revision: https://phabricator.services.mozilla.com/D31468
--HG--
extra : moz-landing-system : lando
2019-05-26 14:31:53 +00:00
Gurzau Raul
967bc2a754
Backed out 31 changesets (bug 1552643, bug 1550422
) for xpcshell crash on a CLOSED TREE.
...
Backed out changeset e30c1aa75529 (bug 1552643)
Backed out changeset caadcd7e02d3 (bug 1552643)
Backed out changeset aa7086ab09be (bug 1552643)
Backed out changeset 0b4029671710 (bug 1550422
)
Backed out changeset a16295296035 (bug 1550422
)
Backed out changeset 3b70307c0db5 (bug 1550422
)
Backed out changeset 69df7818d4a3 (bug 1550422
)
Backed out changeset d98dfc565927 (bug 1550422
)
Backed out changeset 6f0997976944 (bug 1550422
)
Backed out changeset 0edd264464c2 (bug 1550422
)
Backed out changeset 9ea6da7a74ec (bug 1550422
)
Backed out changeset f855f9309c8b (bug 1550422
)
Backed out changeset 1033546224a7 (bug 1550422
)
Backed out changeset ade7384c6186 (bug 1550422
)
Backed out changeset 75b04de7e99c (bug 1550422
)
Backed out changeset 91c3acdb2454 (bug 1550422
)
Backed out changeset 77d2f80257d1 (bug 1550422
)
Backed out changeset e0cd10d35327 (bug 1550422
)
Backed out changeset 097091082423 (bug 1550422
)
Backed out changeset 2f328853c1ab (bug 1550422
)
Backed out changeset f92f2cc29cb1 (bug 1550422
)
Backed out changeset 6dc82f88333d (bug 1550422
)
Backed out changeset c20f66494d69 (bug 1550422
)
Backed out changeset 2ba22cddeb6f (bug 1550422
)
Backed out changeset 3aa72f89e295 (bug 1550422
)
Backed out changeset ab4c4e806977 (bug 1550422
)
Backed out changeset 72e5de040dda (bug 1550422
)
Backed out changeset 7d3c2d486706 (bug 1550422
)
Backed out changeset 132e0b8d8468 (bug 1550422
)
Backed out changeset 54c85ac75dd0 (bug 1550422
)
Backed out changeset d7ba4a18dd54 (bug 1550422
)
2019-05-25 09:07:49 +03:00
Jean-Yves Avenard
074aea57fe
Bug 1550422
- P23. Remove now unused gfxPrefs. r=jrmuizel
...
And with some tidying some comments and removing stray #include "gfxPrefs.h"
Differential Revision: https://phabricator.services.mozilla.com/D31468
--HG--
extra : moz-landing-system : lando
2019-05-24 11:37:50 +00:00
Gurzau Raul
74c555539e
Backed out 28 changesets (bug 1550422
) for marionette AssertionError and failing browser_policy_hardware_acceleration.js on a CLOSED TREE.
...
Backed out changeset 5dd10a365ba9 (bug 1550422
)
Backed out changeset 529f5be01ab9 (bug 1550422
)
Backed out changeset b6861d3badf8 (bug 1550422
)
Backed out changeset 059cff1a3dde (bug 1550422
)
Backed out changeset 6ada1116b241 (bug 1550422
)
Backed out changeset ca67e8e45262 (bug 1550422
)
Backed out changeset a1961a51ae44 (bug 1550422
)
Backed out changeset 1c90b9cb3ad4 (bug 1550422
)
Backed out changeset 285fa46e4f26 (bug 1550422
)
Backed out changeset e2938a444234 (bug 1550422
)
Backed out changeset 7a930fc51125 (bug 1550422
)
Backed out changeset 898ed02804fe (bug 1550422
)
Backed out changeset e1b7abc99ae9 (bug 1550422
)
Backed out changeset f781d415cef6 (bug 1550422
)
Backed out changeset 2fef10a7cce5 (bug 1550422
)
Backed out changeset ea64b4d8d4ff (bug 1550422
)
Backed out changeset 86a8ba1b755c (bug 1550422
)
Backed out changeset 9c0c9e80f309 (bug 1550422
)
Backed out changeset 10c153ddbaea (bug 1550422
)
Backed out changeset 60fe635ec2c9 (bug 1550422
)
Backed out changeset a38796266b28 (bug 1550422
)
Backed out changeset 2db647dcdf1c (bug 1550422
)
Backed out changeset 952ddac02972 (bug 1550422
)
Backed out changeset ba46b53643ec (bug 1550422
)
Backed out changeset ca47ef6c59f7 (bug 1550422
)
Backed out changeset f45f471a1a40 (bug 1550422
)
Backed out changeset 371b4da5b771 (bug 1550422
)
Backed out changeset 02fc78890032 (bug 1550422
)
2019-05-23 05:59:44 +03:00
Jean-Yves Avenard
d59781ac33
Bug 1550422
- P23. Remove now unused gfxPrefs. r=jrmuizel
...
And with some tidying some comments and removing stray #include "gfxPrefs.h"
Differential Revision: https://phabricator.services.mozilla.com/D31468
--HG--
extra : moz-landing-system : lando
2019-05-22 12:46:30 +00:00
Paul Adenot
4be4624d57
Bug 1552530 - Make the wav dumper in AudioStream.cpp reusable. r=jya
...
Differential Revision: https://phabricator.services.mozilla.com/D31648
--HG--
extra : moz-landing-system : lando
2019-05-21 10:10:04 +00:00
Jean-Yves Avenard
1f5dfb6d37
Bug 1524890 - P4. Use Span<> with AudioBufferCursor. r=bryce
...
And we add some strong assertions that we never read passed the end of the buffer.
Differential Revision: https://phabricator.services.mozilla.com/D20162
--HG--
extra : moz-landing-system : lando
2019-02-22 09:18:05 +00:00
Alex Chronopoulos
09df5a19bb
Bug 1481244 - When a stream is errored avoid updating the volume. r=jya
...
Differential Revision: https://phabricator.services.mozilla.com/D20314
--HG--
extra : moz-landing-system : lando
2019-02-20 09:41:30 +00:00
Razvan Maries
c93e77a62f
Backed out changeset b7713efeb5f1 (bug 1525278
) as jya's request for diagnostic and causing crashes. CLOSED TREE
2019-02-15 13:52:45 +02:00
Alex Chronopoulos
16529fa15f
Bug 1525278
- Assert AudioStream is not errored when SetVolume is called. r=jya
...
Differential Revision: https://phabricator.services.mozilla.com/D18682
--HG--
extra : moz-landing-system : lando
2019-02-14 11:13:38 +00:00
Ehsan Akhgari
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Alex Chronopoulos
eaa068b403
Bug 1518443
- Assert AudioStream is not closed when volume is set. r=jya
...
Differential Revision: https://phabricator.services.mozilla.com/D15933
--HG--
extra : moz-landing-system : lando
2019-01-09 17:16:45 +00:00
Sylvestre Ledru
804b8b8883
Bug 1204606 - Reformat of dom/media r=jya
...
# skip-blame
Differential Revision: https://phabricator.services.mozilla.com/D12251
--HG--
extra : moz-landing-system : lando
2018-11-19 13:25:37 +00:00
Alex Chronopoulos
2c94f04194
Bug 934425 - Set device info in MediaSink and switch sink device. r=jya
...
Differential Revision: https://phabricator.services.mozilla.com/D5871
--HG--
extra : moz-landing-system : lando
2018-10-12 08:44:35 +00:00
Emilio Cobos Álvarez
1e9c395548
Bug 1466168: Remove mozilla::Forward in favor of std::forward. r=froydnj
...
Same approach as the other bug, mostly replacing automatically by removing
'using mozilla::Forward;' and then:
s/mozilla::Forward/std::forward/
s/Forward</std::forward</
The only file that required manual fixup was TestTreeTraversal.cpp, which had
a class called TestNodeForward with template parameters :)
MozReview-Commit-ID: A88qFG5AccP
2018-06-02 09:33:26 +02:00
Matthew Gregan
81d70e03c7
Bug 1427011 - Disable default device switching in libcubeb's WASAPI backend. r=padenot
2018-04-30 19:59:32 +12:00
Jean-Yves Avenard
4680798728
Bug 1432779 - P7. Use typedef rather than actual type. r=padenot
...
this improve readability.
MozReview-Commit-ID: IYfrLMZ5djX
2018-03-24 10:57:59 +01:00
Jean-Yves Avenard
87fa7068d5
Bug 1432779 - P4. Remove the concept of preferred layout. r=padenot,r=kamidphish
...
Channel layout is derived by the content being played. The concept of preferred layout is meaningless. Either we have a layout defined, or we don't. There's no in-between.
So we remove it.
MozReview-Commit-ID: CSCAInNmzMS
2018-03-24 10:57:59 +01:00
Bryce Van Dyk
37dd875199
Bug 1432869 - Update usage of cubeb_stream_params to set newly exposed prefs member. r=achronop
...
The changes to the cubeb API mean that the new prefs member on
cubeb_stream_params should be explicitly set. This changeset does so.
MozReview-Commit-ID: 1hwjLTriaBP
--HG--
extra : rebase_source : f32c4a0a945ed7a048ca40c7286024da1fb93473
2018-01-22 13:20:29 -05:00
Tom Ritter
701ee70a22
Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
...
MozReview-Commit-ID: 4v6tPF5aMz7
--HG--
extra : rebase_source : fe434db73a8da686391462c12b91648348abcdc9
2017-10-09 15:01:48 -05:00
JW Wang
acb1219279
Bug 1406821 - improve error logging to facilitate debugging mochitest timeouts in OPT builds. r=kinetik
...
MozReview-Commit-ID: KTmGRueZkxF
--HG--
extra : rebase_source : f6eb1fcdf9cda7cb6b9e8610c567451111386686
extra : intermediate-source : f06e68706b55b602ccb650641da8186bf74ad1a3
extra : source : 1ad5c0d65ecc4875bd5dc388606bf42e363f9353
2017-10-09 10:18:37 +08:00
Sebastian Hengst
ee63f2e30a
Backed out changeset 0317bcff40bc (bug 1406687) for build bustage at testing/gtest/gtest/src/gtest.cc:3871: 'Unused' was not declared in this scope. r=backout
2017-10-09 18:52:39 +02:00
Tom Ritter
22d2cdf063
Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
...
MozReview-Commit-ID: 4v6tPF5aMz7
--HG--
extra : rebase_source : c54b129c6815096035e262322f40aa0884b1ae56
2017-10-09 00:26:16 -05:00
Matthew Gregan
2bf67b1eb5
Bug 1403043 - Avoid reentering libcubeb from data_callback. r=jwwang
...
AudioStream::DataCallback uses cubeb_get_backend_id to work around a bug in
libcubeb's winmm backend, but calling libcubeb APIs from within libcubeb
callbacks is not safe. Move the query to AudioStream::Init and check a simple
bool from within the callback instead.
2017-09-29 17:19:47 +13:00
Chris Pearce
52ca837455
Bug 1399559 - Include nsXULAppAPI.h in AudioStream.cpp. r=jwwang
...
This ensures XRE_IsContentProcess() is defined, as it's used in this file.
MozReview-Commit-ID: JFCmvZ8aZdT
--HG--
extra : rebase_source : 5852da1b4b76f767e7d36071cdfa1f97eaedbf8c
2017-09-14 15:56:35 +12:00
Chun-Min Chang
b7f3746bab
Bug 1392930 - part 2: Make AudioStream inherit from DeviceChangeListener; r=jwwang
...
--HG--
extra : rebase_source : 384f30c0fe923609b1c1f0822179f0165d987d4a
2017-08-29 18:08:46 +08:00
Matthew Gregan
f4d992a821
Bug 1388229 - Remove B2G-only audio stream type handling. r=kamidphish
2017-08-10 13:00:07 +12:00
Eric Rahm
01f545fea7
Bug 1386825 - Part 1: Remove MOZ_B2G from dom. r=bkelly
...
MozReview-Commit-ID: 1zzP2r01B7U
2017-08-08 14:41:05 -07:00
Chun-Min Chang
030729930f
Bug 1361336 - part5: Register the AudioStream into AudioNotificationReceiver when it's created; r=cpearce
...
--HG--
extra : rebase_source : bec94f3f8a710b8b8d21912f0feb5a752e92c7de
2017-07-26 14:50:48 +08:00
Chun-Min Chang
7d076c3ac2
Bug 1361336 - part2: Prevent AudioStream::ResetDefaultDevice() from being called before stream is started; r=cpearce,kinetik
...
--HG--
extra : rebase_source : 95030be6e9ce493b6d42e837f9a7e652907836a8
2017-07-21 17:45:45 +08:00
Chun-Min Chang
bfe0bce52c
Bug 1361336 - part1: A new API for AudioStream that it can reset stream to the default device; r=kinetik
...
MozReview-Commit-ID: ErUYXK9fUvE
--HG--
extra : rebase_source : ced74fba605b6892674a58611d7eb33616c81ce6
2017-07-12 14:51:07 +08:00
Chun-Min Chang
c369131664
Bug 1365225 - Prevent overflow. r=jwwang
...
MozReview-Commit-ID: 6jA1DTgVmrU
2017-05-24 09:22:42 -04:00
Chun-Min Chang
561671475d
Bug 1321502 - part 1: Enable multi-channel support in Gecko on Windows; r=jya
...
MozReview-Commit-ID: KURUk3EffOu
--HG--
extra : rebase_source : a0ce3fb8691f45a33995a3ce1ba895c254a35c8c
2017-01-26 17:35:31 +08:00
Paul Adenot
f012888dd8
Bug 1332905 - For mono or stereo in AudioStream.cpp until the rest of the code is multichannel-aware. r=achronop a=tomcat
...
MozReview-Commit-ID: 5eqBlPnHVk2
2017-01-23 11:36:58 +01:00
Alex Chronopoulos
bad8dea079
Bug 1331869 - Initialize new field of cubeb_stream_params. r=kinetik,padenot
...
MozReview-Commit-ID: KZ08mckJX44
--HG--
extra : rebase_source : 6789db291ace421114055063efa37481cfc524ef
2017-01-20 16:54:00 +02:00
Carsten "Tomcat" Book
572e74ee99
merge mozilla-inbound to mozilla-central a=merge
2016-09-28 15:56:33 +02:00
Paul Adenot
cb690a7e56
Bug 1301648 - Add a pref to be able to control the AudioCallbackDriver requested latency. r=kinetik
...
MozReview-Commit-ID: 19BZUjyXFlq
--HG--
extra : rebase_source : 96df59a9b5c9f8bd7e5f8211a09b854d65833b3b
2016-09-09 15:21:50 +02:00
Gerald Squelart
0614bdb71f
Bug 1247056 - Report specific cubeb-init error code - r=jwwang
...
MozReview-Commit-ID: AqR2jKKtNHL
--HG--
extra : rebase_source : 7ffdae6ca2e10e1fbb43ba84c7c398f0017d040c
2016-09-07 21:26:01 -07:00
Wes Kocher
b20dd04b94
Backed out 13 changesets (bug 1247056) for WinXP bc7 failures in browser_decoderDoctor.js CLOSED TREE
...
Backed out changeset ff3538fd40fe (bug 1247056)
Backed out changeset a444d7cb1091 (bug 1247056)
Backed out changeset 03553484a062 (bug 1247056)
Backed out changeset 001b42631702 (bug 1247056)
Backed out changeset d0d71a80a029 (bug 1247056)
Backed out changeset cd40559e25d7 (bug 1247056)
Backed out changeset b8857adc4003 (bug 1247056)
Backed out changeset 1f3b037bfd1f (bug 1247056)
Backed out changeset c5cd9597ec02 (bug 1247056)
Backed out changeset 2bfe3aeb9f59 (bug 1247056)
Backed out changeset 934d7c9628f1 (bug 1247056)
Backed out changeset 63094a80bee7 (bug 1247056)
Backed out changeset 511ed53eee9a (bug 1247056)
2016-09-26 12:15:55 -07:00
Gerald Squelart
e46d041220
Bug 1247056 - Report specific cubeb-init error code - r=jwwang
...
MozReview-Commit-ID: AqR2jKKtNHL
--HG--
extra : histedit_source : a2789615fa45e191e04657e57f571362d86daf76
2016-09-07 21:26:01 -07:00
Alex Chronopoulos
27be8363ef
Bug 1286041 - AudioStream disable the assert when backend audio is winmm. r=padenot
2016-09-12 12:25:19 +03:00
Alex Chronopoulos
3951f5ffd7
Bug 1286041 - Assert audio callback is not called in initialized state. r=jwwang
2016-07-12 16:53:58 +02:00
Carsten "Tomcat" Book
70d30f62af
Backed out 12 changesets (bug 1247056) for windows bc7 test failures
...
Backed out changeset 13434fa439d1 (bug 1247056)
Backed out changeset e1e5be2fc586 (bug 1247056)
Backed out changeset f48fd90bf839 (bug 1247056)
Backed out changeset 8e164f6d6c5c (bug 1247056)
Backed out changeset 024d7295b6f4 (bug 1247056)
Backed out changeset 32fc8121ca20 (bug 1247056)
Backed out changeset 49558f78782a (bug 1247056)
Backed out changeset 2b3dce1c98f6 (bug 1247056)
Backed out changeset be036a725d3a (bug 1247056)
Backed out changeset 344a41f87a23 (bug 1247056)
Backed out changeset 0ce3c5cb6e6a (bug 1247056)
Backed out changeset 01aa7f5bde71 (bug 1247056)
2016-09-23 16:02:54 +02:00
Gerald Squelart
74bd3981f5
Bug 1247056 - Report specific cubeb-init error code - r=jwwang
...
MozReview-Commit-ID: AqR2jKKtNHL
--HG--
extra : histedit_source : 3b61cc82b635437cad618275ebd0fddfccc4151d
2016-09-07 21:26:01 -07:00
Matthew Gregan
0ebace12e5
Bug 1302348 - Report cubeb context init failures via telemetry. r=padenot
2016-09-16 12:54:24 +12:00
Wes Kocher
677438b338
Backed out 4 changesets (bug 1286041) for making various media tests really failure prone a=backout
...
Backed out changeset af4c053741f1 (bug 1286041)
Backed out changeset b5be689abefa (bug 1286041)
Backed out changeset 2aad01ffac9f (bug 1286041)
Backed out changeset 48117ed311a1 (bug 1286041)
2016-09-12 15:17:23 -07:00
Alex Chronopoulos
c498e1f9a0
Bug 1286041 - AudioStream disable the assert when backend audio is winmm. r=padenot
2016-09-12 12:25:19 +03:00
Alex Chronopoulos
6a23c81135
Bug 1286041 - Assert audio callback is not called in initialized state. r=jwwang
2016-07-12 16:53:58 +02:00
Nicholas Nethercote
34dcc7b852
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
...
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.
In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.
> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.
> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");
This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
be true" sense used in assertions.
A common variation on the side-effect-free case is the following.
> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Sebastian Hengst
8df190bd97
Backed out changeset 71b9d48efac6 (bug 1286041) for failing wpt mediasource-seek-beyond-duration.html on Linux. r=backout on a CLOSED TREE
2016-09-06 19:08:20 +02:00