Commit Graph

78949 Commits

Author SHA1 Message Date
Timothy Guan-tin Chien
a685c05ea5 Bug 1504343 - Convert xbl-marquee to UA Widget r=bgrins,bzbarsky
This patch moves the marquee bindings from xbl-marquee.xml to marquee.js and converts them to a UA Widget.

The contenteditable bindings are dropped, replaced with a styling rule that will fix the position of the scrolling text.

Inline styles have been moved to the stylesheet so usage of display: -moz-box can continue to be parsed.

test_bug840098.html is deleted because it is only valid under the context of in-content XBL bindings.

Differential Revision: https://phabricator.services.mozilla.com/D10385

--HG--
rename : layout/style/xbl-marquee/xbl-marquee.css => toolkit/content/widgets/marquee.css
rename : layout/style/xbl-marquee/xbl-marquee.xml => toolkit/content/widgets/marquee.js
extra : moz-landing-system : lando
2018-11-18 01:23:52 +00:00
Emilio Cobos Álvarez
82956adc4f Bug 1507101 - Use StyleChildrenIterator instead of custom frame tree walking code to handle NAC inside shadow dom. r=smaug
There are lots of frames which create anonymous content (like scrollframes,
which generate scrollbars) but for which this code was wrong.

Use StyleChildrenIterator which has a defined order between NAC and flattened
tree. I've verified this doesn't break tabbing through input type="date" with
UA widget disabled, fwiw.

Differential Revision: https://phabricator.services.mozilla.com/D12152

--HG--
extra : moz-landing-system : lando
2018-11-16 20:31:50 +00:00
Andreea Pavel
72b0594cb8 Merge mozilla-inbound to mozilla-central. a=merge 2018-11-17 13:27:24 +02:00
Ciure Andrei
52f5cabbdf Backed out changeset 85963f594697 (bug 1504343) for HTMLMarqueeElement.cpp build bustages CLOSED TREE 2018-11-17 10:43:14 +02:00
Timothy Guan-tin Chien
451f3371c4 Bug 1504343 - Convert xbl-marquee to UA Widget r=bgrins,bzbarsky
This patch moves the marquee bindings from xbl-marquee.xml to marquee.js and converts them to a UA Widget.

The contenteditable bindings are dropped, replaced with a styling rule that will fix the position of the scrolling text.

Inline styles have been moved to the stylesheet so usage of display: -moz-box can continue to be parsed.

test_bug840098.html is deleted because it is only valid under the context of in-content XBL bindings.

Differential Revision: https://phabricator.services.mozilla.com/D10385

--HG--
rename : layout/style/xbl-marquee/xbl-marquee.css => toolkit/content/widgets/marquee.css
rename : layout/style/xbl-marquee/xbl-marquee.xml => toolkit/content/widgets/marquee.js
extra : moz-landing-system : lando
2018-11-17 06:29:41 +00:00
Brad Werth
0bbbba0715 Bug 1506687 Part 2: Add a test of FlexItemValues frameRect property. r=dholbert
Depends on D12182

Differential Revision: https://phabricator.services.mozilla.com/D12183

--HG--
extra : source : f93f179fb3b46ea0b3612c21db6cf0a044c03ec0
2018-11-17 00:58:26 +00:00
Brad Werth
346bc8427e Bug 1506687 Part 1: Make FlexItemValues also provide the item's frame rect. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D12182

--HG--
extra : source : d8230f3fdd2c3ecea4771ebe98c83be6e3ebcbfc
2018-11-17 00:56:51 +00:00
Cosmin Sabou
06a105eed0 Backed out 2 changesets (bug 1506687) for causing mochitest mass failures. CLOSED TREE
Backed out changeset f93f179fb3b4 (bug 1506687)
Backed out changeset d8230f3fdd2c (bug 1506687)
2018-11-17 05:05:53 +02:00
James Teh
9e968bb929 Bug 1506787: Support tabindex attribute (including value -1) on non-control XUL elements. r=smaug
Previously, the tabindex attribute wasn't supported on non-control XUL elements at all.
The only way to make those focusable was to use -moz-user-focus: normal.
However, that caused the element to be included in the tab order; there was no way to make it focusable but not tabbable.
This can now be achieved using tabindex="-1".
This will primarily be useful for buttons on toolbars, which will be grouped under a single tab stop for efficiency.

For consistency, this also changes the behaviour of tabindex="-1" with -moz-user-focus: ignore on XUL controls.
Previously, -moz-user-focus: ignore would override tabindex="-1", making the element unfocusable.
Now, the tabindex attribute always overrides if explicitly specified.

Differential Revision: https://phabricator.services.mozilla.com/D12000

--HG--
extra : moz-landing-system : lando
2018-11-17 02:38:27 +00:00
Nika Layzell
2f7bbe21e3 Bug 1477432 - Part 11: Update CustomElementRegistry to not use nsIJSID, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D9733
2018-11-16 17:27:48 -05:00
Nika Layzell
589d2a7b6f Bug 1477432 - Part 10: Stop using nsIJSID in nsIArray for optional IID parameters, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D9732
2018-11-16 17:27:46 -05:00
Nika Layzell
11b083d72c Bug 1477432 - Part 9: Switch to using plain JS objects for nsIJS[IC]ID, r=mccr8
This is a complete rewrite of the interface while maintaining the same APIs.
Each ID is fully-contained within a single object, does not require a finalizer,
and is cheap to create.

Beyond using reserved slots, this code avoids using custom ClassOps, instead
preferring Symbol.hasInstance and eager constants.

One major change which occurred in this patch was the move from storing a nsCID
to storing the ContractID for JSCID objects. This eliminates the need for the
'refreshCID' method, and hopefully shouldn't have performance implications.

If we discover that there are performance problems there, we can look into
stashing the CID, and re-introduce 'refreshCID', despite its surprising
behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D2286
2018-11-16 17:27:44 -05:00
Nika Layzell
d036b747e7 Bug 1477432 - Part 6: Stop using nsIJSID inside of WebIDL bindings, r=mccr8
Rather than adding a native type for nsID objects in WebIDL, this patch just
takes the approach of switching consumers over to using 'any' and calling the
APIs defined in Part 1.

Differential Revision: https://phabricator.services.mozilla.com/D2283
2018-11-16 17:27:39 -05:00
Nika Layzell
fe2f2478f7 Bug 1477432 - Part 2: Avoid using nsIJSID in GenerateQI, and produce better diagnostics, r=kmag
This is the first part of hiding the implementation of nsIJSID behind the
interface added in Part 1, such that we can substitute that implementation out.

I had to make a couple of changes to fix the errors caused by the new behaviour
in GenerateQI.

Differential Revision: https://phabricator.services.mozilla.com/D2279
2018-11-16 17:27:31 -05:00
Brad Werth
4476e0d1a3 Bug 1506687 Part 2: Add a test of FlexItemValues frameRect property. r=dholbert
Depends on D12182

Differential Revision: https://phabricator.services.mozilla.com/D12183

--HG--
extra : moz-landing-system : lando
2018-11-17 00:58:26 +00:00
Brad Werth
cae2b12074 Bug 1506687 Part 1: Make FlexItemValues also provide the item's frame rect. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D12182

--HG--
extra : moz-landing-system : lando
2018-11-17 00:56:51 +00:00
Cosmin Sabou
8b0d7e9861 Merge mozilla-central to autoland. a=merge
--HG--
extra : rebase_source : d2d1fef29703d48d14b7ceac0ffa9ee0e5a0a007
2018-11-16 23:57:57 +02:00
Boris Chiou
2718fd0897 Bug 1424134 - Part 3: Implement ComputeSquaredDistance for individual transforms. r=birtles
We manually implement ComputeSquaredDistance for Translate, Rotate, and
Scale because we have to handle mismatch cases, and actually we don't
need to implement it for specified types.

Depends on D11934

Differential Revision: https://phabricator.services.mozilla.com/D11935

--HG--
extra : moz-landing-system : lando
2018-11-16 18:58:41 +00:00
Luke Wagner
00940fee0d Bug 1505632 - Baldr: correctly propagate AbortError from consume stream body operation (r=lth,baku,Ms2ger) 2018-11-16 10:32:20 -06:00
alwu
c084141553 Bug 1493766 - part3 : modify test. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D7017

--HG--
extra : moz-landing-system : lando
2018-11-14 01:32:26 +00:00
alwu
dab4434860 Bug 1493766 - part2 : save the status of temporary autoplay permission in outer window. r=johannh,smaug
In order to know whether we have temporary autoplay permission without creating a request, we need to
cache its state in the outer window so that we can get the correct returned value for AutoplayPolicy::IsAllowedToPlay().

Differential Revision: https://phabricator.services.mozilla.com/D7013

--HG--
extra : moz-landing-system : lando
2018-11-16 18:27:00 +00:00
Gurzau Raul
6d17917258 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-11-16 19:54:35 +02:00
Lina Cambridge
2e957c8eaf Bug 1494713 - Implement a GeckoViewHistory backend. r=jchen,snorp,smaug
Differential Revision: https://phabricator.services.mozilla.com/D11290

--HG--
extra : moz-landing-system : lando
2018-11-16 17:32:02 +00:00
Lina Cambridge
69ee079fa0 Bug 1494713 - Pass the widget for the DocShell to IHistory::VisitURI. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D11287

--HG--
extra : moz-landing-system : lando
2018-11-16 17:29:57 +00:00
Timothy Guan-tin Chien
c4c5775807 Bug 1472237 - Always do XML Pretty print even if the frame is hidden r=mats
XML pretty print, as it was implemented in bug 64945, skips itself when the loaded document is not visible. There is no explanation why it does that, other than the fact that it is backed by an XBL binding, and XBL bindings always bound to DOM with layout frames. A later change in bug 1400618 made the existence of presshell necessary before binding the XBL binding.

With bug 1437956 and bug 1503019, XML pretty print is now backed by Shadow DOM. That leaves no reason for keeping this behavior.

The test file test_bug590812.html also revealed that XML pretty print might incorrectly opt-out itself because of the said behavior. We don't know if this something only happens in the test or it is something that may happen in the wild. Nonetheless, it's a better idea to simplify the behavior here.

Differential Revision: https://phabricator.services.mozilla.com/D12088

--HG--
extra : moz-landing-system : lando
2018-11-16 08:16:27 +00:00
Dragana Damjanovic
7598019f0a Bug 1506512 - ServerTiming header must be updated onStopRequest as well. r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D12026

--HG--
extra : moz-landing-system : lando
2018-11-16 10:17:15 +00:00
Bogdan Tara
647b9eb109 Merge inbound to mozilla-central. a=merge 2018-11-16 11:47:51 +02:00
Hiroyuki Ikezoe
5e079c773c Bug 1507675 - Rewrite test_animation_performance_warning.html with async/await. r=boris
Depends on D12086

Differential Revision: https://phabricator.services.mozilla.com/D12087

--HG--
extra : moz-landing-system : lando
2018-11-16 02:48:41 +00:00
Hiroyuki Ikezoe
a4c04af9af Bug 1507675 - Drop the second argument for then(). r=boris
The second argument should be a callback for reject case.

Differential Revision: https://phabricator.services.mozilla.com/D12086

--HG--
extra : moz-landing-system : lando
2018-11-16 02:35:47 +00:00
Narcis Beleuzu
7493bc4e67 Backed out changeset 11b611171e23 (bug 1507263) for webgl failures on test_common.html 2018-11-16 03:36:54 +02:00
Jeff Gilbert
85168c2699 Bug 1507263 - Expose BPTC and RGTC WebGL exts. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D11970

--HG--
extra : moz-landing-system : lando
2018-11-15 04:05:19 +00:00
Narcis Beleuzu
c8215609ff Backed out 2 changesets (bug 1504728, bug 1505198) for xpcshell failures on test_WebExtensionContentScript.js. CLOSED TREE
Backed out changeset 26318538f077 (bug 1505198)
Backed out changeset fc39602006be (bug 1504728)
2018-11-16 02:34:15 +02:00
alwu
495a70cf3a Bug 1506286 - part2 : finish queue after discarding data. r=jya
After discarding looping data, all data playback needed are in the queue. There is no need to
request more data, so we can finish the queue and disconnect the request.

Differential Revision: https://phabricator.services.mozilla.com/D11535

--HG--
extra : moz-landing-system : lando
2018-11-15 12:57:35 +00:00
alwu
31f9ef35fe Bug 1506286 - part1 : use clock time to decide whether need to discard data. r=jya
Should use both adjusted time to do time comparison.

Differential Revision: https://phabricator.services.mozilla.com/D11534

--HG--
extra : moz-landing-system : lando
2018-11-15 21:53:50 +00:00
Ehsan Akhgari
086fd2d3b8 Bug 1505198 - Make sure the STATE_COOKIES_LOADED state is stored outside of the content blocking log r=baku
Differential Revision: https://phabricator.services.mozilla.com/D11143

--HG--
extra : moz-landing-system : lando
2018-11-15 01:56:09 +00:00
Ehsan Akhgari
7f3a7b13de Bug 1504728 - Part 1: Add a content blocking notification for indicating when a top-level page is using cookies or site data r=baku,valentin,johannh
Differential Revision: https://phabricator.services.mozilla.com/D11122

--HG--
extra : moz-landing-system : lando
2018-11-14 17:19:25 +00:00
alwu
8772ab4639 Bug 1505880 - set mGestureDownPoint when receiving 'touchstart' event. r=smaug
We should set the 'mGestureDownPoint' correctly when receiving 'touchstart' so that we can
distinguish whether the 'touchend' comes from dragging or simply touching by calling
'IsEventOutsideDragThreshold()'.

Differential Revision: https://phabricator.services.mozilla.com/D11395

--HG--
extra : moz-landing-system : lando
2018-11-15 21:22:49 +00:00
Perry Jiang
71c4ea8b76 Bug 1264177 - Implement FetchEvent.resultingClientId r=edenchuang,mrbkap
- Expose FetchEvent.resultingClientId on non-subresource, non-"report"-destination requests.
- Delay Clients.get(FetchEvent.resultingClientId) resolution until the resulting client is execution ready.
- Add WPTs to test for existence of resultingClientId and Clients.get promise resolution values.

Differential Revision: https://phabricator.services.mozilla.com/D5333

--HG--
extra : moz-landing-system : lando
2018-11-15 08:28:23 +00:00
Cosmin Sabou
5394c8a6ca Backed out 3 changesets (bug 1506687) for devtools failures on browser_flexbox_sizing_info_for_text_nodes. CLOSED TREE
Backed out changeset 2788a93e179a (bug 1506687)
Backed out changeset 1c3baa04d4ce (bug 1506687)
Backed out changeset c50af93cfc84 (bug 1506687)
2018-11-15 20:01:52 +02:00
Brad Werth
92eac4e18e Bug 1506687 Part 3: Update test expectations. r=dholbert
Depends on D11783

Differential Revision: https://phabricator.services.mozilla.com/D11784

--HG--
extra : moz-landing-system : lando
2018-11-15 16:20:58 +00:00
Brad Werth
5e72dc5a5b Bug 1506687 Part 2: Make FlexItemValues also provide the item's position and size. r=dholbert
Depends on D11782

Differential Revision: https://phabricator.services.mozilla.com/D11783

--HG--
extra : moz-landing-system : lando
2018-11-15 16:20:40 +00:00
Margareta Eliza Balazs
12e5754397 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-11-15 18:21:01 +02:00
Margareta Eliza Balazs
50ce0da718 Merge inbound to mozilla-central. a=merge 2018-11-15 18:13:49 +02:00
Matthew Noorenberghe
589b8d294e Bug 1435880 - Temporarily disable test_abortPayment and test_canMakePayment due a new leak exposed. r=edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D11924

--HG--
extra : moz-landing-system : lando
2018-11-15 15:06:34 +00:00
Boris Zbarsky
a15e8a72b3 Bug 1341688. Fix IDB leaks due to IDBFactory not declaring all its outgoing edges to the cycle collector. r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D11974

--HG--
extra : moz-landing-system : lando
2018-11-15 13:46:18 +00:00
Jean-Yves Avenard
d05f000f1b Bug 1507093 - P4. Don't lazily allocate mVideoTrackList and mAudioTrackList. r=pehrsons
Should the media element be cycle collected and a decoder still be active, a change of state could have caused the track list to be re-created causing a cycle between the HTMLMediaElement and the track list.

We also check when potentially updating the ready state if the self reference is still needed.

Place various assertions.

Differential Revision: https://phabricator.services.mozilla.com/D11860

--HG--
extra : moz-landing-system : lando
2018-11-15 12:48:34 +00:00
Jean-Yves Avenard
bc18f07d03 Bug 1507093 - P3. Ensure that self AddRef/DeRef occur sequentially r=pehrsons
It was possible for two sequential calls to HTMLMediaElement::AddRemoveSelfReference to leave the media element deregistered when it should have registered.
And we ensure to ony ever self register once.

Differential Revision: https://phabricator.services.mozilla.com/D11859

--HG--
extra : moz-landing-system : lando
2018-11-15 12:48:11 +00:00
Jean-Yves Avenard
5f69f9479d Bug 1507093 - P2. Ensure that when returning from NotifyXPCOMShutdown we don't UAF. r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D11858

--HG--
extra : moz-landing-system : lando
2018-11-15 12:48:02 +00:00
Jean-Yves Avenard
4e317b7bb3 Bug 1474443 - Remove cycle between MP4Demuxer and MP4TrackDemuxer. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D12004

--HG--
extra : moz-landing-system : lando
2018-11-15 12:44:56 +00:00
Andrea Marchesini
ed66410ca1 Bug 1507144 - Enable reporting API by default in nightly only, r=smaug 2018-11-15 11:15:58 +01:00