mod_pywebsocket3 inherits the stdout and stderr handles of its parent process
(the mochitest harness), so anything printed by the websocket server will appear
in the mochitest log. Most websocket server output is logged to a separate log
file, but exceptions are dumped to stderr.
test_worker_websocket2.html appropriately tests special unicode characters in
the reason code used when closing the websocket. On Windows, under python-3,
the special content of that reason code causes an exception in the mod_pywebsocket3
logging, which is reported to the mochitest log; the test still passes and the
websocket server continues to run correctly, but the exception is picked up by
the treeherder log parser as a "failure".
This patch suppresses the websocket server stderr so that any exception reported
by the websocket server will not affect test status directly.
Differential Revision: https://phabricator.services.mozilla.com/D108308
The exception seen in this bug can be avoided by simply replacing the terminate() call
with kill(). While we're here, I've tried to simplify the shutdown logic and improve
logging.
Differential Revision: https://phabricator.services.mozilla.com/D107528
The exception seen in this bug can be avoided by simply replacing the terminate() call
with kill(). While we're here, I've tried to simplify the shutdown logic and improve
logging.
Differential Revision: https://phabricator.services.mozilla.com/D107528
The MochitestFormatter adds an additional count and log level, from the mochitest test
harness. As far as I can tell, the MochitestFormatter is not called during desktop tests
(only Android); this difference appears accidental. Removing this log formatter removes
the extra, undesired fields.
Differential Revision: https://phabricator.services.mozilla.com/D102873
The failures in bug 1678451 are a timeout because gst-launch crashes and
makes itself wait indefinitely for $someone to possibly debug the issue,
which, on CI, is not useful. What happens then is that the task is
killed after a while. A more useful thing to do is just to let it crash
and not wait, turning timeouts into immediate task failures.
Differential Revision: https://phabricator.services.mozilla.com/D98040
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Initial changes to allow mochitests to run in python 3. This works well on Linux,
and almost works on Android. A follow-up will complete the work on Android and
switch mach mochitest over to python 3.
Differential Revision: https://phabricator.services.mozilla.com/D91461
This stamps out an unspoken dependency on `six` in the `mach` `virtualenv`; adding this fixes a bunch of broken tests, namely all those that depend on `pywebsocket_wrapper.py`.
Differential Revision: https://phabricator.services.mozilla.com/D87774
The finally where it's used may be reached before it is set currently,
leading to more important error messages being hidden.
Differential Revision: https://phabricator.services.mozilla.com/D86281
