Commit Graph

63 Commits

Author SHA1 Message Date
Chris Peterson
71920a9550 Bug 1207030 - Enable -Wshadow flag in more directories that have no -Wshadow warnings. r=glandium 2015-09-22 21:39:03 -07:00
Nicholas Nethercote
f44287005f Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.

--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Thomas Zimmermann
7a8e54aa54 Bug 1185478: Add leak checks to socket I/O classes 2015-07-21 08:06:29 +02:00
Thomas Zimmermann
c9da785375 Bug 1173334: Open nfcd connections with socket type SOCK_SEQPACKET, allstars.chh
NFC requires sequential transfer of individual messages. Using the
socket type SOCK_SEQPACKET guarantees these properties.
2015-06-25 08:29:04 -07:00
Thomas Zimmermann
f9ce4741fd Bug 1166638: Use |ListenSocketConsumer| in |ListenSocket|, r=kmachulis, dlee, chucklee, shuang
This patch converts |ListenSocket| to forward events to an instance
of |ListenSocketConsumer|. All users are converted and the related
listener and consumer classes are removed.
2015-05-26 13:24:20 +02:00
Thomas Zimmermann
d24dddee86 Bug 1166638: Use |StreamSocketConsumer| in |StreamSocket|, r=kmachulis, dlee, chucklee, htsai
This patch converts |StreamSocket| to forward events and data to an
instance of |StreamSocketConsumer|. All users are converted and the
related listener and consumer classes are removed.
2015-05-26 13:24:20 +02:00
Thomas Zimmermann
70a7cf2bf2 Bug 1164417: Add |ConnectionOrientedSocket::PrepareAccept| for accepting socket connections, r=kmachulis
With this patch, stream and listening sockets handle the setup of
accepted sockets internally. Sub-classes of |StreamSocket| don't
have to overload StreamSocket's |GetIO| any longer.
2015-05-21 13:34:37 +02:00
Thomas Zimmermann
5689bc8e15 Bug 1164417: Add |UnixSocketConnector::Duplicate|, r=kmachulis
The new method |UnixSocketConnector::Duplicate| allows a socket
connector to duplicate itself. Listening sockets will used this
feature to create socket connectors for accepted connections.
2015-05-21 13:34:37 +02:00
Thomas Zimmermann
a4face3b55 Bug 1161020: Remove old interface and implementation from socket-connector classes, r=kmachulis 2015-05-19 13:28:46 +02:00
Thomas Zimmermann
62b1926054 Bug 1161020: Implement new socket-connector interface for NFC, r=allstars.chh
This patch moves |NfcConnector| into its own file and implements
the new socket-connector interface.
2015-05-19 13:28:46 +02:00
Carsten "Tomcat" Book
643b4d8cd2 Backed out 8 changesets (bug 1161020) for b2g ics emulator debug mochitest memory leaks on a CLOSED TREE
Backed out changeset 976e19eac8b5 (bug 1161020)
Backed out changeset 4f782be31f87 (bug 1161020)
Backed out changeset 384de663084c (bug 1161020)
Backed out changeset a8f42d85ce3f (bug 1161020)
Backed out changeset ac23206e80bd (bug 1161020)
Backed out changeset 34a20b05af6c (bug 1161020)
Backed out changeset 13753f9043f7 (bug 1161020)
Backed out changeset f90b8d3d6b70 (bug 1161020)
2015-05-18 15:01:27 +02:00
Thomas Zimmermann
2b68c73b1e Bug 1161020: Remove old interface and implementation from socket-connector classes, r=kmachulis 2015-05-18 11:28:30 +02:00
Thomas Zimmermann
0936f09ecd Bug 1161020: Implement new socket-connector interface for NFC, r=allstars.chh
This patch moves |NfcConnector| into its own file and implements
the new socket-connector interface.
2015-05-18 11:28:30 +02:00
Thomas Zimmermann
417a91f162 Bug 1156352: Remove |UnixSocketRawData| from socket I/O interfaces, r=kmachulis 2015-04-23 13:48:48 +02:00
Thomas Zimmermann
7f554d1a7f Bug 1156352: Remove |UnixSocketRawData| from NFC interfaces, r=allstars.chh 2015-04-23 13:48:48 +02:00
Ehsan Akhgari
883849ee32 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Thomas Zimmermann
de7c9b005f Bug 1109592 - Cleanup unused variables and fields from NFC's IPC code. r=allstars.chh 2015-03-06 05:54:00 -05:00
Thomas Zimmermann
1ce878358e Bug 1109592 - Listen for connections from NFC daemon. r=allstars.chh
This patch inverses the connection setup procedure between Gecko
and nfcd. Gecko now installs a listen socket and starts nfcd from
the init scripts. Nfcd establishes the connection by connecting
to Gecko's socket.

As a side effect of this patch, nfcd only runs while NFC is switched
on. This saves ~1.6 MiB os memory with contemporary NFC drivers on
flame-kk.
2015-03-11 03:38:00 -04:00
Thomas Zimmermann
60bb14fba6 Bug 1109592 - Add |NfcListenSocket|. r=allstars.chh
The class |NfcListenSocket| is a socket that listens for connections
from nfcd.
2015-03-11 03:34:00 -04:00
Thomas Zimmermann
b71aaf67e2 Bug 1109592 - Move |NfcConnector| to a more public place. r=allstars.chh
|NfcConnector| is required to listen for connections from within
|NfcService|. This patch makes it available.
2015-03-11 03:33:00 -04:00
Thomas Zimmermann
7c78ff1393 Bug 1109592 - Forward socket state from |NfcSocketListener|. r=allstars.chh
This patch allows to handle changes to the socket state at a higher
level than |NfcSocketListener|.
2015-03-09 03:27:00 -04:00
Thomas Zimmermann
5cbe35fbd5 Bug 1123651: Inherit |NfcConsumer| from |StreamSocket|, r=allstars.chh
With this patch, |NfcConsumer| inherits from |StreamSocket| instead
of |UnixSocketConsumer|. Some methods have been renamed. |NfcConsumer|
now contains the method |GetIO|, which is required by |StreamSocket|
for integration with |ListenSocket|.
2015-01-21 10:59:21 +01:00
Thomas Zimmermann
0215081264 Bug 1123651: Improve correctness of |NfcConsumer| and its helpers, r=allstars.chh
This patch changes several small details to make |NfcConsumer| more
 correct. This includes

   - MOZ_FINAL for classes,
   - MOZ_OVERRIDE for virtual methods,
   - static global variables, and
   - nsAutoPtr around explicitly deleted data.
2015-01-21 10:59:21 +01:00
Thomas Zimmermann
cf4bf59525 Bug 1123651: Fix coding style in Nfc.cpp, r=allstars.chh 2015-01-21 10:59:21 +01:00
Yoshi Huang
c3e7baef48 Bug 933588 - Part 1: NFC service. r=khuey 2014-02-19 15:14:22 +08:00
Mike Hommey
70a5917917 Bug 1036864 - Remove EXPORT_LIBRARY. r=mshal 2014-07-11 19:06:55 +09:00
Brian Hackett
00d8fa7118 Bug 1021790 - "Cleanup naming for scalar and typed array types", r=sfink 2014-06-06 09:36:00 -07:00
Ehsan Akhgari
5b0272c079 Bug 1013663 - Fix some bad implicit conversion constructors in the JS engine; r=jorendorff,jandem 2014-05-25 21:46:24 -04:00
Chris Peterson
dbf88e5f6b Bug 1007741 - Fix -Wunused-function warning in ipc/glue/ and mark ipc/ subdirectories as FAIL_ON_WARNINGS. r=bsmedberg 2014-05-07 23:55:30 -07:00
Nicholas Nethercote
1c5751ac95 Bug 952650 (part 13) - Remove JSVAL_IS_PRIMITIVE. r=till.
--HG--
extra : rebase_source : 450ba0261ef5a8546c81f9f645605e312585d6c6
2014-04-27 20:27:54 -07:00
Nicholas Nethercote
530542eecd Bug 952650 (part 12) - Remove JSVAL_TO_OBJECT. r=till.
--HG--
extra : rebase_source : 60dcaa2b778d3cf6eb7dc1a4949aab010ed8c130
2014-04-27 19:58:52 -07:00
Rodrigo Rodriguez Jr.
d65b5ba4e5 Bug 952650 (part 6) - Remove JSVAL_IS_STRING. r=njn.
--HG--
extra : rebase_source : ebd55749447f9feea04a78ff7cc17ba2dd2c5cd0
2014-04-27 19:41:01 -07:00
Jon Coppeard
92f0d66be8 Bug 959787 - Handlify remaining JS APIs r=sfink r=bholley r=smaug 2014-04-02 15:28:03 +01:00
Birunthan Mohanathas
208cf20401 Bug 845478 - Part 7: Use JS::CallArgs instead of JS_ARGV, argc in ipc/{ril,nfc}/. r=vicamo 2014-03-24 08:50:10 -04:00
Douglas Crosher
71972c4eb2 Bug 976537 - Guard against crashing in NFC shutdown when sNfcConsumer is NULL. r=allstars.chh 2014-02-26 00:54:54 +11:00
Thomas Zimmermann
21d22e285e Bug 972265: Use connect delay in NFC IPC code, r=allstars.chh
When trying to re-connect a socket, the NFC IPC code now respects
the delay that is suggested by the UnixSocketConsumer.
2014-02-14 08:03:27 +01:00
Jon Coppeard
735137fc57 Bug 959787 - Handlify arguments for Call APIs r=terrence r=bz 2014-02-13 15:33:04 +00:00
Jon Coppeard
c3759c40ff Bug 965830 - Convert use of JS_CallFunction and related APIs uses to HandleValueArray r=terrence r=smaug 2014-02-11 10:59:16 +00:00
Birunthan Mohanathas
02d0812720 Bug 828300 - Replace NS_ARRAY_LENGTH with mozilla::ArrayLength/MOZ_ARRAY_LENGTH. r=ehsan 2014-01-30 13:26:54 -05:00
Terrence Cole
91ca6a1d69 Bug 959787 - Handlify several JSAPI interfaces that can GC, Part 6; r=jonco 2014-01-17 10:10:17 -08:00
Thomas Zimmermann
ce8c974daf Bug 958444: Fix address setup in NFC connector, r=allstars.chh
The use of htons on the network address truncates its value. Using
htonl instead fixes this problem. The change also makes Nfc.cpp
build without warnings.
2014-01-10 12:40:51 +01:00
Ehsan Akhgari
ae6b29e6ac Bug 951207 - Rename the chromium LOG macro to CHROMIUM_LOG; r=bent 2013-12-17 13:26:45 -05:00
Yoshi Huang
b94bfb6a50 Bug 939052 - B2G NFC: NFC socket callback prints too much log. r=vicamo 2013-11-21 12:23:36 +08:00
Mike Hommey
2812d11fce Bug 939632 - Remove LIBRARY_NAME for leaf libraries. r=gps
Landing on a CLOSED TREE.
2013-11-19 11:50:54 +09:00
Mike Hommey
e06d795c71 Bug 939074 - Remove most LIBXUL_LIBRARY. rs=gps 2013-11-19 11:48:10 +09:00
Mike Hommey
e80e877ab7 Bug 939044 - Remove most definitions of MODULE. r=mshal 2013-11-19 11:47:39 +09:00
Mike Hommey
ffe0380912 Bug 935881 - Use FINAL_LIBRARY for all (fake) libraries that end up linked in a single other library. r=gps 2013-11-19 11:47:14 +09:00
Garner Lee
7105874117 Bug 933635 - Part 3: NFC IPC Sources. r=yoshi 2013-11-01 17:45:46 +08:00
Garner Lee
994bbe133b Bug 933635 - Part 1: NFC IPC Makefiles. r=khuey 2013-11-01 14:52:59 +08:00
Chuck Lee
f497343dae Bug 928223 - 0001. Add function to perform setup for listen socket. r=qDot echou vicamo yoshi 2013-10-25 10:00:22 +08:00