Commit Graph

218 Commits

Author SHA1 Message Date
Chris H-C
bd45a385a1 bug 1408433 - Remove toolkit.telemetry.enabled code from Experiments r=Dexter
MozReview-Commit-ID: 1Kz7G2oJWO6
2017-10-30 10:47:39 -04:00
Chris H-C
75fc345254 bug 1406391 - Remove toolkit.telemetry.enabled manipulation from tests r=Dexter
Minor note:
reftests should've turned off uploadEnabled in the first place.
reftests should have unified telemetry on. It's the future.

MozReview-Commit-ID: 9spzuUAXwwP
2017-10-30 10:47:39 -04:00
Phil Ringnalda
4bc2b1615d Backed out 4 changesets (bug 1408433, bug 1406391, bug 1408512) for crashing tests by touching the network contacting incoming.telemetry.mozilla.org on nightly builds
Backed out changeset 9bfd4b0927dc (bug 1408433)
Backed out changeset 555850d5107e (bug 1408512)
Backed out changeset 15d959b9123e (bug 1406391)
Backed out changeset e1f34ba9cecc (bug 1406391)

MozReview-Commit-ID: BVoGRsD73Hf
2017-10-27 21:08:27 -07:00
Chris H-C
4d5d42a5b6 bug 1408433 - Remove toolkit.telemetry.enabled code from Experiments r=Dexter
MozReview-Commit-ID: 1Kz7G2oJWO6
2017-10-27 11:00:00 -04:00
Chris H-C
8e6dd31d55 bug 1406391 - Remove toolkit.telemetry.enabled manipulation from tests r=Dexter
Minor note:
reftests should've turned off uploadEnabled in the first place.

MozReview-Commit-ID: 9spzuUAXwwP
2017-10-27 10:59:43 -04:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Georg Fritzsche
fceee5b7a0 Bug 1402609 - Part 2: Make Experiments.jsm recover from unloadable manifest cache. r=Dexter 2017-10-06 05:05:00 -04:00
Andy McKay
d98a197abf bug 1355788 rename Appearance to Themes r=aswan
MozReview-Commit-ID: mUhecHDOUD

--HG--
extra : rebase_source : 50835e38c9cbb37caf706c1d05d0bb386067d9be
2017-08-24 11:16:37 -07:00
Mark Banner
a53020d022 Bug 1392098 - Enable the new ESLint no-useless-run-test rule across the tree. r=mossop
MozReview-Commit-ID: 35MaseieNUk

--HG--
extra : rebase_source : 98eaec6a67fd3b30ea6b0be641f26c3911012fab
2017-08-20 18:52:05 +01:00
Masatoshi Kimura
8b713b2b0f Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.

MozReview-Commit-ID: 4ecl3RZhOwC

--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
2017-08-04 17:49:22 +09:00
Rajesh Kathiriya
48e6bc2124 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
2017-07-25 23:45:41 +05:30
Marco Castelluccio
0abc80eebf Bug 1357517 - Remove or delay Preferences.jsm usage from some browser/components/* files. r=Gijs
--HG--
extra : rebase_source : 8ae926bfde827b9a5323d6fb96dc231d429ab9b0
2017-07-31 13:25:41 +02:00
Luciano Italiani
dd592719c1 Bug 1374671 - Enable the ESLint no-whitespace-before-property rule across mozilla-central. r=standard8
MozReview-Commit-ID: 4WkNg0YrgHx

--HG--
extra : rebase_source : 2c32028e81c388406455004c2adcdb4a01942b95
2017-07-27 23:01:13 -03:00
Andrew Halberstadt
21a03ad73c Bug 1383120 - Enable no-arbitrary-setTimeout eslint rule on xpcshell tests, r=mossop
MozReview-Commit-ID: 6DqLaZ9n5EM

--HG--
extra : rebase_source : 5f1264bb3ea23005c91557e5db4ce5f9e167ce9a
2017-07-26 09:08:07 -04:00
Mark Banner
35f3666937 Bug 1380009 - Enable the ESLint no-return-await call to avoid unnecessary intermediate promise creation. r=mossop
MozReview-Commit-ID: EnhSBHMjurr

--HG--
extra : rebase_source : 74ba4c10e369067629af95bf705a9acd0df1089b
2017-07-11 22:49:55 +01:00
Andrew Swan
763a6bb5b1 Bug 1358907 Part 3 Avoid reading XPI database at startup r=Dexter,kmag
Switch telemetry and experiments from AddonManager.getAddonsByTypes()
to AddonManager.getActiveAddons() which gives us less detailed information
in the environment during startup but also means we don't need to load the
extensions database until startup is complete.

MozReview-Commit-ID: 4SxdPHSPovB

--HG--
extra : rebase_source : da99f2692ee57e66d65c6b1c1a84412088cc7b28
extra : source : c391410c07ed5a9462ca7dec8c01037c9ab14466
2017-05-18 13:08:58 -07:00
Wes Kocher
4572107fe1 Backed out 3 changesets (bug 1358907) for devtools failures in leakcheck a=backout
Backed out changeset 529eccc2bc69 (bug 1358907)
Backed out changeset 5368cc2c4f38 (bug 1358907)
Backed out changeset d112bc46842f (bug 1358907)

MozReview-Commit-ID: D2oHpM7GgrW
2017-07-03 14:43:57 -07:00
Andrew Swan
99c51b42b5 Bug 1358907 Part 3 Avoid reading XPI database at startup r=Dexter
Switch telemetry and experiments from AddonManager.getAddonsByTypes()
to AddonManager.getActiveAddons() which gives us less detailed information
in the environment during startup but also means we don't need to load the
extensions database until startup is complete.

MozReview-Commit-ID: 4SxdPHSPovB

--HG--
extra : rebase_source : c4810207bd08c426bb2f5b63b93dfc38e0b0245a
extra : source : c391410c07ed5a9462ca7dec8c01037c9ab14466
2017-05-18 13:08:58 -07:00
Florian Quèze
2924991bf6 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Florian Quèze
721c3ada5e Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Florian Quèze
c3a5e47cea Bug 1034599 - Convert remaining Promise.defer() uses to PromiseUtils.defer() or new Promise(), r=mconley. 2017-06-23 11:25:02 +02:00
Florian Quèze
7375dcec46 Bug 1374282 - script generated patch to remove generators from add_task in browser/ and toolkit/, r=Mossop. 2017-06-22 12:51:43 +02:00
Paolo Amadini
10ee6a5c4e Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P

--HG--
extra : rebase_source : 3a9ea310d3e4a8642aabbc10636c04bfe2e77070
2017-06-19 11:32:37 +01:00
Florian Quèze
85e816d9e7 Bug 1362882 - hand cleanup after applying the previous script-generated patch, r=Mossop. 2017-05-12 14:56:12 +02:00
Florian Quèze
97f401c644 Bug 1362882 - script-generated patch to switch from Promise.defer() to new Promise() where it's straightforward, rs=Mossop. 2017-05-12 14:55:27 +02:00
Florian Quèze
1d0e28a791 Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
16530fa1e3 Bug 1353542 - smaller script-generated patch converting remaining generators that are likely tasks (actual generators were identified by hand and whitelisted), r=Mossop. 2017-05-12 14:45:01 +02:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Quèze
2e2f358aa9 Bug 1353542 - pre-script hand-written cleanup patch, r=Mossop. 2017-05-12 14:41:20 +02:00
Mark Banner
ec019988a1 Bug 1348097 - Fix intermittent failures caused by Experiments.jsm by ensuring the preference monitoring is in sync. r=gfritzsche
Change the ExperimentsService to get the current value of the preferences (since it only uses them once or twice), so that they match the values in Experiments, and avoid differences causing promises to be rejected in the updateManifest call.
Also fix Experiments to correctly re-enable itself when toolkit.telemetry.enabled is changed from false to true (also fixes bug 1232648).
Finally, add a catch for a promise when calling updateManifest so that we don't get an uncaught promise exception.

MozReview-Commit-ID: GD6gfcRSgbx

--HG--
extra : rebase_source : a5045275c2f864b75443c2cb8fc531ea0e84a704
2017-04-19 12:06:16 +01:00
Wes Kocher
ef1cc83d8b Backed out changeset e1c9c6e89f50 (bug 1348097) for asan failures in test_SubsessionChaining.js a=backout
MozReview-Commit-ID: AiAjjlBmODC
2017-04-20 13:34:16 -07:00
Mark Banner
d8477f9e65 Bug 1348097 - Fix intermittent failures caused by Experiments.jsm by ensuring the preference monitoring is in sync. r=gfritzsche
Change the ExperimentsService to get the current value of the preferences (since it only uses them once or twice), so that they match the values in Experiments, and avoid differences causing promises to be rejected in the updateManifest call.
Also fix Experiments to correctly re-enable itself when toolkit.telemetry.enabled is changed from false to true (also fixes bug 1232648).
Finally, add a catch for a promise when calling updateManifest so that we don't get an uncaught promise exception.

MozReview-Commit-ID: GD6gfcRSgbx

--HG--
extra : rebase_source : 44226ad68bc0bc8b9b763016ea54ca022bfcbcf9
2017-04-19 12:06:16 +01:00
Joel Maher
6af97db02d Bug 1355088 - add BUG_COMPONENT to browser/* files. r=mossop
MozReview-Commit-ID: 88mDTdI0oN7
2017-04-19 08:11:47 -04:00
Florian Queze
4c6a68d1c9 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
f935ddc4b3 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
159215e6f4 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
738d097aae Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
3c564a2b02 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
a363fb8c8b Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Zibi Braniecki
3d91da8726 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 513ed31d995864939aa893e73c81ffdf591a6617
2017-03-14 16:09:54 -07:00
Sebastian Hengst
0a04f3b9e2 Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
c2cd68a689 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 13fa4c397ba4c79303a2cd76684b5b8c4bd17331
2017-03-14 16:09:54 -07:00
Mark Banner
bd625e4e9f Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6

--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
Mark Banner
16e6d381ac Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ

--HG--
extra : rebase_source : daa8efb3409031fea553f4fd0c9d0746e38dc308
extra : histedit_source : b4c23aacf678ba0d0ac9c09191a7c494ead11a08
2017-01-18 10:30:39 +00:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Mark Banner
582fcb8090 Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws
MozReview-Commit-ID: 5NKHHb70YA6

--HG--
extra : rebase_source : 4551e56f56065349fb9ddc8d90e67f9dc84c1701
2017-01-09 10:12:26 +00:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00