Commit Graph

145 Commits

Author SHA1 Message Date
Eitan Isaacson
c1c0b3551c Bug 1625184 - Map dialogs and alert dialogs correctly in Mac. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D74957
2020-05-13 05:59:23 +00:00
Eitan Isaacson
c5398f4399 Bug 1625196 - Support select[multiple] and role=listbox/option. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D72485
2020-05-12 23:28:34 +00:00
Eitan Isaacson
f395ad8878 Bug 1635517 - Ignore all invisible XUL elements. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D74433
2020-05-12 17:26:34 +00:00
Eitan Isaacson
ac48c6ea9a Bug 1635517 - Filter ignored mac accessible objects from platform tree. r=morgan
Also, allow parent accessibles to ignore certain children.

Differential Revision: https://phabricator.services.mozilla.com/D74432
2020-05-12 19:06:02 +00:00
Eitan Isaacson
567a8af15c Bug 1635517 - Update deprecated accessibilityIsIgnored to isAccessibilityElement. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D74431
2020-05-12 17:39:18 +00:00
Marco Zehe
6c331c5c53 Bug 1635483 - Avoid unnecessary IPC calls when calculating subroles for landmarks, r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D74008
2020-05-11 17:51:12 +00:00
Morgan Reschenberg
22bf5cdb58 Bug 1624954: Add support for AXPopupValue, modify AXHasPopup to boolean. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D73912
2020-05-07 18:07:34 +00:00
Marco Zehe
0eedff8d8e Bug 1635184 - Add actual support for input type='search' in MacOS, r=eeejay
The code in mozAccessible SubRole was actually never executed for inputs, so the SearchField sub role was never set. Moved the implementation to mozTextAccessible. Also reenabled the tests from bug 1634373, which now pass.

Depends on D73308

Differential Revision: https://phabricator.services.mozilla.com/D73735
2020-05-05 17:45:52 +00:00
Morgan Reschenberg
1c82fd0b4b Bug 1624954: query attribute string for aria-haspopup instead of relying on flag alone. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D70264
2020-04-30 21:38:45 +00:00
Csoregi Natalia
5ca61e2a3c Backed out 2 changesets (bug 1624954) for eslint failure on browser_aria_haspopup.js. CLOSED TREE
Backed out changeset 2a3f592412a2 (bug 1624954)
Backed out changeset 74085e028726 (bug 1624954)
2020-04-30 23:37:28 +03:00
Morgan Reschenberg
5636f6c7df Bug 1624954: query attribute string for aria-haspopup instead of relying on flag alone. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D70264
2020-04-30 20:12:45 +00:00
Morgan Reschenberg
707b0c1a92 Bug 1624936: Add required state caching, attribute handling for mozCheckboxAccessibles. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D70231
2020-04-28 18:19:39 +00:00
Eitan Isaacson
d7324d465e Bug 1625870 - Support figure and figcaption is OSX. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D72509
2020-04-28 19:45:51 +00:00
Brindusan Cristian
ae12f8e207 Backed out changeset b9710246d416 (bug 1625870) for mochitest failures at test_figure.html. CLOSED TREE 2020-04-28 21:54:31 +03:00
Eitan Isaacson
b62ce6a55b Bug 1625870 - Support figure and figcaption is OSX. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D72509
2020-04-28 18:04:00 +00:00
Eitan Isaacson
5e43ff1e1e Bug 1625864 - Expose unlinked a tags as AXGroup. r=morgan
This is the recommended role in the HTML Accessibility API Mappings draft[1].

Although Chrome and Safari just expose unlinked a tags as AXStaticText.
They also don't update the accessble if it gets an href. So while we
are doing this a bit differently, I think it is probably better. And VO is happy.

1. https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings

Differential Revision: https://phabricator.services.mozilla.com/D71260
2020-04-24 14:36:36 +00:00
Marco Zehe
f6858d521e Bug 1631406 - Expose the correct sub role for HTML HR elements, r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D71548
2020-04-23 15:30:35 +00:00
Eitan Isaacson
2edb3fea1a Bug 1619752 - Use AXSelected=false to tell VoiceOver about link groups. r=morgan
I really don't understand why this is what VoiceOver needs, but it seems to do the trick.

Differential Revision: https://phabricator.services.mozilla.com/D70776

--HG--
extra : moz-landing-system : lando
2020-04-14 17:15:07 +00:00
Eitan Isaacson
ca37dab5ab Bug 1627765 - Remove mac heirarchy cache. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D69880

--HG--
extra : moz-landing-system : lando
2020-04-10 17:52:58 +00:00
Eitan Isaacson
17f84615a2 Bug 1627765 - Rename firePlatformEvent to handleAccessibleEvent. r=morgan
The latter seems more accurate to what that method does, since we don't necessarily
forward that event to the OS, but might instead use it to update cached properties.

Differential Revision: https://phabricator.services.mozilla.com/D69878

--HG--
extra : moz-landing-system : lando
2020-04-09 22:57:47 +00:00
Morgan Reschenberg
2e7598ddac Bug 1624964: Add visited attribute to links, state caching for TRAVERSED. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D70095

--HG--
extra : moz-landing-system : lando
2020-04-10 15:54:15 +00:00
Morgan Reschenberg
883afead1b Bug 1627763: Adjust coordinates of layout point for launching context menu. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D69874

--HG--
extra : moz-landing-system : lando
2020-04-06 22:07:25 +00:00
Morgan Reschenberg
945f2ee931 Bug 1618705: Construct column containers and list them as children of our table accessible. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67900

--HG--
extra : moz-landing-system : lando
2020-04-06 16:51:11 +00:00
Eitan Isaacson
99fcfa7336 Bug 1626638 - Add subrole of AXTabButtton to page tabs. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D69212

--HG--
extra : moz-landing-system : lando
2020-04-02 05:47:52 +00:00
Eitan Isaacson
cd6b27feeb Bug 1626036 - Cache SELECTED state in Mac. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D69133

--HG--
extra : moz-landing-system : lando
2020-04-02 16:44:33 +00:00
Eitan Isaacson
9d0aad6f8b Bug 1626036 - Cache CURRENT state in Mac. r=morgan
This allows us to not pull in attributes for every accessible.

Differential Revision: https://phabricator.services.mozilla.com/D69132

--HG--
extra : moz-landing-system : lando
2020-04-02 16:44:24 +00:00
Eitan Isaacson
df0924d72a Bug 1626036 - Initial Mac state caching. r=morgan
Here I added caching for all the toggle states, and expanded.

Differential Revision: https://phabricator.services.mozilla.com/D69131

--HG--
extra : moz-landing-system : lando
2020-04-02 16:42:46 +00:00
Eitan Isaacson
df6032b2ba Bug 1626036 - Add a stateWithMask method to mozAccessible. r=morgan
Having this kind of method will let us know what the states of interest are.
If all the states are cached we can return them without inquiring the full state.

Differential Revision: https://phabricator.services.mozilla.com/D69130

--HG--
extra : moz-landing-system : lando
2020-04-02 05:47:43 +00:00
Morgan Reschenberg
bb48588461 Bug 1625832: Feed mouse synthesizer gecko coordinates instead of Mac coordinates. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D69035

--HG--
extra : moz-landing-system : lando
2020-04-01 05:07:53 +00:00
Morgan Reschenberg
53fcf5a7d2 Bug 1617311: Add details/summary attributes and values. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67233

--HG--
extra : moz-landing-system : lando
2020-03-27 22:08:40 +00:00
Eitan Isaacson
14ca656c7f Bug 1624729 - Notify observer service of mac accessibility events. r=morgan,yzen
Differential Revision: https://phabricator.services.mozilla.com/D68127

--HG--
extra : moz-landing-system : lando
2020-03-27 17:11:44 +00:00
Eitan Isaacson
0ade2fd945 Bug 1624729 - Refactor event firing and encapsulate it in mozAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D68126

--HG--
extra : moz-landing-system : lando
2020-03-27 17:12:33 +00:00
Morgan Reschenberg
9e89b53321 Bug 1623402: Add ShowMenu to action names, perform action. r=eeejay
Depends on D67200

Differential Revision: https://phabricator.services.mozilla.com/D67409

--HG--
extra : moz-landing-system : lando
2020-03-27 17:08:58 +00:00
Marco Zehe
0948ee96fa Bug 1625153 - Implement the WAI-ARIA 1.2 code role, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D68432

--HG--
extra : moz-landing-system : lando
2020-03-26 21:26:15 +00:00
Razvan Maries
3ee91b8422 Backed out changeset 0bf2517f7a99 (bug 1623402) for build bustages. CLOSED TREE 2020-03-26 19:25:30 +02:00
Morgan Reschenberg
791753ad49 Bug 1623402: Add ShowMenu to action names, perform action. r=eeejay
Depends on D67200

Differential Revision: https://phabricator.services.mozilla.com/D67409

--HG--
extra : moz-landing-system : lando
2020-03-25 22:10:27 +00:00
Morgan Reschenberg
70cc6039b1 Bug 1616679: Map accessible actions to Mac actions based on action name. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67200

--HG--
extra : moz-landing-system : lando
2020-03-25 22:09:59 +00:00
Cosmin Sabou
88a9cd318e Backed out changeset 570f25f87e0a (bug 1616679) for bustages on mozAccessible.mm. CLOSED TREE 2020-03-25 19:26:48 +02:00
Morgan Reschenberg
2856a68236 Bug 1616679: Map accessible actions to Mac actions based on action name. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67200

--HG--
extra : moz-landing-system : lando
2020-03-25 17:08:15 +00:00
Eitan Isaacson
f8243143b8 Bug 1622731 - Notify of destruction after detaching accessible wrap/proxy. r=morgan
Depends on D67673

Differential Revision: https://phabricator.services.mozilla.com/D67674

--HG--
extra : moz-landing-system : lando
2020-03-21 05:26:19 +00:00
Eitan Isaacson
d014504afb Bug 1617314 - Support aria-current in OSX. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66813

--HG--
extra : moz-landing-system : lando
2020-03-16 22:15:57 +00:00
Eitan Isaacson
b70e223767 Bug 1618718 - Support AXToggle subrole and states. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66841

--HG--
extra : moz-landing-system : lando
2020-03-14 05:39:59 +00:00
Eitan Isaacson
83b8e2b9c3 Bug 1618700 - Implement expected attributes and events for tabs. r=morgan
I made more generalized mozSelectableAccessible and
mozSelectableChildAccessible classes for other things that will need
this kind of support.

Differential Revision: https://phabricator.services.mozilla.com/D66304

--HG--
extra : moz-landing-system : lando
2020-03-12 22:16:39 +00:00
Eitan Isaacson
b0389fe116 Bug 1617310 - Support AXHasPopup attribute. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66498

--HG--
extra : moz-landing-system : lando
2020-03-12 17:28:42 +00:00
Eitan Isaacson
640b0ba055 Bug 1617310 - Introduce state method in mozAccessible interface. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66497

--HG--
extra : moz-landing-system : lando
2020-03-12 17:28:35 +00:00
Eitan Isaacson
088ece22c2 Bug 1618719 - Support aria radio groups. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66337

--HG--
extra : moz-landing-system : lando
2020-03-11 22:54:37 +00:00
Eitan Isaacson
e275f3ca37 Bug 1617308 - Provide AXDescription for named groupings. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66336

--HG--
extra : moz-landing-system : lando
2020-03-11 22:54:35 +00:00
Marco Zehe
2c553e7cf6 Bug 1371712 - Fall through to ARIA landmark role determination if native landmark roles fail, r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D65946

--HG--
extra : moz-landing-system : lando
2020-03-11 16:23:38 +00:00
Eitan Isaacson
d18ab374a8 Bug 1620318 - Filter out hidden popup menus and announce them when they appear. r=morgan
As the message above suggests this does two things:
1. We filter out the invisible popup menus from the root's children.
2. We dispatch menu opened and closed events.

The latter helps VoiceOver retain some context about the mutating tree and notify the user about the menu.

Differential Revision: https://phabricator.services.mozilla.com/D65612

--HG--
extra : moz-landing-system : lando
2020-03-10 22:42:31 +00:00
Eitan Isaacson
01c6855e5e Bug 1619438 - Don't get dom node id from accessible with no associated content. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D65029

--HG--
extra : moz-landing-system : lando
2020-03-03 17:45:15 +00:00