Commit Graph

348 Commits

Author SHA1 Message Date
Tiberius Oros
edaadd3804 Backed out changeset d4c858c70bc9 (bug 1479445) for failing xpcshell at services/sync/tests/unit/test_corrupt_keys.js on a CLOSED TREE 2018-09-25 23:14:52 +03:00
Siddhant085
2bd3beeba9 Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8
Changed the validation function for PageInfo to use a more general validateItemProperties.
This changes the error message being thrown. Changed the respective test cases to accomodate the change.

Differential Revision: https://phabricator.services.mozilla.com/D5831

--HG--
extra : moz-landing-system : lando
2018-09-25 18:21:56 +00:00
Csoregi Natalia
eeaa237703 Backed out changeset db16547e0d60 (bug 1479445) for failures on /xpcshell/test_ext_history.js. CLOSED TREE 2018-09-24 21:55:55 +03:00
Siddhant085
18019a377e Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8
Changed the validation function for PageInfo to use a more general validateItemProperties.
This changes the error message being thrown. Changed the respective test cases to accomodate the change.

Differential Revision: https://phabricator.services.mozilla.com/D5831

--HG--
extra : moz-landing-system : lando
2018-09-24 16:12:46 +00:00
Marco Bonardo
d21efaaa9b Bug 1488776 - Move the urlbar connection to PlacesUtils. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D5045

--HG--
extra : moz-landing-system : lando
2018-09-05 23:42:05 +00:00
Mark Banner
608eb9f975 Bug 1486783 - Fix some undefined property references to description and previewImageURL in PlacesUtils.jsm and History.jsm. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D4451

--HG--
extra : moz-landing-system : lando
2018-08-30 13:50:14 +00:00
Mark Banner
23c68929d3 Bug 1486808 - Remove nsINavBookmarksService::unfiledBookmarksFolder and PlacesUtils.unfiledBookmarksFolderId. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D4456

--HG--
extra : moz-landing-system : lando
2018-08-30 08:47:46 +00:00
Mark Banner
bf2dba5c9f Bug 1476228 - Enable comma-dangle ESLint rule for Places directories. r=mikedeboer
MozReview-Commit-ID: K8HcZfyF4Sz

Differential Revision: https://phabricator.services.mozilla.com/D3796

--HG--
extra : moz-landing-system : lando
2018-08-22 15:44:43 +00:00
Mark Banner
8ca5017f6f Bug 1481445 - Remove nsINavBookmarksService::mobileFolder and PlacesUtils.mobileFolderId. r=lina
Depends on D2851

Differential Revision: https://phabricator.services.mozilla.com/D2852

--HG--
extra : moz-landing-system : lando
2018-08-07 18:09:01 +00:00
Mark Banner
8c39205461 Bug 1481445 - Remove the id option for PlacesUtils.isRootItem (guids only accepted). r=lina
Depends on D2850

Differential Revision: https://phabricator.services.mozilla.com/D2851

--HG--
extra : moz-landing-system : lando
2018-08-07 17:37:01 +00:00
Mark Banner
ccfb776495 Bug 1481445 - Replace usage of the old bookmark ids in promiseBookmarksTree with guids. r=lina
MozReview-Commit-ID: AgqSKneywM4

Differential Revision: https://phabricator.services.mozilla.com/D2850

--HG--
extra : moz-landing-system : lando
2018-08-07 15:01:32 +00:00
Mark Banner
f1731211b5 Bug 1479722 - Rework PlacesUtils.setCharsetForURI to PlacesUIUtils.setCharsetForPage and avoid main thread sync io. r=mak
MozReview-Commit-ID: HeO3Mm5Dibo

Differential Revision: https://phabricator.services.mozilla.com/D2582

--HG--
extra : moz-landing-system : lando
2018-08-01 10:13:59 +00:00
Mark Banner
1bafa1f3a2 Bug 1468980 - Add an annotations parameter to PlacesUtils.history.update to retrieve any annotations. r=mak
MozReview-Commit-ID: 9pobdfHodcG

--HG--
extra : rebase_source : 05e9dea7b9cced745023c424db07d8e64cbccca0
2018-07-25 07:34:35 +01:00
Marco Bonardo
23cf556fe1 Bug 1477996 - Move getURIsForTag to the bookmarking API. r=Standard8,lina
The tagging API is being merged into the bookmarking API. This is part of it.

Differential Revision: https://phabricator.services.mozilla.com/D2450

--HG--
extra : moz-landing-system : lando
2018-07-27 15:16:57 +00:00
Marco Bonardo
6da5d81859 Bug 1452068 - Move MAX_TAG_LENGTH to the bookmarking API. r=Standard8
The tagging API is moving to the bookmarking API, this is one step

Differential Revision: https://phabricator.services.mozilla.com/D2315

--HG--
extra : moz-landing-system : lando
2018-07-24 18:45:13 +00:00
Mark Banner
8de4344378 Bug 1462135 - Replace PlacesUtils.getCharsetForURI with PU.history.fetch with an option to fetch annotations. r=mak
This also avoids us doing main thread sync io.

MozReview-Commit-ID: KR0p7eeu1sj

Differential Revision: https://phabricator.services.mozilla.com/D2117

--HG--
extra : moz-landing-system : lando
2018-07-24 16:41:22 +00:00
Mark Banner
acb2be40d6 Bug 1446325 - Stop inserting the default smart bookmarks into new profiles. r=mak,lina
MozReview-Commit-ID: AGQaw1rgukO

Differential Revision: https://phabricator.services.mozilla.com/D1831

--HG--
extra : moz-landing-system : lando
2018-07-02 16:25:09 +00:00
Doug Thayer
abe46fa52a Bug 1340498 - Update onVisits uses to 'page-visited' r=mak
Consuming the new 'page-visited' notification was fairly trivial,
since it was already brought over to onVisits. There's not much to
say about this other than that I'm a little bit uncertain about
all the hoops we have to jump through to get a JSContext and
GlobalObject from History.cpp (which is discussed in the earlier
commit in the series).

MozReview-Commit-ID: LHaBWSylyLI

--HG--
extra : rebase_source : ef8fa174f902e6abd397fb80294e83843120aa81
2018-02-14 09:11:49 -08:00
Dorel Luca
d296624690 Backed out 5 changesets (bug 1340498) for build bustage due to conflicts with bug 1470325. a=backout
Backed out changeset 28bedb658af4 (bug 1340498)
Backed out changeset f950a2310e26 (bug 1340498)
Backed out changeset 5fcd31c65fe0 (bug 1340498)
Backed out changeset 515bb5e24dd7 (bug 1340498)
Backed out changeset 79a8619bd3e2 (bug 1340498)
2018-06-27 14:05:20 +03:00
Doug Thayer
0a912f9667 Bug 1340498 - Update onVisits uses to 'page-visited' r=mak
Consuming the new 'page-visited' notification was fairly trivial,
since it was already brought over to onVisits. There's not much to
say about this other than that I'm a little bit uncertain about
all the hoops we have to jump through to get a JSContext and
GlobalObject from History.cpp (which is discussed in the earlier
commit in the series).

MozReview-Commit-ID: LHaBWSylyLI

--HG--
extra : rebase_source : fd064e53e8645c3914188c05e71c8800d6f2174b
2018-02-14 09:11:49 -08:00
Bogdan Tara
d2fb3a8812 Backed out 5 changesets (bug 1340498) for build bustages on nsDOMCSSAttrDeclaration.h CLOSED TREE
Backed out changeset 9ebcdb66ceff (bug 1340498)
Backed out changeset 63321093bb70 (bug 1340498)
Backed out changeset f8c799971f81 (bug 1340498)
Backed out changeset 21d8c1fbbbd1 (bug 1340498)
Backed out changeset fa40c179eb0d (bug 1340498)
2018-06-26 21:31:09 +03:00
Doug Thayer
4dd5940382 Bug 1340498 - Update onVisits uses to 'page-visited' r=mak
Consuming the new 'page-visited' notification was fairly trivial,
since it was already brought over to onVisits. There's not much to
say about this other than that I'm a little bit uncertain about
all the hoops we have to jump through to get a JSContext and
GlobalObject from History.cpp (which is discussed in the earlier
commit in the series).

MozReview-Commit-ID: LHaBWSylyLI

--HG--
extra : rebase_source : 1190d4f127453cdcb692deb5982e92a93e236b9e
2018-02-14 09:11:49 -08:00
Mark Banner
1808cc5dec Bug 1467996 - Remove all the code adding a description annotation. r=mak,lina
MozReview-Commit-ID: CRBSxJtJELp

Differential Revision: https://phabricator.services.mozilla.com/D1748
2018-06-26 12:33:45 +00:00
arthur.iakab
fc7e217166 Backed out 5 changesets (bug 1340498) for build bustages on SelectionChangeListener.h on a CLOSED TREE
Backed out changeset c89b86622d38 (bug 1340498)
Backed out changeset b270d4a01986 (bug 1340498)
Backed out changeset 8ed32495b46f (bug 1340498)
Backed out changeset df9a67c58183 (bug 1340498)
Backed out changeset a5977e0708ea (bug 1340498)
2018-06-26 07:59:01 +03:00
Doug Thayer
22f93b18ef Bug 1340498 - Update onVisits uses to 'page-visited' r=mak
Consuming the new 'page-visited' notification was fairly trivial,
since it was already brought over to onVisits. There's not much to
say about this other than that I'm a little bit uncertain about
all the hoops we have to jump through to get a JSContext and
GlobalObject from History.cpp (which is discussed in the earlier
commit in the series).

MozReview-Commit-ID: LHaBWSylyLI

--HG--
extra : rebase_source : 1190d4f127453cdcb692deb5982e92a93e236b9e
2018-02-14 09:11:49 -08:00
arthur.iakab
8b1be0e972 Backed out 5 changesets (bug 1340498) for build bustages on SelectionChangeListener.h on a CLOSED TREE
Backed out changeset fae677707059 (bug 1340498)
Backed out changeset 2adde1d1742a (bug 1340498)
Backed out changeset a444ab9cefde (bug 1340498)
Backed out changeset e2ac49ef2034 (bug 1340498)
Backed out changeset 6465310b3de9 (bug 1340498)
2018-06-26 03:53:21 +03:00
Doug Thayer
41d49cecec Bug 1340498 - Update onVisits uses to 'page-visited' r=mak
Consuming the new 'page-visited' notification was fairly trivial,
since it was already brought over to onVisits. There's not much to
say about this other than that I'm a little bit uncertain about
all the hoops we have to jump through to get a JSContext and
GlobalObject from History.cpp (which is discussed in the earlier
commit in the series).

MozReview-Commit-ID: LHaBWSylyLI

--HG--
extra : rebase_source : 148555189f73fb29a48296215e367c406f3f0286
2018-02-14 09:11:49 -08:00
Mark Banner
5b8ba7f27e Bug 1452645 - Remove load in sidebar functionality. r=lina,mak
Based on patch by mixedpuppy.

MozReview-Commit-ID: BZwOtr4VbCH

--HG--
extra : rebase_source : 2e3ad3fedaf82d0e5d3db9bcebf1c2faa46447e7
2018-06-06 21:00:45 +01:00
Rob Hoelz
4006db9fd9 Bug 1468104 - Existence of tag on a bookmark prevents deletion of associated keyword. r=mak
MozReview-Commit-ID: B0w1dZhVBWw

--HG--
extra : rebase_source : 58d8fe1ac60f0130474e47fa6820bee484097ec1
2018-06-19 16:40:08 +02:00
Kris Maglione
7b7264f453 Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8
MozReview-Commit-ID: 9APGewiDDYB

--HG--
extra : rebase_source : 2931dd0eec0e4206414b698a9700fc20d922eb3a
2018-05-25 17:02:29 -07:00
Mark Banner
cc9a408716 Bug 1465380 - Add handling of objects and arrays to PlacesUtils.metadata, and add optional default values for get(). r=mak
MozReview-Commit-ID: 8OQxAus4rXY

--HG--
extra : rebase_source : e0ef0bba5873485562a2e85c0df68c4015dc3bd7
2018-05-30 11:36:31 +01:00
Mark Banner
b321b832fd Bug 824502 - Fix unit tests for the folder=<id> to parent=<guid> transition. r=mak
MozReview-Commit-ID: FCaiJrSAMAV

--HG--
extra : rebase_source : 1edf169c3a24b1c0b8c1be2e8eb0f06e8605df80
2018-05-01 08:14:53 +01:00
Drew Willcoxon
cd74785cab Bug 1239708: Improve awesomebar autofill. Part 2: Non-core follow-ons. r=mak
MozReview-Commit-ID: IFm1arAhjF5

--HG--
extra : rebase_source : f1d8c838e2b690de30bfbc688926aba62880509e
2018-05-14 11:25:33 -07:00
Marco Bonardo
c8e987256f Bug 1460570 - Merge mozIAsyncFavicons into nsIFaviconService. r=standard8
MozReview-Commit-ID: JAxNj9MfcUI

--HG--
extra : rebase_source : b096792719a74fcf15909ce93f0d9341754009f6
2018-05-10 13:49:00 +02:00
Marco Bonardo
c77855f4fe Bug 1458910 - Merge nsPIPlacesDatabase into nsINavHistoryService. r=standard8
MozReview-Commit-ID: LacXKR32Jn3

--HG--
extra : rebase_source : 27f7d939ab9acab6eb4896e8fc1348e74aee35cf
2018-05-10 10:39:12 +02:00
Mark Banner
5eb5ca8bc6 Bug 1460580 - Drop remaining references to the 'placesInternal/READ_ONLY' annotation. r=mak
MozReview-Commit-ID: JlZFgKWEH4V

--HG--
extra : rebase_source : 1c5784c4e83554ba0f24f1bee012a3a7615bf846
2018-05-10 13:53:58 +01:00
Marco Bonardo
eb1c7462fb Bug 1459856 - Remove the comm-central only asyncHistory accessor. r=standard8
MozReview-Commit-ID: BU2FnIakdob

--HG--
extra : rebase_source : 4e57d4dc19fa464e86c25f8ff45c897c0d864b8e
2018-05-10 10:19:12 +02:00
Marco Bonardo
ad2c103055 Bug 739219 - Remove nsIBrowserHistory. r=standard8
MozReview-Commit-ID: G1n44eSFWr1

--HG--
extra : rebase_source : 5329ed861c6f46ed5534ab775f69ed4e3fe447be
2018-05-07 17:36:16 +02:00
Marco Bonardo
c77ad1727f Bug 1354531 - Remove PlacesUtils.asyncHistory to make History internals access less convenient. r=standard8
MozReview-Commit-ID: K9oQTJbVAZF

--HG--
extra : rebase_source : 1f9c19911602a2620dace4d85c8174347c8eeb42
2018-05-03 15:08:06 +02:00
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Kris Maglione
e318b76d56 Bug 1456035: Part 3 - Replace XPCOMUtils.generateQI with a stub for ChromeUtils.generateQI. r=mccr8
MozReview-Commit-ID: HWnlxUQvxYZ

--HG--
extra : rebase_source : a5801a0d7427a2cf3cedec2a4e8db1a3d80273ec
2018-04-22 18:55:49 -07:00
Kris Maglione
a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Marco Bonardo
dbde0c7df9 Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp

--HG--
extra : rebase_source : 6f5ec9404f12eb988501df56c7ee264ade2b054c
2018-04-16 18:24:06 +02:00
Dorel Luca
c4fec6222b Backed out changeset 897bbf35e781 (bug 1453580) for XPCShell failure on services/sync/tests/unit/test_syncedtabs.js. CLOSED TREE 2018-04-18 14:06:34 +03:00
Marco Bonardo
b00d20562d Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp

--HG--
extra : rebase_source : e8a1adb7c1004eaefddc42d12048d445eecd6530
2018-04-16 18:24:06 +02:00
Marco Bonardo
3a337abf8a Bug 1452621 - Cleanup some tag queries related code. r=standard8
MozReview-Commit-ID: L8L3i5W1CHe

--HG--
extra : rebase_source : 50b547644e39238402985072d400022c83a33a7a
2018-04-09 15:38:45 +02:00
Marco Bonardo
a68b7f8aea Bug 1293445 - 5 - Rename RESULTS_AS_TAG_QUERY. r=standard8
MozReview-Commit-ID: 7HwPKkGvAvv

--HG--
extra : rebase_source : e8c8bb963061c23907bacc68082d4e70a609bbf2
2018-04-04 16:14:20 +02:00
Mark Banner
2596efb656 Bug 1451719 - Add the failing type to a bookmarks error, and replace some xpcom interface usages with pure javascript ones. r=mak
MozReview-Commit-ID: 1MSbFOsraLV

--HG--
extra : rebase_source : db121b63f3bc722e646e66679018d03f1bc86e04
2018-04-05 13:36:08 +01:00
Marco Bonardo
ba1483da46 Bug 1450210 - Remove remaining references to the POST data anno. r=standard8
MozReview-Commit-ID: 5AOMj1VBgT7

--HG--
extra : rebase_source : 3b89f4a26e77b37a0da8ff8640af4a648c93b351
2018-03-30 12:33:02 +02:00
Marco Bonardo
d666e0fda1 Bug 1421664 - 3 - Fix the UI and tests. r=standard8
test_419731.js can be removed since it is already covered by browser_bookmarkProperties_editTagContainer.js

MozReview-Commit-ID: K0LFuTptWyW

--HG--
extra : rebase_source : 10066aa0bdb6a598fc6af638fed455d58422b7fb
2018-03-22 14:13:07 +01:00