Ehsan Akhgari
377b919b76
Bug 1214305 - Part 1: Refactor the logic for querying whether a connection should go through a secure upgrade into NS_ShouldSecureUpgrade; r=mcmanus
2016-01-04 16:30:02 -05:00
Wes Kocher
dbbade6e75
Backed out 10 changesets (bug 1214305) for leaks on linux debug m-e10s(bc7)
...
Backed out changeset 1f482566235a (bug 1214305)
Backed out changeset 001b31489756 (bug 1214305)
Backed out changeset 4e94d2088219 (bug 1214305)
Backed out changeset fba4a5bcea41 (bug 1214305)
Backed out changeset 100f8e249007 (bug 1214305)
Backed out changeset a59c453192dc (bug 1214305)
Backed out changeset 2daa86fc1fb9 (bug 1214305)
Backed out changeset c04efb57b0ed (bug 1214305)
Backed out changeset 52046e843c60 (bug 1214305)
Backed out changeset ac4fd6615828 (bug 1214305)
--HG--
extra : commitid : ILmaVumvmvH
2016-01-04 10:34:24 -08:00
Ehsan Akhgari
96c8327a92
Bug 1214305 - Part 7: Decide in the child process whether an intercepted channel should go through a secure upgrade; r=mcmanus
...
This is OK from a security perspective, since this decision only affects
whether the channel will be intercepted with the secure URI in the child
process. If the intercepting service worker decides to fall back to an
actual network request, we send the request to the parent process with
the original pre-upgrade URI, and the parent process will still be in
charge of whether a network visible HTTP request should be upgraded.
2016-01-04 09:52:47 -05:00
Ehsan Akhgari
1927591d62
Bug 1214305 - Part 6: Use a non-IPC redirect for synthesized upgraded responses to ensure the response URL is correctly propagated; r=mcmanus
2016-01-04 09:52:45 -05:00
Ehsan Akhgari
17e63f2856
Bug 1214305 - Part 3: Add a nsIInterceptedChannel.secureUpgradedChannelURI helper; r=jdm
2016-01-04 09:52:40 -05:00
Ehsan Akhgari
478b7b9bc3
Bug 1214305 - Part 2: Refactor the logic for obtaining the secure upgraded URI into HttpBaseChannel; r=mcmanus
2016-01-04 09:52:39 -05:00
Ehsan Akhgari
3e8d2fe85d
Bug 1214305 - Part 1: Refactor the logic for querying whether a connection should go through a secure upgrade into NS_ShouldSecureUpgrade; r=mcmanus
2016-01-04 09:52:37 -05:00
Ehsan Akhgari
bbc181b4fe
Bug 1219469 - Part 2: Make HttpChannelParentListener be the controller; r=jdm,jduell
...
The controller needs to be able to handle redirects.
HttpChannelParentListener is a listener object that can attach to
multiple HttpChannelParent objects as part of a single logical Necko
channel (meaning that the listener object will be reused for redirected
channels) so it seems like the better choice for the object that should
implement nsINetworkInterceptController. This patch moves the
implementation of the nsINetworkInterceptController interface to
HttpChannelParentListener.
2016-01-04 09:39:12 -05:00
Ehsan Akhgari
77182bbd83
Bug 1219469 - Part 1: Revert the error reporting added in bug 1233845; r=jdm
2016-01-04 09:39:10 -05:00
Ehsan Akhgari
208f93e405
Bug 1233245 - Propagate the interception information in the non-e10s case for all HTTP redirects, not just the internal ones; r=jdm
...
Doing this work in StartRedirectChannelToURI() was causing us to not set
the bypass service worker flag properly in the case of real HTTP redirects.
This patch also fixes the incorrect test expectation value.
2016-01-04 09:39:09 -05:00
Kate McKinley
82579c5c6c
Bug 1195881 - Pass userContext through NeckoParent and TabChild. r=tanvi, r=sicking
2016-01-07 10:51:04 -08:00
Honza Bambas
5b430fab1f
Bug 996836 - Merge CLOSE and WRITE priority in cache2 I/O thread. r=michal
...
--HG--
extra : rebase_source : 2d16c6fb54061dfa87b338da22e019295e9c299f
2016-01-05 11:50:00 -05:00
Valentin Gosu
f86b01846d
Bug 1233610 - IDN service should return NS_ERROR_MALFORMED_URI instead of NS_ERROR_FAILURE r=mcmanus
...
--HG--
extra : rebase_source : ed7923a472a3da8c1dcc4161daf4836c8565629c
2016-01-07 14:31:22 +01:00
Jason Duell
b091fa291e
Bug 1199841 - Restructure private browsing to remember status after OnStopRequest r=jdm
2015-12-30 17:51:21 -05:00
Jeff Walden
5be7be38a1
Bug 1235615 - Split JS::CompartmentOptions into JS::CompartmentCreationOptions that are immutable characteristics of a compartment, and JS::CompartmentBehaviors that may be changed after the compartment's been created. r=terrence
...
--HG--
extra : rebase_source : f08c380ae247d3308d4c36788ac765de1b75af50
2015-12-28 16:15:52 -06:00
Mike Hommey
ce3914c897
Bug 1225384 - Change how the default resource "host names" are handled. r=michal
...
The meaning of resource:///, resource://app/ and resource://gre/ needs to
remain constant. Unfortunately, the model of the resource protocol handler
is that it is possible to set substitutions that change their meaning.
So, we forbid setting overwriting the substitutions for those three
special "host names".
Unfortunately, with e10s, the full list of substitutions is also sent to
the content process, which then sets substitutions, making it harder to
know in which cases SetSubstitution is valid for those three "host names"
or not.
So instead of trying to find the right heuristics, use the recently added
SubstitutingProtocolHandler::ResolveSpecialCases API to handle the three
"host names" instead of storing them as "normal" substitutions.
Still actively reject SetSubstitution with the three special "host names"
so as to find issues such as bug 1224000 instead of allowing the chrome
manifest entry and have it silently ignored.
Additionally, make GetSubstitution return the URIs for the three special
"host names" through GetSubstitutionInternal, replacing what was originally
added in bug 257162. Those changes from bug 257162 relied on the
resource:app string being handled by nsXREDirProvider::GetFile, but that was
removed in bug 620931, effectively making that code now in
GetSubstitutionInternal useless.
2015-12-28 06:49:05 +09:00
Shih-Chiang Chien
84d3fa49fe
Bug 1229726 - fix the data copy from sockaddr to NetAddr on OSX/FreeBSD. r=mcmanus.
...
--HG--
extra : commitid : 8MlF9vIlTGZ
2015-12-23 14:13:58 +08:00
Patrick McManus
736aaab8e3
Bug 1234591 - Use channel.asyncOpen2 within netwerk/test/unit/test_http2.js r=ckerschb
2015-12-23 17:46:31 -05:00
Patrick McManus
9f784d6ae1
Bug 1234366 - Convert netwerk/test/unit/test_spdy.js to use asyncOpen2 r=ckerschb
2015-12-23 17:36:33 -05:00
Ben Kelly
3972c8300e
Bug 1220681 P5 Don't double suspend parent channel during synthesized divert to parent. r=jdm
2015-12-23 12:20:53 -08:00
Ben Kelly
dd179ed223
Bug 1220681 P4 Automatically suspend the parent channel after synthesizing the response for diverison. r=jdm
2015-12-23 12:20:53 -08:00
Ben Kelly
9230279805
Bug 1220681 P3 Delay diversion on parent side until response head has been synthesized. r=jdm
2015-12-23 12:20:53 -08:00
Ben Kelly
0616535096
Bug 1220681 P1 Make HttpChannelChild::DivertToParent() work with synthetic responses. r=jdm
2015-12-23 12:20:53 -08:00
Patrick McManus
29ca4c0e9d
Bug 1218297 - eventtokenbucket shutdown leak r=valentin
2015-12-23 10:47:13 -05:00
Patrick McManus
90c978fb27
Bug 1234896 - refptrs for httphandler.cpp r=valentin.gosu
2015-12-23 11:43:41 -05:00
Carsten "Tomcat" Book
719ce6825c
merge mozilla-inbound to mozilla-central a=merge
2015-12-23 12:00:09 +01:00
Christoph Kerschbaumer
0fb857d90b
Bug 1234596 - Convert 20 tests within netwerk/test to use AsyncOpen2 (r=mcmanus)
2015-12-22 20:57:57 -08:00
Wes Kocher
c9ba10fdd9
Backed out changeset 7459e0c97939 (bug 1234596) for test_protocolproxyservice.js failures in xpcshell CLOSED TREE
...
--HG--
extra : commitid : FXbwzdhNjgj
2015-12-22 18:37:37 -08:00
Christoph Kerschbaumer
8adf739828
Bug 1234596 - Convert 20 tests within netwerk/test to use AsyncOpen2 (r=mcmanus)
2015-12-22 13:09:31 -08:00
Kannan Vijayan
9cc5a540ac
Bug 1233813 - Fix mDNS bug in resolving services with no TXT records. r=schien
2015-12-22 16:24:56 -05:00
Kris Maglione
77d984b84a
Bug 1210996: [webext] Check host permissions in the browser.cookies API. r=billm
...
--HG--
rename : toolkit/components/extensions/test/mochitest/test_ext_cookies.html => toolkit/components/extensions/test/mochitest/test_ext_cookies_permissions.html
extra : commitid : IqgOPGfrF2K
extra : rebase_source : 1ba3322fec537ba5e0c0f5fe8a30b7e6eec46911
2015-12-02 21:20:01 -08:00
Henry
f090013aed
Bug 1223678 - Use package-identifier from argument to create principal. r=kanru.
2015-12-22 11:08:56 +08:00
Christoph Kerschbaumer
24a75dc0de
Bug 1234369 - Convert 25 tests within netwerk/test to use AsyncOpen2 (r=mcmanus)
2015-12-21 16:29:26 -08:00
Sebastian Hengst
678b0a4325
Backed out changeset e8c63b932647 (bug 1225384) for bustage in netwerk/test/unit/test_bug580508.js in e.g. XPCshell tests. r=bustage
2015-12-22 01:33:26 +01:00
Mike Hommey
b6ec2d180a
Bug 1225384 - Change how the default resource "host names" are handled. r=michal
...
The meaning of resource:///, resource://app/ and resource://gre/ needs to
remain constant. Unfortunately, the model of the resource protocol handler
is that it is possible to set substitutions that change their meaning.
So, we forbid setting overwriting the substitutions for those three
special "host names".
Unfortunately, with e10s, the full list of substitutions is also sent to
the content process, which then sets substitutions, making it harder to
know in which cases SetSubstitution is valid for those three "host names"
or not.
So instead of trying to find the right heuristics, use the recently added
SubstitutingProtocolHandler::ResolveSpecialCases API to handle the three
"host names" instead of storing them as "normal" substitutions.
Still actively reject SetSubstitution with the three special "host names"
so as to find issues such as bug 1224000 instead of allowing the chrome
manifest entry and have it silently ignored.
2015-12-22 07:55:40 +09:00
Ehsan Akhgari
aa999694ec
Bug 1234251 - Remove HttpChannelChild::mSynthesizedResponseHead; r=jdm
2015-12-21 17:01:28 -05:00
Christoph Kerschbaumer
9f4842f614
Bug 1233843 - Convert 30 tests within netwerk/test to use AsyncOpen2 (r=mcmanus)
2015-12-21 13:06:46 -08:00
Wes Kocher
a4bead1f65
Backed out changeset 28da91dbe6c5 (bug 1233843) for failures in test_bug203271.js in various test suites
2015-12-21 12:29:10 -08:00
Christoph Kerschbaumer
5ab4c2a41a
Bug 1233843 - Convert 30 tests within netwerk/test to use AsyncOpen2 (r=mcmanus)
2015-12-18 14:56:57 -08:00
Gian-Carlo Pascutto
2652d00be1
Bug 1211090 - Don't fail to open databases if we can't do buffered IO. r=froydnj
2015-12-21 17:51:03 +01:00
Gian-Carlo Pascutto
73ac6a6ca3
Bug 1211090 - Add fallocate support to nsIOutputFileStream and use it. r=froydnj
2015-12-21 17:50:53 +01:00
Ben Kelly
aa9b3c6150
Bug 1233962 P2 Fix service worker xpcshell test to return a dispatcher from ChannelIntercepted(). r=jdm
2015-12-22 11:57:11 -08:00
Ben Kelly
3fcfa5995a
Bug 1233962 P1 Call ResetInterception() if the controller is nullptr. r=jdm
2015-12-22 11:57:10 -08:00
Blake Kaplan
92c07bc4ad
Bug 1229177 - Show the tracking protection shield for fetch and XHR requests. r=jduell
...
--HG--
extra : rebase_source : 81f1819355ee85b323cdfff4505e20613c4c5296
2015-12-21 14:12:52 -08:00
Nicholas Hurley
151ac66626
Bug 1233784 - Disallow illegal characters in cookie names. r=jduell
2015-12-17 14:41:38 -08:00
Dragana Damjanovic
c2d5cae269
Bug 664163 - Fix Get(Local|Remote)(Address|Port) in HttpChannelChild. r=jduell
2015-12-19 16:11:39 -05:00
Josh Matthews
d2cef8692f
Bug 1233845 - Report an interception error and cancel the HTTP channel when encountering a known topcrash situation. r=ehsan
2015-12-19 09:40:06 -05:00
Christoph Kerschbaumer
16f9142afe
Bug 1233760 - Revert test_spdy.js to use AsyncOpen2 (r=mcmanus)
2015-12-18 15:23:36 -08:00
Christoph Kerschbaumer
c83699f25f
Bug 1233760 - Convert 25 tests within netwerk/test to use AsyncOpen2 (r=mcmanus)
2015-12-18 13:31:16 -08:00
Patrick McManus
ae19b61b33
Bug 513129 - Dont reuse connections after security prefs change r=hurley
2015-12-17 17:37:53 -05:00
Wes Kocher
48e8bea219
Backed out changeset 82cd6a486698 (bug 1233245) for fetch-request-redirect.https.html failures CLOSED TREE
...
--HG--
extra : commitid : 2O37Vand5Zd
2015-12-17 16:18:29 -08:00
Ehsan Akhgari
91432f79e5
Bug 1233245 - Propagate the interception information in the non-e10s case for all HTTP redirects, not just the internal ones; r=jdm,bkelly
...
Doing this work in StartRedirectChannelToURI() was causing us to not set
the bypass service worker flag properly in the case of real HTTP redirects.
This patch also fixes the incorrect test expectation value.
2015-12-17 17:32:38 -05:00
Christoph Kerschbaumer
a09beee411
Bug 1232899 - Convert JS callsites to use open2 within netwerk/test (r=mcmanus)
2015-12-17 12:47:01 -08:00
Christoph Kerschbaumer
55c5c7efa6
Bug 1232567 - Convert 10 tests within netwerk/test to use AsyncOpen2 (r=mcmanus)
2015-12-17 12:47:22 -08:00
Honza Bambas
5a7f903046
Bug 1229235 - Make RedirectChannelRegistrar thread-safe. r=jduell
2015-12-04 09:55:00 +01:00
Ten Thumbs
0c54b5682e
Bug 234031 - broken parsing of xlen in gzip rfc 1952 r=mcmanus
2015-12-16 16:33:40 -05:00
Nicholas Hurley
a6d6d5ef55
Bug 1228822 - Ensure we send out the window update when matching a pushed stream with a pull stream. r=mcmanus
...
--HG--
extra : commitid : D6pRH1pTQe6
extra : rebase_source : 0b1d5f10a9ebeda7b037e2c147f426908ef241a2
2015-12-09 10:11:04 -08:00
Gijs Kruitbosch
06c03baf6f
Bug 1232287 - revert bug 1224046 and fix resource: URIs to not have a base tag, r=glandium,valentin
...
--HG--
extra : rebase_source : 66d108d2bd4d17306df3ec3e259c9f69772613b1
2015-12-15 12:09:05 +00:00
Carsten "Tomcat" Book
5a86bca15a
merge mozilla-inbound to mozilla-central a=merge
2015-12-15 12:16:29 +01:00
Tim Nguyen
8fe11e6a5d
Bug 1137681 - Make user agent docshell overrides affect network requests. r=jduell
2015-12-08 09:27:00 +01:00
Christoph Kerschbaumer
bd418a8bfe
Bug 1232422 - Convert 5 tests within netwerk/test to use AsyncOpen2 (r=mcmanus)
2015-12-14 12:36:12 -08:00
Patrick McManus
653ee2068a
Bug 1228457 create pref to allow blocking .onion at dns level rfc 7687 r=valentin.gosu
2015-12-11 14:28:21 -05:00
Daniel Stenberg
07e9a26610
Bug 1231552 - Back out bug 1121800, bug 1207798 and bug 1214200 changesets. r=mcmanus
2015-12-10 07:21:00 +01:00
Patrick McManus
2c38f642a7
Bug 1228457 - backout 625248e1115c broke e10s xpcshell test CLOSED TREE r=backout
2015-12-09 13:12:19 -05:00
Patrick McManus
70d505ba42
Bug 1228457 create pref to allow blocking .onion at dns level rfc 7687 r=valentin.gosu
2015-12-04 06:20:15 -05:00
Patrick McManus
4c8ee0930e
Bug 1230743 - telemtry for nsConnectionEntry hit rate r=hurley
2015-12-05 07:43:01 -05:00
Bogdan Postelnicu
b0926d6bae
Bug 1230939 - check the return of sGlobalEntryTables->Get(aContextKey, &diskEntries). r=mayhemer
2015-12-07 06:38:00 +01:00
Jonas Sicking
081cb24a23
Bug 1226909 followup to fix bustage. Make sure that the channel returned by NS_NewChannel doesn't have a loadinfo that indicates that the channel has already been opened
2015-12-06 23:50:49 -05:00
Jonas Sicking
0bb4231605
Bug 1216687: Add nsILoadInfo flags for cookie policies. r=ckerschb
2015-12-06 18:33:15 -05:00
Jonas Sicking
f7193fdf30
Bug 1226909 part 4: Make AsyncOpen2 set taining information on channels. Use this information in XHR and fetch(). r=bkelly
2015-12-06 18:33:15 -05:00
Jonas Sicking
28de02f687
Bug 1226909 part 3: Move logic of when to initiate CORS preflight into channels. Allow CORS preflight to happen when doing a same-origin to cross-origin redirect. r=ckerschb
2015-12-06 18:33:14 -05:00
Jonas Sicking
0e0c8c52ea
Bug 1226909 part 2: Let CORS preflight logic grab information from nsILoadInfo rather than duplicate it. r=ckerschb
2015-12-06 18:33:14 -05:00
Jonas Sicking
6cc5074df0
Bug 1226909 part 1: Do security checks in a redirect handler rather than when opening the redirected channel. r=ckerschb
2015-12-06 18:33:14 -05:00
Randell Jesup
a94574d60f
Bug 1216837: add explicit error checks for packet length in srtp r=mcmanus rs=jesup
2015-12-05 11:06:40 -05:00
Sebastian Hengst
774236075d
Backed out changeset 09d64535bcda (bug 1216687), a7f1a289dd78, 4dbf06183e6c, 26318a5e3006, 9ae2af3cf86d (bug 1226909) for M(1,2,5) oranges. r=backout
2015-12-05 16:34:47 +01:00
Jonas Sicking
993136c2c9
Bug 1216687: Add nsILoadInfo flags for cookie policies. r=ckerschb
2015-12-05 01:46:21 -08:00
Jonas Sicking
7fae3fd853
Bug 1226909 part 4: Make AsyncOpen2 set taining information on channels. Use this information in XHR and fetch(). r=bkelly
2015-12-05 01:46:20 -08:00
Jonas Sicking
ff12f48c5a
Bug 1226909 part 3: Move logic of when to initiate CORS preflight into channels. Allow CORS preflight to happen when doing a same-origin to cross-origin redirect. r=ckerschb
2015-12-05 01:46:20 -08:00
Jonas Sicking
918c689657
Bug 1226909 part 2: Let CORS preflight logic grab information from nsILoadInfo rather than duplicate it. r=ckerschb
2015-12-05 01:46:20 -08:00
Jonas Sicking
df33e62850
Bug 1226909 part 1: Do security checks in a redirect handler rather than when opening the redirected channel. r=ckerschb
2015-12-05 01:46:20 -08:00
Nicholas Nethercote
59bbf6548a
Bug 1187134 (part 5) - Replace nsBaseHashtable::Enumerate() calls in netwerk/cache{,2}/ with iterators. r=valentin.
...
--HG--
extra : rebase_source : d47d5a91025ce6a06ec63155d68b0969c45e4d29
2015-12-03 14:00:04 -08:00
Nicholas Nethercote
edfdcd39d9
Bug 1187134 (part 4) - Replace nsBaseHashtable::Enumerate() calls in netwerk/cache{,2}/ with iterators. r=valentin.
...
--HG--
extra : rebase_source : 0d62ad6d5e6cad0d4202cb58ec77890e3213cecf
2015-12-03 14:00:03 -08:00
Nicholas Nethercote
2e1080a108
Bug 1187134 (part 3) - Replace nsBaseHashtable::Enumerate() calls in netwerk/cache{,2}/ with iterators. r=valentin.
...
--HG--
extra : rebase_source : c7de2d58545b298f362a042788531fe9e13fc52a
2015-12-03 14:00:02 -08:00
Nicholas Nethercote
abd63ceb7a
Bug 1187134 (part 2) - Replace nsBaseHashtable::Enumerate() calls in netwerk/cache{,2}/ with iterators. r=valentin.
...
--HG--
extra : rebase_source : 1c69a912e8c27cf9789057f0813ec3bbfd30c57c
2015-12-03 13:59:58 -08:00
Nicholas Nethercote
b342baf62e
Bug 1187134 (part 1) - Replace nsBaseHashtable::Enumerate() calls in netwerk/cache{,2}/ with iterators. r=valentin.
...
--HG--
extra : rebase_source : 0955e8f7a94794d7615c3a17650908d410b52559
2015-11-29 14:01:44 -08:00
Jan Beich
814acd7ab8
Bug 1228208 - Make sure ICU flags are prepended before system flags. r=glandium
2015-12-02 09:40:50 +00:00
Bogdan Postelnicu
797941ef16
Bug 1228342 - initialize mTainting by all constructors. r=bkelly
2015-12-03 02:39:00 +01:00
Nigel Babu
e414eeae7a
Backed out changeset 7b77be698443 (bug 1228342) for build bustage ON CLOSED TREE
2015-12-03 15:51:20 +05:30
Bogdan Postelnicu
bdffacc229
Bug 1228342 - initialize mTainting by all constructors. r=bkelly
2015-12-02 00:43:00 +01:00
Nathan Froyd
9a956c9885
Bug 1223808 - part 3 - replace nsAutoArrayPtr<T> with UniquePtr<T[]> in netwerk/; r=mcmanus
2015-11-08 21:28:05 -05:00
Nathan Froyd
ce11c393a5
Bug 1223808 - part 2 - use UniquePtr<uint8_t[]> instead of nsAutoArrayPtr<SHA1Sum::Hash> in HandleHashKey; r=michal
2015-11-18 15:56:47 -05:00
Nathan Froyd
fcdd745657
Bug 1223808 - part 1 - optimize creating a WebSocketFrame with a payload; r=mcmanus
...
This function:
- Allocates a block of memory;
- Copies things into that block of memory;
- Allocates another block of memory inside nsAutoCString;
- Copies into our string from the block of memory we just allocated.
Clearly we can avoid a memory allocation and some copying by just
allocating the amount of data we need in the string first, and copying
things into the string.
2015-11-08 21:26:46 -05:00
Nathan Froyd
3071ec2419
Bug 1218454 - part 2a - fix bootlegging of nsContentUtils.h includes from nsILoadContext.h; r=bz
2015-12-01 21:49:38 -05:00
Nathan Froyd
c381a6b86c
Bug 1218454 - part 2 - don't #include nsContentUtils.h from CallbackObject.h; r=bz
...
We used to need nsContentUtils.h here for nsCxPusher, but since that got
moved to ScriptSettings.h, we no longer need nsContentUtils.h for
anything.
2015-10-26 12:14:47 -04:00
Lars T Hansen
7664162964
Bug 1176214 - Part 14: Changes to netwerk. r=jduell
...
--HG--
extra : rebase_source : aaba474cc050b07188f6c78eb17d31f2733c91fc
2015-11-25 17:30:52 +01:00
Carsten "Tomcat" Book
5adcabb340
merge mozilla-inbound to mozilla-central a=merge
2015-12-02 15:20:57 +01:00
Carsten "Tomcat" Book
44cd9f4db8
Backed out changeset 7a9e01e904b0 (bug 1137681) for test bustage on a CLOSED TREE
2015-12-02 11:28:46 +01:00
Tim Nguyen
e0f8972f78
Bug 1137681 - Make user agent docshell overrides affect network requests. r=jduell
2015-12-01 13:08:00 +01:00
Nicholas Nethercote
ddc78c3b0c
Bug 1229458 - Remove SizeOfIncludingThisMustBeUnshared() from string classes. r=mccr8.
...
The patch changes all uses of SizeOfIncludingThisMustBeUnshared() to
SizeOfIncludingThisIfUnshared(). This incurs the (tiny) cost of an unnecessary
IsReadonly() check for guaranteed-unshared strings, but avoids the possible
assertion failures that would occur when MustBeUnshared() was used incorrectly
on shared strings, which is an easy mistake to make.
--HG--
extra : rebase_source : b1e91f1c19bcbe0521b0ce461d6c90512ca938ef
2015-12-01 15:36:26 -08:00
Mike Hommey
b2e31e6ade
Bug 1225682 - Don't use nsAuto{,C}String as class member variables in netwerk/. r=mcmanus
2015-12-02 11:04:37 +09:00