Commit Graph

2664 Commits

Author SHA1 Message Date
Ehsan Akhgari
4aa18e126d Bug 1509047 - Part 2: Add an API for measuring the number of unique origins visited in the past 24 hours; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D12863
2018-11-29 00:45:06 -05:00
Jan-Erik Rediger
5fd1cd8036 Bug 1498163 - Migrate external callers to the new snapshot API r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D12890

--HG--
extra : moz-landing-system : lando
2018-11-28 09:36:03 +00:00
Dão Gottwald
65b52f7de5 Bug 1510418 - Use TelemetryStopwatch.running instead of custom _tabSwitchStopWatchRunning flag. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D13126

--HG--
extra : moz-landing-system : lando
2018-11-27 21:53:13 +00:00
Cosmin Sabou
e1e8f2ea69 Merge mozilla-inbound to mozilla-central. a=merge 2018-11-28 06:08:19 +02:00
Marco Bonardo
7adb9377d5 Bug 1510281 - Use a private and isolated context for search suggestions. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D13082

--HG--
extra : moz-landing-system : lando
2018-11-27 17:18:28 +00:00
Shane Caraveo
29892c75cf Bug 1508853 make the search default panel persistent, r=aswan
This is a quick fix to ensure that the search install panel is shown when an extension uses is_default.  The intention is to uplift for 64.

Differential Revision: https://phabricator.services.mozilla.com/D13078

--HG--
extra : moz-landing-system : lando
2018-11-27 18:05:59 +00:00
Mike de Boer
1c9d33675e Bug 1496764 - extend search event telemetry to never expire and change the probe owners. r=chutten,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D9229

--HG--
extra : moz-landing-system : lando
2018-11-27 15:15:35 +00:00
Andreea Pavel
ebe85db8e7 Backed out changeset ad857edac6a5 (bug 1498163) for failing devtools/client/performance/test/browser_perf-telemetry-04.js on a CLOSED TREE 2018-11-27 11:05:28 +02:00
Jan-Erik Rediger
c6e72f0819 Bug 1498163 - Migrate external callers to the new snapshot API r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D12890

--HG--
extra : moz-landing-system : lando
2018-11-26 14:34:23 +00:00
Ehsan Akhgari
923b4f06ad Bug 1503074 - Only touch the FX_TAB_SWITCH_COMPOSITE_E10S_MS stopwatch when we have actually started it in the past
Differential Revision: https://phabricator.services.mozilla.com/D12966

--HG--
extra : moz-landing-system : lando
2018-11-26 19:16:09 +00:00
Ehsan Akhgari
164791340d Bug 1490811 - Part 2: Add a test for the basic functionality of the storage access prompt r=johannh
Depends on D12467

Differential Revision: https://phabricator.services.mozilla.com/D12507

--HG--
extra : moz-landing-system : lando
2018-11-26 21:23:18 +00:00
Ehsan Akhgari
cc714b7adc Bug 1490811 - Part 1: Add a permission doorhanger for the storage access API r=baku,johannh
Differential Revision: https://phabricator.services.mozilla.com/D12467

--HG--
extra : moz-landing-system : lando
2018-11-26 21:23:16 +00:00
Shane Caraveo
dfbb130d83 Bug 1489531 Expose telemetry client_id hash to about:addons via cookie r=Gijs,chutten
Differential Revision: https://phabricator.services.mozilla.com/D9317

--HG--
extra : moz-landing-system : lando
2018-11-26 15:26:39 +00:00
Ehsan Akhgari
5eb383c4df Bug 1508759 - Add support for hooking up permission prompts that don't use SitePermissions to TemporaryPermissions r=johannh
Normally, permission prompts would define a permissionKey attribute in order
to get integrated with SitePermissions.  Since SitePermissions is internally
hooked up to TemporaryPermissions, such permission prompts do not need any
extra handling for taking benefit from the temporary permissions infrastructure.

For the Storage Access API, however, we're not going to use SitePermissions,
and instead Gecko will be in charge of defining the required permissions in the
permission manager database when the prompt is responded to with an Allow
action.  This means that by default we won't be integrated with the temporary
permissions setup either.

This patch allows prompts to define a new way to opt out of reading and writing
permissions through the permission manager but still being integrated with
temporary permissions.  That is, through returning false from the new
usePermissionManager attribute and returning a name from the permissionKey
attribute.  TemporaryPermissions will do the expected work in order to ensure
that each prompt with a unique key will be automatically blocked if a previous
instance of the same prompt type with the same key has been blocked in the
current tab.

Note that this doesn't yet include support for showGloballyBlocked or
permitTemporaryAllow since those features aren't needed for our use case.

Differential Revision: https://phabricator.services.mozilla.com/D12466

--HG--
extra : moz-landing-system : lando
2018-11-26 10:32:19 +00:00
Christian Holler
e48061eb07 Bug 1506044 - Do not send cookies with ASan reporter submits. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D12317

--HG--
extra : moz-landing-system : lando
2018-11-21 23:18:27 +00:00
Jan-Erik Rediger
b07e153ff0 Bug 1498173 - Migrate external tests to changed histogram API r=chutten
Depends on D12557

Differential Revision: https://phabricator.services.mozilla.com/D12558

--HG--
extra : moz-landing-system : lando
2018-11-22 23:35:43 +00:00
Mark Striemer
28551ead0f Bug 1505751 - Wait for menulist close for browser language handlers r=Gijs
The search handler was being called when focusing the menuitem with the keyboard on Windows. This didn't provide a good experience and left the popup open once the search started. Ensure the popup is always shown when using the keyboard and don't trigger the search until the popup is closed.

Differential Revision: https://phabricator.services.mozilla.com/D12324

--HG--
extra : moz-landing-system : lando
2018-11-21 15:36:52 +00:00
Andrea Marchesini
e8cb35c9b3 Bug 1507171 - Cleanup data on shutdown just for http, https and file URLs, r=johannh 2018-11-19 16:02:23 +01:00
Tim Nguyen
f3c3251f9d Bug 1468517 - Make toolbar_bottom_separator color apply to findbar top border. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D11577

--HG--
extra : moz-landing-system : lando
2018-11-18 18:16:52 +00:00
Andreea Pavel
72b0594cb8 Merge mozilla-inbound to mozilla-central. a=merge 2018-11-17 13:27:24 +02:00
Nika Layzell
fe2f2478f7 Bug 1477432 - Part 2: Avoid using nsIJSID in GenerateQI, and produce better diagnostics, r=kmag
This is the first part of hiding the implementation of nsIJSID behind the
interface added in Part 1, such that we can substitute that implementation out.

I had to make a couple of changes to fix the errors caused by the new behaviour
in GenerateQI.

Differential Revision: https://phabricator.services.mozilla.com/D2279
2018-11-16 17:27:31 -05:00
Drew Willcoxon
b8258389b8 Bug 1499193 - Follow-up 2: Update SEARCH_COUNTS key r=mkaply
Change the `<engine>.<alias>.urlbar` `SEARCH_COUNTS` keys to `<engine>.alias` as described in bug 1499193 comment 23 and later.

Differential Revision: https://phabricator.services.mozilla.com/D12038

--HG--
extra : moz-landing-system : lando
2018-11-16 21:15:54 +00:00
alwu
4515d99b29 Bug 1493766 - part1 : notify when temporary permission changed. r=johannh
Since temporary permissions are only stored in the front-end side, we can't know whether we have
allowed page to autoplay or not without sending a request. Therefore, we want to notify the back-end
side when the temporary permissions changed.

Differential Revision: https://phabricator.services.mozilla.com/D7011

--HG--
extra : moz-landing-system : lando
2018-11-15 19:51:26 +00:00
Dave Townsend
3e18f3d532 Bug 1503696: Cache cookies in the same way we did before Firefox 63. r=mak
Previous to bug 1453751 favicons were loaded from the network by a <xul:image>
tag with validate="never". This caused us to always use any cached version if
possible. Bug 1453751 used a normal load type causing us to revalidate with the
server for each request. This switches the loader to using the cache if possible.

Differential Revision: https://phabricator.services.mozilla.com/D11402

--HG--
extra : moz-landing-system : lando
2018-11-15 20:46:32 +00:00
Mark Banner
7e8a95c1c9 Bug 1505456 - Move recordSearchURLTelemetry to its own module. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D11188

--HG--
rename : toolkit/components/search/tests/xpcshell/test_urltelemetry.js => browser/components/search/test/unit/test_urlTelemetry.js
extra : moz-landing-system : lando
2018-11-15 14:45:20 +00:00
Mark Banner
008609384d Bug 1505456 - Move browser tests into a sub-directory for browser/components/search/test. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D11187

--HG--
rename : browser/components/search/test/.eslintrc.js => browser/components/search/test/browser/.eslintrc.js
rename : browser/components/search/test/426329.xml => browser/components/search/test/browser/426329.xml
rename : browser/components/search/test/483086-1.xml => browser/components/search/test/browser/483086-1.xml
rename : browser/components/search/test/483086-2.xml => browser/components/search/test/browser/483086-2.xml
rename : browser/components/search/test/SearchTestUtils.jsm => browser/components/search/test/browser/SearchTestUtils.jsm
rename : browser/components/search/test/browser.ini => browser/components/search/test/browser/browser.ini
rename : browser/components/search/test/browser_426329.js => browser/components/search/test/browser/browser_426329.js
rename : browser/components/search/test/browser_483086.js => browser/components/search/test/browser/browser_483086.js
rename : browser/components/search/test/browser_aboutSearchReset.js => browser/components/search/test/browser/browser_aboutSearchReset.js
rename : browser/components/search/test/browser_addEngine.js => browser/components/search/test/browser/browser_addEngine.js
rename : browser/components/search/test/browser_amazon.js => browser/components/search/test/browser/browser_amazon.js
rename : browser/components/search/test/browser_bing.js => browser/components/search/test/browser/browser_bing.js
rename : browser/components/search/test/browser_contextSearchTabPosition.js => browser/components/search/test/browser/browser_contextSearchTabPosition.js
rename : browser/components/search/test/browser_contextmenu.js => browser/components/search/test/browser/browser_contextmenu.js
rename : browser/components/search/test/browser_ddg.js => browser/components/search/test/browser/browser_ddg.js
rename : browser/components/search/test/browser_eBay.js => browser/components/search/test/browser/browser_eBay.js
rename : browser/components/search/test/browser_google.js => browser/components/search/test/browser/browser_google.js
rename : browser/components/search/test/browser_google_behavior.js => browser/components/search/test/browser/browser_google_behavior.js
rename : browser/components/search/test/browser_healthreport.js => browser/components/search/test/browser/browser_healthreport.js
rename : browser/components/search/test/browser_hiddenOneOffs_cleanup.js => browser/components/search/test/browser/browser_hiddenOneOffs_cleanup.js
rename : browser/components/search/test/browser_hiddenOneOffs_diacritics.js => browser/components/search/test/browser/browser_hiddenOneOffs_diacritics.js
rename : browser/components/search/test/browser_oneOffContextMenu.js => browser/components/search/test/browser/browser_oneOffContextMenu.js
rename : browser/components/search/test/browser_oneOffContextMenu_setDefault.js => browser/components/search/test/browser/browser_oneOffContextMenu_setDefault.js
rename : browser/components/search/test/browser_oneOffHeader.js => browser/components/search/test/browser/browser_oneOffHeader.js
rename : browser/components/search/test/browser_private_search_perwindowpb.js => browser/components/search/test/browser/browser_private_search_perwindowpb.js
rename : browser/components/search/test/browser_searchEngine_behaviors.js => browser/components/search/test/browser/browser_searchEngine_behaviors.js
rename : browser/components/search/test/browser_searchbar_keyboard_navigation.js => browser/components/search/test/browser/browser_searchbar_keyboard_navigation.js
rename : browser/components/search/test/browser_searchbar_openpopup.js => browser/components/search/test/browser/browser_searchbar_openpopup.js
rename : browser/components/search/test/browser_searchbar_smallpanel_keyboard_navigation.js => browser/components/search/test/browser/browser_searchbar_smallpanel_keyboard_navigation.js
rename : browser/components/search/test/browser_tooManyEnginesOffered.js => browser/components/search/test/browser/browser_tooManyEnginesOffered.js
rename : browser/components/search/test/browser_webapi.js => browser/components/search/test/browser/browser_webapi.js
rename : browser/components/search/test/google_codes/browser.ini => browser/components/search/test/browser/google_codes/browser.ini
rename : browser/components/search/test/head.js => browser/components/search/test/browser/head.js
rename : browser/components/search/test/opensearch.html => browser/components/search/test/browser/opensearch.html
rename : browser/components/search/test/test.html => browser/components/search/test/browser/test.html
rename : browser/components/search/test/testEngine.xml => browser/components/search/test/browser/testEngine.xml
rename : browser/components/search/test/testEngine_diacritics.xml => browser/components/search/test/browser/testEngine_diacritics.xml
rename : browser/components/search/test/testEngine_dupe.xml => browser/components/search/test/browser/testEngine_dupe.xml
rename : browser/components/search/test/testEngine_missing_namespace.xml => browser/components/search/test/browser/testEngine_missing_namespace.xml
rename : browser/components/search/test/testEngine_mozsearch.xml => browser/components/search/test/browser/testEngine_mozsearch.xml
rename : browser/components/search/test/tooManyEnginesOffered.html => browser/components/search/test/browser/tooManyEnginesOffered.html
rename : browser/components/search/test/webapi.html => browser/components/search/test/browser/webapi.html
extra : moz-landing-system : lando
2018-11-15 14:44:55 +00:00
Paolo Amadini
f6b106efb2 Bug 1496827 - Remove the "notification" binding. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D11650

--HG--
rename : browser/components/customizableui/content/.eslintrc.js => browser/components/translation/content/.eslintrc.js
rename : browser/components/translation/jar.mn => browser/components/translation/content/jar.mn
rename : browser/components/translation/microsoft-translator-attribution.png => browser/components/translation/content/microsoft-translator-attribution.png
rename : browser/components/customizableui/content/moz.build => browser/components/translation/content/moz.build
rename : browser/components/translation/translation-infobar.xml => browser/components/translation/content/translation-notification.js
extra : rebase_source : 598396d2da96b04782413946976f7bb9fb6be75f
2018-11-13 12:56:42 +00:00
Noemi Erli
3b0f69841f Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-11-13 18:34:32 +02:00
Andrea Marchesini
1a3d20aa4f Bug 1505071 - Cleanup cookies should ignore OriginAttributes on shutdown, r=johannh 2018-11-13 16:49:01 +01:00
Siddhant085
6218cd4d20 Bug 1503851 - Replace Services.search.currentEngine by defaultEngine in test code r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D11553

--HG--
extra : moz-landing-system : lando
2018-11-13 09:34:00 +00:00
Michael Kaply
fb81651d50 Bug 1504686 - Don't count search for same document changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D11394

--HG--
extra : moz-landing-system : lando
2018-11-09 11:24:59 +00:00
Andreea Pavel
6cebff1713 Backed out changeset 655b8b4a0e67 (bug 1503696) for failing eslint at gecko/browser/base/content/test/favicons/browser_favicon_cache.js on a CLOSED TREE 2018-11-12 19:11:08 +02:00
Dave Townsend
918425999d Bug 1503696: Cache cookies in the same way we did before Firefox 63. r=mak
Previous to bug 1453751 favicons were loaded from the network by a <xul:image>
tag with validate="never". This caused us to always use any cached version if
possible. Bug 1453751 used a normal load type causing us to revalidate with the
server for each request. This switches the loader to using the cache if possible.

Differential Revision: https://phabricator.services.mozilla.com/D11402

--HG--
extra : moz-landing-system : lando
2018-11-12 16:41:35 +00:00
Paolo Amadini
cdb5b4eb19 Bug 1471403 - Part 4 - Convert "notificationbox" to a custom class. r=bgrins
As part of the conversion, support for notificationsHidden and children that are not notifications is also removed.

Differential Revision: https://phabricator.services.mozilla.com/D10894

--HG--
rename : toolkit/content/widgets/notification.xml => toolkit/content/widgets/notificationbox.js
extra : rebase_source : 36a5412e1e9a9dc591fd486d1123c1f763a6f173
2018-11-09 14:58:18 +00:00
Paolo Amadini
ce13039af3 Bug 1471403 - Part 2 - Lazify the creation of "notificationbox" elements. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D10892

--HG--
extra : rebase_source : f66fe90d780c3d446f4a065c0397cbb37f43cb0c
2018-11-09 14:38:49 +00:00
Cosmin Sabou
1b7e778d69 Merge mozilla-central to mozilla-inbound. 2018-11-28 00:04:55 +02:00
Ehsan Akhgari
31a9e2ed4f Bug 1503074 follow-up: Address review comments 2018-11-27 14:48:23 -05:00
Drew Willcoxon
9fbda91757 Bug 1504370 - Update SEARCH_COUNTS telemetry for private browsing mode r=mkaply
* If a search is performed in a private window and the new pref `browser.engagement.search_counts.pbm` is true, then do not record `SEARCH_COUNTS` telemetry. Note that the the pref must be true. If it's false or doesn't exist, then we record telemetry even in pbm like we normally do currently. (We record `SEARCH_COUNTS` telemetry in two places: (1) In BrowserUsageTelemetry.jsm, and (2) "in-content" telemetry directly in the search service. So skip both of those places.)
* Also skip the other ancillary telemetry recorded by `BrowserUsageTelemetry._recordSearch`: a keyed scalar and a telemetry event.
* I made some modifications to the search service to let me test the "in-content" telemetry keys

Differential Revision: https://phabricator.services.mozilla.com/D10851

--HG--
extra : moz-landing-system : lando
2018-11-06 17:58:07 +00:00
Gijs Kruitbosch
a0bf942503 Bug 1496360 - make BrowserWindowTracker and its deps use the docshell to obtain an outerWindowID, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D11003

--HG--
extra : moz-landing-system : lando
2018-11-06 09:48:46 +00:00
Drew Willcoxon
28cc94facb Bug 1499193 - Add new SEARCH_COUNTS telemetry for internal search engine alias usage. r=mkaply
Modify `BrowserUsageTelemetry.recordSearch` to take an alias instead of the bool `isAlias`. If an alias is given and it's an internal alias of the given engine, then increment a new `"engineName.@engine.source"` key under the `SEARCH_COUNTS` histogram -- in addition to incrementing the usual `"engineName.source"` key under that same histogram.

Differential Revision: https://phabricator.services.mozilla.com/D10633

--HG--
extra : moz-landing-system : lando
2018-11-03 16:47:16 +00:00
Kris Maglione
ade8c9ede8 Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888

--HG--
extra : source : afd0a13bcfff4c92ad2497ec687f466484481667
extra : amend_source : 501bca3f94a0cb0c8bec1f30d0b3f64a50b04e48
extra : intermediate-source : bc03f101937e373fdaca735f3f356960a5239bc0
2018-10-25 19:04:01 -07:00
arthur.iakab
0c81738411 Backed out 2 changesets (bug 1482091) for bc failures on browser_domFullscreen_fullscreenMode.js
Backed out changeset bc03f101937e (bug 1482091)
Backed out changeset 28a19b7290ab (bug 1482091)
2018-11-03 01:08:36 +02:00
Kris Maglione
7fa01216a4 Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888

--HG--
extra : source : afd0a13bcfff4c92ad2497ec687f466484481667
extra : amend_source : bf22d8e9ce5c081902bd5c75b892cc434a167300
2018-10-25 19:04:01 -07:00
arthur.iakab
cf2aa54f83 Backed out 2 changesets (bug 1482091)for failing browser chrome failures on browser_panelUINotifications_fullscreen_noAutoHideToolbar.js
Backed out changeset afd0a13bcfff (bug 1482091)
Backed out changeset a19c6b3e0402 (bug 1482091)
2018-11-02 23:01:15 +02:00
Kris Maglione
96f3e16d1a Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888

--HG--
extra : rebase_source : a9daea3a9efea37acdbcaecda8bf0b7f69631de4
extra : histedit_source : bb8b416b1387da9de3bd95c7a171f10426a22602
2018-10-25 19:04:01 -07:00
prathiksha
7a42d37605 Bug 1459603 - Remove the checkbox from the persistent storage notification. r=johannh
Remove the checkbox from the persistent storage notification.

Differential Revision: https://phabricator.services.mozilla.com/D8891

--HG--
extra : moz-landing-system : lando
2018-11-02 08:15:05 +00:00
Daniel Varga
e86b1d05f8 Merge mozilla-inbound to mozilla-central. a=merge
--HG--
rename : mobile/android/chrome/geckoview/GeckoViewNavigationContent.js => mobile/android/chrome/geckoview/GeckoViewNavigationChild.js
2018-11-02 00:27:53 +02:00
Jan-Erik Rediger
50555e7773 Bug 1468761 - Migrate external Telemetry tests to handle packed histograms r=chutten
Depends on D9236

Differential Revision: https://phabricator.services.mozilla.com/D9237

--HG--
extra : moz-landing-system : lando
2018-11-01 13:46:59 +00:00
Jay Lim
b232c83d80 Bug 1472212 - Ensure that tab does not show busy or burst status whenever we navigate to about:home, about:newtab, or about:welcome in a new window. r=Gijs
Now that we have moved some about: pages to the privileged content process,
opening these URLs from a non-privileged content process will trigger SessionStore
to restore the tab state due to a process flip. We will set favicons for these
URLs earlier to avoid flickering and improve perceived performance.

This patch also prevents the spinner whenever a page with a local about: URI
(about:blank and about: pages that resolve to jar:// or file:// URIs) is
loaded from a process that the URI cannot load in (e.g. loading about:newtab
in the web content process), as well as during tab duplication or session
restoration for such local about: URIs.

Before this patch, there were additional frames when opening a new window, causing
browser/base/content/test/performance/browser_windowopen.js to fail. This patch
will reduce the number of frames when opening a new window.

MozReview-Commit-ID: yjj2964KSz

--HG--
extra : source : cecc2d52e72e7c6e61137a9147735cb07a079d51
extra : intermediate-source : 21a6f1a83c73ce4fff654d4b2118e98375f0a528
extra : histedit_source : e8b8132856b7ee27b530798c2721b76118de655e
2018-07-20 16:43:12 -04:00
Ciure Andrei
60ea98ca60 Backed out 10 changesets (bug 1501044, bug 1472212) for fetch-destination.https.html perma failure CLOSED TREE
Backed out changeset aa35078cabaa (bug 1472212)
Backed out changeset bf02793f802d (bug 1472212)
Backed out changeset 95a7ef6102a6 (bug 1472212)
Backed out changeset 7b7fa6ab2229 (bug 1472212)
Backed out changeset 4fe4ec18f2f3 (bug 1472212)
Backed out changeset 18f824674b76 (bug 1472212)
Backed out changeset 1978a7837502 (bug 1472212)
Backed out changeset 21a6f1a83c73 (bug 1472212)
Backed out changeset 48242d39d532 (bug 1472212)
Backed out changeset 0b5cf2f4305a (bug 1501044)
2018-10-30 23:31:10 +02:00