Commit Graph

12973 Commits

Author SHA1 Message Date
Andreas Pehrson
4acbf7149c Bug 1438538 - Fix SourceListener::CapturingAudio logic. r=johannh
MozReview-Commit-ID: 9K0kOatj1CQ

--HG--
extra : rebase_source : ff026916008bafa17615d01ad01dd87aafab467a
2018-02-20 13:40:46 +01:00
Dorel Luca
f41b03eca9 Backed out changeset 38577c007450 (bug 1424371) for Marionett test failure on testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py. CLOSED TREE 2018-02-19 22:15:23 +02:00
Dorel Luca
037478c033 Backed out 9 changesets (bug 1410456) for Mochitest failure on mobile/android/tests/browser/chrome/test_media_playback.html
Backed out changeset 36f6b40dfa88 (bug 1410456)
Backed out changeset 19f3248502d9 (bug 1410456)
Backed out changeset 18ef18999175 (bug 1410456)
Backed out changeset 0ec75a56b4c7 (bug 1410456)
Backed out changeset f7eae1545d5e (bug 1410456)
Backed out changeset d59060ecd24c (bug 1410456)
Backed out changeset f996b9dce4a6 (bug 1410456)
Backed out changeset 1f75636b5bce (bug 1410456)
Backed out changeset c170d37b1a04 (bug 1410456)
2018-02-19 21:45:10 +02:00
Milan Sreckovic
7571df7e7c Bug 1424371: Use BaseRect access methods instead of member variables in dom/ r=qdot
MozReview-Commit-ID: HXWhggOMIEK

--HG--
extra : rebase_source : 9c9eacf80d2b7f78faa82a1549170b98d12cdaa8
2018-02-19 12:56:10 -05:00
Alex Chronopoulos
33dc85d377 Bug 1410456 - use jni methods in place of removed cubeb methods. r=padenot
MozReview-Commit-ID: 7DqORSl0Sm2

--HG--
extra : rebase_source : 4559b6a65297bf3b2c70f33b6ab27e612a0fced2
2018-02-19 18:28:10 +02:00
Masatoshi Kimura
0c0ddaa7e8 Bug 1425219 - Stop using GetNativePath in ffvpx. r=jya
FFVPXRuntimeLinker could not handle file paths that contain characters outside the current system code page on Windows. This patch will fix it by using wide char APIs.

MozReview-Commit-ID: 9ES1xFELjDs

--HG--
extra : rebase_source : 4bdc082bd6db9263b41fe74d524e0a4d98802ea8
extra : intermediate-source : 8afa22df3893c678884e3a0811fb6c82790c1a3c
extra : source : c6f916a967a78e176bdb699a85e194bbdc372bce
2017-12-15 23:16:39 +09:00
Andreas Pehrson
f5d34fea0d Bug 1430856 - Default to two default capabilities when a camera can handle anything. r=jib
If a camera returns no capabilities we interpret it as it being able to handle
any capability we throw at it. However, we also end up trying to start it with
the default capability of 0x0@0. This often works, but we can crash when
rescaling it to the chosen target capability 0x0@0.

With this patch we inject up to two default capabilities, one at 640x480@30 and
one at 1280x720@30. With constraints present we'll try to adjust these defaults
so they fit within the constraints while at the same time preserve the
aspect ratio given by prefs.

MozReview-Commit-ID: 3mr7Li5TTbV

--HG--
extra : rebase_source : c525c2fd8d60f5dece548216caefc4976e9afb0b
2018-02-13 20:22:18 +01:00
Andreas Pehrson
7186f8d0f3 Bug 1430856 - Cache CaptureCapability in CapabilityCandidate. r=jib
This will lead to less ipc calls, hopefully speeding up getUserMedia for many
devices.

This also lets us inject any hardcoded capabilities into the candidateSet in
the future (read: next patch).

MozReview-Commit-ID: HjIhRK1nVA1

--HG--
extra : rebase_source : f58e16c45f7bd6738ce0a0527dc86854f804bc7b
2018-02-13 20:13:47 +01:00
Dan Glastonbury
35b53a22df Bug 1428947 - Check plane width & stride constraints. r=mattwoodrow
MozReview-Commit-ID: HEcMG4JoEl3
2018-02-19 11:41:41 +10:00
Chris Peterson
0129d900f3 Bug 1436263 - Part 2: Replace override final virtual function specifiers with just final. r=froydnj
MozReview-Commit-ID: 70gt5SUu4Dv

--HG--
extra : rebase_source : 71912c6bde22aaed01e70615a4ee794a36e70d0e
extra : source : 1c22d4c65d70b797ee3e963ec426c90e1f89b5e3
2018-02-05 22:50:00 -08:00
Chris Peterson
d09123f248 Bug 1436263 - Part 1: Replace final override virtual function specifiers with just final. r=froydnj
MozReview-Commit-ID: DE5HkIhsZ6D

--HG--
extra : rebase_source : 94831c1e13a840dd2ea0600f64bcf70c2bf938d9
extra : source : cf9283bf1b0bca3a6311c98e227329d451f80ecb
2018-02-05 22:46:57 -08:00
Kyle Machulis
9e159ac69d Bug 1407040 - Change HTMLMediaElement XPCOM Enums to WebIDL Enums; r=bz
MozReview-Commit-ID: 55GnbaL2HKl

--HG--
extra : rebase_source : 5bb6c927443bf6adcfe594e69bd70c3b597b9ea4
2018-02-14 19:23:32 -08:00
Ralph Giles
31e3a8ea65 Bug 1437351 - Update callers for mp4parse v0.10.0. r=kinetik
Remove references to the mp4parse_log() method which was
removed in this release. Instead we default to the logging
implementation provided by libgkrust.

MozReview-Commit-ID: KKzeEcB5UiP

--HG--
extra : rebase_source : 2777f13a006c09afb82772475d25245b2752524c
2018-02-13 17:22:37 -08:00
Dorel Luca
dabf7b41ee Merge mozilla-central to autoland. CLOSED TREE
--HG--
extra : amend_source : 021950f3661e3b1d96e768155c5754b7af039f84
2018-02-15 00:35:45 +02:00
Paul Adenot
46da831f14 Bug 1422820 - Don't recurse too much when shutting down cameras. r=pehrsons
--HG--
extra : histedit_source : 2f3145f04e4ca35a412b9870a29ff26d28eab5d6
2018-02-08 17:49:25 +01:00
Munro Mengjue Chiang
6a3772c982 Bug 1426129 - Hold CamerasChild via promoting "this" to a RefPtr. r=jib
MozReview-Commit-ID: JdZqnGxlsBV

--HG--
extra : histedit_source : e7ad3a93f442260b2b9e4f6e8acb6d4e244f3fa1
2018-01-16 15:27:09 +08:00
Boris Zbarsky
9bdcffc985 Bug 1436902 part 3. Replace usage of NS_IMPL_ISUPPORTS_INHERITED0 with NS_INLINE_DECL_REFCOUNTING_INHERITED when possible. r=mccr8
The change to RootAccessible.cpp fixes an obvious bug introduced in bug 741707.

The visibility changes in gfx/thebes are because NS_DECL_ISUPPORTS has a
trailing "public:" that those classes were relying on to have public
constructors.

MozReview-Commit-ID: IeB8KIJCGhU
2018-02-12 15:44:40 -05:00
Tom Ritter
aa82f54ab6 Bug 1435296 Address test failures caused by bumping timer precision to 2 ms r=baku
There are a few different reasons why tests needed updating (not an exhaustive list):

- Tests assume that successive operations take place at different times.
- Tests assume that an operation took a minimum amount of time.
- Tests hardcodes a specific delay.

In most cases we hardcode the preference off. In some cases this is the best approach,
in others, we would like to improve. The bug for tracking those improvements is Bug 1429648

An improvement that is present in some tests is to hardcode a specific precision reduction
that is acceptable based on the confides of the test. (Obviously this needs to be a fix for
the test framework and not a requirement on the feature being tested.)

In a few places, the test itself can be fixed, for example to no longer require the end
time of an operation to be strictly greater than the start time, and allows it to be equal
to it.

MozReview-Commit-ID: J59c7xQtZZJ

--HG--
extra : rebase_source : df8a03e76eaf9cdc9524dbb3eb9035af237e534b
2018-02-12 11:39:41 -06:00
Chris Pearce
e878eeef74 Bug 1182329 - Allow pages which have camera/microphone permission to autoplay audible media. r=jib
It seems reasonable to assume that when a page has been granted permission
to capture camera/microphone, the user intends it to play audible media.

MozReview-Commit-ID: 1RdsPK1vRPt

--HG--
extra : rebase_source : 688b68c29d73f117a2cc376233d664bc9cdb5d52
2018-02-08 16:05:46 +13:00
Andreas Pehrson
5a51d4ff01 Bug 1435670 - Remove assert when there's no capability for a device. r=jib
Not all devices have capabilities. Our code is already setup to handle that
case by defaulting to a capability with width,height,maxFPS=0 and propagating
the failure to start.

MozReview-Commit-ID: AZJKZeBrYC2

--HG--
extra : rebase_source : f1030fc97416f9b3b8e363edcbf440f6f250c749
2018-02-08 11:23:53 +01:00
Andreas Pehrson
1f1e4dde69 Bug 1433552 - Allow zeroes to CamerasParent's FeasibilityDistance functions. r=jib
Getting zeroes here is rare, but the numbers come from a platform API so no
guarantees are given for them. This patch makes it as permissive as possible.

MozReview-Commit-ID: 2bjPRzhk1L7

--HG--
extra : rebase_source : 0a3bf122f79d4ff69c0d471dde32d5865edbfce5
2018-02-02 16:57:45 +01:00
Byron Campen [:bwc]
01d2150df6 Bug 1437832 - Part 2: Use the same C++ logic for replaceTrack, removeTrack, and addTrack (when on a pre-existing transceiver). r+jib r=jib
MozReview-Commit-ID: KQSlagkmAZ

--HG--
extra : rebase_source : 10a1f60995277f37b76b32ed741f51821a8a9729
2018-02-13 13:25:19 -06:00
Byron Campen [:bwc]
76cebe2eb1 Bug 1437832 - Part 1: Test-case for addTransceiver, then addTrack, then removeTrack. r+jib r=jib
MozReview-Commit-ID: 70hjut3HIsw

--HG--
extra : rebase_source : 0e7b247aeb1da696d208978683dfbedda9daf41d
2018-02-13 13:21:29 -06:00
Alex Chronopoulos
344ccb9379 Bug 1431056 - Stop using fake constraints in a media mochitest. r=pehrsons
MozReview-Commit-ID: 8vhrSvOKfIR

--HG--
extra : rebase_source : 85c84fddf8195d7178c2dc541bdfd3b6414a2ec7
2018-02-14 12:26:12 +02:00
Andrew McCreight
b7bb86d0d4 Bug 1436184 - Remove definitions of Ci, Cr, Cc, and Cu from httpd.js and .sjs files. r=florian
MozReview-Commit-ID: IKKb9zr2OSf

--HG--
extra : rebase_source : 72d949405c18e6d421422e7865182352eee0c407
2018-02-06 15:03:13 -08:00
Narcis Beleuzu
a167feb192 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-02-08 21:34:52 +02:00
Andrea Marchesini
806d5dbc75 Bug 1434884 - WebVTT parser must be able to deal with partial lines, r=rillian 2018-02-08 11:45:06 +01:00
Paul Adenot
7ed231dd99 Bug 1420322 - Add a test for seamless looping. r=pehrsons
MozReview-Commit-ID: 8WdItn7SXB3

--HG--
extra : rebase_source : e4b45545013733b03d41f9eedb5125866f2d50a4
2018-02-06 15:25:25 +01:00
Karl Tomlinson
df12c01556 bug 1436267 fallback from audio callback to system clock driver on error only once r=padenot
Usually, mShouldFallbackIfError has been reset to false in DataCallback()
before Stop() is called.  However, if fallback to a system clock driver due to
cubeb error had already occurred, then mShouldFallbackIfError would not have
been reset, and Stop() is still called.  With mShouldFallbackIfError still
true, a cubeb error in stop would have created another fallback thread.

I expect that resetting mShouldFallbackIfError in Stop() would also be an
effective alternative solution, but resetting on StateCallback() happens
earlier, which would be an advantage if any additional errors could possibly
be reported to StateCallback().

MozReview-Commit-ID: E9j7PQmS3O4

--HG--
extra : rebase_source : 200993c9e99475101c429005cfadb7260df29067
2018-02-07 20:16:01 +13:00
Byron Campen [:bwc]
63e00f7ce5 Bug 1435013: Sync transceivers before creating offers/answers. r=jib
MozReview-Commit-ID: EORXVc8Hnky

--HG--
extra : rebase_source : 1ea186ac38f44b83f247b51224dd83be0b09df42
2018-02-01 12:07:02 -06:00
Andreas Pehrson
fe7bade6b4 Bug 1434946 - Indentation fix. r=jib
MozReview-Commit-ID: JCQxatbThyI

--HG--
extra : rebase_source : 6d5c7319a69da1b5e93b352be79400ad8fd526f8
2018-02-01 18:35:55 +01:00
Andreas Pehrson
0c896f9aef Bug 1434946 - Set framerate in settings when capabilities are updated. r=jib
This adds back the `framerate` update that was removed in bug 1299515.

It also fixes a threading issue (not really an issue, but it broke the
documented policy) where Start() wrote to mCapability without holding mMutex.

MozReview-Commit-ID: Jda5moNhlkM

--HG--
extra : rebase_source : a8f27f064b9f818eb29aa72a18605786c474631b
2018-02-01 17:00:59 +01:00
Andreas Pehrson
f52aa5b27e Bug 1434946 - Report resolution change in settings already on first frame. r=jib
MozReview-Commit-ID: IzhdiHgVKOc

--HG--
extra : rebase_source : 085308eb966554ed71fb6b758cd59132b43d6ceb
2018-02-01 16:58:35 +01:00
Andreas Pehrson
422d32be88 Bug 1434861 - Simplify rescaling code in MediaEngineRemoteVideoSource::DeliverFrame. r=jib
Most importantly, this reduces the number of copies to 1 in the common case.
In a case where we are rescaling because there are competing gUM requests
this does two copies, where one is the crop-and-scale operation itself.

In the worst case we do two allocations, but with a buffer pool and a recycling
ImageContainer we allocate very rarely in practice.

MozReview-Commit-ID: B0Et4wZol9n

--HG--
extra : rebase_source : e0950a53278336773570c9e989a21392195f8898
2018-02-01 16:06:19 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Paul Adenot
03d4052829 Bug 1434600 - Clean up the MediaEngineWebRTC*Source when navigating away from a document. r=pehrsons
MozReview-Commit-ID: 4XXJ6fcdV9G

--HG--
extra : rebase_source : 610219c774e4fbfe5265d51f9cf818c178e0704b
2018-01-31 19:03:39 +01:00
Paul Adenot
8413544b59 Bug 1434600 - Add a method to clean up by window ID, on a MediaEngine. r=pehrsons
MozReview-Commit-ID: 12w4StZE2eg

--HG--
extra : rebase_source : 3c3ddf24da24e42e53d9e5352cb83945c97ead99
2018-01-31 19:02:00 +01:00
Paul Adenot
4bf54def7a Bug 1434600 - Plumb the window ID down to Enumerate{Audio,Video}Devices. r=pehrsons
MozReview-Commit-ID: 57d8l89Iq4v

--HG--
extra : rebase_source : a31703dfedadbedfc0dbbb0a4949db672cc16c70
2018-01-31 17:57:59 +01:00
Andreas Pehrson
54d329cb35 Bug 1435673 - Strengthen some MediaEngineWebRTCMicrophoneSource asserts. r=padenot
MozReview-Commit-ID: HtjndNLWZI8

--HG--
extra : rebase_source : e9076defa2bc667d5c96cee3bbccc6d297fc8aab
2018-02-05 10:58:21 +01:00
Andreas Pehrson
06be9533d1 Bug 1435673 - Do some cleanup that was meant to happen earlier. r=padenot
MozReview-Commit-ID: 1v07YH1hKiG

--HG--
extra : rebase_source : c7aab7a7480d8a72b0e312cfe24a7aa212f0cf5d
2018-02-05 10:54:10 +01:00
Andreas Pehrson
c1032b3da7 Bug 1435673 - Inline Alloc/FreeChannel and fix access per threading model. r=padenot
MozReview-Commit-ID: 1hpt8tAFuKW

--HG--
extra : rebase_source : 7ce40c2811b1869f98a7737373f02db7b488b829
2018-02-05 10:50:47 +01:00
Andreas Pehrson
650dcb5d2d Bug 1435673 - Fix calling Deallocate() without SetTrack(). r=padenot
Before bug 1299515 we assigned stream and track id in Allocate(), meaning that
any Deallocate() had a guarantee of them being set.

This changed to require an extra step of SetTrack() to assign stream and
track id. Deallocate() needs to handle this, which it does with this patch.

MozReview-Commit-ID: Js0cXXOR2Bb

--HG--
extra : rebase_source : f90dc1345ae0c034d2237d771630055729180df4
2018-02-05 10:48:23 +01:00
Sylvestre Ledru
f25e5479bc Bug 1435262 - Remove the const type qualifiers to silent a gcc 8 warning r=gerald
MozReview-Commit-ID: 28NSnyYMPQ0

--HG--
extra : rebase_source : 8674d1dbfabaf8ecc20a58d755e103d13abfc725
2018-02-02 15:49:00 +01:00
Michael Froman
475c6b33c7 Bug 1414171 - pt 3 - Add componentId to expected fields in test_peerConnection_stats.html. r=drno
MozReview-Commit-ID: Hez0vOu5vTs

--HG--
extra : rebase_source : c722927207ad5c8e3c26a56cea70e1d20233e98d
2018-02-01 15:06:01 -06:00
Michael Froman
38bdfba7a2 Bug 1414171 - pt 2 - Sort ICE stats by componentId on about:webrtc. r=drno
- add new component_id field to NrIceCandidatePair
- add the candidate pair component_id to RTCIceCandidatePairStats in
  RecordIceStats_s
- add new column in ice stats table for component id
- sort ice stats by component id first


MozReview-Commit-ID: J89ZIYEUyRk

--HG--
extra : rebase_source : 681a5afa1303b4e377fcc14d099ce0b3d852f22c
2018-01-30 22:23:54 -06:00
Andreas Pehrson
44946573a2 Bug 1434988 - Make audio loopback mochitest return early without loopback device set up. r=achronop
MozReview-Commit-ID: AA05i50qI2A

--HG--
extra : rebase_source : 9b5911586741eacd8c8b32b1e291b9d8bd64b709
2018-02-01 19:28:57 +01:00
Gurzau Raul
1315ffda06 Merge inbound to mozilla-central. a=merge 2018-02-02 00:22:39 +02:00
Gurzau Raul
047564ed7a Merge inbound to mozilla-central. a=merge 2018-02-01 23:53:53 +02:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Boris Zbarsky
478687c2e8 Bug 1434686 part 4. Use IgnoreErrors() in dom/. r=mystor
MozReview-Commit-ID: GwVDrTLPTOb
2018-02-01 14:21:14 -05:00