19042 Commits

Author SHA1 Message Date
Markus Stange
47d0dd8d47 Bug 1721109 - Move sharedLibraries extraction out of createMultiModalGetSymbolTableFn. r=canaltinova
Depends on D120167

Differential Revision: https://phabricator.services.mozilla.com/D120168
2021-07-29 20:28:39 +00:00
Markus Stange
cf1d90ff69 Bug 1721109 - Split createLibraryMap into two functions. r=canaltinova
Depends on D120166

Differential Revision: https://phabricator.services.mozilla.com/D120167
2021-07-29 20:28:39 +00:00
Nicolas Chevobbe
6cd53a1071 Bug 1722462 - [devtools] Wait for dom-complete in waitForViewportLoad. r=ochameau
Depends on D121059

Differential Revision: https://phabricator.services.mozilla.com/D121071
2021-07-29 09:07:37 +00:00
Claudia
c0e4f423b1 Bug 1430022 - [devtools] Adds an error message in the copy command on a cyclic object r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D120623
2021-07-29 05:36:13 +00:00
Christoph Kerschbaumer
4a6250387f Bug 1719272: Annotate failing browser/ tests to potentially enable https-first mode in Nightly r=webcompat-reviewers,denschub,webdriver-reviewers,preferences-reviewers,Gijs,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D119177
2021-07-28 19:16:16 +00:00
Sandor Molnar
68cdec0548 Backed out changeset 7eb8945dd8e3 (bug 1719272) for causing bustages in gecko decision task. CLOSED TREE 2021-07-28 19:47:06 +03:00
Hubert Boma Manilla
8197c6fc6a Bug 1721161 - [devtools] Fix debugger highlight on pause/resume xhr breakpoints r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D120978
2021-07-28 16:21:30 +00:00
Christoph Kerschbaumer
bb716f0701 Bug 1719272: Annotate failing browser/ tests to potentially enable https-first mode in Nightly r=webcompat-reviewers,denschub,webdriver-reviewers,preferences-reviewers,Gijs,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D119177
2021-07-28 16:08:07 +00:00
Alexandre Poirot
7b8be8dd09 Bug 1722553 - [devtools] Avoid enabling server targets for WebExtension commands. r=jdescottes
WebExtension reload command is still broken with target switching.
Enabling server targets would break this on all reloads.
So prevent enabling server targets until this is fixed.

Differential Revision: https://phabricator.services.mozilla.com/D120982
2021-07-28 12:04:32 +00:00
Nicolas Chevobbe
38c85b13c1 Bug 1722665 - [devtools] Use reloadViewport helper for reloading page in RDM tests. r=ochameau.
Depends on D121058

Differential Revision: https://phabricator.services.mozilla.com/D121059
2021-07-28 12:04:01 +00:00
Nicolas Chevobbe
2d0b1355f3 Bug 1722461 - [devtools] Wait for dom-complete after reloading in browser_viewport_resizing_after_reload.js . r=ochameau.
This patch adds a `reloadViewport` helper that listen for both the viewport
`load` event and for the next dom-complete DOM event so the page is fully loaded.
This makes the test to pass when server side target switching is enabled.

Depends on D120979

Differential Revision: https://phabricator.services.mozilla.com/D121058
2021-07-28 12:04:01 +00:00
Hubert Boma Manilla
c0f417dca9 Bug 1722677 - [devtools] Fix intermittent for browser_net_stacktraces-visibility.js with server targets r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D121072
2021-07-28 11:51:37 +00:00
Hubert Boma Manilla
6649d46dda Bug 1722688 - [devtools] Fix browser_dbg-unselected-pause.js failure with server targets r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D121073
2021-07-28 11:50:16 +00:00
Alexandre Poirot
382206d3e0 Bug 1722501 - [devtools] Migrate styleeditor to will-navigate. r=nchevobbe
We used to handle navigation with a subtle and complex combination of target-available + dom-loading.
Just because we were missing will-navigate event in some cases.
But will-navigate is now reliable and is fired in all types of navigations.

Differential Revision: https://phabricator.services.mozilla.com/D120961
2021-07-28 11:48:47 +00:00
Alexandre Poirot
472ebe58a2 Bug 1722664 - [devtools] Fix browser_net_error-boundary-01.js intermittent with server targets. r=nchevobbe
Accessing TargetMixin.localTab during destroy is risky as it may throw.
Reading TabDescriptor.localTab is safer as it will never throw.

This test was failing intermittently on debug builds.

Differential Revision: https://phabricator.services.mozilla.com/D121055
2021-07-28 11:42:28 +00:00
Alexandre Poirot
2a1c2621cb Bug 1722545 - [devtools] Disable server targets in browser_perf-docload.js/browser_perf-refresh.js. r=nchevobbe
The old performance panel behaves quite differently in case of target switching.
It will open a brand new profile for the next test, which confuses these tests.

Differential Revision: https://phabricator.services.mozilla.com/D120990
2021-07-28 11:42:27 +00:00
Nicolas Chevobbe
551ded00a4 Bug 1722460 - Wait for dom-complete after reloading between each test case in browser_viewport_changed_meta.js . r=ochameau.
This makes the test to pass when server side target switching is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D120979
2021-07-28 05:25:02 +00:00
Julian Descottes
5b6e5d9bb4 Bug 1722458 - [devtools] New performance panel can not be disabled from Settings panel in DevEdition r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D120943
2021-07-27 19:03:54 +00:00
Alexandre Poirot
957ea4e3c9 Bug 1722547 - [devtools] Fix browser_allocations_target.js with server targets. r=jdescottes
This test was still using TabDescriptorFactory instead of CommandsFactory.

Differential Revision: https://phabricator.services.mozilla.com/D120981
2021-07-27 16:50:52 +00:00
Paul Zuehlcke
947223ccc9 Bug 1721131 - [devtools] Use WindowGlobalParent documentStoragePrincipal for storage access. r=nchevobbe
We need to use documentStoragePrincipal rather than the regular document principal, because it
contains the partitionKey which is used to isolate storage of third-party resources.

Differential Revision: https://phabricator.services.mozilla.com/D120853
2021-07-27 16:44:55 +00:00
Csoregi Natalia
aa5c510638 Backed out changeset 6a96e55759fa (bug 1721161) for causing failures on browser_dbg-xhr-breakpoints.js. CLOSED TREE 2021-07-27 18:52:37 +03:00
Alexandre Poirot
cf218bbc87 Bug 1721823 - [devtools] Make isServerTargetSwitchingEnabled be a runtime flag from server standpoint. r=jdescottes,devtools-backward-compat-reviewers
This helps enabling server targets only for local tabs descriptors
and so prevents enabling them for about:debugging toolboxes.
They are always using remote tabs descriptors and do not support target switching yet.

Differential Revision: https://phabricator.services.mozilla.com/D120629
2021-07-27 15:23:24 +00:00
Alexandre Poirot
c85b6b459f Bug 1722476 - [devtools] Fix browser_dbg-link-reload.js with server side target. r=nchevobbe
We weren't waiting for the html page to be displayed in the source tree,
leading to failure when trying to set the breakpoint just after opening the toolbox.

Differential Revision: https://phabricator.services.mozilla.com/D120950
2021-07-27 15:10:35 +00:00
Alexandre Poirot
d9ab53c848 Bug 1722477 - [devtools] Fix browser_theme_switching.js with server targets. r=nchevobbe
Mochitest's default tab is very special.
Its WindowGlobal is stuck on the initial about:blank document.
This document should be transient and we should have another final about:blank document,
even if we expect about:blank document at the end.
This isn't reproducible with a regular firefox run,
but we should investigate this as it may bit us in some other random tests.

Differential Revision: https://phabricator.services.mozilla.com/D120949
2021-07-27 15:10:35 +00:00
Alexandre Poirot
2089c9ab98 Bug 1713670 - [devtools] Disable server targets in tests covering client targets. r=nchevobbe
target actor's will-navigate and navigate is no longer fired with server targets.
These two tests are still asserting them, so disable server target in these two tests.
We should probably remove them once we drop the server target preference (bug 1721852).

Differential Revision: https://phabricator.services.mozilla.com/D120947
2021-07-27 15:10:34 +00:00
Hubert Boma Manilla
335c9eb2f1 Bug 1721161 - [devtools] Fix debugger highlight on pause/resume xhr breakpoints r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D120978
2021-07-27 14:59:29 +00:00
Julian Descottes
457ff0e57c Bug 1720067 - [devtools] Fix computed view when remote debugging servers with different properties r=nchevobbe
This might not be critical for FF90 debugging, as it will be replaced by FF91 soon.
However in the long run, this issue could happen again so having a fix would be nice.

Differential Revision: https://phabricator.services.mozilla.com/D120859
2021-07-27 14:08:18 +00:00
Hubert Boma Manilla
4d911c3bf0 Bug 1722320 - [devtools] Fix intermittent for browser_net_stacktraces-visibility r=nchevobbe
Switched to using a simple/consistent test page with one request
as we just test stacktrace visibility

Differential Revision: https://phabricator.services.mozilla.com/D120941
2021-07-27 13:42:18 +00:00
Hubert Boma Manilla
6e06a8ee2d Bug 1721885 - [devtools] Fix browser_dbg-unselected-pause.js race condition r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D120957
2021-07-27 13:22:25 +00:00
Nicolas Chevobbe
8ded5695e6 Bug 1721911 - [devtools] Fix a11y inspector with server side target switch.r=ochameau.
Wait for accessibility front to be available on target switch in the client.
Disable accessibility service on ParentAccessibilityActor destroy.

Differential Revision: https://phabricator.services.mozilla.com/D120827
2021-07-27 12:19:56 +00:00
Nicolas Chevobbe
eee80235c1 Bug 1721369 - [devtools] Fix browser_inspector_highlighter-eyedropper-xul.js with server side target switching enabled. r=ochameau.
The test was failing with server side target switching when navigating to the
html document from the xul one.
As the navigation is clearing up the selection, it led to the color picker to
be closed, which was trigerring an RDP call (setRuleText), which would fail
as the navigation would end up closing the connection, and triggering an error
as the RDP call was still pending.
Closing the picker before navigating fixes this issue.

Differential Revision: https://phabricator.services.mozilla.com/D120812
2021-07-27 05:38:41 +00:00
Iulian Moraru
bbb0465443 Bug 1683265 - disable browser_toolbox_zoom.js on windows_10_64_qr for frequent failures. r=intermittent-reviewers,bhearsum DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D120887
2021-07-26 20:17:34 +00:00
Alexandru Michis
152604b0fb Bug 1639020 - Disable browser_filter-editor-04.js and browser_flame-graph-01.js for frequent failures on linux and windows webrender. r=intermittent-reviewers,jmaher DONTBUILD
browser_filter-editor-04.js is frequently failing on windows/linux webrender platforms together with browser_flame-graph-01.js on windows webrender ones.

Differential Revision: https://phabricator.services.mozilla.com/D120778
2021-07-26 18:43:43 +00:00
Julian Descottes
f59663fd57 Bug 1722311 - [devtools] Disable debugger ACTION logs in mochitests r=ochameau
You can re-enable action logs when running a test by passing --setpref devtools.debugger.log-actions=true

Differential Revision: https://phabricator.services.mozilla.com/D120855
2021-07-26 18:22:40 +00:00
Hubert Boma Manilla
2c45a516e9 Bug 1722153 - [devtools] Fix blank stacktrace panel when opening from a second location r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D120819
2021-07-26 13:07:55 +00:00
Hubert Boma Manilla
d54f0f14dd Bug 1721384 - [devtools] Fix browser_net_websocket_stacks.js with server side targets r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D120620
2021-07-26 11:51:53 +00:00
Julian Descottes
e9af7b1ac5 Bug 1721984 - [devtools] Wait for style update in browser_rules_color_scheme_simulation*.js r=nchevobbe
Those tests are relying on a specific event to assume that color scheme simulation has been disabled, but nothing guarantees that we don't capture another unrelated event in the meantime so this is very fragile.

Instead waitFor the correct style to be applied. This is already what we do in most asserts in those tests.

Differential Revision: https://phabricator.services.mozilla.com/D120820
2021-07-26 09:22:57 +00:00
Emilio Cobos Álvarez
38cb903038 Bug 1717873 - Move link color styles to ua.css. r=morgan
We expose these via CSS system colors, so this way we don't need to
rebuild the preference sheet when the link color is different.

Differential Revision: https://phabricator.services.mozilla.com/D120677
2021-07-24 12:05:30 +00:00
Alexandre Poirot
a4a5bf63c2 Bug 1691588 - [devtools] Rewrite browser_dbg_WorkerTargetActor.attach.js into a TargetCommand test. r=nchevobbe
This test was relying the BrowsingContextTargetActor.listWorkers, but this isn't fission compatible.
The target actor will be destroyed in case of top level target.
This starts to be failing with bfcache in parent, and will also fail with server side targets.

We should rather be testing TargetCommand's behavior instead of individual fronts.

The main STR being covered in this test which isn't covered yet is BF Cache navigation.

Differential Revision: https://phabricator.services.mozilla.com/D117164
2021-07-23 09:01:55 +00:00
Julian Descottes
8c7729a8a4 Bug 1721197 - [devtools] Add test re-opening the toolbox after setting breakpoints in evaled sources r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D120504
2021-07-23 08:31:50 +00:00
Julian Descottes
66ea60801d Bug 1721540 - [devtools] Remove the preference behind devtools color-scheme simulation buttons r=nchevobbe
Depends on D120441

Differential Revision: https://phabricator.services.mozilla.com/D120442
2021-07-23 07:12:06 +00:00
Markus Stange
523ac2e175 Bug 1721072 - Stop exporting getSymbolsFromThisBrowser and remove its pageContext argument. r=canaltinova
This function is now only used by the keyboard shortcuts and by the popup.

Differential Revision: https://phabricator.services.mozilla.com/D120166
2021-07-22 18:54:31 +00:00
Markus Stange
239ea3c657 Bug 1721072 - Improve type coverage for nsIProfiler. r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D120165
2021-07-22 18:54:30 +00:00
Markus Stange
e6f68680c1 Bug 1721072 - Clarify ActorReadyGeckoProfilerInterface situation. r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D120164
2021-07-22 18:54:30 +00:00
Markus Stange
e33b60e05f Bug 1721072 - Stop supplying a perfFront argument to about:profiling's gInit function. r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D120163
2021-07-22 18:54:30 +00:00
Markus Stange
c9bda00134 Bug 1721072 - Move perfFront out of the redux state, into component props. r=canaltinova
Now it's only used in components that are used in the devtools panel.
It is no longer used for about:profiling.

Differential Revision: https://phabricator.services.mozilla.com/D120162
2021-07-22 18:54:29 +00:00
Markus Stange
7ffab28686 Bug 1721072 - Move recordingState updates into the reducer. r=canaltinova
What ProfilerEventHandling was doing was basically a reducer, just
not in the place where reducers are normally put.

Differential Revision: https://phabricator.services.mozilla.com/D120161
2021-07-22 18:54:29 +00:00
Markus Stange
0b2272d8d5 Bug 1721072 - Move ProfilerEventHandling initialization logic into the reducer. r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D120160
2021-07-22 18:54:28 +00:00
Markus Stange
72afc2d946 Bug 1721072 - Run prettier on perf.d.ts. r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D120159
2021-07-22 18:54:28 +00:00
Markus Stange
f4d62b0632 Bug 1721072 - Stop using combineReducers, for improved type coverage. r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D120158
2021-07-22 18:54:28 +00:00