Commit Graph

201 Commits

Author SHA1 Message Date
Mike Hommey
66d7fe943e Bug 1575420 - Replace MOZ_WIDGET_TOOLKIT value of "gtk3" with "gtk". r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D42765

--HG--
extra : moz-landing-system : lando
2019-08-21 12:25:42 +00:00
Samuel Thibault
55522b7f0f Bug 1574950 - atk: Set returned values to -1 in case of errors, as newly documented in atk r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D42515

--HG--
extra : moz-landing-system : lando
2019-08-20 22:42:49 +00:00
Joanmarie Diggs
534bd455b6 Bug 1446699 - Fix ATK mapping for EVENT_TEXT_SELECTION_CHANGED r=Jamie
The correct mapping for nsIAccessibleEvent::EVENT_TEXT_SELECTION_CHANGED
in ATK is text_selection_changed; not selection_changed. The latter is
meant for containers which support selection of child objects, such as
a menu or expanded select element.

Differential Revision: https://phabricator.services.mozilla.com/D34521

--HG--
extra : moz-landing-system : lando
2019-06-12 04:01:51 +00:00
Sylvestre Ledru
e226046cb8 Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956

--HG--
extra : moz-landing-system : lando
2019-05-01 08:47:10 +00:00
Masayuki Nakano
d8d0bcab65 Bug 1543013 - part 2: Make accessible use mozilla::PresShell directly rather than via nsIPresShell r=Jamie
This patch makes accessible module use `mozilla::PresShell` directly rather
than via `nsIPresShell`.  Additionally, renames `DocAccessible::PresShell()`
to `DocAccessible::PresShellPtr()` for avoiding conflict with using
`PresShell` in it and its sub classes.

Differential Revision: https://phabricator.services.mozilla.com/D26663

--HG--
extra : moz-landing-system : lando
2019-04-13 12:13:15 +00:00
Masayuki Nakano
09fd54444c Bug 1543013 - part 1: Mark some methods of nsCoreUtils as MOZ_CAN_RUN_SCRIPT r=Jamie
This patch marks some methods of nsCoreUtils which are found at writing the
following patches, as `MOZ_CAN_RUN_SCRIPT`.

Due to bug 1543294, some of them are marked as `MOZ_CAN_RUN_SCRIPT_BOUNDARY`
because `MOZ_CAN_RUN_SCRIPT` requires to change base class, but that's
other licenses header or used in our code too many places.

Differential Revision: https://phabricator.services.mozilla.com/D26926

--HG--
extra : moz-landing-system : lando
2019-04-13 12:13:13 +00:00
Sylvestre Ledru
7f60810d86 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D27245

--HG--
extra : moz-landing-system : lando
2019-04-12 13:14:25 +00:00
Martin Stransky
883022425a Bug 1542691 - [Linux] Replace nsGConfService by GSettingsService in accessible/atk/Platform.cpp, r=karlt
Differential Revision: https://phabricator.services.mozilla.com/D26477

--HG--
extra : moz-landing-system : lando
2019-04-09 20:47:45 +00:00
Samuel Thibault
81cc6f4467 Bug 1541457: atk: When watching for toplevel windows to manage as native root accessibles, Also look for refined roles of dialog boxes. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D26181

--HG--
extra : moz-landing-system : lando
2019-04-04 22:50:21 +00:00
Samuel Thibault
2d9c404352 Bug 1535325 atk: Always convert control character events into key names r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D23638

--HG--
extra : moz-landing-system : lando
2019-03-19 01:04:19 +00:00
Boris Zbarsky
9a4ba73134 Bug 1534370 part 3. Mark InsertFromTransferable as MOZ_CAN_RUN_SCRIPT. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D23042

--HG--
extra : moz-landing-system : lando
2019-03-12 01:55:03 +00:00
Martin Robinson
d74ffde9eb Bug 1533429 - Return -1 for atk_text_get_caret_offset when we can't get the offset r=surkov
This makes Gecko conform to the newly documented expected behavior of ATK.

MozReview-Commit-ID: K9sRUDqeLq4

Differential Revision: https://phabricator.services.mozilla.com/D22550

--HG--
extra : moz-landing-system : lando
2019-03-07 18:07:24 +00:00
Marco Zehe
7f72d56975 Bug 1303429 - expose placeholder object attribute for HTML placeholder, r=Jamie
The appropriate case is when placeholder is not used as the absolutely last fallback for the accessible name, and the input is not labeled by the same text as in the placeholder attribute itself. So a label and the placeholder text must be different for the object attribute to be exposed.

In addition, for ATK, placeholder is being renamed to placeholder-text to comply with the platform specification.

Differential Revision: https://phabricator.services.mozilla.com/D19808

--HG--
extra : moz-landing-system : lando
2019-02-18 09:21:32 +00:00
Sylvestre Ledru
14486004b6 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D18488

--HG--
extra : moz-landing-system : lando
2019-02-04 19:10:18 +00:00
Samuel Thibault
782e0fca1e Bug 1523118 atk: Implement scrollsubstringto ATK API. r=surkov 2019-01-26 20:38:53 +01:00
Eitan Isaacson
e18c6010be Bug 1520611 - Consolidate ProxyAccessible::MustPruneChildren into nsAccUtils. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D16997

--HG--
extra : moz-landing-system : lando
2019-01-24 00:23:30 +00:00
Dorel Luca
207c24c7d2 Backed out 3 changesets (bug 1520611) for Android gv-junit failures in org.mozilla.geckoview.test.AccessibilityTest.testTree
Backed out changeset 0a48519a9ad1 (bug 1520611)
Backed out changeset 1fea939a7e7c (bug 1520611)
Backed out changeset c9e244ccc88d (bug 1520611)

--HG--
extra : rebase_source : 448bfe14fbb8741251064da295e036a93a376145
2019-01-23 12:09:29 +02:00
Eitan Isaacson
112ac1fb11 Bug 1520611 - Consolidate ProxyAccessible::MustPruneChildren into nsAccUtils. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D16997

--HG--
extra : moz-landing-system : lando
2019-01-22 19:49:15 +00:00
Ehsan Akhgari
e5e885ae31 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
# ignore-this-changeset

--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Emilio Cobos Álvarez
d2ed260822 Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.

Overall it's not a very interesting patch I think.

nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.

I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.

While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
2019-01-03 17:48:33 +01:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Ehsan Akhgari
6099c9f67b Bug 1508472 - Part 1: First batch of comment fix-ups in preparation for the tree reformat r=sylvestre
This is a best effort attempt at ensuring that the adverse impact of
reformatting the entire tree over the comments would be minimal.  I've used a
combination of strategies including disabling of formatting, some manual
formatting and some changes to formatting to work around some clang-format
limitations.

Differential Revision: https://phabricator.services.mozilla.com/D13046

--HG--
extra : moz-landing-system : lando
2018-11-27 10:08:58 +00:00
Mike Hommey
229e466656 Bug 1504906 - Add another -Werror exception for G_DEFINE_TYPE_EXTENDED. r=gps
Versions of glib newer than the one we currently use adds a function we
don't use.

Differential Revision: https://phabricator.services.mozilla.com/D11136
2018-11-08 19:49:38 +09:00
Mike Hommey
ad2fed0601 Backed out 6 changesets (bug 1504906 and bug 1505652) to give time to toolchains and docker images to build without blocking other landings.
Backed out changeset 2fe1e2b7d9c6 (bug 1504906)
Backed out changeset 27b4002951a4 (bug 1504906)
Backed out changeset f7a685b16579 (bug 1504906)
Backed out changeset f8064dbb8009 (bug 1504906)
Backed out changeset f899fbb4a5d7 (bug 1504906)
Backed out changeset 3f71db4aef73 (bug 1505652)
2018-11-08 17:18:05 +09:00
Mike Hommey
53f7817573 Bug 1504906 - Add another -Werror exception for G_DEFINE_TYPE_EXTENDED. r=gps
Versions of glib newer than the one we currently use adds a function we
don't use.

Differential Revision: https://phabricator.services.mozilla.com/D11136
2018-11-08 17:13:20 +09:00
Sylvestre Ledru
dd5741407b Bug 1498586 - Add clang-format off to avoid the reformatting of the data structures r=Ehsan
Too hard/impossible for the tool to format correctly these structs

Differential Revision: https://phabricator.services.mozilla.com/D8569

--HG--
extra : moz-landing-system : lando
2018-10-12 20:48:24 +00:00
Eitan Isaacson
4561e8e337 Bug 1479036 - Android classes role additions. r=surkov
--HG--
extra : rebase_source : a3612efad26d164c33e7724079722c3163b5cf71
2018-08-09 14:43:00 +03:00
Robert Bartlensky
f68f435575 Bug 1475964 - Add null checks in nsMaiInterfaceTableCell.cpp. r=davidb
MozReview-Commit-ID: 5RSioCelGo3

--HG--
extra : amend_source : 2c811fde280f3b81048eda4a2a09439c49e9dcee
2018-07-16 15:16:42 +01:00
Paolo Amadini
dc49387df8 Bug 1472555 - Part 5 - Remove the listbox layout. r=bz,surkov
MozReview-Commit-ID: Bx1p1nTurCz

--HG--
extra : rebase_source : 6910e500f30eb42b45032dbab85a3dc9c014390b
2018-07-18 11:23:32 +01:00
Robert Bartlensky
9873588035 Bug 1472672 - Add null check for textAcc. r=davidb
MozReview-Commit-ID: AL7R1fdlcvN

--HG--
extra : amend_source : 653d47dd5b5aaf637e5f5796239b304f4f27ccc2
2018-07-04 14:09:32 +01:00
Tokio Kajitsuka
0f609dc771 Bug 1438193 - part11-4: Name r=surkov
turn Name & ARIAName & NativeName into const functions
2018-05-16 01:13:02 +09:00
Samuel Thibault
9fd0d30422 Bug 1458548 - atk: Implement scrollto ATK API. r=surkov 2018-05-02 15:55:33 +02:00
Alexander Surkov
1b66a81b51 Bug 1449530 - fix bustage of a11cb2c5d1f9c CLOSED TREE 2018-04-03 11:00:48 -04:00
Alexander Surkov
4c64dee806 Bug 1449530 - clean up ATK states mapping, r=eeejay 2018-04-03 10:26:57 -04:00
Samuel Thibault
127ee40c95 Bug 1445954 - atk: Fix getTextAfter/Before/AtOffset in character boundary case. r=surkov 2018-03-16 05:52:00 -04:00
Samuel Thibault
6f09cb80ba Bug 1445968 Accessible: factorize and optimize testing for password role r=surkov
--HG--
extra : rebase_source : 5f945bab6c2c86d059893082f9f04d6ac4492f73
2018-03-16 13:02:00 +02:00
Samuel Thibault
39ed413777 Bug 1346535 - atk: Introduce U+FEFF characters to match AT-SPI offsets with DOM offsets. r=surkov, r=dbaron 2018-03-16 15:57:00 -04:00
Alexander Surkov
ea486874e9 Bug 857348 - assert if defunct state is out of sync with content ref, rs=jamie 2018-02-27 16:34:12 -05:00
Sylvestre Ledru
424664ff30 Bug 1278282 - Remove the 'MOZ_WIDGET_GTK == 2' defines r=karlt,lsalzman
MozReview-Commit-ID: 3v8D600g8St

--HG--
extra : rebase_source : 34ea6f9868c1b322076c24daa75dc33e27b6704e
2018-01-10 08:52:04 +01:00
Sylvestre Ledru
eabcdd21b2 Bug 1278282 - Replace #if (MOZ_WIDGET_GTK == 3) by #ifdef MOZ_WIDGET_GTK r=lsalzman
MozReview-Commit-ID: Bo0m7n078oh

--HG--
extra : rebase_source : 1874ac3e0abca65b821b5d04a6610a5cbb63fe24
2018-01-09 11:51:07 +01:00
Sylvestre Ledru
a9961096c0 Bug 1394734 - Simplify various corner cases r=glandium
MozReview-Commit-ID: 4s4JdXZPvmv

--HG--
extra : rebase_source : c8f663c99442d41db5f81ac5fe1aa1f47fd5ed82
2017-12-07 22:10:19 +01:00
Sylvestre Ledru
4591d82b23 Bug 1394734 - Replace CONFIG['CLANG*'] by CONFIG['CC_TYPE'] r=glandium
MozReview-Commit-ID: HbF5oT5HW6f

--HG--
extra : rebase_source : eca479b6ae4bff7f600d1cdb39e11ac2057e4e79
2017-12-07 22:09:38 +01:00
Sylvestre Ledru
9bfe27d903 Bug 1394734 - Replace CONFIG['GNU_C*'] by CONFIG['CC_TYPE'] r=glandium
MozReview-Commit-ID: 7duJk2gSd4m

--HG--
extra : rebase_source : 7312fe276e561e8c034a5f6749774ae812727f9c
2017-12-07 22:09:15 +01:00
Chris Peterson
c4dff4f83d Bug 1402666 - Part 3: Replace Replace(NS_LITERAL_STRING("")) with ReplaceLiteral(u""). r=erahm
MozReview-Commit-ID: Ji6UdG32RF4

--HG--
extra : rebase_source : 1565a1e99f40785dad0d0d7652e42222dcdf8881
extra : source : c57e906ba75fda4745134ef8307589e28f4c8d70
2017-09-15 19:32:55 -07:00
Sylvestre Ledru
4e9cf83ee8 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG

--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Joanmarie Diggs
b66b7af7bc Bug 1355921 - Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE. r=marcoz
Create states::CURRENT and add it to the list of "universal" (global)
ARIA states. Map states::CURRENT to ATK_STATE_ACTIVE and emit accessible
state-change notifications when the value of aria-current is modified.
2017-07-03 17:02:00 +02:00
Joanmarie Diggs
1115881728 Bug 1375460 - "haspopup" AtkObject attribute missing if multiprocess enabled. r=surkov
Move the object attribute exposure of states::HASPOPUP from the ATK wrapper
code to the shared accessibility code. Call UniversalStatesFor() rather than
State() for performance.

--HG--
extra : rebase_source : e31c2d00da302538a7f6962d8f4dfd148a7d877e
2017-06-22 07:25:00 -04:00
Joanmarie Diggs
d8b6b99320 Bug 1355447 - Map non-false values of aria-haspopup to ATK_STATE_HAS_POPUP. r=surkov
Change the mapping of states::HASPOPUP from kNone to ATK_STATE_HAS_POPUP.
No new test added because there is not yet support for testing platform
accessibility API mappings via mochitest.

--HG--
extra : rebase_source : bdf50704fa23db29ec5d5b3cdc0b51c8e6466215
2017-06-22 04:34:00 -04:00
Joanmarie Diggs
c306e05c88 Bug 1343537 - Implement ARIA DPUB extension. r=surkov
--HG--
extra : rebase_source : 38af7ac790cb60d952b1dc2885f50fc9c15cdea6
2017-06-13 15:06:08 -04:00
David Major
ed0b8f8653 Bug 1344615: Remove nsXPCOMStrings.{h,cpp} r=bsmedberg
These are now dead code.

MozReview-Commit-ID: AClU0Qx3kmN

--HG--
extra : rebase_source : df83cf89292da1519bb26027c11e14923d5c54a0
2017-03-06 17:52:54 +13:00