Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)
Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.
Co-authored-by: Yutaka Hirano <yhirano@chrmomium.org>
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
--
wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325
Automatic update from web-platform-tests
Revert "Add drawImage() and createImageBitmap() support for blink::VideoFrame."
This reverts commit 27830868be3b06b19761c7ca4507a8e77ab1f535.
Reason for revert: New tests SEGVing on several linux bots
Original change's description:
> Add drawImage() and createImageBitmap() support for blink::VideoFrame.
>
> This makes blink::VideoFrame a CanvasImageSource for drawImage() and
> wires up the existing ImageBitmapSource implementation to
> createImageBitmap() to deprecate VideoFrame.createImageBitmap().
>
> A deprecation notice is added for VideoFrame.createImageBitmap(); the
> method will be removed prior to shipping WebCodecs.
>
> Bug: 1175907
> Test: New (moved from internal) WPT tests.
>
> Change-Id: I549d996c9b16a8d0a1dd5293b5bee29f61cac8f3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2680955
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Reviewed-by: Fernando Serboncini <fserb@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#854938}
Bug: 1175907
Change-Id: I41b3cc7e6d76e4c80131d8cad2299774e4ebec95
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702757
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#855005}
--
wpt-commits: d614b23de08adf12271dcdca27fe752bc4c6a952
wpt-pr: 27667
Automatic update from web-platform-tests
Allow fragmentainers with zero block-size.
The spec [1] says that fragmentainers are assumed to have a minimum
block-size of 1px regardless of their used size, in order to guarantee
content progress. We implemented this by simply making sure that the
used block-size of a fragmentainer would never become less than 1px. But
this wasn't ideal, as that would contribute to unwanted layout overflow
in cases where the content of the multicol container was shorter than
1px.
We'll now still accept at least 1px of content into each fragmentainer,
but don't stretch the fragmentainer itself (just allow the actual column
fragments to become that short as they want, and instead let the content
overflow the columns if necessary).
We still need to fill at least 1px of content before moving to the next
fragmentainer, and fast/multicol/zero-height-with-children.html is a
good test for this.
[1] https://www.w3.org/TR/css-break-3/#breaking-rules
Bug: 829028
Change-Id: I7b4e69524288dad8bb10fd10c715339d1769815a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698554
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#854974}
--
wpt-commits: dfa6dff98df467e0fa2721833c54f7a538d10158
wpt-pr: 27660
Automatic update from web-platform-tests
[TableNG] Fix saturated sizes issue.
We can end up in a situation where:
- table_inline_size is at LayoutUnit::Max()
- border_padding.InlineSum() is at LayoutUnit::Max()
- border_spacing.inline_size is some small value.
This combination results in a negative section_available_inline_size.
Bug: 1178044
Change-Id: I3bd860033195ed420323445e1c790d9f59962b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2694345
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#854940}
--
wpt-commits: 806ae8875bea1b8380081b0da8fd416337ea447f
wpt-pr: 27622
Automatic update from web-platform-tests
Add drawImage() and createImageBitmap() support for blink::VideoFrame.
This makes blink::VideoFrame a CanvasImageSource for drawImage() and
wires up the existing ImageBitmapSource implementation to
createImageBitmap() to deprecate VideoFrame.createImageBitmap().
A deprecation notice is added for VideoFrame.createImageBitmap(); the
method will be removed prior to shipping WebCodecs.
Bug: 1175907
Test: New (moved from internal) WPT tests.
Change-Id: I549d996c9b16a8d0a1dd5293b5bee29f61cac8f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2680955
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#854938}
--
wpt-commits: 5eb4f915be3924ab711150454b1fe083a685e620
wpt-pr: 27617
Automatic update from web-platform-tests
[AspectRatio] Take box-sizing into account in replaced element intrinsic sizing
Take box-sizing into account in replaced element intrinsic sizing when
using aspect-ratio, but keep using content-box when resolving
width/height when no aspect-ratio is set.
This CL removes ResolveWidthForRatio/ResolveHeightForRatio functions
and instead uses InlineSizeFromAspectRatio/BlockSizeFromAspectRatio.
Finally code is added to handle non horizontal writing-mode and a test
is added for that.
Bug: 1163176
Change-Id: I28449b3a0f567d4b3e41afe9a7429a0b03250fb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2690332
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#854925}
--
wpt-commits: c9da3535ef3eb8ad5c24a7c5812e68ac3359ba86
wpt-pr: 27613
Automatic update from web-platform-tests
Fix touch-events/single-touch.html on WPT dashboard
On WPT dashboard, touch-events/single-touch.html fails because touchmove
and touchend events are not received. I fixed this test, so we can now
receive all the touch events.
https://wpt.fyi/results/touch-events/single-touch.html?
label=experimental&label=master&aligned
Bug: 1163370
Change-Id: If0b2ca65d597c89ad982ea51f80e7d026c8a72e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2689949
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#854921}
--
wpt-commits: 618b27ffa120cc7c5a576b6375954c9fb42c36a9
wpt-pr: 27663
Automatic update from web-platform-tests
[TablesNG] Fix orthogonal cell sizing crash.
In order to pick up the fallback orthogonal size we need to call
SetAvailableSize on the builder.
This was triggered after some logic tightening within ng_length_utils.
Bug: 1178130
Change-Id: I59d1c4c9882d96a558e035daa07debb80283fa9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2694344
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#854893}
--
wpt-commits: 7198e2d0ff453d9d2ff1622dee4bd08be2ba7224
wpt-pr: 27621
Automatic update from web-platform-tests
[AspectRatio] treat <ratio> that ends with slash as invalid
Treat <ratio> that ends with slash as invalid:
https://drafts.csswg.org/css-values-4/#ratio-value
Bug: 1045668
Change-Id: Icc4c16222f89402958b7e9f01c904472b15cfa80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2697151
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#854815}
--
wpt-commits: 2ebf73585d4644cc5f232184b69642f36b6b8344
wpt-pr: 27649
Automatic update from web-platform-tests
[selectors] Use ENTER instead of SHIFT in focus-visible-007.html
It's not clear if a modifier key like SHIFT implies
that "the user interacts with the page via the keyboard".
Using ENTER key instead of SHIFT it seems everyone agree,
so let's change the test to use ENTER.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1688539.
--
wpt-commits: 1bee46095eea9411a13783fba4cb08bffbdc8af2
wpt-pr: 27656
This was a little more work than I first thought because fixing it uncovered
another problem: The recurse logic in the muxer isn't quite right. There are a
couple of problems actually:
1. By re-using the results from children that did not fill up, we skip updating
`stateCopy` (and therefore `state`), which messes up subsequent buckets in
the recursion because they're working with the wrong state.
2. By simply assigning `state = stateCopy` after handling children that didn't
fill up, we're not really doing anything because at that point the function
is done. The caller and subsequent buckets in the recursion won't see the
updated state. We need to update `state` in place.
These problems were revealed in test_resultBuckets.js, which is pretty thorough.
To fix the actual problem that the bug is about (not deduping remote suggestions
and form history), we just need to keep a set of suggestions that the muxer has
seen so far, and then `_canAddResult` can discard dupe suggestions. This patch
adds `state.suggestions` for that, and it includes form history, remote
suggestions, and the heuristic query when it's a search result. This way the
relative ordering of form history vs. remote suggestions doesn't matter. We'll
dedupe whichever comes later.
A bunch of tasks in test_resultBuckets.js needed to be updated to account for
this because they were incorrectly not expecting dupes to be removed.
Differential Revision: https://phabricator.services.mozilla.com/D106030
Add a reference to MOZ_NO_ADDREF_RELEASE_ON_RETURN in the message.
Use the qualified name of the function returning the object.
Differential Revision: https://phabricator.services.mozilla.com/D106143
`appearance` CSS rules allow elements to take on system appearance. For UI elements that we want to take on system styling, we set `appearance: auto` combined with platform-specific rules like `-moz-default-appearance: -moz-mac-vibrant-titlebar-light;`
macOS sidebar vibrancy broke because a background-color was being applied to `root`. That colour appeared under elements with `appearance: auto` set, so we wouldn't see the platform-specific styling. This patch moves the root background-color to `#navigator-toolbox`, so that it does not appear under `#sidebar-box`.
We still want a background colour applied to sidebars when a lwtheme includes one. We only want `appearance: auto` applied to sidebars when the active theme does not have sidebar styling rules. That's why `#sidebar-box:not(:-moz-lwtheme)` is changed to `#sidebar-box:not([lwt-sidebar])`.
This patch also removes the rule
```
:root:-moz-lwtheme {
appearance: none;
}
```
from osx/global/global.css. There's no corresponding addition of a `#navigator-toolbox { appearance:none; }` rule because that rule already exists in [osx/browser.css](https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/browser/themes/osx/browser.css#45).
Differential Revision: https://phabricator.services.mozilla.com/D104416
Blit render tasks have special code to read from the texture cache. This isn't necessary anymore now that texture cache items can be used as nodes of the frame graph. Blits can be simplified into reading from any render task without knowing how it was produced.
Differential Revision: https://phabricator.services.mozilla.com/D105746
Other browsers don't have this UI, and there's no way to know whether
the form will actually be validated, so it can cause false-positives.
Depends on D105968
Differential Revision: https://phabricator.services.mozilla.com/D105969
There's no way to know whether the submission will actually be
validated, because formnovalidate on submit buttons is a thing (and even
if all the submit controls had formnovalidate, you could still submit
the form and validate it via form.submit()), so it seems better to make
these pseudo-classes not depend on this.
Differential Revision: https://phabricator.services.mozilla.com/D105968
Currently the default value of buttons is set to
MOUSE_BUTTONS_NOT_SPECIFIED, which defers calculation of the value to
the DOMWindowUtils GetButtonsFlagForButton function. This calculates a
default value based upon the value of the button key.
By specifying a default button value of 0, which has a meaning of
ePrimary, the buttons value is calculated as the
ePrimaryFlag (1), suggesting that a button was pressed.
This patch changes the behaviour to set the value of buttons based on
the original value of button before the default was applied. The value
of buttons also considers the event type to ensure that a mousedown
event has a default value calculated by DOMWindowUtils.
With the new behaviour:
- if a value was explicitly set for buttons, this is used
- if a value was explicitly set for button, then the not-specified
constant is used to defer calculation to DOMWindowUtils
- if an event type was specified and that event type was not the
'mousedown' event, then the no-button constant is used
- if an event type was not specified or it was for the 'mousedown'
event, then the not-specified constant is used to defer calculation to
DOMWindowUtils
Differential Revision: https://phabricator.services.mozilla.com/D105877
The only thing missing now are things that draw arrows / checkmarks.
Make the disabled range thumb opaque, to avoid dealing with clipping
(also matches all other browsers, fwiw).
Differential Revision: https://phabricator.services.mozilla.com/D106011
We basically use a couple primitives to draw these
(PaintRoundedRectWithRadius, FillRect), so making the code a bit generic
implementing stuff with WebRender seems straight-forward.
I've kept using the fallback codepath for the bits that draw complex
paths like arrows and such, but the rest of the things should work with
this patch.
A thing I'm not too happy about is the scrollbar painting setup (requires a lot
of boilerplate), but modulo template hacks make nsNativeBasicTheme a template
that receives its super class as a parameter or something) it seems hard to do
better.
Differential Revision: https://phabricator.services.mozilla.com/D105931
