Commit Graph

618 Commits

Author SHA1 Message Date
Sylvestre Ledru
ba488cdc09 Bug 1598971 - codespell: Fix typos in the doc r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,ato
Depends on D54430

Differential Revision: https://phabricator.services.mozilla.com/D54431

--HG--
extra : moz-landing-system : lando
2019-11-25 10:06:12 +00:00
Mathieu Leplatre
a6d949c39b Bug 1559132 - Add ability to download Remote Settings attachments as bytes r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D53812

--HG--
extra : moz-landing-system : lando
2019-11-25 16:13:52 +00:00
Dorel Luca
b6eeb7d5d3 Backed out changeset 35d4451f348d (bug 1588458) as requested by the dev 2019-10-15 19:04:22 +03:00
Sylvestre Ledru
0f71aeba53 Bug 1588458 - Replace dxr by searchfox in the doc r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D49140

--HG--
extra : moz-landing-system : lando
2019-10-15 15:27:13 +00:00
Geoff Brown
dcb380399e Bug 1582785 - Enable some xpcshell tests on Android; r=geckoview-reviewers,agi
Most of these tests have been disabled for a long time; they run well
in the current test environment.

Differential Revision: https://phabricator.services.mozilla.com/D46642

--HG--
extra : moz-landing-system : lando
2019-09-23 22:43:55 +00:00
Mathieu Leplatre
43084d5e54 Bug 1577218 - Upgrade kinto-offline-client to 12.7.0 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D43773

--HG--
extra : moz-landing-system : lando
2019-08-28 16:08:29 +00:00
Lina Cambridge
19557885f6 Bug 1572615 - Abort bookmark merges that take longer than 5 minutes. r=markh
This commit introduces a new `Watchdog` class that signals an abort,
either after a delay or at shutdown, and wires up the buffered engine
to use it.

Differential Revision: https://phabricator.services.mozilla.com/D41311

--HG--
extra : moz-landing-system : lando
2019-08-13 18:48:25 +00:00
Nicholas Nethercote
73d5a12400 Bug 1572621 - Merge services-common.js into all.js. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D41322

--HG--
extra : moz-landing-system : lando
2019-08-09 09:18:27 +00:00
Mark Hammond
05df0254b8 Bug 1568353 - set the default rest.js timeout to be 5 minutes. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D40927

--HG--
extra : moz-landing-system : lando
2019-08-07 05:25:49 +00:00
Mathieu Leplatre
68a314f460 Bug 1569894 - Upgrade kinto-http-client.js to 4.7.3 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D39852

--HG--
extra : moz-landing-system : lando
2019-07-30 13:32:45 +00:00
Mathieu Leplatre
326c302870 Bug 1563213 - Upgrade kinto-http-client.js to 4.7.2 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D36752

--HG--
extra : moz-landing-system : lando
2019-07-05 13:45:56 +00:00
Victor Porof
34c33b48c4 Bug 1561435 - Fix linting errors for services/, r=standard8
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35931

--HG--
extra : source : f441e31c307bc815c7f05e99c0cd8ee77344dc80
extra : intermediate-source : 7e366ab79479e3a9bbdf9e61f04cfa7b6c271990
2019-06-21 13:38:54 -07:00
Victor Porof
9d673f1f0f Bug 1561435 - Format services/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35930

--HG--
extra : source : 073567e8ded785e46382ba7e402d8da939a69d7b
2019-07-05 10:58:22 +02:00
Mathieu Leplatre
e661f9a03d Bug 1558710 - Make sure clients never try to push local changes r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D36718

--HG--
extra : moz-landing-system : lando
2019-07-03 13:41:21 +00:00
Mathieu Leplatre
0cf601cfff Bug 1559158 - Improve performance of sync for large collections r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D36171

--HG--
extra : moz-landing-system : lando
2019-06-27 13:25:57 +00:00
Mathieu Leplatre
94be713565 Bug 1558812 - Upgrade kinto-offline-client to 12.4.3 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D34715

--HG--
extra : moz-landing-system : lando
2019-06-12 14:20:59 +00:00
Mathieu Leplatre
a102f01554 Bug 1543598 - Move OneCRL and Pinning blocklist clients out of services r=jcj,glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32297

--HG--
rename : services/common/tests/unit/test_blocklist_onecrl.js => security/manager/ssl/tests/unit/test_blocklist_onecrl.js
rename : services/common/tests/unit/test_blocklist_pinning.js => security/manager/ssl/tests/unit/test_blocklist_pinning.js
extra : moz-landing-system : lando
2019-06-11 10:14:40 +00:00
Brian Grinstead
402bc3a970 Bug 1553188 - Part 4 - Update remaining references to browser.xul;r=bdahl
These are generally:
- Code comments to browser.xhtml
- Testcases, assertions that were mostly using browser.xul as a generic chrome URL
- References to the browser.xul path in tree

Differential Revision: https://phabricator.services.mozilla.com/D33208
2019-05-28 16:40:42 -07:00
Mathieu Leplatre
9871d095db Bug 1554178 - Disable events sampling for uptake telemetry tests r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32484

--HG--
extra : moz-landing-system : lando
2019-05-27 07:35:45 +00:00
Mathieu Leplatre
8708f07d79 Bug 1553797 - Fix OneCRL tests when MOZ_NEW_CERT_STORAGE is disabled r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D32331

--HG--
extra : moz-landing-system : lando
2019-05-24 14:32:13 +00:00
Narcis Beleuzu
b9bb66c9e0 Backed out changeset 204c7f42d427 (bug 1554178) for xpcshell failures on test_remote_settings.js . CLOSED TREE 2019-05-25 02:41:41 +03:00
Mathieu Leplatre
daebd4816c Bug 1554178 - Disable events sampling for uptake telemetry tests r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32484

--HG--
extra : moz-landing-system : lando
2019-05-24 16:23:31 +00:00
Mathieu Leplatre
b538ac9a32 Bug 1553142 - Leverage ConsoleAPI in Remote Settings r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32138

--HG--
extra : moz-landing-system : lando
2019-05-22 14:01:53 +00:00
Mathieu Leplatre
8f123db7b9 Bug 1553145 - Improve Remote Settings documentation r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32130

--HG--
extra : moz-landing-system : lando
2019-05-23 09:19:37 +00:00
Mathieu Leplatre
ecf5714fea Bug 1548542 - Remove notions of Kinto in blocklists unit tests r=keeler,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D31221

--HG--
extra : moz-landing-system : lando
2019-05-22 11:25:04 +00:00
Mathieu Leplatre
8eb7224e54 Bug 1526018 - Initialize PSM clients in their own service r=Gijs,jcj
Differential Revision: https://phabricator.services.mozilla.com/D31603

--HG--
extra : moz-landing-system : lando
2019-05-21 21:14:11 +00:00
Ethan Glasser-Camp
cb48225a1c Bug 1551952: Update kinto-offline-client.js to v12.4.2 r=leplatrem
This fixes the bug where the call to getData was not passing
authentication information.

Depends on D31379

Differential Revision: https://phabricator.services.mozilla.com/D31377

--HG--
extra : moz-landing-system : lando
2019-05-16 13:12:40 +00:00
Mathieu Leplatre
2282e96a6d Bug 1471522 - Move blocklist target app filter to Blocklist module r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D31222

--HG--
extra : moz-landing-system : lando
2019-05-15 22:22:50 +00:00
Mathieu Leplatre
78ecdc82c5 Bug 1546912 - Dedicated signature tests for Remote Settings r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D30650

--HG--
rename : services/common/tests/moz.build => services/settings/test/unit/moz.build
rename : services/common/tests/unit/test_blocklist_signatures.js => services/settings/test/unit/test_remote_settings_signatures.js
rename : services/common/tests/unit/test_blocklist_signatures/collection_signing_ee.pem.certspec => services/settings/test/unit/test_remote_settings_signatures/collection_signing_ee.pem.certspec
rename : services/common/tests/unit/test_blocklist_signatures/collection_signing_int.pem.certspec => services/settings/test/unit/test_remote_settings_signatures/collection_signing_int.pem.certspec
rename : services/common/tests/unit/test_blocklist_signatures/collection_signing_root.pem.certspec => services/settings/test/unit/test_remote_settings_signatures/collection_signing_root.pem.certspec
rename : services/common/tests/unit/test_blocklist_signatures/moz.build => services/settings/test/unit/test_remote_settings_signatures/moz.build
extra : moz-landing-system : lando
2019-05-13 17:04:26 +00:00
Mathieu Leplatre
7242d228b7 Bug 1551347 - Fix Uptake Telemetry test failure if channel is release r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D31005

--HG--
extra : moz-landing-system : lando
2019-05-14 13:13:23 +00:00
Mathieu Leplatre
268d77c37f Bug 1547995 - Upgrade kinto-offline-client.js to v12.4.0 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D30356

--HG--
extra : moz-landing-system : lando
2019-05-13 09:30:54 +00:00
Narcis Beleuzu
035ea12dc3 Backed out 2 changesets (bug 1547995) for xpcshell failures on /test_remote_settings.js . CLOSED TREE
Backed out changeset 0bcfcc0bbc65 (bug 1547995)
Backed out changeset 411f5783f046 (bug 1547995)
2019-05-12 14:18:35 +03:00
Mathieu Leplatre
62f3958c34 Bug 1547995 - Upgrade kinto-offline-client.js to v12.4.0 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D30356

--HG--
extra : moz-landing-system : lando
2019-05-09 16:38:56 +00:00
Mathieu Leplatre
a66d81bdb1 Bug 1501214 - Reusable helper to download Remote Settings attachments r=nanj,glasserc,Gijs
Reusable helper to download Remote Settings attachments

Differential Revision: https://phabricator.services.mozilla.com/D28707

--HG--
extra : moz-landing-system : lando
2019-05-10 22:57:40 +00:00
Andreea Pavel
67007aabfa Backed out changeset 7e1942ace2b2 (bug 1501214) for failing test_attachments_downloader.js on a CLOSED TREE 2019-05-08 21:12:06 +03:00
Mathieu Leplatre
54094a0078 Bug 1501214 - Reusable helper to download Remote Settings attachments r=nanj,glasserc,Gijs
Reusable helper to download Remote Settings attachments

Differential Revision: https://phabricator.services.mozilla.com/D28707

--HG--
extra : moz-landing-system : lando
2019-05-08 16:18:07 +00:00
Mathieu Leplatre
3f60f66f05 Bug 1547994 - Remove preference that can disable Remote Settings signature verification r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D29656

--HG--
extra : moz-landing-system : lando
2019-05-07 14:16:22 +00:00
Gijs Kruitbosch
509b7f217a Bug 1257565 - move addon blocklist tests from services/common to the blocklist dir, r=leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D29835

--HG--
rename : services/common/tests/unit/test_blocklist_clients.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js
rename : services/common/tests/unit/test_blocklist_targetapp_filter.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_targetapp_filter.js
extra : moz-landing-system : lando
2019-05-07 00:56:01 +00:00
Gijs Kruitbosch
d773fd23da Bug 1257565 - add remote settings support for plugin and addon blocklist, r=aswan
MozReview-Commit-ID: AiGycyhGUta

Differential Revision: https://phabricator.services.mozilla.com/D29834

--HG--
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_appversion.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_appversion.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_metadata_filters.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_metadata_filters.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_osabi.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_osabi.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_flashonly.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_flashonly.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_outdated.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_outdated.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_regexp.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_regexp.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_severities.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_severities.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_prefs.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_prefs.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_severities.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_severities.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklistchange.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklistchange.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_pluginBlocklistCtp.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_pluginBlocklistCtp.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_pluginInfoURL.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_pluginInfoURL.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_softblocked.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_softblocked.js
extra : moz-landing-system : lando
2019-05-07 00:55:53 +00:00
Gijs Kruitbosch
d8a027e065 Bug 1257565 - switch gfx blocklist over to kinto-based storage, r=leplatrem,aswan
Differential Revision: https://phabricator.services.mozilla.com/D29833

--HG--
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist.xml => toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist.json
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist2.xml => toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist2.json
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist_AllOS.xml => toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist_AllOS.json
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist_OSVersion.xml => toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist_OSVersion.json
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/head.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/head.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_gfx.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_gfx.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Device.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Device.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_DriverNew.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_DriverNew.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Equal_DriverNew.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Equal_DriverNew.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Equal_DriverOld.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Equal_DriverOld.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Equal_OK.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Equal_OK.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_GTE_DriverOld.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_GTE_DriverOld.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_GTE_OK.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_GTE_OK.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_No_Comparison.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_No_Comparison.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OK.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_OK.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OS.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_OS.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OSVersion_match.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_OSVersion_match.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OSVersion_mismatch_DriverVersion.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_OSVersion_mismatch_DriverVersion.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OSVersion_mismatch_OSVersion.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_OSVersion_mismatch_OSVersion.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Vendor.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Vendor.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Version.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Version.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_prefs.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_prefs.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/xpcshell.ini => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/xpcshell.ini
extra : moz-landing-system : lando
2019-05-07 00:55:32 +00:00
Dana Keeler
399a45f767 bug 1546361 - recreate cert_storage data as necessary r=jcj,myk
It turns out that an rkv database created on a 32-bit platform cannot be used on
a 64-bit platform and vice-versa. To work around this for now, we delete and
recreate the DB backing cert_storage and set flags to let our consumers know
to re-load all known data.

Differential Revision: https://phabricator.services.mozilla.com/D29591

--HG--
extra : moz-landing-system : lando
2019-05-03 23:41:17 +00:00
Dana Keeler
f8e974fdd8 bug 1534600 - make nsIContentSignatureVerifier asynchronous r=KevinJacobs,mythmon,glasserc
Differential Revision: https://phabricator.services.mozilla.com/D29763

--HG--
extra : moz-landing-system : lando
2019-05-03 21:21:58 +00:00
Myk Melez
bfe7c7e0b4 Bug 1547877 - enable configuration of new cert storage implementation r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D29306

--HG--
extra : moz-landing-system : lando
2019-05-02 23:02:13 +00:00
Myk Melez
e78c3248d7 Bug 1539549 - update cert blocklist using single transaction r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D28540

--HG--
extra : moz-landing-system : lando
2019-04-26 20:10:59 +00:00
Mathieu Leplatre
6083edb468 Bug 1546525 - Fix intermittent failure between blocklist clients tests and security settings r=glasserc,mgoodwin
Fix intermittent failure between blocklist clients tests and security settings

Differential Revision: https://phabricator.services.mozilla.com/D28974

--HG--
extra : moz-landing-system : lando
2019-04-26 14:36:22 +00:00
Mathieu Leplatre
582063c263 Bug 1512451 - Read OneCRL blocklist from security-states/onecrl r=jcj,mgoodwin,glasserc
Read OneCRL blocklist from security-states/onecrl

Differential Revision: https://phabricator.services.mozilla.com/D23645

--HG--
rename : services/common/tests/unit/test_blocklist_certificates.js => services/common/tests/unit/test_blocklist_onecrl.js
extra : moz-landing-system : lando
2019-04-24 14:52:13 +00:00
Andreea Pavel
75578f7684 Backed out changeset a19d696f96fb (bug 1512451) for failing bc at browser_all_files_referenced.js on a CLOSED TREE
--HG--
rename : services/common/tests/unit/test_blocklist_onecrl.js => services/common/tests/unit/test_blocklist_certificates.js
2019-04-24 00:59:27 +03:00
Mathieu Leplatre
6e4798bb72 Bug 1512451 - Read OneCRL blocklist from security-states/onecrl r=jcj,mgoodwin,glasserc
Read OneCRL blocklist from security-states/onecrl

Differential Revision: https://phabricator.services.mozilla.com/D23645

--HG--
rename : services/common/tests/unit/test_blocklist_certificates.js => services/common/tests/unit/test_blocklist_onecrl.js
extra : moz-landing-system : lando
2019-04-23 18:40:40 +00:00
Rob Wu
4a6f84f91d Bug 1544834 - Replace deprecated generics in test code r=evilpie
- `Array.map` becomes `Array.from`
- Array copying via `Array.slice` becomes `Array.from`.
- `Array.forEach` that did not rely on closures becomes `for`-`of` loops.
- Anything else: `Array.X` becomes `Array.prototype.X`.

Complex cases:

dom/bindings/test/TestInterfaceJS.js and
dom/bindings/test/test_exception_options_from_jsimplemented.html
use `Array.indexOf` to generate an error with a specific error message.
Switched to `Array.prototype.forEach` to generate the same error.

js/src/jit-test/tests/basic/exception-column-number.js
In this test `Array.indexOf()` is used to generate an error. Since the
exact message doesn't matter, I switched to `Array.from()`.

Intentionally not changed:

editor/libeditor/tests/browserscope/lib/richtext/richtext/js/range.js
Did not modify because this is 3rd-party code and the code uses
feature detection as a fall back when Array generics are not used.

testing/talos/talos/tests/dromaeo/lib/mootools.js
Did not modify because mootools adds the `Array.slice` method to the
`Array` object.

Not changed because they check the implementation of Array generics:
js/src/jit-test/tests/basic/arrayNatives.js
js/src/jit-test/tests/basic/bug563243.js
js/src/jit-test/tests/basic/bug618853.js
js/src/jit-test/tests/basic/bug830967.js
js/src/jit-test/tests/jaeger/recompile/bug656753.js
js/src/jit-test/tests/self-hosting/alternate-static-and-instance-array-extras.js
js/src/tests/non262/Array/generics.js
js/src/tests/non262/Array/regress-415540.js
js/src/tests/non262/extensions/regress-355497.js
js/src/tests/non262/extensions/typedarray-set-neutering.js

Depends on D27802

Differential Revision: https://phabricator.services.mozilla.com/D27803

--HG--
extra : moz-landing-system : lando
2019-04-17 19:03:19 +00:00
Rob Wu
1af4c55c01 Bug 1544834 - Replace non-test uses of deprecated Array generics r=evilpie,dao
- `Array.forEach` becomes for-of loop or `array.forEach`.
- `Array.slice(a)` or `Array.slice(a, 0)` becomes `Array.from(a)`.
- `Array.map` becomes `Array.from`
- `Array` copy + concatenation becomes Array literal + spread syntax.
- All other `Array.X(a, ...)` become `Array.prototype.X.call` or `Array.from(a).X(...)`

Differential Revision: https://phabricator.services.mozilla.com/D27802

--HG--
extra : moz-landing-system : lando
2019-04-17 19:03:17 +00:00