Commit Graph

54 Commits

Author SHA1 Message Date
Anup Kumar
4e1436bd05 Bug 1003204: Removed CommonUtils.exceptionStr() in toolkit/ r=gfritzsche 2015-12-18 04:05:00 +01:00
Dave Townsend
86f03db916 Bug 1229142: Link browser and toolkit test directory to the shared eslintrc files. r=Standard8
--HG--
extra : commitid : CKT2WDkxE4k
extra : rebase_source : 0be50c483317355b1e9af5985d53e85604748432
extra : histedit_source : 65d203f57ebd38b8c130e5db9aaa8ae3f507e7ac
2015-11-30 13:05:00 -08:00
Dave Townsend
265caf229e Bug 1229519: Fix crash manager to pass eslint checks. r=mak
--HG--
extra : commitid : 2Lm9e2zVu5g
extra : rebase_source : 3e1e564bfed49a13548af0f3bd0aa2cb72be64ed
extra : amend_source : dc45a48fe9f498f3c5476f45071eb6494018016e
2015-12-03 10:01:18 -08:00
Carsten "Tomcat" Book
08997000eb Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
e7ef778c9d Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
Backed out changeset cfc1820361f5 (bug 1202902)

--HG--
extra : rebase_source : 5d3db72337754bc7ab0ed0c30b2896100411ff92
2015-10-07 12:13:45 +02:00
Shu-yu Guo
d06b6030f6 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Benjamin Smedberg
3133303347 Bug 1199662 - Crash ping environment block is broken when any string field contains a quotation mark. Unescape INI fields properly using the library that already exists for the purpose. r=ted
--HG--
extra : commitid : 55V6027qEVE
extra : rebase_source : 700466ab6f872b049fae11c0ca3514def99dbd74
2015-08-28 12:53:43 -04:00
Benjamin Smedberg
a2306b9736 Bug 1121013 part C - report a new crash ping type on main-process crashes, and record submission rate/failure information in telemetry. Plugin/content crashes are already recorded via SUBPROCESS_ABNORMAL_ABORT and SUBPROCESS_CRASHES_WITH_DUMP and this patch leaves that unchanged. r=gfritzsche
--HG--
extra : rebase_source : 10df4948d9bd64197d652f84bdd02991353cf26b
2015-03-30 17:48:11 -04:00
Sebastian Hengst
394a2dd441 Bug 1143470 - Add BUG_COMPONENT to moz.build files in toolkit and xulrunner. r=gavin 2015-03-15 19:36:24 +01:00
David Major
cefaf7e2a9 Bug 1135543 - Part 4: Define DailyCrashesMeasurement6 containing main-crash-oom; r=bsmedberg
--HG--
extra : rebase_source : 8a3dadbf53b03d6a8170d38cb13b106c0637f15c
2015-03-14 18:59:21 +13:00
David Major
267318954e Bug 1135543 - Part 3: Create events file format crash.main.2 which contains metadata; r=bsmedberg
--HG--
extra : rebase_source : 26de3cac35f9e5a5398f912f36f3d3cc0b286806
2015-03-14 18:54:36 +13:00
David Major
5de2cde13f Bug 1135543 - Part 2 (no part 1): Add a |metadata| parameter to CrashManager.addCrash(); r=bsmedberg
--HG--
extra : rebase_source : a0a4c06fb530eebfdf690d170c819b67375bd5b7
2015-03-14 18:54:06 +13:00
Gregory Szorc
b931cfa945 NO BUG - Fix reStructuredText warnings
Sphinx has been complaining about a number of reStructuredText warnings
for a while. Fix all the ones in .rst files.

Not asking for review because this is docs only and changing .rst files
can't break anything important.

DONTBUILD (NPOTB)
2015-03-01 22:51:32 -08:00
Birunthan Mohanathas
95711085e5 Bug 1024672 - Part 6: Allow storing multiple crash classifications. r=bsmedberg 2014-10-16 16:14:16 +03:00
Andrew Halberstadt
d292ee73f1 Bug 1066735 - Remove root b2g and android specific xpcshell manifests, r=chmanchester 2014-10-07 18:18:28 -04:00
Shu-yu Guo
59ccd2fecb Bug 1001090 - Part 5: Fix errors in tests throughout the tree. (r=robcee,gavin) 2014-09-15 16:30:47 -07:00
Shu-yu Guo
15262d36a9 Bug 1001090 - Part 4: Fix errors in chrome code. (r=zombie,gavin,fitzgen,dcamp,bgrins,fabrice,gwagner,margaret,mrbkap,mak,njn,vicamo) 2014-09-15 16:30:46 -07:00
Birunthan Mohanathas
3dfe19eb74 Bug 1059390 - Part 5: Add and use CrashManager.generateSubmissionID(). r=gps 2014-09-02 10:02:40 -07:00
Birunthan Mohanathas
19f657d3d6 Bug 1024672 - Part 5: Allow classifications to be stored in crash metadata. r=gps 2014-09-02 09:55:16 -07:00
Birunthan Mohanathas
d0c5512276 Bug 1059940 - Part 1: Expose CrashStore.reset() to clear all data. r=bsmedberg 2014-08-29 13:39:01 -07:00
Birunthan Mohanathas
f102d8b356 Bug 1059859 - Fix race condition in CrashManager._getStore() resulting in multiple stores being created. r=gps 2014-08-29 13:38:57 -07:00
Birunthan Mohanathas
38c41f731b Bug 1059390 - Part 4: Fix crash submission event file handling and add test. r=bsmedberg
This also changes things to use a "sub-" prefix for the generated submission ID
in order to distinguish it from a local/remote crash ID.
2014-08-29 13:38:53 -07:00
Birunthan Mohanathas
924ea725cc Bug 1059390 - Part 3: Limit count only for new crash records in CrashStore._ensureCrashRecord. r=bsmedberg 2014-08-29 13:38:49 -07:00
Birunthan Mohanathas
c048f089d0 Bug 1059390 - Part 1: Allow remote Breakpad ID to be stored in crash metadata. r=gps 2014-08-28 21:03:02 -07:00
Birunthan Mohanathas
b86bfef458 Bug 1024672 - Part 3: Remove CrashManager.addSubmission in favor of CrashManager.addSubmission{Attempt,Result}. r=gps 2014-08-21 15:43:50 -07:00
Birunthan Mohanathas
0044622b7e Bug 1024672 - Part 2: Convert submission details stored in separate crash records to crash metadata. r=gps 2014-08-21 15:43:46 -07:00
Birunthan Mohanathas
389d895d4d Bug 1024672 - Part 1: Allow submission details to be stored in crash metadata. r=gps 2014-08-21 15:43:42 -07:00
Bill McCloskey
0f6b688b48 Bug 1046964 - Fix some JS warnings (r=ttaubert) 2014-08-19 17:27:58 -07:00
Drew Willcoxon
807f12f4d6 Bug 1009765 - Add GMP plugin crashes to FHR crash reporting (part 2: FHR, toolkit/components/crashes). r=gps 2014-08-08 15:41:07 -07:00
Birunthan Mohanathas
6619c1dadc Bug 1049257 - Fix typo in CrashManager.addCrash() in order to update the crash date of existing items. r=gps 2014-08-07 21:52:05 -07:00
Gregory Szorc
30f5396657 Bug 1045421 - Remove date time bomb from test_crash_manager.js, add logging; r=gfritzsche
There was a hard-coded date in test_crash_manager.js of around August 3,
2013. This meant that about a year later we would start to run into
boundary issues since we weren't wrapping Date.now() inside
CrashManager.jsm.

It turns out the actual value of DUMMY_DATE doesn't really matter. So,
the test has been changed to produce a value that is reasonably modern.

While I was debugging this, I noticed we're not getting logging in the
tests. So I added that.

--HG--
extra : rebase_source : 4e5534f5df70b01268790396481bdd3236dd8e8e
extra : amend_source : d73ea0a333fa9b0b9c65d890d6f34cb923861acd
2014-07-29 09:47:59 -07:00
Wes Kocher
e365871f17 Bug 1045419 - Disable test_crash_manager.js for failures on a CLOSED TREE r=me 2014-07-28 20:14:19 -07:00
Gregory Szorc
25170257c3 Bug 1033836 - Convert TESTING_JS_MODULES to moz.build; r=glandium
--HG--
extra : rebase_source : 1cd9e402c507260358af7a93c6fb2fc91c24994b
2014-07-02 16:43:41 -07:00
Steven MacLeod
eaaaed8472 Bug 994707 - Introduce crash submission events and handle them. r=bsmedberg
This introduces a new crash event type for submissions and handles
them in the Crash Manager. These crash submissions will also be counted
in FHR.

--HG--
extra : rebase_source : c37fc86cecc86aea0afdd8cfa7b31295aad3d6f8
2014-07-03 14:04:28 -04:00
Wes Kocher
5b3a2dbf16 Backed out 3 changesets (bug 994707) for Valgrind and XPCShell bustage on a CLOSED TREE
Backed out changeset 76555f34c210 (bug 994707)
Backed out changeset 3dd92fb7c846 (bug 994707)
Backed out changeset 802779efce2b (bug 994707)
2014-07-01 11:04:30 -07:00
Steven MacLeod
211efd020a Bug 994707 - Introduce crash submission events and handle them. r=bsmedberg
This introduces a new crash event type for submissions and handles
them in the Crash Manager. These crash submissions will also be counted
in FHR.

--HG--
extra : rebase_source : 41fb43f9588885033e49dccfaf9351ef805c476b
2014-07-01 12:52:23 -04:00
Drew Willcoxon
f1907fd96d Bug 983313 - Write crash events for plugin crashes and hangs (part 1: main changes). r=bsmedberg 2014-05-12 11:58:18 -07:00
David Rajchenbach-Teller
a3ad7bf035 Bug 961665 - Fix typo in CrashManager's use of OS.File. r=gps 2014-03-13 09:50:24 -04:00
Gregory Szorc
30f8839c06 Bug 875562 - Part 9: Change Health Report to pull from crashes manager; r=bsmedberg, r=rnewman
This patch changes Firefox Health Report to pull crash counts from the
newly-implemented crash manager. The crash manager is now the canonical
source of crash data, so all the code for reading crash dump files from
disk has been removed.

This regresses the collection capability of Firefox Health Report by
removing plugin crashes and hangs from the reported values. This
regression is intended to be temporary and a follow-up bug will be
created to add plugin process event recording to the crash events
system.

This regression has been justified because the old crash reporting
mechanism was severely flawed and wasn't sending accurate data (not all
crashes were being saved to dumps and some dumps would be deleted).

--HG--
extra : amend_source : d54bb3bf9f740508cb4eda286536ce16a4c3bee5
2014-01-30 16:48:52 -08:00
Wes Kocher
030d5126a7 Backed out changeset 21793ea94b09 (bug 875562) for ASAN xpcshell failures 2014-03-13 15:22:40 -07:00
Gregory Szorc
1e8ae344f7 Bug 875562 - Part 9: Change Health Report to pull from crashes manager; r=bsmedberg, r=rnewman
This patch changes Firefox Health Report to pull crash counts from the
newly-implemented crash manager. The crash manager is now the canonical
source of crash data, so all the code for reading crash dump files from
disk has been removed.

This regresses the collection capability of Firefox Health Report by
removing plugin crashes and hangs from the reported values. This
regression is intended to be temporary and a follow-up bug will be
created to add plugin process event recording to the crash events
system.

This regression has been justified because the old crash reporting
mechanism was severely flawed and wasn't sending accurate data (not all
crashes were being saved to dumps and some dumps would be deleted).

--HG--
extra : rebase_source : 7442a712d06b4d875010e78d4dd4f5cc179c8dfc
2014-01-30 16:48:52 -08:00
Ryan VanderMeulen
d2b4456c69 Backed out changesets c6ca1aa3887a, d741e117a033, 1fd26e822e73, and 720962c9f993 (bug 961665) for build bustage and xpcshell failures. 2014-03-13 10:32:57 -04:00
David Rajchenbach-Teller
6b10efa7e9 Bug 961665 - Fix typo in CrashManager's use of OS.File. r=gps 2014-03-13 09:50:24 -04:00
Gregory Szorc
2ebfe5bfc6 Bug 976241 - Create crash store directory; r=Yoric
--HG--
extra : rebase_source : f23aed8ade10dba5f75cc904deddacb0aad1ad4f
2014-03-04 16:21:11 -08:00
Gregory Szorc
4db4278111 NO BUG - Fix bustage in toolkit/components/crashes/tests/xpcshell/test_crash_manager.js; r=me 2014-02-14 14:53:47 -08:00
Gregory Szorc
7b9f6f570a Bug 972093 - Detect run_next_test() during add_task(); r=ted, rnewman
If an xpcshell test called run_next_test() from inside an add_task(),
bad things would happen. This patch detects that behavior and aborts the
test immediately with an actionable error message.

--HG--
extra : rebase_source : c5cf11070421b95a6fcf476d0a86289a3d0ba73a
extra : amend_source : cec6ad2a751bba01e7d4ecbff0735b39e3326efb
2014-02-12 16:47:29 -08:00
Gregory Szorc
738b579962 Bug 875562 - Part 7: Implement limits for stored crash data; r=Yoric
This patch institutes limits for how much crash data can be stored in
terms of maximum number of crash events per day. If more events than the
limit are encountered, we record that a high water mark has been
encountered and we silently discard the payload of future events.

We chose to not increment the version of the store payload because no
clients are actively saving this data yet, so it doesn't make sense to
incur a version bump.

--HG--
extra : rebase_source : 3d5d92668b38e8b9c3c45e1a61a3a172b576e0a5
extra : amend_source : 71fffa0724450c5fe13563d2539813e9a831b3de
2014-01-28 17:33:38 -08:00
Gregory Szorc
df0a8cce6d Bug 875562 - Part 6: Implement initial crash events; r=bsmedberg
Support for main process crashes, plugin crashes, and plugin hangs is
added to the crash manager. This includes a JS API for reporting them as
well as support for reading the event files.

There is still an issue of unbound growth on the store. This will be
addressed in a subsequent patch.

--HG--
extra : rebase_source : e714bf5f9c2fd9c50f2e40659c3b1a89591f3b1a
2014-01-28 15:46:03 -08:00
Gregory Szorc
3a291faf35 Bug 875562 - Part 5: Document crash events for initial implementation; r=bsmedberg
The initial implementation of this feature will write 3 distinct event
types and will only count occurrences of each. Future iterations of the
feature will capture more metadata, such as submission state and extra
crash annotations. These will not be included in this patch set.

DONTBUILD (NPOTB)

--HG--
extra : rebase_source : a1be4ceb6e06f2153d0927e50090c5f352b741d6
2014-01-28 12:00:10 -08:00