Previously, mozharness defined a separate action to collect build
metrics. This required the script and/or config to define that
action.
Metrics collection for CI is important. So it should be enabled by
default.
This commit changes the "build" action/method to always call the
metrics collection function after successful build. References to
the "generate-build-stats" action have been removed because it is
redundant.
A side-effect of this change is we may generate build metrics where
we weren't before. This could lead to e.g. duplicate entries in some
Perfherder series. Let's see what breaks ;)
MozReview-Commit-ID: 42UQI5YQTMC
--HG--
extra : rebase_source : 3377c70c833f44ef280a4f81f9ae4a78edcee9cf
This avoids using substring matching on labels, which is likely to lead to
sadness someday.
MozReview-Commit-ID: J1pFuP1U335
--HG--
extra : rebase_source : 0783ce1aef7297fdd73a9d4d05450a534857fdbd
In order to migrate from buildbot to taskcluster gradually, we read an
external json file to tells the percentage of jobs that must run in
Taskcluster.
MozReview-Commit-ID: K9KZMhe36Cu
--HG--
extra : rebase_source : 9619e5cdb010527538f03b3effe4756fc9574c4e
This patch affects the following linux64-qr test jobs (for both opt and debug):
- Stops running reftest-no-accel on central, since they don't seem to provide
much value over regular reftests.
- Starts running mochitest-gpu on central.
- Starts running crashtests, reftests, jsreftests, mochitest-gpu and
mochitest-webgl on mozilla-inbound and autoland (this matches the set of
tests on central).
- Promotes all the tests running on central/autoland/inbound to tier-1.
MozReview-Commit-ID: LgU4VgGz7S
In order to migrate from buildbot to taskcluster gradually, we read an
external json file to tells the percentage of jobs that must run in
Taskcluster.
MozReview-Commit-ID: JQhvsXKpcLz
--HG--
extra : rebase_source : 0c1a83b31831b788fb374adcb9fd181f97121239
The macosx64-opt build task executes through buildbot-bridge, and there
is a specific task in which artifacts are uploaded.
MozReview-Commit-ID: GTOXBwBdwfM
This is a more robust approach than using substring matching on task labels.
As an optimization, this simply avoids creating balrog tasks for unsigned beets
using only-for-attributes, rather than omitting them in a transform.
MozReview-Commit-ID: 8MNOxu0WgXo
--HG--
extra : rebase_source : 9e93a996241bcb0d345c18813919a41320e95651
This will fail until Bug 1265537 lands, which is what will switch windows to SIMPLE NAME package format.
MozReview-Commit-ID: J0zVLptvxNO
--HG--
extra : rebase_source : 6c388f24bce78ee6f6a8d7eb17cd6bce036b1d35
Because of bug 1338651, we need to stick to BBB macosx64 builds for now.
MozReview-Commit-ID: AwQc5r6ikUN
--HG--
extra : rebase_source : d5ee1605bf5ec70223e7676bd2d2fd760841d59a
The "generate-build-stats" mozharness action collects a bunch of build
system metrics, including build_resources.json, ctors count, and
installer size and reports them by writing special messages that
log parsers read.
Before this commit, this mozharness action occurred sometime after
"build." But relative ordering to other actions was not consistent
and appears to be significantly cargo culted.
4e61e69a383c (bug 1304508) changed the "check" mozharness action to
invoke `mach build check` instead of `make` directly. An unintended
consequence of this is that `mach build` replaced the
build_resources.json file from the build itself with one measuring
`make check`. This made the "build time summary" metric take a nose
dive.
This commit works around the issue introduced by 4e61e69a383c by
reordering the mozharness actions so "generate-build-stats" follows
immediately after the "build" action. Not only does it now occur
before the "check" action, but it also occurs before uploading and
other actions.
I'm not sure why "generate-build-stats" is its own action and not
part of "build" itself. As the diff shows, numerous instances of
"generate-build-stats" are commented out, which means we aren't
collecting metrics. "generate-build-stats" is also missing from a
handful of mozharness configs, including Windows Clang builds. I'm
not sure what the history is (it is likely varied and almost certainly
involves a fair amount of cargo culting), but I think it is a bug that
we aren't collecting build metrics for every build. I would like to
fix this. And moving "generate-build-stats" immediately after "build"
should make that transition easier.
MozReview-Commit-ID: 7jNTVWRvMnh
--HG--
extra : rebase_source : 0b5fd1f462caa5c283ba7e1b693fdc5b8b948add
