Commit Graph

13553 Commits

Author SHA1 Message Date
Daisuke Akatsuka
4f3436e304 Bug 1507126: Execute adb shell command to specified device. r=jdescottes
Depends on D14313

Differential Revision: https://phabricator.services.mozilla.com/D14708

--HG--
extra : moz-landing-system : lando
2018-12-18 01:44:15 +00:00
Julian Descottes
618278197a Bug 1508956 - Add test for unknown USB runtimes;r=daisuke,ladybenko,Ola
Depends on D14313

Differential Revision: https://phabricator.services.mozilla.com/D14318

--HG--
extra : moz-landing-system : lando
2018-12-19 18:07:52 +00:00
Julian Descottes
36c7065b18 Bug 1508956 - Display unknown runtimes in about:debugging;r=daisuke,ladybenko,Ola
Depends on D14310. This patch enables displaying devices on which the debuggable
runtime is not started yet. To test it, simply use an android phone with USB debugging enabled
but don't start Firefox yet. You should see the Unknown Runtime item in the sidebar.

Not that once you start Firefox on the device, you need to click refresh runtimes here to get
the sidebar to refresh (more on that in the last patch of the series).

Two things I am not completely happy with:
- calling this a runtime, when really it's just a device that has no runtime.
  but I don't want to start renaming all our state for that. Hope we can treat it as
  placeholder runtime, and forget about it.
- localization for the runtime item name can be done in many ways. Not using getString
  at all makes things really complicated, but I'm open to suggestions if you have any

Differential Revision: https://phabricator.services.mozilla.com/D14313

--HG--
extra : moz-landing-system : lando
2018-12-19 18:08:22 +00:00
Julian Descottes
c34f54849f Bug 1508956 - Migrate sidebar_usb_runtime to use head_mocks;r=daisuke
Depends on D14309. Relying on head_mocks will make it easier to
update the mocks when we start calling isUnknown() on our USB runtimes.

Differential Revision: https://phabricator.services.mozilla.com/D14310

--HG--
extra : moz-landing-system : lando
2018-12-19 18:07:41 +00:00
Julian Descottes
eff4be5306 Bug 1508956 - Add unknown runtime entries for devices with no runtime detected;r=daisuke
Depends on D14307. Introduce a placeholder UnknownAdbRuntime extending AdbRuntime.
AdbRuntime implements isUnknown(). This method is used to filter out the unknown runtimes in
webide and about:debugging. (filter will be removed in about:debugging in a patch in the same
queue)

Differential Revision: https://phabricator.services.mozilla.com/D14309

--HG--
extra : moz-landing-system : lando
2018-12-19 18:07:37 +00:00
Julian Descottes
3c74b5f444 Bug 1508956 - Refactor AdbDevice to have an async initialize step;r=daisuke
The model information is duplicated between adb runtime and adb device.
This allows to keep the information in a single place.

Differential Revision: https://phabricator.services.mozilla.com/D14307

--HG--
extra : moz-landing-system : lando
2018-12-19 18:06:28 +00:00
Julian Descottes
4588523316 Bug 1500393 - Add test for serviceworker push service in new aboutdebugging;r=ladybenko,Ola
Depends on D14590

Differential Revision: https://phabricator.services.mozilla.com/D14591

--HG--
extra : moz-landing-system : lando
2018-12-19 17:56:03 +00:00
Julian Descottes
a981f8eaf3 Bug 1500393 - Cleanup existing serviceworker test;r=ladybenko,Ola
Depends on D14589. I did a first cleanup when migrating the first
service worker test, but I think we can go a bit further, and this is not
strictly related to the new test I am about to add.

Differential Revision: https://phabricator.services.mozilla.com/D14590

--HG--
extra : moz-landing-system : lando
2018-12-19 17:55:53 +00:00
Julian Descottes
b87c7d40b1 Bug 1500393 - Add support for push service URL in new about:debugging;r=ladybenko,Ola
Looks like we missed this feature when doing the initial service worker support
so implementing here. UI-wise, I reused the same wording/positioning etc as in the current
about:debugging.

Note that this is another spot that uses client.request, so we will need to clean this up
when we finally add a front to represent service worker registrations.

Differential Revision: https://phabricator.services.mozilla.com/D14589

--HG--
extra : moz-landing-system : lando
2018-12-19 17:55:51 +00:00
Florens Verschelde
77cbc33fd2 Bug 1513501 - Use open-inspector.svg in Rules view for sharper rendering; r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D14293

--HG--
extra : moz-landing-system : lando
2018-12-19 12:02:31 +00:00
Alexandre Poirot
5cddbab43d Bug 1513565 - Remove now-unused form argument from Target. r=yulia
Depends on D14280

Differential Revision: https://phabricator.services.mozilla.com/D14765

--HG--
extra : moz-landing-system : lando
2018-12-18 23:36:06 +00:00
Alexandre Poirot
21e7072949 Bug 1513565 - Convert the last manually instantiated fronts to target.getFront. r=yulia
Depends on D14279

Differential Revision: https://phabricator.services.mozilla.com/D14280

--HG--
extra : moz-landing-system : lando
2018-12-18 23:35:59 +00:00
Alexandre Poirot
ac13c87f42 Bug 1513565 - Get rid of all target.form usages. r=yulia,nchevobbe
Depends on D14278

Differential Revision: https://phabricator.services.mozilla.com/D14279

--HG--
extra : moz-landing-system : lando
2018-12-18 23:35:57 +00:00
Alexandre Poirot
bd9855b903 Bug 1513565 - Always use Target's WebConsoleClient instead of trying to instantiate it manually. r=yulia,nchevobbe
This will help getting rid of another usage of Target.form.
And also helps instantiating only one WebConsole client.
Once WebConsole becomes a front, we can replace all the target.activeTab
to target.getFront("console").

Differential Revision: https://phabricator.services.mozilla.com/D14278

--HG--
extra : moz-landing-system : lando
2018-12-18 23:35:55 +00:00
Alexandre Poirot
690a921d87 Bug 1514819 - Convert RootFront.getWindow to return a front instead of a form. r=yulia
This method is only used by target-from-url, it allows to return
a target got one precise top level window and instead of the whole main process.

It looks like it was the very last non-front/still-form target codepath.

Differential Revision: https://phabricator.services.mozilla.com/D14841

--HG--
extra : moz-landing-system : lando
2018-12-18 08:54:01 +00:00
Bogdan Tara
91d742d138 Merge inbound to mozilla-central. a=merge 2018-12-19 06:50:57 +02:00
Zibi Braniecki
d59b6ed7ff Bug 1513958 - Fix aboutdebugging.noftl to work with Fluent 0.10. r=jaws
Depends on D14612

Differential Revision: https://phabricator.services.mozilla.com/D14904

--HG--
extra : moz-landing-system : lando
2018-12-18 23:04:42 +00:00
Boris Chiou
c35f47093e Bug 1322780 - Part 2: Support unprefixed min-content and max-content. r=mats,emilio
Support unprefixed min-content and max-content and treat the prefixed
version as aliases for
1. width, min-width, max-width if inline-axis is horizontal, and
2. height, min-height, max-height if inline-axis is vertical, and
3. inline-size, min-inline-size, max-inline-size, and
4. flex-basis.

Besides, update the test cases to use unprefixed max-content and
min-content.

Depends on D7535

Differential Revision: https://phabricator.services.mozilla.com/D7536

--HG--
extra : moz-landing-system : lando
2018-12-18 18:47:37 +00:00
Florens Verschelde
7c5190820e Bug 1513530 - Improve doorhanger menu icons alignment; r=gl
Differential Revision: https://phabricator.services.mozilla.com/D14422

--HG--
extra : moz-landing-system : lando
2018-12-18 19:58:39 +00:00
Alexandre Poirot
87bb1e2701 Bug 1513028 - Throw exception with stack and message when a module doesn't exists. r=jdescottes
loadSubScript throws a string, without any stack/location.
Consider all string exceptions as coming from loadSubScript and re-throw a real error
object, coming with the stack of the require call.
Also handle wrong require path with a more explicit error message.

Differential Revision: https://phabricator.services.mozilla.com/D14139

--HG--
extra : moz-landing-system : lando
2018-12-18 13:35:42 +00:00
Brindusan Cristian
228a150262 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-12-18 11:52:48 +02:00
yulia
4b0a97499c Bug 1508660 - migrate getOrCreateHighlighterByType to inspectorFront; r=ochameau
Depends on D12439

Differential Revision: https://phabricator.services.mozilla.com/D12440

--HG--
extra : moz-landing-system : lando
2018-12-18 08:45:30 +00:00
yulia
edb57234af Bug 1508660 - make storage front and changes front async; r=ochameau
Depends on D13110

Differential Revision: https://phabricator.services.mozilla.com/D13336

--HG--
extra : moz-landing-system : lando
2018-12-18 08:33:11 +00:00
yulia
cda3c1b7bc Bug 1508660 - introduce getCachedFront; r=ochameau
Depends on D12439

Differential Revision: https://phabricator.services.mozilla.com/D13110

--HG--
extra : moz-landing-system : lando
2018-12-18 08:32:33 +00:00
yulia
c8a2ddf91b Bug 1508660 - migrate getKnownHighlighter to inspectorFront; r=ochameau
Depends on D12438

Differential Revision: https://phabricator.services.mozilla.com/D12439

--HG--
extra : moz-landing-system : lando
2018-12-18 08:45:28 +00:00
yulia
0b73b92f31 Bug 1508660 - migrate getHighlighterByType to inspector front; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D12438

--HG--
extra : moz-landing-system : lando
2018-12-18 08:31:43 +00:00
Julian Descottes
e046e9a177 Bug 1502346 - Retrieve ::slotted rules in InspectorUtils getCSSStyleRules;r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D14759

--HG--
extra : moz-landing-system : lando
2018-12-17 21:33:40 +00:00
Logan Smyth
f6b29a07c4 Bug 1510463 - Allow adding breakpoints without pausing. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D13737

--HG--
extra : moz-landing-system : lando
2018-12-17 19:20:05 +00:00
Tom Schuster
be525ca8b0 Bug 1462741 - Update tests. r=jorendorff
Depends on D14704

Differential Revision: https://phabricator.services.mozilla.com/D14705

--HG--
extra : moz-landing-system : lando
2018-12-17 18:40:13 +00:00
Razvan Caliman
081ab9f961 Bug 1512634 - Ensure cssProperties validates in lowercase. r=pbro
[Bug 1512634](https://bugzilla.mozilla.org/show_bug.cgi?id=1512634) occurred because the Rule view marks CSS properties as overriden when they are not lowercase. This happens because `ElementStyle.markOverridden()` relies on computed properties. They get built using `CSSProperties.getSubproperties()`. If the input to that method is not lowercase, it doesn't match properties from the CSS database and returns an empty array. This has a side-effect of marking the property as overriden.

In this patch we allow users to type property names in any case, but we validate the lowercase version of them.

Differential Revision: https://phabricator.services.mozilla.com/D14568

--HG--
extra : moz-landing-system : lando
2018-12-17 16:26:18 +00:00
Micah Tigley
a5beaa5c57 Bug 1508613 - Transform the flex item sizing outline to match the main/cross direction of the item on the page. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D14169

--HG--
extra : moz-landing-system : lando
2018-12-17 09:21:43 +00:00
Ciure Andrei
2540abfecb Backed out 14 changesets (bug 1508660, bug 1508656, bug 1504185) for browser_target_cached-front.js perma failures CLOSED TREE
Backed out changeset 08e5ae4312b3 (bug 1508660)
Backed out changeset 01b687bb0b75 (bug 1504185)
Backed out changeset 140374b098aa (bug 1504185)
Backed out changeset caafdc0ea4c7 (bug 1508656)
Backed out changeset 8b98b777aec2 (bug 1508656)
Backed out changeset f1905a2f9b6c (bug 1508656)
Backed out changeset 8b01632f9e3d (bug 1508656)
Backed out changeset eb4c893d451e (bug 1508656)
Backed out changeset 70db61618160 (bug 1508656)
Backed out changeset dff79b73c7fe (bug 1508660)
Backed out changeset b3518d5285be (bug 1508660)
Backed out changeset 94a957b9ba90 (bug 1508660)
Backed out changeset 773938f18269 (bug 1508660)
Backed out changeset 4eca8fce0a47 (bug 1508660)
2018-12-17 17:15:23 +02:00
Nicolas Chevobbe
eeb8faea6e Bug 1496044 - Fix __proto__ handling in ObjectInspector; r=Oriol.
This patch only remove the extends calls that
were used to transpile object spread syntax.
A test is added to ensure we don't regress
this in the future.

Differential Revision: https://phabricator.services.mozilla.com/D14233

--HG--
extra : moz-landing-system : lando
2018-12-17 13:46:50 +00:00
Yulia Startsev
020c286b42 Bug 1508660 - Fix eslint issue from rebase r=ochameau CLOSED TREE 2018-12-17 05:55:00 +02:00
yulia
f14ff81dbc bug 1504185 - remove highlighterUtils documentation from devtools; r=ochameau
Depends on D11084

Differential Revision: https://phabricator.services.mozilla.com/D11085

--HG--
extra : moz-landing-system : lando
2018-12-17 12:23:31 +00:00
yulia
4f24c22449 bug 1504185 - remove highlighterUtils from devtools; r=ochameau
Depends on D11083

Differential Revision: https://phabricator.services.mozilla.com/D11084

--HG--
extra : moz-landing-system : lando
2018-12-17 12:29:26 +00:00
yulia
1038ce7497 Bug 1508656 - fix failing test browser_inspector_switch-to-inspector-on-pick; r=ochameau
Depends on D12290

Differential Revision: https://phabricator.services.mozilla.com/D12291

--HG--
extra : moz-landing-system : lando
2018-12-17 12:29:30 +00:00
yulia
3ff8185945 Bug 1508656 - migrate picker-node-hovered to nodePicker; r=ochameau
Depends on D12290

Differential Revision: https://phabricator.services.mozilla.com/D12738

--HG--
extra : moz-landing-system : lando
2018-12-17 12:18:45 +00:00
yulia
0f2c847896 Bug 1508656 - migrate cancel picker to nodePicker; r=ochameau
Depends on D12126

Differential Revision: https://phabricator.services.mozilla.com/D12290

--HG--
extra : moz-landing-system : lando
2018-12-17 12:51:35 +00:00
yulia
bd3436032f Bug 1508656- migrate togglePicker to nodePicker; r=ochameau
Depends on D12119

Differential Revision: https://phabricator.services.mozilla.com/D12122

--HG--
extra : moz-landing-system : lando
2018-12-17 12:51:31 +00:00
yulia
c7cea4d5d9 Bug 1508656 - migrate startPicker and stopPicker to nodePicker; r=ochameau
Depends on D12122

Differential Revision: https://phabricator.services.mozilla.com/D12126

--HG--
extra : moz-landing-system : lando
2018-12-17 12:51:33 +00:00
yulia
9f95f0cc50 bug 1508656 - migrate node picking methods to NodePicker module, and use it through the inspector; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D12119

--HG--
extra : moz-landing-system : lando
2018-12-17 12:51:10 +00:00
yulia
7a50140d2e Bug 1508660 - migrate getOrCreateHighlighterByType to inspectorFront; r=ochameau
Depends on D12439

Differential Revision: https://phabricator.services.mozilla.com/D12440

--HG--
extra : moz-landing-system : lando
2018-12-17 12:29:39 +00:00
yulia
ff201583ca Bug 1508660 - make storage front and changes front async; r=ochameau
Depends on D13110

Differential Revision: https://phabricator.services.mozilla.com/D13336

--HG--
extra : moz-landing-system : lando
2018-12-17 12:29:52 +00:00
yulia
26f279b0fb Bug 1508660 - introduce getCachedFront; r=ochameau
Depends on D12439

Differential Revision: https://phabricator.services.mozilla.com/D13110

--HG--
extra : moz-landing-system : lando
2018-12-17 13:23:29 +00:00
yulia
0913e97c35 Bug 1508660 - migrate getKnownHighlighter to inspectorFront; r=ochameau
Depends on D12438

Differential Revision: https://phabricator.services.mozilla.com/D12439

--HG--
extra : moz-landing-system : lando
2018-12-17 12:29:37 +00:00
yulia
cb4645ae90 Bug 1508660 - migrate getHighlighterByType to inspector front; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D12438

--HG--
extra : moz-landing-system : lando
2018-12-17 12:07:03 +00:00
Alexandre Poirot
9d435e1006 Bug 1508285 - Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form. r=yulia,jdescottes
MozReview-Commit-ID: 4CMHJ3tV7Rc

Depends on D14174

Differential Revision: https://phabricator.services.mozilla.com/D14175

--HG--
extra : moz-landing-system : lando
2018-12-17 11:56:30 +00:00
Alexandre Poirot
0d4cf81b11 Bug 1508285 - Use RootFront.rootForm instead of listTabs to fetch global actors. r=yulia
MozReview-Commit-ID: Ed5SyZbB0kq

Depends on D14173

Differential Revision: https://phabricator.services.mozilla.com/D14174

--HG--
extra : moz-landing-system : lando
2018-12-17 11:56:28 +00:00
Alexandre Poirot
c3d53c83bb Bug 1508285 - Refactor RootFront.getTab to return BrowsingContextTargetFront instead of JSON form. r=yulia
MozReview-Commit-ID: 6TOInM5BmYe

Differential Revision: https://phabricator.services.mozilla.com/D14173

--HG--
extra : moz-landing-system : lando
2018-12-17 11:56:26 +00:00