Commit Graph

64231 Commits

Author SHA1 Message Date
Mats Palmgren
4fc82257aa Bug 1460158 - Ignore non-primary child frames when searching for the main <summary> frame. r=xidorn 2018-05-17 17:30:34 +02:00
Botond Ballo
9faccb4911 Bug 1462177 - Do not condition dumping of inactive layer trees on MOZ_DUMP_PAINTING. r=mstange
MozReview-Commit-ID: t38JkoVfQl

--HG--
extra : rebase_source : 37f9f9893519ccc5a59d5f2ce2c4409aca89ed7a
2018-05-16 19:02:27 -04:00
Kartikaya Gupta
f70c1bbb80 Bug 1461946 - Remove more unused code. r=mattwoodrow
MozReview-Commit-ID: Ji5L1Ce2utN

--HG--
extra : rebase_source : 31d1c82b51ecadeceb9e3974837458521882d397
2018-05-16 14:58:56 -04:00
Kartikaya Gupta
a251efe15a Bug 1461946 - Remove unused function and parameter. r=mattwoodrow
MozReview-Commit-ID: CJ9ObpuRJCD

--HG--
extra : rebase_source : d8014372b7c6c17f7a34c6dc50b8df1a4a443460
2018-05-16 08:32:18 -04:00
Botond Ballo
d3215239ec Bug 1459890 - Do not clip mask for clip path to bbox of clipped content. r=mstange
MozReview-Commit-ID: 9yZ1ziiDAKa

--HG--
extra : rebase_source : 945b2048b31843c27cd21c19374cb7f61ea62be5
2018-05-11 18:55:30 -04:00
Ciure Andrei
3b611bc04f Backed out changeset 51cd668c0e87 (bug 1459890) dev request a=backout CLOSED TREE 2018-05-17 01:29:54 +03:00
Botond Ballo
c44bf295e5 Bug 1459890 - Do not clip mask for clip path to bbox of clipped content. r=mstange
MozReview-Commit-ID: 9yZ1ziiDAKa

--HG--
extra : rebase_source : 59ef1bc77e869a1b157f2ddb79a3c3bf674bb9a9
2018-05-11 18:55:30 -04:00
Matt Woodrow
6d94d6c09f Bug 1459997 - Add much more rigorous assertions for retained-dl assumptions. r=miko
This adds an assertion checking for duplicate items whenever we create an item, and when we merge an item into the final list.

I had to disable tracking for the anonymous inner list for nsDisplayPerspective and nsDisplayTransform (and manually forward RemoveFrame to them), as well as skipping the assertion for multi-page (since we can end up duplicating wrap lists, but isn't a problem, since we don't retain these).

MozReview-Commit-ID: 4n6rx9bQNan

--HG--
extra : source : ff93cd94b7c548ef57fa13b7eaf85992a0a60587
2018-05-01 11:56:40 -04:00
Brad Werth
5c9353c14c Bug 1457532 Part 2: Change ImageLoader::AssociateRequestToFrame to kickoff decode for images that block onload. r=tnikkel
MozReview-Commit-ID: DpBqTzMLQXo

--HG--
extra : rebase_source : 521ee05ee20db9f88d68bca898f0b213f94c2e72
2018-05-08 14:13:56 -07:00
Brad Werth
ada534c10a Bug 1457532 Part 1: Narrow ImageLoader::OnLoadComplete to only unblock onload in response to an error status on the image request. r=tnikkel
MozReview-Commit-ID: 929PTrT9iP1

--HG--
extra : rebase_source : 062efe4ab3aae5bc85ae696d85ab1cc4081a13e2
2018-04-27 12:00:35 -07:00
Matt Woodrow
b4687fa515 Bug 1460526 - Don't attempt to do a partial rebuild when a sublist DAG gets too complex, always rebuild the whole display list. r=miko
MozReview-Commit-ID: 5u3sBSepgJa

--HG--
extra : rebase_source : f08034d384cac0353017ff6dd6fe4f152d77d48d
extra : source : 21ab7bb3b993f2b2778f9dde10ff16c3c20f320f
2018-05-15 14:21:05 +12:00
Xidorn Quan
5896b33074 Bug 1461933 - Remove ServoBindings.h from ComputedStyleInline.h. r=emilio
For doing this, ServoComputedData is split into separate files, so that
files don't need to include ServoBindings.h just for accessing style
structs from ComputedStyles.

MozReview-Commit-ID: DPAd7PUUCl9

--HG--
extra : rebase_source : 7d6f739b7fb58a46e1624ba62e717412057ea9c1
2018-05-16 15:35:59 +10:00
Xidorn Quan
d9091cf557 Bug 1461940 - Rename two GetImageRequest() methods to ImageRequest(). r=emilio
MozReview-Commit-ID: 3eA86IOSLta

--HG--
extra : rebase_source : 3ec406a9b14b394abb42cc6324d19e093fd991f8
2018-05-16 22:28:50 +10:00
Matt Woodrow
5412f4e50b Bug 1461812 - Make sure we fully cleanup any partially constructed display lists when returning a failure from AttemptPartialUpdate. r=miko
MozReview-Commit-ID: DJBG6UFcoyR

--HG--
extra : rebase_source : 38e33ad785556b92b8058f00a85d48c27fb4d2e3
2018-05-16 12:55:08 +12:00
Xidorn Quan
07df897bae Bug 1461858 part 3 - Have from_image_request reuse ImageValue from image request directly. r=emilio
And also remove ComputedImageUrl::from_url_value_data.

MozReview-Commit-ID: 5zifQlU7tOz

--HG--
extra : rebase_source : 23631ad2e9144cf30951a3d07421a8e5ae0ba8ec
2018-05-16 14:01:25 +10:00
Margareta Eliza Balazs
d4b9e50875 Merge inbound to mozilla-central. a=merge 2018-05-16 13:00:51 +03:00
Andreea Pavel
9badaa53d2 Backed out changeset ff93cd94b7c5 (bug 1459997) for assertion failures at builds/worker/workspace/build/src/layout/painting/nsDisplayList.cpp:141 on a CLOSED TREE 2018-05-16 09:48:56 +03:00
Matt Woodrow
33d829994f Bug 1460491 - Part 2: Only recompute visibility for items if they are newly added to this layer, or intersect one that changed. r=jnicol
MozReview-Commit-ID: EAgvVQGsSPE

--HG--
extra : rebase_source : 44bc132a95d6d1b7e9cc3c22adcd4166a099237c
2018-05-16 16:02:37 +12:00
Matt Woodrow
0d65266918 Bug 1460491 - Part 1: Split nsDisplayItem::mVisibleRect into two members, one for each stated purpose. Gets rid of the save/restore since we no longer modify the building rect. r=jnicol
MozReview-Commit-ID: 5wcsSoZRN44

--HG--
extra : rebase_source : 1bf7d655b048a972e392514542aee171e20afe82
2018-05-16 15:56:32 +12:00
Hiroyuki Ikezoe
c3b289216c Bug 1460389 - Reftests for opacity and transform animations that are sent to the compositor in their delay phase. r=birtles
Both tests fail on WebRender without the fix in this patch series.

In the delay phase, those animations should be painted using non-animated
value (i.e. opacity:0 or translateX(100px)), but on WebRender they were painted
using opacity: 1 or identity transform.

MozReview-Commit-ID: DOHopfleWB0

--HG--
extra : rebase_source : 1075557f04d4ae1ce049e2c4513b00287ee9d4be
2018-05-15 09:08:49 +09:00
Hiroyuki Ikezoe
ea397e2c09 Bug 1460389 - Use non-animated (static) value if the animation is in not in-effect. r=birtles,kats
MozReview-Commit-ID: 87YgNy0RkKt

--HG--
extra : rebase_source : ac77b639a558197082f4ac52c02a9988bb2a9194
2018-05-15 09:02:38 +09:00
arthur.iakab
5a50fe880e Backed out changeset 21ab7bb3b993 (bug 1460526) for failing reftest on worker/workspace/build/src/layout/painting/RetainedDisplayListBuilder 2018-05-16 04:51:23 +03:00
Matt Woodrow
840b789b4b Bug 1459997 - Add much more rigorous assertions for retained-dl assumptions. r=miko
This adds an assertion checking for duplicate items whenever we create an item, and when we merge an item into the final list.

I had to disable tracking for the anonymous inner list for nsDisplayPerspective and nsDisplayTransform (and manually forward RemoveFrame to them), as well as skipping the assertion for multi-page (since we can end up duplicating wrap lists, but isn't a problem, since we don't retain these).

MozReview-Commit-ID: 4n6rx9bQNan

--HG--
extra : rebase_source : 49da303965d63258f4c6023a0b09ef0de7553724
2018-05-01 11:56:40 -04:00
Matt Woodrow
4216a1235a Bug 1460526 - Don't attempt to do a partial rebuild when a sublist DAG gets too complex, always rebuild the whole display list. r=miko
MozReview-Commit-ID: 5u3sBSepgJa

--HG--
extra : rebase_source : 860e147fdc463fec8ddb6c6d08cb86f1873a6326
2018-05-15 14:21:05 +12:00
Dorel Luca
7285fe0e8b Merge mozilla-central to autoland
--HG--
extra : rebase_source : 28cf949fe5cbd372058adac2d3a9d6e66902e6e3
2018-05-16 00:58:05 +03:00
Dorel Luca
0d2ff9e60d Merge mozilla-inbound to mozilla-central. a=merge 2018-05-16 00:54:22 +03:00
Emilio Cobos Álvarez
cb56e2c9f3 Bug 1459529: Remove UPDATE_STYLE. r=heycam
Now that BeginUpdate is useless for the UPDATE_STYLE case, we don't need the
update mechanism at all. Just ensure that ApplicableStylesChanged is called on
the pres shell via the relevant RuleChanged, etc. notifications.

There's a big hidden gotcha here. nsIDocument::BeginUpdate does put a script
blocker on the stack for these updates. However it's not needed, since no script
can run during these notifications (only the stylesheet events we post for
devtools, but those use AsyncEventDispatcher and PostDOMEvents, so they don't
try to run immediately).

nsIDocument::BeginUpdate also does XBL binding attached queue stuff, but we
can't change bindings during these notifications anyway, so it also doesn't
matter.

MozReview-Commit-ID: HJvK6zQfloh
2018-05-15 18:44:29 +02:00
Emilio Cobos Álvarez
6380ec638d Bug 1459529: Remove PresShell::BeginUpdate. r=heycam
It's useless after the last patch.

MozReview-Commit-ID: LdljMfnMjTy
2018-05-15 18:44:27 +02:00
Emilio Cobos Álvarez
00ee40fe4c Bug 1459529: Remove ServoStyleSet::{Begin,End}Update. r=heycam
They're empty, and make PresShell::BeginUpdate useless. Now we don't have
document observers that listen for these anymore.

MozReview-Commit-ID: GpDDNonFUFC
2018-05-15 18:44:26 +02:00
Emilio Cobos Álvarez
2054320f28 Bug 1459529: Make sheets be associated to a shadow root too potentially. r=bz
MozReview-Commit-ID: Cd8xJuLRY5w
2018-05-15 18:44:25 +02:00
Matt Woodrow
d6cb6ead56 Bug 1371668 - Don't attempt a catch up paint from FinishedWaitingForTransaction, wait until the next vsync. r=bas
MozReview-Commit-ID: ARDOwyBgiAm

--HG--
extra : rebase_source : 7ff89dd80f19a1e8b114c5fff16d85346aba2a21
2018-05-11 10:39:40 +12:00
Matt Woodrow
d7cebc698d Bug 1461231 - Don't omit deleted items when constructing the DAG, since we need to record that we made a modification during MergeDisplayLists. r=miko
We can unconditionally delete the item though, and just put a placeholder entry into the DAG.

MozReview-Commit-ID: 7a2UnaByIZu

--HG--
extra : rebase_source : f9cf83f09c1a6b9b23f469f7d3ab3a67f99f4018
2018-05-15 14:20:59 +12:00
Emilio Cobos Álvarez
a6a7ba02de Bug 1461288: Distinguish between specified and computed URLs. r=xidorn
This is needed to serialize computed URLs correctly from getComputedStyle.

MozReview-Commit-ID: 9wakhqNrszb

--HG--
extra : rebase_source : 7d120ac0917a5e13de4e52b7dfa0d784495fd8f7
2018-05-14 12:29:40 +02:00
Emilio Cobos Álvarez
bdc9e3e0db Bug 1414303: Make nsLayoutUtils::CompareTreePosition handle Shadow DOM in a sensible way. r=xidorn
We probably need more fixes for counters and Shadow DOM. The spec only mentions
"document order", and this is the most reasonable thing to do accounting for
shadow DOM in that regard...

This ensures a reasonable behavior for all callers which pretty much expect
otherwise for all children to be connected.

MozReview-Commit-ID: YEQIKdjRTK

--HG--
extra : rebase_source : 9b31f5d00d270cf21476776144d62350b5453f99
2018-05-14 16:34:45 +02:00
Matt Woodrow
085d0bbe3b Bug 1459441 - Make sure we build the full display list when we have blend containers in order to get the correct sorting for them. r=mstange
MozReview-Commit-ID: ECTU7enMb1r

--HG--
extra : rebase_source : 70f1b6187c152e770c4e19539645174c62198dc0
2018-05-10 11:39:12 +12:00
Cameron McCormack
624847ad88 Bug 1461517 - Fix clip-path test misspelling. r=longsonr
MozReview-Commit-ID: GwalUzcFOVc

--HG--
extra : amend_source : c01006afaa3208fb2a125cc43584eb2f9660d404
2018-05-15 09:42:07 +10:00
Narcis Beleuzu
25e3477b34 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-05-15 00:39:41 +03:00
Narcis Beleuzu
932adad93d Merge inbound to mozilla-central. a=merge 2018-05-15 00:36:35 +03:00
Adrian Wielgosik
c501e3beb0 Bug 1460940 - Clean up most remaining C++-side uses of nsIDOMDocument. r=bz
MozReview-Commit-ID: LKRnyDPNlle

--HG--
extra : rebase_source : a48b7c72a0f7ede38c91149a04d5de53987736f1
2018-05-11 19:46:15 +02:00
Adrian Wielgosik
f1457c6874 Bug 1460940 - Remove nsIDOMDocument uses in layout/. r=bz
MozReview-Commit-ID: KixJ5edlCjl

--HG--
extra : rebase_source : 677049bc7eb131dc86ed468eb8a6b06085f2c17d
2018-05-11 19:46:15 +02:00
Kristen Wright
5b0c2d18cb Bug 1460682 - nsSelectionStyle::mUnderlineStyle should be compared against NS_STYLE_TEXT_DECORATION_STYLE_NONE r=dbaron
Removed comparison to NS_STYLE_BORDER_STYLE_NONE and replaced with NS_STYLE_TEXT_DECORATION_STYLE_NONE

--HG--
extra : rebase_source : 559d47c0379229c169c5da75d38db6850ff3d60b
2018-05-10 10:55:47 -07:00
bobslept
705b29c214 Bug 1459111 - Rename ServoCSSParsingEnvironment to ParsingEnvironment. r=emilio
MozReview-Commit-ID: Jl5aoarH0aU
2018-05-14 20:20:20 +02:00
Margareta Eliza Balazs
2b9779c593 Merge inbound to mozilla-central. a=merge 2018-05-14 19:44:11 +03:00
Kartikaya Gupta
849bc9d409 Bug 1437036 - Stop the reftest harness from waiting for MozAfterPaint during infinite/superlong animations. r=hiro
These tests rely on an optimization within Gecko where it stops firing
MozAfterPaint events if there was no visible change to the generated
layers. This allows the reftest harness to exit the
waiting-for-MozAfterPaint loop and proceed with the test. However, with
webrender, this optimization does not exist and so the loop never exits.
In order to solve this problem, this patch adds an explicit mechanism to
exit the loop by means of a class attribute on the root element of the
test page.

MozReview-Commit-ID: 17ta5kLPDr9

--HG--
extra : rebase_source : 96ea462274724c6c65f1186f473bc1767253fd6b
2018-05-14 08:53:52 -04:00
Robert Longson
1baf4cf80c Bug 1422226 - Don't build display lists for NONDISPLAY content. r=jwatt 2018-05-13 19:16:26 +01:00
Bas Schouten
bbc1a8c2c3 Bug 1460624: Switch FIFO buffer to use stl::deque instead of stl::list. r=mattwoodrow
MozReview-Commit-ID: 3oeH9WyRKBp
2018-05-12 22:21:38 +02:00
Brindusan Cristian
6c56b182d4 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-05-12 12:51:43 +03:00
Brindusan Cristian
1df25b391a Merge inbound to mozilla-central. a=merge 2018-05-12 12:47:14 +03:00
Emilio Cobos Álvarez
5aab8db970 Bug 1408301: Remove getPropertyCSSValue. r=bz
It's been removed for a while on Nightly without any known regressions. This
gives us a full beta cycle of telemetry and two nightly cycles without the API
before shipping.

This only removes the API, followup work will replace serialization by Servo's,
and remove the remaining DOM interfaces.

MozReview-Commit-ID: 2m1taYg5xEr
2018-05-12 11:23:47 +02:00
Jonathan Watt
4753528362 Bug 1447039 - Stop using getPropertyCSSValue in test files. r=emilio
MozReview-Commit-ID: GjsNPBZmje0
2018-05-12 11:23:30 +02:00