Commit Graph

12796 Commits

Author SHA1 Message Date
Gurzau Raul
9470d77271 Backed out changeset a396ec8f44fd (bug 1577439) for failing valgrind-test on a CLOSED TREE. 2019-09-07 19:03:27 +03:00
Emilio Cobos Álvarez
d748b6062a Bug 1577439 - Shutdown Servo's thread-pool in leak-checking builds, leak the atom table elsewhere. r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D44217

--HG--
extra : moz-landing-system : lando
2019-09-05 19:18:27 +00:00
Emilio Cobos Álvarez
d5bc03b6f0 Bug 1578295 - Use cbindgen for counters. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D44403

--HG--
extra : moz-landing-system : lando
2019-09-02 23:11:26 +00:00
Emilio Cobos Álvarez
a8acf7d61d No bug - Add a comment about a Send bound that may look confusing.
MANUAL PUSH: comment only, no bug
2019-09-02 13:53:55 +02:00
Razvan Maries
80cfb7b1f5 Backed out changeset 42ebd8a50978 (bug 1577439) for causing perma leakcheck | tab process: negative leaks caught. 2019-09-01 03:41:33 +03:00
Emilio Cobos Álvarez
5ba33267fa Bug 1577439 - Shutdown Servo's thread-pool in leak-checking builds, leak the atom table elsewhere. r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D44217

--HG--
extra : moz-landing-system : lando
2019-08-31 23:28:26 +00:00
Emilio Cobos Álvarez
4505c339ab Bug 1576229 - Account for user stylesheets for Shadow DOM invalidation. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D43992

--HG--
extra : moz-landing-system : lando
2019-08-30 14:35:34 +00:00
Boris Chiou
c8dba8c886 Bug 1575062 - Support css use counters for unimplemented properties. r=emilio
For developing properties, we will handle them in an other bug.

Besides, I use an iframe for the test because we create a use counter in
the constructor of Document, which use the prefs to decide what kind of
properties we want to record. So, in the test, we have to reload iframe
to make sure we re-create the document, so does the use counter, to make
sure the prefs work properly.

The two prefs affect the css use counters:
1. layout.css.use-counters.enabled: Allocate use counters, and record
   non-custom properties.
2. layout.css.use-counters-unimplemented.enabled: Record all unimplmented
   properties into the use counters.

If we disable layout.css.use-counters.enblaed, we don't create use counters
object, so layout.css.use-counters-unimplemented.enabled doesn't work,
either.

Differential Revision: https://phabricator.services.mozilla.com/D43860

--HG--
extra : moz-landing-system : lando
2019-08-29 23:40:13 +00:00
Mats Palmgren
e45d08541b Bug 1576821 - [css-lists-3] Make 'none' invalid as a <counter-style> in counter()/counters(). r=emilio
CSSWG resolution:
https://github.com/w3c/csswg-drafts/issues/4163#issuecomment-521331100

Spec:
https://drafts.csswg.org/css-lists-3/#counter-functions

Differential Revision: https://phabricator.services.mozilla.com/D43893

--HG--
extra : moz-landing-system : lando
2019-08-30 00:15:37 +00:00
Joel Olsson
00e5276301 Bug 1565562: Media Query - Enable single <number> and <number>/<number> for <aspect-ratio>. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D41557

--HG--
extra : moz-landing-system : lando
2019-08-29 10:48:52 +00:00
Emilio Cobos Álvarez
c17fdaaa27 Bug 1576703 - Update cbindgen. r=boris
This cleans up the pattern of "Use a private dtor so that the helper functions
do the right thing" by enabling it everywhere using:

  https://github.com/eqrion/cbindgen/pull/377

It also caught some uninitialized value issues.

I think they're mostly harmless since we zero-initialize our structs:

https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/servo/components/style/properties/gecko.mako.rs#632

And since we override the clip rect, which is the other bit of code that was
failing to build with this change.

Differential Revision: https://phabricator.services.mozilla.com/D43491

--HG--
extra : moz-landing-system : lando
2019-08-26 23:18:46 +00:00
Emilio Cobos Álvarez
7cc40cf7ef Bug 1576666 - Use cbindgen for clip / -moz-image-region. r=boris
This also fixes some of the issues with -moz-image-region, where we just minted
an auto out of the blue.

Depends on D43472

Differential Revision: https://phabricator.services.mozilla.com/D43474

--HG--
extra : moz-landing-system : lando
2019-08-26 23:09:47 +00:00
Emilio Cobos Álvarez
996cd73ea9 Bug 1576666 - Remove old warning allow which is no longer relevant. r=boris
-moz-appearance uses cbindgen since a long time ago.

Differential Revision: https://phabricator.services.mozilla.com/D43472

--HG--
extra : moz-landing-system : lando
2019-08-26 20:09:19 +00:00
Emilio Cobos Álvarez
f93d4c2566 Bug 1576587 - Rustfmt declaration_block.rs and glue.rs
Differential Revision: https://phabricator.services.mozilla.com/D43400

--HG--
extra : moz-landing-system : lando
2019-08-26 09:58:53 +00:00
Emilio Cobos Álvarez
ba5c709666 Bug 1575608 - Simplify -x-span property. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D42914

--HG--
extra : moz-landing-system : lando
2019-08-21 20:02:13 +00:00
Emilio Cobos Álvarez
346d47d739 Bug 1575608 - Avoid manual paint-order glue code. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D42913

--HG--
extra : moz-landing-system : lando
2019-08-21 19:47:53 +00:00
Emilio Cobos Álvarez
611e05f178 Bug 1575608 - Avoid some signed -> unsigned conversions for box-ordinal-group. r=dholbert
This is consistent with the `order` property anyhow, and allows to simplify some
code.

Negatives are still not parsed, but rust uses a similar representation for all
CSS <integer> values and so should C++.

Differential Revision: https://phabricator.services.mozilla.com/D42912

--HG--
extra : moz-landing-system : lando
2019-08-21 18:35:31 +00:00
Emilio Cobos Álvarez
f11bf00012 Bug 1575559 - Make font-variant-alternates use cbindgen. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D42859

--HG--
extra : moz-landing-system : lando
2019-08-21 22:45:26 +00:00
Emilio Cobos Álvarez
110fe36713 Bug 1575559 - Fix rebase messup that makes a constructor public which shouldn't be. r=boris
I just drive-by noticed this, but I think it's worth fixing.

Differential Revision: https://phabricator.services.mozilla.com/D42858

--HG--
extra : moz-landing-system : lando
2019-08-21 18:28:23 +00:00
Emilio Cobos Álvarez
5ad7bad9b0 Bug 1575559 - Remove unused impl_coord_copy. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D42857

--HG--
extra : moz-landing-system : lando
2019-08-21 18:25:21 +00:00
Mats Palmgren
acbd6a2b96 Bug 1574994 part 2 - Remove display:-moz-inline-grid/-moz-inline-stack. r=emilio
Depends on D42551

Differential Revision: https://phabricator.services.mozilla.com/D42552

--HG--
extra : moz-landing-system : lando
2019-08-19 21:19:04 +00:00
Boris Chiou
03853a6e87 Bug 1574957 - Clamp negative values for font-size-adjust animations. r=hiro
Differential Revision: https://phabricator.services.mozilla.com/D42586

--HG--
extra : moz-landing-system : lando
2019-08-20 01:30:43 +00:00
Dzmitry Malyshau
9875e48074 Bug 1575008 - Update parking_lot dependency to 0.9.0 r=aosmond
Updating parking_lot would allow us to avoid dependency duplication when WebGPU tree is vendored.

Differential Revision: https://phabricator.services.mozilla.com/D42557

--HG--
rename : third_party/rust/parking_lot_core/src/thread_parker/wasm.rs => third_party/rust/parking_lot_core/src/thread_parker/wasm_atomic.rs
extra : moz-landing-system : lando
2019-08-19 21:28:51 +00:00
Emilio Cobos Álvarez
6a74af6652 Bug 1572738 - Don't clamp font-size calc() factors too early. r=manishearth
These two bugs (bug 1572738 and bug 1572451) are stylo regressions.

When font-family changes, we try to recompute the font-size with a length /
percentage combinations in case the generic family changes, so the user
preferences are kept.

When calc() is involved, we clamp to non-negative too early, via
NonNegativeLength::scale_by.

I think we should generally dump this "try to track font-size across calc()"
thingie, as as various comments note it is not quite perfect, and it's not clear
how it should work in presence of min()/max().

This patch fixes the issue and simplifies code a bit, I may consider removing
this altogether in a follow-up.

Differential Revision: https://phabricator.services.mozilla.com/D41776

--HG--
extra : moz-landing-system : lando
2019-08-19 19:59:48 +00:00
Emilio Cobos Álvarez
a03875ef63 Bug 1568536 - Simplify some style system APIs. r=heycam
Return a raw pointer instead of a strong reference to a ComputedStyle, and
handle the case of the style not being present by returning null rather than
requiring an extra function to check it and crashing if the precondition is not
met.

Also, name them so that it's clear they just return outdated styles and don't
make any extra effort.

This is just cleanup that makes the next patch easier / more obvious.

Differential Revision: https://phabricator.services.mozilla.com/D40080

--HG--
extra : moz-landing-system : lando
2019-08-16 05:59:03 +00:00
Mats Palmgren
1f1f009b71 Bug 1574060 - Implement layout for 'display: flow-root list-item'. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D42087

--HG--
extra : moz-landing-system : lando
2019-08-16 06:30:24 +00:00
Emilio Cobos Álvarez
4be851e345 Bug 1574148 - Update itertools in the style crate.
It was updated in Servo long ago.

Differential Revision: https://phabricator.services.mozilla.com/D42131

--HG--
extra : moz-landing-system : lando
2019-08-15 13:31:47 +00:00
Emilio Cobos Álvarez
3a60b58080 Bug 1574148 - Fix Servo build and unify display representation.
Differential Revision: https://phabricator.services.mozilla.com/D42130

--HG--
extra : moz-landing-system : lando
2019-08-15 13:31:44 +00:00
Emilio Cobos Álvarez
3fb09c923b Bug 1574148 - Fix formatting of recent changes.
Differential Revision: https://phabricator.services.mozilla.com/D42129

--HG--
extra : moz-landing-system : lando
2019-08-15 13:31:37 +00:00
Emilio Cobos Álvarez
7455082edb Bug 1574148 - Cherry-pick some Servo build/formatting fixes.
Differential Revision: https://phabricator.services.mozilla.com/D42128

--HG--
extra : moz-landing-system : lando
2019-08-15 13:31:36 +00:00
Mats Palmgren
c784db904f Bug 1557825 part 1 - Implement 'display:block ruby'. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D40211

--HG--
extra : moz-landing-system : lando
2019-08-14 14:38:31 +00:00
Mats Palmgren
740cfc08a3 Bug 1105868 part 3 - Implement 'inline list-item' and 'inline flow-root list-item' values for the 'display' property. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D39832

--HG--
extra : moz-landing-system : lando
2019-08-14 14:37:03 +00:00
Mats Palmgren
307e0a6d66 Bug 1569825 - Hide some 'display' values in devtools auto-completion that we want to discourage authors from using. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D39810

--HG--
extra : moz-landing-system : lando
2019-08-14 14:35:56 +00:00
Mats Palmgren
6b3058eeb5 Bug 1038294 part 12 - Implement multi-keyword 'display' values for Gecko. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D39764

--HG--
extra : moz-landing-system : lando
2019-08-14 14:34:37 +00:00
Charlie Marlow
693746ef3d Bug 1558929: adding from-font support to text-underline-offset and text-decoration-thickness r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D41476

--HG--
extra : moz-landing-system : lando
2019-08-13 17:43:25 +00:00
Emilio Cobos Álvarez
588e375d87 Bug 1573106 - Use shortest serialization for computed text-emphasis-style too. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D41513

--HG--
extra : moz-landing-system : lando
2019-08-13 19:26:02 +00:00
Narcis Beleuzu
043721cdd8 Backed out changeset 0836c998795b (bug 1573106) for wpt failures on accumulation-per-property.html . CLOSED TREE 2019-08-13 05:18:44 +03:00
Emilio Cobos Álvarez
7e441e1dd8 Bug 1573106 - Use shortest serialization for computed text-emphasis-style too. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D41513

--HG--
extra : moz-landing-system : lando
2019-08-12 21:31:52 +00:00
Emilio Cobos Álvarez
6283631506 Bug 1572805 - Adjust comment grammar as suggested by xidorn. r=comment-only
MANUAL PUSH: Comment only post-review fixup

DONTBUILD
2019-08-11 22:47:15 +02:00
Razvan Maries
c9a1909817 Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE 2019-08-11 12:48:00 +03:00
Csoregi Natalia
99bc0eceee Merge mozilla-central to mozilla-inbound. CLOSED TREE 2019-08-11 00:39:45 +03:00
Csoregi Natalia
6d04491407 Merge inbound to mozilla-central. a=merge 2019-08-11 00:28:20 +03:00
Emilio Cobos Álvarez
20dc132b08 Bug 1553545 - Remove now-incorrect comment. r=comment-only
MANUAL PUSH: Comment-only fixup to an inbound patch.

DONTBUILD
2019-08-10 18:40:18 +02:00
Joel Olsson
aa7bc8f357 Bug 1553545 - Enable font-size:xxx-large. r=emilio
MANUAL PUSH: Manually fixed up contributor's patch stack to squash the two patches in the bug.

Differential Revision: https://phabricator.services.mozilla.com/D41240
2019-08-10 18:32:33 +02:00
Charlie Marlow
ab6f4c453d Bug 1572303: updating text-underline-offset to support ::first-line/first-letter/placeholder r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D41227

--HG--
extra : moz-landing-system : lando
2019-08-09 04:58:10 +00:00
Csoregi Natalia
3edad1f4b7 Merge mozilla-central to autoland. CLOSED TREE 2019-08-11 00:36:21 +03:00
Emilio Cobos Álvarez
1322bb7290 Bug 1572805 - Undo last minute serialization change so that I can land it with tests. r=me
MANUAL PUSH: bustage, some WPTs need updating.
2019-08-10 22:21:12 +02:00
Emilio Cobos Álvarez
6068035edc Bug 1572805 - Use cbindgen for text-emphasis-style. r=boris
I sent https://github.com/eqrion/cbindgen/pull/377 since I got sick of
copy-pasting the private default constructor stuff :)

Differential Revision: https://phabricator.services.mozilla.com/D41419

--HG--
extra : moz-landing-system : lando
2019-08-10 18:11:31 +00:00
Emilio Cobos Álvarez
60447df0e6 Bug 1572805 - Simplify text-emphasis-style. r=boris,xidorn
Differential Revision: https://phabricator.services.mozilla.com/D41418

--HG--
extra : moz-landing-system : lando
2019-08-10 18:15:37 +00:00
Daniel Varga
3430859a68 Backed out 2 changesets (bug 1572805) for build-rusttests failure. On a CLOSED TREE
Backed out changeset 849ca4b3f9de (bug 1572805)
Backed out changeset 81b56d76505a (bug 1572805)
2019-08-10 21:07:03 +03:00