This patch shuffles the code in ElementAnimations::GetEventsAt to make it easier
to follow.
It also removes a check for whether or not the animation is paused.
Previously we would not dispatch events if the animation was paused and in its
active phase (but we would if the animation had finished). There doesn't seem to
be any reason for this. If the animation was paused between the last sample and
the current sample and the boundary of an iteration also occurred in that time
then I expect we should dispatch that event. Removing this check for the pause
state does not cause any tests fail.
Separating out the event logic here makes it clear that we do not dispatch start
events in the situation where one sample falls before the active interval and
one sample falls after it (filed as bug 1004361). This patch adds a comment to
this effect.
This patch simply shifts the event-related code from GetPositionInIteration to
GetEventsAt. Although there are simplifications that could be done to
GetEventsAt, they are deferred to a subsequent patch so as not to obscure the
translation of code from one function to another.
As a result of moving event-related handling from GetPositionInIteration it no
longer needs to support different main-thread vs compositor modes.
This patch makes ElementAnimations::GetPositionInIteration return
a ComputedTiming object instead of just a time portion (time fraction).
Since the ComputedTiming object includes phase information, we can fix those
parts of EnsureStyleRule and GetEventsAt that were temporarily using the time
portion to guess if the animation might have finished or not.
This patch moves the FillsForwards/FillsBackwards methods previously defined on
ElementAnimations to the structure contain the fill mode: AnimationTiming. It
also changes GetPositionInIteration to use these methods.
Introduces a struct to store timing parameters for passing to
GetPositionInIteration. In future this struct is expected to be expanded to
include other timing parameters as well (based roughly on Web Animations'
"Timing" interface, hence the name AnimationTiming).
This patch moves event queuing out of EnsureStyleRuleFor into a separate method.
This is a preparatory step towards making GetPositionInIteration into a more
generic method for calculating the current time fraction.
In order to achieve this, GetPositionInIteration needs to be able to calculate
the correct time portion for times outside the range [0, 1] even when it is not
passed a ElementAnimation object. Specifically, it needs the fill mode of the
animation to be passed in.
(Rather than using FillForwards/FillBackwards this patch just compares the
NS_STYLE_ANIMATION_FILL_MODE_* values directly but FillForwards/FillBackwards
are restored in a subsequent patch when they are added to the struct used to
lump the timing parameters together.)
There are a number of places where positionInIteration is used to determine if
the current sample occurs in the active phase or after. This is sub-optimal but
is fixed in a subsequent patch in this series.
The actual work of removing event queuing from GetPositionInIteration is
deferred to a subsequent patch in order to keep the changes as small as
possible. This patch simply makes separate calls to GetPositionInIteration for
interpolating and for event queuing.
========
https://hg.mozilla.org/integration/gaia-central/rev/f2274c0c94a9
Author: BavarianTomcat <tomcat@mozilla.com>
Desc: Revert "Bug 1006357 - make test agent to run tests from all apps locally and in travis" for build bustages
This reverts commit f382b51dc36de20de9ad06bb1798f8300dd164a8.
========
https://hg.mozilla.org/integration/gaia-central/rev/99663e0fba4c
Author: Greg Weng <snowmantw@gmail.com>
Desc: Revert "Bug 1010651 - (vertical-homescreen) RocketBar missing search icon"
This reverts commit 08eb5e8e12e4c1d9634fffc1768ca0da6778b8dd.
* This bug make the status bar incorrectly overlap on the LockScreen window
If the USB cable is pulled after we call SetIsSharing(true) but before we actually initiate the
sharing operation, then the volume doesn't change state, and mIsSharing never gets set back to
false. So we detect this condition now and force mIsSharing to be false when the USB cable is
unplugged.
========
https://hg.mozilla.org/integration/gaia-central/rev/d7e18028030c
Author: Fernando Campo <fernando.campo@telefonica.com>
Desc: Merge pull request #19444 from fcampo/split-basket-990058
Bug 990058 - [FTU] Re-implement Basket newsletter for splitted FTU (r=arcturus, etienne)
========
https://hg.mozilla.org/integration/gaia-central/rev/c254a88ac066
Author: Fernando Campo <fernando.campo@telefonica.com>
Desc: Bug 990058 - [FTU] Re-implement Basket newsletter for splitted FTU
- Basket functionality moved to shared, use Promises
- Use DataStore instead of AsyncStore
- Launched from System instead of Dialer
