Mitch has been inactive for ~2 years now. I don't necessarily needs to
add myself in his stead, but I think it makes sense to have me on there
as the current triage owner.
Differential Revision: https://phabricator.services.mozilla.com/D209031
This was needed because we didn't use to override the color of the
textfield, so it needed to work with whatever color was there already.
Now that we enforce the color however, there's no point on it being
semi-transparent.
Add a darker version of the color so that it also works on dark mode
(<input style="color-scheme: dark"> or so).
Now that it's opaque, there's no need for Theme.cpp to blend with the
field background.
Differential Revision: https://phabricator.services.mozilla.com/D209021
These tests used to live directly in the css-pseudo directory, which already
has this pref enabled via its own __dir__.ini file. But this bucket of tests
moved to their own directory recently, so we need to turn on the pref in that
directory so that these tests can work properly (beyond Nightly where the pref
is default-enabled).
(There are still a few tests in the css-pseudo directory that use the highlight
API -- e.g. css/css-pseudo/highlight-painting-soft-hyphens-001.html -- so we do
still need to leave the pref enabled there as well.)
Differential Revision: https://phabricator.services.mozilla.com/D209070
These properties are inherited anyways. Maybe in the past they were
somehow overridden?
This seems worth doing but is not upliftable.
Differential Revision: https://phabricator.services.mozilla.com/D208976
So that we honor the cursor property on those elements. This is the only
declaration that applies to the label otherwise.
The file input behavior matches other browser too.
Differential Revision: https://phabricator.services.mozilla.com/D208975
With the new changes in bug 1724083, it is possible for an actor to be
destroyed during SetManagerAndRegister, which can lead to RemoveManagee being
called before the managee is even registered, leading to an assertion failure.
The easiest fix here is to relax this assertion, as we won't insert the entry
later in this failure case.
Differential Revision: https://phabricator.services.mozilla.com/D208936
@file are supported by gcc since gcc 7 and by clang since clang 3.x,
which removes the need for linker script to list input files.
We cannot directly use @file from the compiler driver (it would expand
to a large number of arguments and hit the linker limit) so pass
-Wl,@FILE instead, which is supported since binutils 2.17.
As a side effect this removes the LTO dependency from the check.
Differential Revision: https://phabricator.services.mozilla.com/D207839
Adds test infrastructure and a test case to test the
SelectTranslationsPanel functionality when a PDF
is the current page.
Depends on D208710
Differential Revision: https://phabricator.services.mozilla.com/D208711
The existing PDF file in the Translations test suite
has no content. Now that we're testing Select Translations
with PDFs, we need one with content.
Depends on D208709
Differential Revision: https://phabricator.services.mozilla.com/D208710
Ensures that the translate-full-page button is hidden
from the SelectTranslationsPanel when Full Page Translations
is not available on the active page.
Depends on D208708
Differential Revision: https://phabricator.services.mozilla.com/D208709
Ensures that all locations where the SelectTranslationsPanel
would attempt to retrieve the Translations actor
are handled gracefully if the Translations actor
cannot be retrieved.
Depends on D208697
Differential Revision: https://phabricator.services.mozilla.com/D208708
Renames the TranslationsParent.isRestrictedPage function
to isFullPageTranslationsRestrictedForPage to be more clear
about which translation functionality is restricted.
Differential Revision: https://phabricator.services.mozilla.com/D208697
- Consolidates `historyMapByDate`, `historyMapBySite`, and `searchResults` into one single `historyCache`, which represents all of the visits that should be rendered by the host and what options are currently in place.
- Converts `HistoryController` to a system level module.
- Adds preventative code to account for race conditions in cases during test verification.
Differential Revision: https://phabricator.services.mozilla.com/D207861
This helps avoid conflicting guidance at the end of the rebase
process when there have been changes in mozilla-central since
the last rebase (or since the initial elm reset).
Differential Revision: https://phabricator.services.mozilla.com/D208961
Adds a test case where the FullPageTranslationsPanel is
opened from a new window after click-and-dragging a tab
to become its own window.
Depends on D208820
Differential Revision: https://phabricator.services.mozilla.com/D208821
Fixes an issue where the Translations panels initialization
cache would encounter an false cache hit if a tab is dragged
to become its own new window after one of the panels was already
opened in the previous window.
Differential Revision: https://phabricator.services.mozilla.com/D208820
This doesn't necessarily prove it works as a singleton component since the
unit tests don't initialize it, but I figure it makes sense to convert the
unit test now before subsequent modifications.
The changes to the component code are due to the fact that previously,
the unit test would do one test after another with a new instance of a TopSitesFeed.
Since I'm re-using the instance, it needs to be reset. And since a
method could still be running when the next test runs, I wait until a
possible refresh is happening before continuing on to another test.
Differential Revision: https://phabricator.services.mozilla.com/D208996
