All fronts are destroyed when we call TargetMixin.destroy.
All but the inspector. This changeset move the inspector front destruction
from being done in parallel to panels destruction to do it after.
This highlight races in tests that are not waiting correctly for the full
loading of the grid sidebar.
Differential Revision: https://phabricator.services.mozilla.com/D39408
--HG--
extra : moz-landing-system : lando
InspectorFront.destroy isn't returning a promise. So the `await` in the toolbox
code is not relevant and is only spinning the event loop.
Removing it introduce races which should be fixed.
The toolbox buttons shouldn't try to unhighlight if the inspector isn't used.
Differential Revision: https://phabricator.services.mozilla.com/D39407
--HG--
extra : moz-landing-system : lando
This patch ensures that any existing query text in the search bar is highlighted when the Cmd/Ctrl + F shortcut is used.
Differential Revision: https://phabricator.services.mozilla.com/D38934
--HG--
extra : moz-landing-system : lando
This actor isn't implemented for processes, but only by browsing context targets.
Differential Revision: https://phabricator.services.mozilla.com/D38905
--HG--
extra : moz-landing-system : lando
Before this patch we would only treat audio elements as replaced if they
had something visible on the page, so if they had the controls attribute.
This is a specific case that we don't really need to worry about. If we
unconditionnally assume audio elements are replaced, then the code is
simpler and the heuristic is still fine for the vast majority of cases.
In fact, it's even more correct, as an audio element that's inline and
does *not* have the controls attribute still has active width/height
properties. So we do need to treat it as replaced even in this case.
Differential Revision: https://phabricator.services.mozilla.com/D39216
--HG--
extra : moz-landing-system : lando
All fronts are destroyed when we call TargetMixin.destroy.
All but the inspector. This changeset move the inspector front destruction
from being done in parallel to panels destruction to do it after.
This highlight races in tests that are not waiting correctly for the full
loading of the grid sidebar.
Differential Revision: https://phabricator.services.mozilla.com/D39408
--HG--
extra : moz-landing-system : lando
InspectorFront.destroy isn't returning a promise. So the `await` in the toolbox
code is not relevant and is only spinning the event loop.
Removing it introduce races which should be fixed.
The toolbox buttons shouldn't try to unhighlight if the inspector isn't used.
Differential Revision: https://phabricator.services.mozilla.com/D39407
--HG--
extra : moz-landing-system : lando
The code callng action.updateRequest, in FirefoxDataProvider, expects the updateRequest action
to be processed once the returned promise is resolved. Otherwise it may spawn
duplicated requestData requests.
Differential Revision: https://phabricator.services.mozilla.com/D39153
--HG--
extra : moz-landing-system : lando
We retrieve the preference in the hudservice, where
WebConsoles and BrowserConsoles are created from.
If the pref is set to true, we assign a different
title to the Browser Console window so it will be
easier to spot.
The preference is then passes to the BrowserConsole,
WebConsole, WebConsoleUI and finally WebConsoleConnectionProxy
instances.
Later, we'll check this pref to connect to different
targets and listen to new ones.
Depends on D39646
Differential Revision: https://phabricator.services.mozilla.com/D39647
--HG--
extra : moz-landing-system : lando
In `EventListeners.css` I added `width: 100%` to the `.event-listener-label` to increase the width of the clickable area.
Differential Revision: https://phabricator.services.mozilla.com/D39500
--HG--
extra : moz-landing-system : lando
The reference isn't used within the component itself,
and is available in the webConsoleUI.
Callsites are updated.
Differential Revision: https://phabricator.services.mozilla.com/D39505
--HG--
extra : moz-landing-system : lando
There's no reason it should be JsTerm's responsability
to clear the output node.
Differential Revision: https://phabricator.services.mozilla.com/D39508
--HG--
extra : moz-landing-system : lando
In the last patch of this series, I forgot to sync `remoteWebNavigationImpl`
state in the progress listener. This patch corrects that.
Differential Revision: https://phabricator.services.mozilla.com/D39395
--HG--
extra : moz-landing-system : lando
Some failures crept in and out after my last sets of annotations landed. This
patch updates most of the annotations to deal with them.
MANUAL PUSH: Lando won't let me land.
Differential Revision: https://phabricator.services.mozilla.com/D39462
--HG--
extra : rebase_source : 4cfccf95c5bb2521533a9f5c4c25d67f414fb6f5
extra : histedit_source : c19187a3b3002e0eebdd809738b57641e1e432cd
The test is supposed that the document is not scalable at all when
"minimum-scale=maximum-scale" is set in the viewport meta content, but it's
actually invalid. A correct content is assumed "minimum-scale=1,maximum-scale=1"
so that the document is not scaled at all.
The reason why this check has passed is that "user-scalable=no" which is set
right before this check remains in cache so that the content of the meta
viewport becomes "user-scalable=no,minimum-scale=maximum-scale" which means the
document is not scalable. But we are going to fix this weird behavior in this
commit series so that we are no longer able to rely on the cached
"user-scalable=no" value.
Differential Revision: https://phabricator.services.mozilla.com/D38919
--HG--
extra : moz-landing-system : lando
The fronts are destroyed when the toolbox closes and when a front is destroyed,
all its listeners are removed. So there is no real value in trying to unregister
them. On top of that, this destroy method is called by Inspector.destroy
and doesn't wait for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D39302
--HG--
extra : moz-landing-system : lando
This code in ToolSidebar.destroy looks dead as there shouldn't be any sidebar
loaded in distinct iframes anymore. So we are not trying to call sidebars destroy
from here anymore. Instead, it is being done from Inspector.destroy, via the _panels
Map.
Differential Revision: https://phabricator.services.mozilla.com/D39301
--HG--
extra : moz-landing-system : lando