Commit Graph

16533 Commits

Author SHA1 Message Date
Margareta Eliza Balazs
2fe43133db Merge inbound to mozilla-central. a=merge 2018-08-29 12:43:37 +03:00
Valentin Gosu
0267a22bb2 Bug 1486228 - Grab mutex when accessing nsDNSService::mLocalDomains r=mayhemer!
Differential Revision: https://phabricator.services.mozilla.com/D4452

--HG--
extra : moz-landing-system : lando
2018-08-28 22:37:12 +00:00
Ciure Andrei
d716a04e20 Merge inbound to mozilla-central. a=merge 2018-08-29 00:58:21 +03:00
Nicholas Hurley
dd1853e164 Bug 1483294 - Always advertise h2 if TLS 1.3 is being offered. r=dragana
Previously (under TLS 1.2), we would avoid advertising h2 support if the
spec-mandatory suite was disabled. That suite is only required for TLS
1.2, though. We would like to offer h2 in more cases, so only check for
the mandatory suite if someone has turned off TLS 1.3.

Differential Revision: https://phabricator.services.mozilla.com/D4345

--HG--
extra : moz-landing-system : lando
2018-08-27 18:56:44 +00:00
Gurzau Raul
123404288d Backed out changeset 0192efea1b66 (bug 1486137) for failing at netwerk/test/unit/test_trr.js on a CLOSED TREE 2018-08-28 16:29:25 +03:00
Daniel Stenberg
ec82b55b39 bug 1486137 - TRR: fix the FAMILY field in the ECS code r=mcmanus
... since AF_INET wouldn't actually use IPv4!

MozReview-Commit-ID: FCf7psawENI

Differential Revision: https://phabricator.services.mozilla.com/D4328

--HG--
extra : moz-landing-system : lando
2018-08-27 16:03:30 +00:00
Daniel Stenberg
ef67442423 bug 1485515 - range check the network.trr.mode pref on read r=valentin
MozReview-Commit-ID: 8OdeXYQEzQJ

Differential Revision: https://phabricator.services.mozilla.com/D4332

--HG--
extra : moz-landing-system : lando
2018-08-27 13:13:12 +00:00
Henri Sivonen
cbab098175 Bug 1485343 - Avoid locale-dependent C standard library functions in FTP code. r=valentin
MozReview-Commit-ID: CXcluPKLwIv

Differential Revision: https://phabricator.services.mozilla.com/D4315

--HG--
extra : moz-landing-system : lando
2018-08-27 09:11:30 +00:00
Henri Sivonen
2be0158cae Bug 1485340 - Avoid isdigit() and isxdigit() in URL parsing. r=valentin
MozReview-Commit-ID: 13DUMcZIE19

Differential Revision: https://phabricator.services.mozilla.com/D4308

--HG--
extra : moz-landing-system : lando
2018-08-27 09:12:25 +00:00
arthur.iakab
5527acb8d8 Merge inbound to mozilla-central a=merge 2018-08-25 01:08:22 +03:00
David Keeler
1cd81e4c5a bug 1485087 - remove the option to use the TLS session cache from nsITLSServerSocket r=jryans,mayhemer
As initially implemented, nsITLSServerSocket by default enabled the use of the
TLS session cache provided by NSS. However, no consumers of nsITLSServerSocket
actually used it. Because it was an option, though, PSM had to jump through some
hoops to a) make it work in the first place and b) not have NSS panic on
shutdown. Furthermore, it meant increased memory usage for every user of Firefox
(and again, nothing actually used the feature, so this was for naught).

In bug 1479918, we discovered that if PSM shut down before Necko, NSS could
attempt to acquire a lock on the session cache that had been deleted, causing a
shutdown hang. We probably should make it less easy to make this mistake in NSS,
but in the meantime bug 1479918 needs uplifting and this workaround is the
safest, most straight-forward way to achieve this.

Differential Revision: https://phabricator.services.mozilla.com/D3919

--HG--
extra : moz-landing-system : lando
2018-08-24 16:00:34 +00:00
Henri Sivonen
b1e7ee63f3 Bug 1485945 - Set the length instead of capacity of an address string to avoid writing past its logical length. r=valentin
MozReview-Commit-ID: 5anNIW843JJ

Differential Revision: https://phabricator.services.mozilla.com/D4201

--HG--
extra : moz-landing-system : lando
2018-08-24 14:05:13 +00:00
Nicholas Nethercote
fe34f19459 Bug 1486690 - Rename nsMemory::Clone() and remove unnecessary checks after it. r=glandium
The 'x' in the new name makes it clearer that it's infallible.

--HG--
extra : rebase_source : 51fd946c482befe8a8ca5bd88ecc967971f455da
2018-08-28 15:59:19 +10:00
Nicholas Nethercote
2fcd08a173 Bug 1486690 - Rename NS_str{,}dup and remove unnecessary checks after calls to them. r=glandium
The 'x' prefix makes it clearer that these are infallible.

A couple of nsJSID methods are now also infallible.

--HG--
extra : rebase_source : fcce44a00212d6d341afbf3827b31bd4f7355ad5
2018-08-28 15:58:54 +10:00
Nicholas Nethercote
e51afbee7e Bug 1486690 - Remove unnecessary checks after moz_xrealloc() calls. r=glandium
--HG--
extra : rebase_source : c036680008cef1f87ed94700f9146022ce879e53
2018-08-28 15:56:23 +10:00
Nicholas Nethercote
ac5efebb4b Bug 1486690 - Remove unnecessary checks after moz_xmalloc() calls. r=glandium
There are surprisingly many of them.

(Plus a couple of unnecessary checks after `new` calls that were nearby.)

--HG--
extra : rebase_source : 47b6d5d7c5c99b1b50b396daf7a3b67abfd74fc1
2018-08-28 15:56:01 +10:00
Jeff Walden
64fceacad0 Bug 1486577 - Don't #include "js/CompilationAndEvaluation.h" in jsapi.h, minimizing the scope of that header and reducing translation-unit size of anything that needs JSAPI but doesn't need to compile/evaluate JavaScript. r=jandem
--HG--
extra : rebase_source : cd9a8becc15477bc5e24408159d4f061ec81c8b2
2018-08-24 22:51:49 -05:00
Daniel Stenberg
7786d290c0 bug 1485956 - make DNS cache lookups respect DISABLE_TRR r=valentin
So that explicitly disabling TRR for specific resolves won't end up just
using the cached entry resolved with TRR!

MozReview-Commit-ID: HZ4AyKOMpet

Differential Revision: https://phabricator.services.mozilla.com/D4215

--HG--
extra : moz-landing-system : lando
2018-08-24 14:09:22 +00:00
Noemi Erli
d9cb8a1d4a Backed out changeset b24238e8e714 (bug 1481199) for failures in mobile/android/tests/browser/chrome/test_device_search_engine.html 2018-08-24 20:34:36 +03:00
Ehsan Akhgari
9172f9d616 Bug 1485494 - Remove the XPCOM registration for RedirectChannelRegistrar; r=mayhemer 2018-08-24 13:04:10 -04:00
Ehsan Akhgari
50793958bf Bug 1485532 - Part 2: Make sure that tracking requests that webRequest.onBeforeRequest handlers do not handle will still get blocked by tracking protection; r=mayhemer 2018-08-24 11:23:10 -04:00
Ehsan Akhgari
5306437473 Bug 1485673 - Allow tracking channels being redirected from http-on-modify-request observer notifications when tracking protection is turned on; r=mayhemer 2018-08-24 11:23:09 -04:00
Diego Pino Garcia
1f9d6d9b78 Bug 1481199 - Drop the obsolete dataType parameter for nsIBrowserSearchService.addEngine. r=mkaply 2018-08-23 17:25:12 -05:00
Tiberius Oros
2ee9341d01 Merge inbound to mozilla-central. a=merge 2018-08-24 12:43:45 +03:00
Daniel Stenberg
9eb175b4cb bug 1470853 - Add Telemetry::DNS_TRR_REQUEST_PER_CONN r=nwgh
Count number of requests/streams per connection done when the connection
was used for TRR.

MozReview-Commit-ID: 50NVSCcd6jy

Differential Revision: https://phabricator.services.mozilla.com/D4083

--HG--
extra : moz-landing-system : lando
2018-08-23 18:13:34 +00:00
Ehsan Akhgari
3efae05d6c Bug 1485427 - Add two assertions ensuring that request observers are (not) fired at the right times; r=mayhemer 2018-08-23 22:59:32 -04:00
Kris Maglione
7baee54e0f Bug 1484496: Follow-up: Fix more NoQueryNeeded assertions. r=bustage 2018-08-23 17:15:41 -07:00
Kris Maglione
3a5c05e76f Bug 1484496: Part 5e - Convert remaining nsISimpleEnumerator users to use JS iteration. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D3733

--HG--
extra : rebase_source : c0fac176d7b3d840c4dbb14f8d95ccfc7f83a5a8
extra : histedit_source : a92c40117d0808a3ad68c972f622a7a42c9ae8ba
2018-08-18 18:13:14 -07:00
Kris Maglione
2dee0aae3c Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj
This allows JS callers to automatically get the correct types during
interation, without having to explicitly specify them.

Differential Revision: https://phabricator.services.mozilla.com/D3728

--HG--
extra : rebase_source : b708f382d8ea571d199c669bfed5b5a7ca9ffac4
extra : histedit_source : 7df6feb82088c8a5ca45dc28fe4d2b852c177fee
2018-08-18 21:06:32 -07:00
Kris Maglione
c943b2a5c4 Bug 1484496: Part 4a - Add JS iterator support to nsISimpleEnumerator. r=mccr8
This patch adds simple stubs to convert between the nsISimpleEnumerator
iteration protocol and the JS iteration protocol.

Each iterable object is required to have an @@iterator method which returns an
object implementing the iterator protocol. The later objects, by convention,
also have such a method which returns the object itself.

This patch adds both a @@iterator() and entries() methods to
nsISimpleEnumerator. The former returns an iterator which returns plain
nsISupports objects. The latter accepts an IID and queries each element to
that IID before returning it. If any element fails to query, the error is
propagated to the caller.

Differential Revision: https://phabricator.services.mozilla.com/D3727

--HG--
extra : rebase_source : 340eb43a1c5e6d7ae69fa8ee486d66d31d079b14
extra : histedit_source : f3efc6c265851a563968ee410e4626e0540f55c0
2018-08-18 16:02:49 -07:00
Dorel Luca
8e7a61886b Backed out changeset d47a2f5db828 (bug 1481199) browser/base/content/test/urlbar/browser_autocomplete_a11y_label.js. CLOSED TREE 2018-08-23 23:45:02 +03:00
Diego Pino Garcia
6900fb42ab Bug 1481199 - Drop the obsolete dataType parameter for nsIBrowserSearchService.addEngine. r=mkaply 2018-08-23 09:00:00 -04:00
Andrea Marchesini
c80c929412 Bug 1476967 - Allow the adding of tracking-protection entries via prefs, r=francois 2018-08-27 21:01:14 +02:00
Cosmin Sabou
d141575366 Merge mozilla-central to mozilla-inbound. a=merge 2018-08-27 19:00:38 +03:00
Ehsan Akhgari
2d62042b5c Bug 1486092 - Part 1: Move the browser.contentblocking.enabled pref to StaticPrefs; r=baku 2018-08-27 09:22:01 -04:00
Ehsan Akhgari
0a3c630be4 Bug 1486184 - Add reject tracker to the list of cases that we consider requiring third-party checks for; r=baku
This was an omission from bug 1480780 which merged the prefs.
2018-08-27 09:17:25 -04:00
Polly Shaw
06de5fed24 Bug 1482224 Crash in Shutdown due to ProxyAutoConfig still aiming to resolve addressThis crash has arisen due to a loop in ProxyAutoConfig which spins until apending PAC request is complete, even when the ProxyAutoConfig object is beingshut... r=valentin
...down. The remedy to prevent the crash is to exit the loop when the
mShutdown flag is set. This does not attempt to address the underlying cause
of why the request continues to be pending, although this is also a concern.
Files changed:
netwerk/base/ProxyAutoConfig.cpp - expanded lambda containing logic of when
to stop waiting for the request to complete to include a check to the mShutdown
flag. Also logged a warning if the loop is exited because of mShutdown.

Differential Revision: https://phabricator.services.mozilla.com/D3977

--HG--
extra : moz-landing-system : lando
2018-08-22 23:23:08 +00:00
Ehsan Akhgari
3788f265e3 Bug 1485182 - Part 1: Run http-on-modify-request observers when tracking protection cancels an HTTP channel; r=mayhemer 2018-08-22 14:00:01 -04:00
Ehsan Akhgari
b1a6405b4c Bug 1484876 - Part 3: Refactor the code responsible for checking whether the top window URI is on the content blocking allow list into AntiTrackingCommon; r=francois 2018-08-22 12:02:43 -04:00
Ehsan Akhgari
7a3e0c65f0 Bug 1484876 - Part 2: Check the trackingprotection-pb permission in the channel classifier code instead of accessing nsIPrivateBrowsingTrackingProtectionWhitelist; r=francois 2018-08-22 12:02:43 -04:00
Dylan Roeh
ee984e1e49 Bug 1478171 - [1.0] Forward channel redirect to nsILoadURIDelegate to allow external handling. r=smaug,snorp 2018-08-21 12:52:39 -05:00
Cosmin Sabou
ed624fa8d0 Backed out 6 changesets (bug 1484876) for eslint failure on PrivateBrowsingUtils. CLOSED TREE
Backed out changeset e80737d6af55 (bug 1484876)
Backed out changeset b1cb63d8c8bb (bug 1484876)
Backed out changeset cd2ced689895 (bug 1484876)
Backed out changeset d31e39a47704 (bug 1484876)
Backed out changeset babf6abc7f4c (bug 1484876)
Backed out changeset 1c9895ab06c6 (bug 1484876)
2018-08-22 16:26:33 +03:00
Ehsan Akhgari
c4e0a11824 Bug 1484876 - Part 3: Refactor the code responsible for checking whether the top window URI is on the content blocking allow list into AntiTrackingCommon; r=francois 2018-08-22 09:08:10 -04:00
Ehsan Akhgari
57a5790ea9 Bug 1484876 - Part 2: Check the trackingprotection-pb permission in the channel classifier code instead of accessing nsIPrivateBrowsingTrackingProtectionWhitelist; r=francois 2018-08-22 09:08:10 -04:00
Tiberius Oros
05b46cf200 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-08-22 00:59:19 +03:00
Honza Bambas
0a40274f51 Bug 1469117 - Make sure we reset network socket timeout epoch to 0 when timeout on a socket is turned off r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D3880

--HG--
extra : moz-landing-system : lando
2018-08-21 14:33:52 +00:00
Henri Sivonen
57d5f3ee13 Bug 1484984 - Avoid writing past the logical length of a string in networking code. r=valentin
MozReview-Commit-ID: IIffoxnF6KS

Differential Revision: https://phabricator.services.mozilla.com/D3884

--HG--
extra : moz-landing-system : lando
2018-08-21 14:20:48 +00:00
Dorel Luca
d9bdf77969 Merge mozilla-central to autoland 2018-08-21 12:57:58 +03:00
Dorel Luca
07c6e76122 Merge mozilla-inbound to mozilla-central. a=merge 2018-08-21 12:54:24 +03:00
Daniel Stenberg
8225a95bbd bug 1483311 - add LOAD_DISABLE_TRR as a loadflag r=mcmanus
Disable TRR at will without needing to toggle the pref.

MozReview-Commit-ID: 1Ept6kDrjN3

Differential Revision: https://phabricator.services.mozilla.com/D3399

--HG--
extra : moz-landing-system : lando
2018-08-20 22:02:04 +00:00