Commit Graph

678988 Commits

Author SHA1 Message Date
Jon Coppeard
b894ce9008 Bug 1593329 - Fix problems handling OOM related to FinalizationGroup r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D52021

--HG--
extra : moz-landing-system : lando
2019-11-08 13:40:12 +00:00
Nicolas Chevobbe
4051daad83 Bug 1594637 - Fix browser_webconsole_output_order intermittent. r=Honza.
It's not obvious to me what the culprit is, but it may be because
of the clearOutput call somehow.
Let's see if this fix the intermittent.

Differential Revision: https://phabricator.services.mozilla.com/D52321

--HG--
extra : moz-landing-system : lando
2019-11-08 11:52:16 +00:00
Nicolas Chevobbe
dc2101bfa2 Bug 1572667 - Re-enable stubs tests. r=Honza.
The tests are rewritten so we only have one test per
stub type. The stubs can be re-generated by passing
the --setenv WEBCONSOLE_STUBS_UPDATE=true arg when running
mach test.
We take this as an opportunity to not store the Messages
directly, but we generate them programmatically, which would
still reveal a bug as most of the test import messages.
Since we're doing that, some messages aren't localized, so
we need to add them to the L10N fixtures we have (which is
revamped a bit as getStr was getting too complex).

Differential Revision: https://phabricator.services.mozilla.com/D51596

--HG--
extra : moz-landing-system : lando
2019-11-08 12:06:42 +00:00
Marco Bonardo
87849aa2b6 Bug 1593663 - Polish megabar one-offs shrinking behavior. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D52198

--HG--
extra : moz-landing-system : lando
2019-11-08 12:56:56 +00:00
Simon Giesecke
365b8934ac Bug 1497007 - Mark group of methods exposed via webidl. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47232

--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:56 +00:00
Simon Giesecke
67ff3f2964 Bug 1497007 - Added explaining comments. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47231

--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:45 +00:00
Simon Giesecke
b390f011e5 Bug 1497007 - Use IDBTransaction::IsWriteAllowed to simplify code. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47230

--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:33 +00:00
Simon Giesecke
66ba8c7bd1 Bug 1497007 - Extracted GetIndexedDBThreadLocal function. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46949

--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:25 +00:00
Simon Giesecke
f5146ed829 Bug 1497007 - Replace custom for loops by range-based for and appropriate algorithms. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46948

--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:13 +00:00
Simon Giesecke
a90f156203 Bug 1497007 - Minor improvements. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46947

--HG--
extra : moz-landing-system : lando
2019-11-08 13:29:58 +00:00
Simon Giesecke
d905508bee Bug 1497007 - Extracted HasTransactionChild and DoWithTransactionChild functions. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46946

--HG--
extra : moz-landing-system : lando
2019-11-08 13:29:46 +00:00
Simon Giesecke
df38d08c1d Bug 1497007 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46945

--HG--
extra : moz-landing-system : lando
2019-11-08 13:29:39 +00:00
octavian.negru
0231d67fa2 Bug 1595028 - Fix manifest error r=perftest-reviewers,Bebe
Differential Revision: https://phabricator.services.mozilla.com/D52349

--HG--
extra : moz-landing-system : lando
2019-11-08 13:25:25 +00:00
Henrik Skupin
ef21b9b3af Bug 1594871 - [remote] Callers of loadURL() in browser_captureScreenshot.js have to use await. r=remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D52353

--HG--
extra : moz-landing-system : lando
2019-11-08 13:35:24 +00:00
André Bargull
a1298a12f9 Bug 1592992 - Part 19: Move jsutil.cpp to util/Utility.cpp. r=jonco
This file provides the implementation of js/Utility.h, so it should be renamed
to match the header name.

Differential Revision: https://phabricator.services.mozilla.com/D51378

--HG--
rename : js/src/jsutil.cpp => js/src/util/Utility.cpp
extra : moz-landing-system : lando
2019-11-08 13:24:15 +00:00
André Bargull
7e0e092dc9 Bug 1592992 - Part 18: Remove jsutil.h. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51377

--HG--
extra : moz-landing-system : lando
2019-11-08 11:09:57 +00:00
André Bargull
34f632c778 Bug 1592992 - Part 17: Remove includes for jsutil.h. r=jonco
And handle the fallout of missing #includes when compiling a non-unified build.

Differential Revision: https://phabricator.services.mozilla.com/D51376

--HG--
extra : moz-landing-system : lando
2019-11-08 11:09:40 +00:00
André Bargull
1ab50a790e Bug 1592992 - Part 16: Include util/DiagnosticAssertions.h where necessary. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51375

--HG--
extra : moz-landing-system : lando
2019-11-08 11:08:52 +00:00
André Bargull
387a601299 Bug 1592992 - Part 15: Include util/Poison.h where necessary. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51374

--HG--
extra : moz-landing-system : lando
2019-11-08 11:08:29 +00:00
André Bargull
58a84e9861 Bug 1592992 - Part 14: Include util/Memory.h where necessary. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51373

--HG--
extra : moz-landing-system : lando
2019-11-08 11:08:01 +00:00
André Bargull
c82e907a68 Bug 1592992 - Part 13: Include util/BitArray.h where necessary. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51372

--HG--
extra : moz-landing-system : lando
2019-11-08 11:07:21 +00:00
André Bargull
17b59c3ea0 Bug 1592992 - Part 12: Replace js::Min/Max with std::min/max. r=jonco
For the most part another mechanical change, except for two changes:
- In gc/Nursery.cpp and vm/DateTime.cpp, the initializer_list variants for
  std::min/max are used, because the two parameter forms of min/max take const
  reference parameters. And it's not possible to take the reference of a
  constexpr variable which wasn't previously explicitly defined. This is just
  a C++14 limitation and as soon as we compile with C++17, we can revert this
  change.
- builtin/String.cpp was calling `Max(unsignedVar, 0U)` in a few places, which
  led to compiler warnings, because the result is always `unsignedVar`.

Differential Revision: https://phabricator.services.mozilla.com/D51371

--HG--
extra : moz-landing-system : lando
2019-11-08 11:06:58 +00:00
André Bargull
4248a374ed Bug 1592992 - Part 11: Remove no longer needed includes from jsutil.h. r=jonco
The includes are still transitively reachable through the new "#include util/*.h" headers.

Differential Revision: https://phabricator.services.mozilla.com/D51370

--HG--
extra : moz-landing-system : lando
2019-11-08 11:06:00 +00:00
André Bargull
93a91151b4 Bug 1592992 - Part 10: Split diagnostic assertions from jsutil.h. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51369

--HG--
rename : js/src/jsutil.h => js/src/util/DiagnosticAssertions.h
extra : moz-landing-system : lando
2019-11-08 11:05:41 +00:00
André Bargull
9e0678f877 Bug 1592992 - Part 9: Move js::IsInitialized() into its sole caller. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51368

--HG--
extra : moz-landing-system : lando
2019-11-08 11:05:23 +00:00
André Bargull
b320c60fc2 Bug 1592992 - Part 8: Split memory and byte alignment functions from jsutil.h. r=jonco
A single header for both memory and byte alignment functions, similar to the
standard <memory> header, which also provides memory and byte alignment related
functionality.

Differential Revision: https://phabricator.services.mozilla.com/D51367

--HG--
rename : js/src/jsutil.h => js/src/util/Memory.h
extra : moz-landing-system : lando
2019-11-08 11:05:16 +00:00
André Bargull
5b0689fff8 Bug 1592992 - Part 7: Split bit-array functions from jsutil.h. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51366

--HG--
rename : js/src/jsutil.h => js/src/util/BitArray.h
extra : moz-landing-system : lando
2019-11-08 11:05:14 +00:00
André Bargull
0b2f713a4a Bug 1592992 - Part 6: Split poisoning functions from jsutil.h. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51365

--HG--
rename : js/src/jsutil.h => js/src/util/Poison.h
extra : moz-landing-system : lando
2019-11-08 11:04:14 +00:00
André Bargull
bf486d2dce Bug 1592992 - Part 5: Replace js::Reverse with std::reverse. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51364

--HG--
extra : moz-landing-system : lando
2019-11-08 11:03:52 +00:00
André Bargull
3bb3e7e653 Bug 1592992 - Part 4: Replace js::EqualContainers with std::equal. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51363

--HG--
rename : js/src/jsutil.h => js/src/wasm/WasmUtility.h
extra : moz-landing-system : lando
2019-11-08 11:03:32 +00:00
André Bargull
9010f66124 Bug 1592992 - Part 3: Replace js::EraseIf with Vector::eraseIf where possible. r=jonco
mozilla::Vector already provides an `eraseIf` method, so we should prefer to use
the existing method. Except that Vector::eraseIf doesn't return the number of
elements removed, but that's easy to determine manually. More annoyingly is the
use of a modifying predicate function in Zone.cpp, which prevents using
Vector::eraseIf. It looks like for that specific use case a custome `EraseIf`
function is still necessary.

Differential Revision: https://phabricator.services.mozilla.com/D51362

--HG--
extra : moz-landing-system : lando
2019-11-08 11:03:05 +00:00
André Bargull
8a116f84e5 Bug 1592992 - Part 2: Replace js::Find with std::find. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D51361

--HG--
extra : moz-landing-system : lando
2019-11-08 11:02:42 +00:00
André Bargull
ef7724330c Bug 1592992 - Part 1: Remove unused jsutil functions. r=jonco
AddContainerToHash and ForEach aren't used (anymore).

Differential Revision: https://phabricator.services.mozilla.com/D51360

--HG--
extra : moz-landing-system : lando
2019-11-08 11:02:20 +00:00
Mihai Alexandru Michis
e27325e726 Backed out changeset 1aae03a822b8 (bug 1591947) for causing reftest failures in image-appearance-dynamic.xul CLOSED TREE 2019-11-08 15:39:52 +02:00
Mihai Alexandru Michis
129577da8f Backed out changeset 14e64e208672 (bug 1590167) for causing failures in spurious-hyphenation-after-explicit.html and nsHyphenator.cpp 2019-11-08 15:38:44 +02:00
Brindusan Cristian
adcc503b82 Bug 1583214 - follow-up for failing xpcshell's test_engine_selector.js. CLOSED TREE 2019-11-08 15:33:13 +02:00
Brindusan Cristian
a1dd1302ad Backed out 2 changesets (bug 1583214) for failing xpcshell's test_engine_selector.js. CLOSED TREE
Backed out changeset 3d07be0ac7bc (bug 1583214)
Backed out changeset 4eadc0b0b1f8 (bug 1583214)
2019-11-08 15:16:47 +02:00
Sebastian Hengst
0341151d63 Bug 1594981 - update Core::DOM* and Core::Storage* bugzilla product and component meta data in moz.build files after reorganization in bug 1594717. r=annevk
Differential Revision: https://phabricator.services.mozilla.com/D52345

--HG--
extra : moz-landing-system : lando
2019-11-08 12:17:57 +00:00
Jonathan Kew
09fc119a12 Bug 1590167 - Add Rust implementation of hyphenation (mapped_hyph) and hook up in place of libhyphen. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D49967

--HG--
extra : moz-landing-system : lando
2019-11-08 12:33:23 +00:00
Mark Banner
122d30257e Bug 1593561 - Ensure the search service can still run if the distribution directory is unreadable by the current user. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D52095

--HG--
extra : moz-landing-system : lando
2019-11-08 12:28:53 +00:00
Jon Coppeard
d8178cef59 Bug 1594273 - Add an RAII class which empties the nursery as well as preparing for tracing r=sfink CLOSED TREE
Nursery eviction needs to be correctly interleaved with the other preparation steps since finishing the current GC can cause arbitrary code to run (and hence nursery allocations to be made) via calling the GC callbacks.

Differential Revision: https://phabricator.services.mozilla.com/D52161

--HG--
extra : source : 50b2bb645118f2650abfc9f40d409114e57746bd
extra : histedit_source : 4ee3a63419883791eceed3957fa7c328424f9e6d
2019-11-08 11:00:18 +00:00
Itiel
59387abc05 Bug 1279230 - Convert Pocket CSS to logical properties to prepare for RTL support r=thecount,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D50754

--HG--
extra : moz-landing-system : lando
2019-11-08 11:52:52 +00:00
sotaro
7001d3c524 Bug 1592512 - Handle surface opacity of OS compositor surface on Windows r=gw
Differential Revision: https://phabricator.services.mozilla.com/D52322

--HG--
extra : moz-landing-system : lando
2019-11-08 10:15:07 +00:00
Maja Frydrychowicz
5237b5f25c Bug 1590467 - Use new testing options in puppeteer-test mach command; r=remote-protocol-reviewers,ato
This takes advantage of the browser-selection patch proposed to Puppeteer.
A --product option allows choice between 'firefox' and 'chrome'.
Puppeteer takes care of profile creation for Firefox. Additional Puppeteer
Launcher options can be passed along with --setopt.

Depends on D52313

Differential Revision: https://phabricator.services.mozilla.com/D52314

--HG--
extra : moz-landing-system : lando
2019-11-08 11:58:08 +00:00
Maja Frydrychowicz
ea7a28398b Bug 1590467 - Updated vendored puppeteer with proposed browser selection; r=remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D52313

--HG--
extra : moz-landing-system : lando
2019-11-08 11:52:18 +00:00
Gijs Kruitbosch
e5ac0416bc Bug 1593487 - tighten up registerWindowActor's handling of nonsensical actor specifications and remove cruft, r=nika,mconley
Differential Revision: https://phabricator.services.mozilla.com/D52002

--HG--
extra : moz-landing-system : lando
2019-11-08 11:59:37 +00:00
Itiel
550a45ad16 Bug 1594526 - Fix margin of seachbar image for RTL r=mikedeboer
Also improve CSS code style/quality around about:preferences

Differential Revision: https://phabricator.services.mozilla.com/D52086

--HG--
extra : moz-landing-system : lando
2019-11-08 11:51:21 +00:00
Emilio Cobos Álvarez
bf22f445d7 Bug 1591947 - Fix style changes from list-style-image to -moz-appearance for XUL images. r=TYLin
Consider the following case:

  <image style="list-style-image: url(foo.png)"></image>

  image.style.MozAppearance = "something"

The early return was preventing us from clearing the image.

This is an ancient bug, but it has started happening in the browser chrome
because the lack of lazy frame construction for XUL elements makes us construct
elements with an outdated style, which means in this case that they wouldn't
have the -moz-appearance rule applied yet.

Differential Revision: https://phabricator.services.mozilla.com/D52112

--HG--
extra : moz-landing-system : lando
2019-11-08 11:14:35 +00:00
Mark Banner
fe6fdaf91c Bug 1583214 - Support ESR settings in the modern search configuration. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D52041

--HG--
extra : moz-landing-system : lando
2019-11-08 12:04:02 +00:00
Mark Banner
1ce5cc514a Bug 1583214 - Split the search engine configuration schema documentation onto a separate page. r=mikedeboer
This helps with getting to the relevant parts more quickly, and a better heading scheme.

Differential Revision: https://phabricator.services.mozilla.com/D52039

--HG--
rename : toolkit/components/search/docs/SearchEngineConfiguration.rst => toolkit/components/search/docs/SearchConfigurationSchema.rst
extra : moz-landing-system : lando
2019-11-08 12:04:00 +00:00