Commit Graph

9719 Commits

Author SHA1 Message Date
Mike Conley
1e1fa52a31 Bug 1695345 - Fork Dark Mode compact theme for Proton. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D106691
2021-03-02 04:36:57 +00:00
Csoregi Natalia
2a685ce5ab Backed out changeset 3251eaf83891 (bug 1695345) for causing build bustages. CLOSED TREE 2021-03-02 03:20:40 +02:00
Mike Conley
a2f8675ecd Bug 1695345 - Fork Dark Mode compact theme for Proton. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D106691
2021-03-01 23:48:26 +00:00
Tim Nguyen
5fa0e52b5f Bug 1693374 - Make common.css sidebar footer styles re-usable. r=desktop-theme-reviewers,harry,robwu
Differential Revision: https://phabricator.services.mozilla.com/D106300
2021-02-26 22:18:44 +00:00
Butkovits Atila
f64a8e2f9f Backed out changeset d146eb93b6d0 (bug 1693374) for causing failures at browser_interaction_telemetry.js. CLOSED TREE 2021-02-26 21:32:25 +02:00
Tim Nguyen
63b3b5e5ca Bug 1693374 - Make common.css sidebar footer styles re-usable. r=desktop-theme-reviewers,harry,robwu
Differential Revision: https://phabricator.services.mozilla.com/D106300
2021-02-26 17:44:32 +00:00
Tim Nguyen
617dd08efc Bug 1689230 - Simplify gViewController API methods. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D103251
2021-02-22 22:44:03 +00:00
Gijs Kruitbosch
8002a3c48c Bug 1678255 - prompt for external protocol links whose loads were also triggered externally, instead of looping forever, r=pbz,nika
This passes around the "are we external" bit of load information a bunch,
such that the external protocol handling code has access to it.

In this bug and bug 1667468, I think ideally I would have used a check
if we're the OS default for a given protocol before continuing. However,
this information is currently unavailable on Linux (bug 1599713), and
worse, I believe is likely to remain unavailable in flatpak and other
such restricted environments (cf. bug 1618094 - we aren't able to find
out anything about protocol handlers from the OS).

So instead, we prompt the user if we are about to open a link passed
to us externally. There is a small chance this will be Breaking People's
Workflows, where I don't know whether anyone relies on Firefox happily
passing these URIs along to the relevant application (more convenient
than doing all the registry/API work yourself in scripts!) or anything
like that. To help with that, there's a pref,
`network.protocol-handler.prompt-from-external`, that can be created and
set to false to avoid prompting in this case.

Differential Revision: https://phabricator.services.mozilla.com/D103967
2021-02-22 19:00:10 +00:00
Gijs Kruitbosch
0598e83a2b Bug 1693276 - update button styles for proton r=desktop-theme-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D105481
2021-02-22 10:53:34 +00:00
Itiel
1fc32fef7f Bug 1693642 - Vertically align the radio buttons' text on about:addons details panel r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D105677
2021-02-18 22:01:12 +00:00
Alexis Beingessner
07f2f659c6 Bug 1686616 - make StringBundle use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105531
2021-02-18 13:26:32 +00:00
Alexis Beingessner
3f1a425606 Bug 1686616 - make IO use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105530
2021-02-18 13:26:32 +00:00
Alexis Beingessner
07ad6bc655 Bug 1686616 - make UUIDGenerator use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105526
2021-02-18 13:26:30 +00:00
Andreea Pavel
64289058b6 Backed out 5 changesets (bug 1690167) for failing xpcshell at bootstrapSvc.js on a CLOSED TREE
Backed out changeset d28c0f11743f (bug 1690167)
Backed out changeset 3b2bebed9128 (bug 1690167)
Backed out changeset 7e925e90a251 (bug 1690167)
Backed out changeset f85934a2b7ad (bug 1690167)
Backed out changeset 6d83474e81bb (bug 1690167)
2021-02-17 07:10:58 +02:00
Mike Hommey
622b111f9e Bug 1690167 - Change VsprintfLiteral/SprintfLiteral to rely on PrintfTarget. r=nika,Gankra,firefox-build-system-reviewers,mhentges
Instead of snprintf.

Because some standalone code uses those functions directly or indirectly,
and PrintfTarget lives in mozglue, they now need to depend on mozglue
instead of mfbt. Except logalloc/replay, which cherry-picks what it
uses.

Differential Revision: https://phabricator.services.mozilla.com/D103730
2021-02-16 21:20:04 +00:00
Mihai Alexandru Michis
9154148880 Backed out 4 changesets (bug 1690167) for causing cppunit failures in TestIntegerPrintfMacros.
CLOSED TREE

Backed out changeset 27dee66eba83 (bug 1690167)
Backed out changeset cfffb092a39f (bug 1690167)
Backed out changeset 87b2a2a66fd9 (bug 1690167)
Backed out changeset cac4879f50b4 (bug 1690167)
2021-02-13 00:07:00 +02:00
Mike Hommey
47675f5460 Bug 1690167 - Change VsprintfLiteral/SprintfLiteral to rely on PrintfTarget. r=nika,Gankra,firefox-build-system-reviewers,mhentges
Instead of snprintf.

Because some standalone code uses those functions directly or indirectly,
and PrintfTarget lives in mozglue, they now need to depend on mozglue
instead of mfbt. Except logalloc/replay, which cherry-picks what it
uses.

Differential Revision: https://phabricator.services.mozilla.com/D103730
2021-02-12 20:21:50 +00:00
Itiel
beca07c798 Bug 1689480 - Changes to the appchooser/permission dialog checkboxes to accomodate for the added margin-block r=pbz
This also gets rid of the non clickable area between the checkbox and its label.

Differential Revision: https://phabricator.services.mozilla.com/D103400
2021-02-12 17:05:28 +00:00
Tim Nguyen
1a337bb3b7 Bug 1691313 - Use hidden DOM property instead of attribute methods in toolkit/. r=mtigley,preferences-reviewers,jaws
Differential Revision: https://phabricator.services.mozilla.com/D104777
2021-02-12 02:05:49 +00:00
Mark Banner
3ef6acac59 Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (application changes). r=geckoview-reviewers,Gijs,agi
Differential Revision: https://phabricator.services.mozilla.com/D104684
2021-02-11 22:02:15 +00:00
Mark Banner
263d555274 Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104683
2021-02-11 22:02:15 +00:00
Tim Nguyen
5e21782d43 Bug 1689234 - Remove hideView function from aboutaddons.js. r=rpl
This is only called right before showView is called, which already does what hideView does (save scroll offsets and clear content).

Differential Revision: https://phabricator.services.mozilla.com/D103248
2021-02-11 21:42:39 +00:00
Noemi Erli
e9cf2ebf0d Backed out changeset 89dd5f05ca91 (bug 1678255) for causing assertion failures in BasePrincipal.cpp CLOSED TREE 2021-02-11 06:15:26 +02:00
Gijs Kruitbosch
ee25637a13 Bug 1678255 - prompt for external protocol links whose loads were also triggered externally, instead of looping forever, r=pbz,nika
This passes around the "are we external" bit of load information a bunch,
such that the external protocol handling code has access to it.

In this bug and bug 1667468, I think ideally I would have used a check
if we're the OS default for a given protocol before continuing. However,
this information is currently unavailable on Linux (bug 1599713), and
worse, I believe is likely to remain unavailable in flatpak and other
such restricted environments (cf. bug 1618094 - we aren't able to find
out anything about protocol handlers from the OS).

So instead, we prompt the user if we are about to open a link passed
to us externally. There is a small chance this will be Breaking People's
Workflows, where I don't know whether anyone relies on Firefox happily
passing these URIs along to the relevant application (more convenient
than doing all the registry/API work yourself in scripts!) or anything
like that. To help with that, there's a pref,
`network.protocol-handler.prompt-from-external`, that can be created and
set to false to avoid prompting in this case.

Differential Revision: https://phabricator.services.mozilla.com/D103967
2021-02-10 23:49:21 +00:00
Jan de Mooij
36c0274c42 Bug 1674777 part 9 - Change GetArrayBufferByteLength return type from uint32_t to size_t. r=sfink
Note that previous patches already fixed various other callers.

Depends on D103760

Differential Revision: https://phabricator.services.mozilla.com/D103761
2021-02-10 08:30:06 +00:00
Michael Goossens
0747b8564f Bug 1649590 - Convert XPIProvider.jsm to use IOUtils r=emalysz,mixedpuppy,barret,gcp
Differential Revision: https://phabricator.services.mozilla.com/D97354
2021-02-10 02:46:04 +00:00
Nick Alexander
1b17d2b73e Bug 1674408 - Define stat64 as stat on OpenBSD. r=application-update-reviewers,bytesized
This is the approach taken for Bug 648735: see
https://bugzilla.mozilla.org/attachment.cgi?id=561029&action=diff.

Differential Revision: https://phabricator.services.mozilla.com/D104250
2021-02-05 18:48:34 +00:00
Kirk Steuber
57b49a2593 Bug 1682810 - Fix tests to expect the correct pending status r=application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D104124
2021-02-05 04:16:30 +00:00
Kirk Steuber
529aad0d9b Bug 1682810 - When staging fails, leave the update in the same state regardless of how it failed r=nalexander
I am changing the way that we handle staging failures here: https://searchfox.org/mozilla-central/rev/851bbbd9d9a38c2785a24c13b6412751be8d3253/toolkit/mozapps/update/UpdateService.jsm#4322
to more closely match the way we handle staging failures here: https://searchfox.org/mozilla-central/rev/851bbbd9d9a38c2785a24c13b6412751be8d3253/toolkit/mozapps/update/UpdateService.jsm#6015

This change will allow the Mozilla Maintenance Service to be used when the partial patch fails to stage. The updater already falls back if the Maintenance Service fails, so if there is indeed a problem with the Service a UAC will still be shown.

Differential Revision: https://phabricator.services.mozilla.com/D103406
2021-02-05 00:59:39 +00:00
Csoregi Natalia
cc417af149 Backed out changeset ee49da8ea890 (bug 1649590) for failures on browser_content_sandbox_fs.js. CLOSED TREE 2021-02-05 04:21:45 +02:00
Michael Goossens
1fa798a7eb Bug 1649590 - Convert XPIProvider.jsm to use IOUtils r=emalysz,mixedpuppy,barret,gcp
Differential Revision: https://phabricator.services.mozilla.com/D97354
2021-02-04 23:08:01 +00:00
Luca Greco
e3cdd5d06f Bug 1687326 - Fix leaked FullZoomChange/TextZoomChange listeners in aboutaddons.js. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D103815
2021-02-04 17:29:23 +00:00
Dorel Luca
91c6bbd136 Backed out changeset d26c67a77da4 (bug 1682810) for XPCshell failures in toolkit/mozapps/update/tests/unit_service_updater/marAppApplyDirLockedStageFailureSvc_win.js. CLOSED TREE 2021-02-04 03:47:44 +02:00
Mike Hommey
22b5d8eaf9 Bug 1690453 - Remove TSAN suppression for bug 1623034. r=Gankra
Differential Revision: https://phabricator.services.mozilla.com/D103863
2021-02-03 16:41:19 +00:00
Kirk Steuber
954c57e7dc Bug 1682810 - When staging fails, leave the update in the same state regardless of how it failed r=nalexander
I am changing the way that we handle staging failures here: https://searchfox.org/mozilla-central/rev/851bbbd9d9a38c2785a24c13b6412751be8d3253/toolkit/mozapps/update/UpdateService.jsm#4322
to more closely match the way we handle staging failures here: https://searchfox.org/mozilla-central/rev/851bbbd9d9a38c2785a24c13b6412751be8d3253/toolkit/mozapps/update/UpdateService.jsm#6015

This change will allow the Mozilla Maintenance Service to be used when the partial patch fails to stage. The updater already falls back if the Maintenance Service fails, so if there is indeed a problem with the Service a UAC will still be shown.

Differential Revision: https://phabricator.services.mozilla.com/D103406
2021-02-03 20:21:58 +00:00
Luca Greco
553ed667b3 Bug 1525179 - Ensure InlineOptionsBrowser does not leave a loadURI call pending if disconnected while rendering. r=robwu
Depends on D103200

Differential Revision: https://phabricator.services.mozilla.com/D103814
2021-02-03 17:39:31 +00:00
Luca Greco
db6fb5be1a Bug 1525179 - Removed duplicate getAddonCard helper functions used in AOM tests. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D103200
2021-02-02 20:22:42 +00:00
Luca Greco
b3c5f1bf45 Bug 1525179 - Removed checkOpenWindows helper checking unused Addons:Manager/Compatibility/Install window types. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D103199
2021-02-02 20:22:40 +00:00
Luca Greco
e1d14d5183 Bug 1525179 - Use aboutaddons.html at the root of about:addons. r=robwu
- Moved aboutaddons.html at the root of the about:addons page
- renamed aboutaddons.js `initialize` global function to `initializeView` (and renamed `show` and `hide` global functions accordingly)
- Simplify initial load logic a bit more:
  - remove gCategories
  - moved responsability of the CategoriesBox initialization to the `initializationView` function
  - replaced initialization logic based on `gPendingInitializations` and `notifyInitialized` with
    a `promiseInitialized` global resolved when `initializeView` method has been called and its return value resolved
- Fix test helpers and test failures
  - InlineOptionsBrowser: take into account that browser-custom-element does opt-in the delayedConnectedCallback behavior
    and browser.loadURI may throw if called while the document is still loading.

Differential Revision: https://phabricator.services.mozilla.com/D96472
2021-02-03 17:08:14 +00:00
Emma Malysz
205673ebee Bug 1689405: remove components of library panel r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D103532
2021-01-30 17:12:51 +00:00
Tim Nguyen
d21554599f Bug 1689727 - Stop using XUL <deck> for #updateDeck. r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D103519
2021-01-30 15:02:35 +00:00
Mark Banner
930543e681 Bug 1687235 - Enable ESLint rule no-setter-return for toolkit and services. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D102153
2021-01-26 13:43:58 +00:00
Brindusan Cristian
70ab748bed Backed out 5 changesets (bug 1687235) for mochitest failures at test_menulist_null_value.xhtml. CLOSED TREE
Backed out changeset 638c802ca1d1 (bug 1687235)
Backed out changeset ec830b771bce (bug 1687235)
Backed out changeset a7c933ddecfd (bug 1687235)
Backed out changeset c36493fb0599 (bug 1687235)
Backed out changeset 6eb33ad5d460 (bug 1687235)
2021-01-26 10:58:43 +02:00
Mark Banner
9cbc91833a Bug 1687235 - Enable ESLint rule no-setter-return for toolkit and services. r=mossop
Depends on D102152

Differential Revision: https://phabricator.services.mozilla.com/D102153
2021-01-25 22:27:01 +00:00
Itiel
0dfabb9a65 Bug 1685595 - Make input[type=radio] styling match xul|radio styling in common.inc.css r=sfoster,robwu,extension-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D101064
2021-01-25 19:14:58 +00:00
Kirk Steuber
278d391073 Bug 1685594 - Tests for ManualAppUpdateOnly policy r=agashlin
Differential Revision: https://phabricator.services.mozilla.com/D101252
2021-01-21 23:49:41 +00:00
Kirk Steuber
c50930cb95 Bug 1685594 - Add capability for turning off automatic application update checks r=agashlin,preferences-reviewers
Note that this does not add the policy necessary to enable this feature. That policy will be added in Bug 1653430

Differential Revision: https://phabricator.services.mozilla.com/D101251
2021-01-21 23:47:19 +00:00
Csoregi Natalia
5f5a79166e Backed out changeset 0b9a1b2668a4 (bug 1685595) for browser_parsable_css.js failures. CLOSED TREE 2021-01-25 20:22:31 +02:00
Itiel
3dc765d056 Bug 1685595 - Make input[type=radio] styling match xul|radio styling in common.inc.css r=sfoster,robwu,extension-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D101064
2021-01-25 15:57:45 +00:00
William Durand
212085ec25 Bug 1687375 - Fix add-on "line" badge title. r=rpl,flod
Differential Revision: https://phabricator.services.mozilla.com/D102624
2021-01-22 13:07:21 +00:00