18491 Commits

Author SHA1 Message Date
Matt Woodrow
53740310b4 Bug 1583076 - Pass LoadInfo back for the current channel when confirming redirects. r=ckerschb
We previously used the initial LoadInfo from when the DocumentChannel was created, but need the one from the most recent channel in the parent.

Differential Revision: https://phabricator.services.mozilla.com/D46741

--HG--
extra : moz-landing-system : lando
2019-09-25 04:50:58 +00:00
Matt Woodrow
6aa089f744 Bug 1583076 - Make nsCSPService::ConsultCSPForRedirect return both the AsyncOnChannelRedirect result, as well as an optional result to cancel the old channel with. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D46740

--HG--
extra : moz-landing-system : lando
2019-09-25 04:50:44 +00:00
Junior Hsu
173804c32c Bug 1574000 - Obtain COOP only over a secure context r=nika,bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D42046

--HG--
extra : moz-landing-system : lando
2019-09-25 00:39:17 +00:00
Mihai Alexandru Michis
3ced6be81c Backed out 1 changesets (bug 1577643) for causing bustages in QuicSocketControl.h:45:57 CLOSED TREE
Backed out changeset 48ce2b670f32 (bug 1577643)
2019-09-25 03:08:58 +03:00
Dragana Damjanovic
2fe2e913f8 Bug 1577643 - Implement a security info class for the quic transport. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D44073

--HG--
extra : moz-landing-system : lando
2019-09-24 20:56:39 +00:00
Bogdan Tara
f1b65b22c7 Backed out 5 changesets (bug 1583076) for href-location-redirected-blocked.sub.html failures CLOSED TREE
Backed out changeset dd4117098844 (bug 1583076)
Backed out changeset 97bc75b1cfe1 (bug 1583076)
Backed out changeset 084b244a33c0 (bug 1583076)
Backed out changeset 1baaf14e2451 (bug 1583076)
Backed out changeset 56c3918b5c21 (bug 1583076)
2019-09-25 00:53:46 +03:00
Matt Woodrow
4b5ad7f5c4 Bug 1583076 - Pass LoadInfo back for the current channel when confirming redirects. r=ckerschb
We previously used the initial LoadInfo from when the DocumentChannel was created, but need the one from the most recent channel in the parent.

Depends on D46740

Differential Revision: https://phabricator.services.mozilla.com/D46741

--HG--
extra : moz-landing-system : lando
2019-09-24 12:13:49 +00:00
Matt Woodrow
29c34b4b28 Bug 1583076 - Make nsCSPService::ConsultCSPForRedirect return both the AsyncOnChannelRedirect result, as well as an optional result to cancel the old channel with. r=ckerschb
Depends on D46739

Differential Revision: https://phabricator.services.mozilla.com/D46740

--HG--
extra : moz-landing-system : lando
2019-09-24 12:12:18 +00:00
Valentin Gosu
04851f6503 Bug 1577574 - Only assert that string is propely lowercased in AlternateServices::SchemeIsHTTPS r=kershaw
According to the comment above, SchemeIsHTTPS should return an error if the
input is neither http or https.
But we don't assert that the string is not lowercased (as the comment says),
instead we assert if it's not http or https, meaning in debug mode the
function would always panic for such an input.
This patch changes the MOZ_ASSERT to match the comment and only assert if
for some reason the input scheme is not lowercase.

Differential Revision: https://phabricator.services.mozilla.com/D46279

--HG--
extra : moz-landing-system : lando
2019-09-24 17:54:54 +00:00
Kershaw Chang
5574704830 Bug 1583507 - Handle ftp channel diversion properly r=valentin
This patch fixes two problems.
1. nsFtpChannel::SuspendInternal should return NS_ERROR_NOT_AVAILABLE when OnStopRequest is already called, since NS_ERROR_NOT_AVAILABLE is the error code that caller expects.
2. In FTPChannelChild::DivertToParent, we should set mDivertingToParent before calling Suspend. Otherwise, FTPChannelChild could send unexpected suspend message to FTPChannelParent.

Differential Revision: https://phabricator.services.mozilla.com/D46953

--HG--
extra : moz-landing-system : lando
2019-09-24 17:26:57 +00:00
Paul Zuehlcke
a20be9ee64 Bug 1574469 - Removed block param from nsICookieManager::Remove. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D45848

--HG--
extra : moz-landing-system : lando
2019-09-24 17:13:43 +00:00
Ehsan Akhgari
7239f850ee Bug 1583211 - Use the URL file path when performing cookie path matching instead of the url path query ref; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D46809

--HG--
extra : moz-landing-system : lando
2019-09-24 14:33:59 +00:00
Sebastian Streich
b731ffbff3 Bug 1578991 - Skip Calling Sniffers in Case of NoSniff and JSON Mime r=ckerschb,dragana
Differential Revision: https://phabricator.services.mozilla.com/D45681

--HG--
extra : moz-landing-system : lando
2019-09-24 12:26:22 +00:00
Oana Pop Rus
3144f81e55 Backed out changeset cb1b6afa9f33 (bug 1574469) for multiple failures in nsICookieManager.remove on a CLOSED TREE 2019-09-24 13:10:07 +03:00
Paul Zuehlcke
b7de7aec93 Bug 1574469 - Removed block param from nsICookieManager::Remove. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D45848

--HG--
extra : moz-landing-system : lando
2019-09-19 17:10:58 +00:00
Paul Zuehlcke
2189ac4496 Bug 1574469 - Implemented nsPermissionManager::LegacyTestPermissionFromURI for nsIURI queries with origin attributes. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D45847

--HG--
extra : moz-landing-system : lando
2019-09-19 17:07:22 +00:00
Geoff Brown
b0e5901c93 Bug 1582884 - Enable some crashtests on Android; r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D46784

--HG--
extra : moz-landing-system : lando
2019-09-24 01:12:09 +00:00
Geoff Brown
dcb380399e Bug 1582785 - Enable some xpcshell tests on Android; r=geckoview-reviewers,agi
Most of these tests have been disabled for a long time; they run well
in the current test environment.

Differential Revision: https://phabricator.services.mozilla.com/D46642

--HG--
extra : moz-landing-system : lando
2019-09-23 22:43:55 +00:00
Ehsan Akhgari
5f56dea240 Bug 833723 - Part 2: Fix typo
Differential Revision: https://phabricator.services.mozilla.com/D46863

--HG--
extra : moz-landing-system : lando
2019-09-23 21:33:30 +00:00
Ehsan Akhgari
4382a07f0c Bug 833723 - Make test_bug455311.js pass locally on Linux by resolving symlinks; r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D46816

--HG--
extra : moz-landing-system : lando
2019-09-23 20:48:20 +00:00
Noemi Erli
519878e346 Backed out changeset 89552e3aa8be (bug 833723) for xpcshell failures in test_bug455311.js CLOSED TREE 2019-09-23 23:39:50 +03:00
Ehsan Akhgari
78123454f5 Bug 833723 - Make test_bug455311.js pass locally on Linux by resolving symlinks; r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D46816

--HG--
extra : moz-landing-system : lando
2019-09-23 19:08:39 +00:00
ffxbld
bdeece726d No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D46777

--HG--
extra : moz-landing-system : lando
2019-09-23 13:09:04 +00:00
Jean-Yves Avenard
e3fc8f8970 Bug 1575744 - P8. Remove no longer necessary interface. r=mayhemer
Thanks to the promisifying of SendCrossProcessRedirect we no longer needs callback to DocumentChannelParent from nsHttpChannelParent. So we can remove the interface that allowed to do so.

Differential Revision: https://phabricator.services.mozilla.com/D46174

--HG--
rename : netwerk/base/nsICrossProcessSwitchChannel.idl => netwerk/base/nsIProcessSwitchRequestor.idl
extra : moz-landing-system : lando
2019-09-20 04:09:48 +00:00
Jean-Yves Avenard
7cdc8e0a68 Bug 1575744 - P7. Promisify SendCrossProcessRedirect to avoid needing PHttpChannel to get a response. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D46163

--HG--
extra : moz-landing-system : lando
2019-09-21 11:14:49 +00:00
Jean-Yves Avenard
9d8eadbabe Bug 1575744 - P6. Remove unused nsIProcessSwitchRequestor implementation. r=mayhemer
nsViewSourceChannel will never trigger a change of process. So we can remove this interface from nsViewSourceChannel.

Differential Revision: https://phabricator.services.mozilla.com/D46160

--HG--
extra : moz-landing-system : lando
2019-09-20 04:09:47 +00:00
Jean-Yves Avenard
abec029eac Bug 1575744 - P5. Implement process switch from DocumentChannelParent. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D46020

--HG--
extra : moz-landing-system : lando
2019-09-20 04:09:47 +00:00
Jean-Yves Avenard
912b0df630 Bug 1575744 - P4. Add MozPromise::FromDomPromise. r=bholley
Similar to MozPromise::FromGeckoResult.

Allows to create a MozPromise that will be resolved/rejected when the JS promise does the same.
It would be nice to be able to chain the two promise types, but it would be an additional effort.
MozPromise::FromDomPromise is limited to primitive types only and the reject value type must be nsresult.

Differential Revision: https://phabricator.services.mozilla.com/D46017

--HG--
extra : moz-landing-system : lando
2019-09-20 04:09:46 +00:00
Jean-Yves Avenard
89412cad70 Bug 1575744 - P3. Make ContentProcessIdPromise exclusive. r=mayhemer
There's only one consumer of these promises. It doesn't need to be non-exclusive.

Differential Revision: https://phabricator.services.mozilla.com/D46016

--HG--
extra : moz-landing-system : lando
2019-09-20 04:09:46 +00:00
Jean-Yves Avenard
4986f63ec2 Bug 1575744 - P2. Add nsIProcessSwitchRequestor interface. r=mayhemer,nika
Will allow for SessionStore.jsm process switching to be used by other objects than nsHttpChannel.

Differential Revision: https://phabricator.services.mozilla.com/D46015

--HG--
extra : moz-landing-system : lando
2019-09-20 04:09:46 +00:00
Jean-Yves Avenard
f985ff154a Bug 1575744 - P1. Only perform process switch once we have completed all redirects. r=mayhemer
This is a stepped transition ; as SessionStore currently only knows how to deal with nsHttpChannel we have to go through the redirect only if the current channel is a nsHttpChannel.
In a followup change we will allow SessionStore to directly deal with the DocumentParentProcess.

Differential Revision: https://phabricator.services.mozilla.com/D46014

--HG--
extra : moz-landing-system : lando
2019-09-20 04:09:46 +00:00
Michal Novotny
815ac794a5 Bug 1561944 - Implement nsINetworkLinkService.networkID for Android r=valentin
Patch changes nsAndroidNetworkLinkService so it uses NetlinkService for network ID calculation as well as for notifications about network changes.

Differential Revision: https://phabricator.services.mozilla.com/D43385

--HG--
extra : moz-landing-system : lando
2019-09-19 13:47:46 +00:00
Bogdan Tara
bee28f01d7 Backed out 8 changesets (bug 1575744) for HttpChannelParent related assertion failures
Backed out changeset af61675dd488 (bug 1575744)
Backed out changeset bf794b9373c8 (bug 1575744)
Backed out changeset 39ffb74d2e12 (bug 1575744)
Backed out changeset c1547b3df672 (bug 1575744)
Backed out changeset 382ee8672027 (bug 1575744)
Backed out changeset 5abb38484f11 (bug 1575744)
Backed out changeset d5244c1bbfe8 (bug 1575744)
Backed out changeset c74b81debf73 (bug 1575744)

--HG--
rename : netwerk/base/nsIProcessSwitchRequestor.idl => netwerk/base/nsICrossProcessSwitchChannel.idl
2019-09-20 06:58:44 +03:00
Jean-Yves Avenard
1c9ba44fc0 Bug 1575744 - P8. Remove no longer necessary interface. r=mayhemer
Thanks to the promisifying of SendCrossProcessRedirect we no longer needs callback to DocumentChannelParent from nsHttpChannelParent. So we can remove the interface that allowed to do so.

Differential Revision: https://phabricator.services.mozilla.com/D46174

--HG--
rename : netwerk/base/nsICrossProcessSwitchChannel.idl => netwerk/base/nsIProcessSwitchRequestor.idl
extra : moz-landing-system : lando
2019-09-18 13:17:05 +00:00
Jean-Yves Avenard
99df1db827 Bug 1575744 - P7. Promisify SendCrossProcessRedirect to avoid needing PHttpChannel to get a response. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D46163

--HG--
extra : moz-landing-system : lando
2019-09-18 13:14:30 +00:00
Jean-Yves Avenard
7018b7cfca Bug 1575744 - P6. Remove unused nsIProcessSwitchRequestor implementation. r=mayhemer
nsViewSourceChannel will never trigger a change of process. So we can remove this interface from nsViewSourceChannel.

Differential Revision: https://phabricator.services.mozilla.com/D46160

--HG--
extra : moz-landing-system : lando
2019-09-18 14:20:23 +00:00
Jean-Yves Avenard
91ca56d295 Bug 1575744 - P5. Implement process switch from DocumentChannelParent. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D46020

--HG--
extra : moz-landing-system : lando
2019-09-20 01:08:02 +00:00
Jean-Yves Avenard
bafae6af97 Bug 1575744 - P4. Add MozPromise::FromDomPromise. r=bholley
Similar to MozPromise::FromGeckoResult.

Allows to create a MozPromise that will be resolved/rejected when the JS promise does the same.
It would be nice to be able to chain the two promise types, but it would be an additional effort.
MozPromise::FromDomPromise is limited to primitive types only and the reject value type must be nsresult.

Differential Revision: https://phabricator.services.mozilla.com/D46017

--HG--
extra : moz-landing-system : lando
2019-09-20 02:21:12 +00:00
Jean-Yves Avenard
3a157fb111 Bug 1575744 - P3. Make ContentProcessIdPromise exclusive. r=mayhemer
There's only one consumer of these promises. It doesn't need to be non-exclusive.

Differential Revision: https://phabricator.services.mozilla.com/D46016

--HG--
extra : moz-landing-system : lando
2019-09-16 18:08:16 +00:00
Jean-Yves Avenard
db9dcef811 Bug 1575744 - P2. Add nsIProcessSwitchRequestor interface. r=mayhemer,nika
Will allow for SessionStore.jsm process switching to be used by other objects than nsHttpChannel.

Differential Revision: https://phabricator.services.mozilla.com/D46015

--HG--
extra : moz-landing-system : lando
2019-09-18 23:49:51 +00:00
Jean-Yves Avenard
02d8a3d841 Bug 1575744 - P1. Only perform process switch once we have completed all redirects. r=mayhemer
This is a stepped transition ; as SessionStore currently only knows how to deal with nsHttpChannel we have to go through the redirect only if the current channel is a nsHttpChannel.
In a followup change we will allow SessionStore to directly deal with the DocumentParentProcess.

Differential Revision: https://phabricator.services.mozilla.com/D46014

--HG--
extra : moz-landing-system : lando
2019-09-17 02:51:11 +00:00
Zibi Braniecki
8c34ae8cc7 Bug 1581692 - Remove unused .properties from netwerk. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com//D46194

Depends on D46193

--HG--
extra : histedit_source : 6604010dd875bfd0dba8e1a92842d5310fa989a7
2019-09-18 19:38:50 +03:00
ffxbld
959ff7f82f No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D46469

--HG--
extra : moz-landing-system : lando
2019-09-19 14:37:28 +00:00
Nico Grunbaum
11d7e7febf Bug 1581023 - Expand DataChannel logging capabilities - r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D45800

--HG--
extra : moz-landing-system : lando
2019-09-19 14:50:57 +00:00
Doug Thayer
5920fc459e Bug 1554242 - Don't open file just to ftell it r=baku
In bug 1554242 we're noticing main thread file IO sending a PNG
thumbnail as a blob over IPC. The stack is roughly
IPCBlobInputStream::Close() -> nsFileInputStream::Close() ->
nsFileStreamBase::DoOpen(). The file in question is always a
deferred open file, and we didn't open it in append mode, so there
is no way for ftell to be anything other than 0 (?). This was
verified with an assertion on a try run.

Differential Revision: https://phabricator.services.mozilla.com/D46328

--HG--
extra : moz-landing-system : lando
2019-09-19 10:03:23 +00:00
Byron Campen [:bwc]
85cc5df79c Bug 1569183: Fix bugs where OnProxyAvailable would be called with a proxy info whose resolve flags did not match what was asked for. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D46052

--HG--
extra : moz-landing-system : lando
2019-09-17 18:19:38 +00:00
Byron Campen [:bwc]
abf0777414 Bug 1569183: Create an ipdl struct called WebrtcProxyConfig, to cut down on the arg count on lots of functions. r=mjf,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D45562

--HG--
extra : moz-landing-system : lando
2019-09-17 18:19:04 +00:00
Byron Campen [:bwc]
fec8b0d807 Bug 1569183: Stop doing a proxy lookup to determine whether we're configured to use a proxy (for the proxy_only_if_behind_proxy pref), and instead look at whether we loaded the doc using a proxy. r=mjf,mayhemer,jld
Differential Revision: https://phabricator.services.mozilla.com/D45289

--HG--
extra : moz-landing-system : lando
2019-09-18 14:27:42 +00:00
Byron Campen [:bwc]
fbfb9f6754 Bug 1569183: Make proxy config parameters optional in WebrtcTCPSocket to get the NAT simulator working again. r=mjf,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D45104

--HG--
extra : moz-landing-system : lando
2019-09-17 18:17:37 +00:00
Byron Campen [:bwc]
ffa09cee72 Bug 1569183: Rename PWebrtcProxyChannel to PWebrtcTCPSocket. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D45098

--HG--
rename : media/mtransport/WebrtcProxyChannelWrapper.cpp => media/mtransport/WebrtcTCPSocketWrapper.cpp
rename : media/mtransport/WebrtcProxyChannelWrapper.h => media/mtransport/WebrtcTCPSocketWrapper.h
rename : media/mtransport/ipc/PWebrtcProxyChannel.ipdl => media/mtransport/ipc/PWebrtcTCPSocket.ipdl
rename : media/mtransport/ipc/WebrtcProxyChannel.cpp => media/mtransport/ipc/WebrtcTCPSocket.cpp
rename : media/mtransport/ipc/WebrtcProxyChannel.h => media/mtransport/ipc/WebrtcTCPSocket.h
rename : media/mtransport/ipc/WebrtcProxyChannelCallback.h => media/mtransport/ipc/WebrtcTCPSocketCallback.h
rename : media/mtransport/ipc/WebrtcProxyChannelChild.cpp => media/mtransport/ipc/WebrtcTCPSocketChild.cpp
rename : media/mtransport/ipc/WebrtcProxyChannelChild.h => media/mtransport/ipc/WebrtcTCPSocketChild.h
rename : media/mtransport/ipc/WebrtcProxyLog.cpp => media/mtransport/ipc/WebrtcTCPSocketLog.cpp
rename : media/mtransport/ipc/WebrtcProxyLog.h => media/mtransport/ipc/WebrtcTCPSocketLog.h
rename : media/mtransport/ipc/WebrtcProxyChannelParent.cpp => media/mtransport/ipc/WebrtcTCPSocketParent.cpp
rename : media/mtransport/ipc/WebrtcProxyChannelParent.h => media/mtransport/ipc/WebrtcTCPSocketParent.h
extra : moz-landing-system : lando
2019-09-17 18:15:41 +00:00